Re: [dpdk-dev] [PATCH 1/2] net/mlx5: modify PMD args process

2017-04-17 Thread Nélio Laranjeiro
Hi Shahaf, On Sun, Apr 16, 2017 at 10:46:39AM +0300, Shahaf Shuler wrote: > Currently the argument process is done without indication which > parameter was forced by the application and which one is on it > default value. > This becomes problematic when different features requires different > defa

Re: [dpdk-dev] [PATCH] net/mlx5: change calculating inline room for Tx

2017-04-17 Thread Nélio Laranjeiro
On Thu, Apr 13, 2017 at 10:46:51AM -0700, Yongseok Koh wrote: > Current implementation is error-prone if the max inline size > (txq->max_inilne) is decoupled from txq->inline_en and becomes zero. If it > becomes zero, HW can crash due to WQ overflow. > > Signed-off-by: Yongseok Koh > Acked-by: Sh

Re: [dpdk-dev] Unable to send ping requests using pktgen-dpdk

2017-04-17 Thread Wiles, Keith
> On Apr 17, 2017, at 11:35 AM, Safiyat Reza wrote: > > On 17 April 2017 at 21:25, Wiles, Keith wrote: > Comments below: > > > On Apr 17, 2017, at 8:07 AM, Safiyat Reza wrote: > > > > Hi, > > > > I am trying to ping a remote machine (within the same network) via port 0 > > using the command >

Re: [dpdk-dev] [PATCH v2] doc: relocate i40e known issues

2017-04-17 Thread Yang, Qiming
Hi, Ferruh It's a good way, I'll send a new patch. Thank you. Qiming > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, April 13, 2017 6:14 PM > To: Yang, Qiming ; dev@dpdk.org > Cc: Wu, Jingjing ; Mcnamara, John > ; Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2] doc: relocate

[dpdk-dev] [PATCH] doc: add VF support statement

2017-04-17 Thread Qiming Yang
This patch adds two note in doc build_dpdk, suggests DPDK user don't use ``vfio-pci`` and ``uio_pci_generic`` module to create virtual functions(VFs). Signed-off-by: Qiming Yang --- doc/guides/linux_gsg/build_dpdk.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/linux_g

Re: [dpdk-dev] Working of pipeline in a given config file and regarding user-defined actions in IP_PIPELINE application

2017-04-17 Thread Nidhia Varghese
Hi Christian, Can you please elaborate on how to use DMA action of pass-through table for this? Is that like creating a separate pipeline for saving this metadata to the headroom space and in the next pipeline we use this metadata field for further lookups. And we will be using different keys for

[dpdk-dev] [PATCH 4/4] net/ixgbe/base: update base driver version to 2017.03.29

2017-04-17 Thread Wei Dai
* Acquire PHY semaphore before device reset * Add support for 2.5G KX physical layer * Add MAC X550em/X557 LED on|off support Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/README b/drivers/net/i

[dpdk-dev] [PATCH 2/4] net/ixgbe/base: add support for 2.5G KX physical layer

2017-04-17 Thread Wei Dai
Add another define for the 2.5G KX physical layer. This requires all variables and support functions that deal with "physical_layer" to be bumped to u64 as this is the 33rd define. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_82598.c | 4 ++-- drivers/net/ixgbe/base/ixgbe_82598.h |

[dpdk-dev] [PATCH 1/4] net/ixgbe/base: acquire PHY semaphore before device reset

2017-04-17 Thread Wei Dai
A recent firmware change fixed an issue to acquire the PHY semaphore before accessing PHY registers. This led to a case where SW can issue a device reset clearing the MDIO registers. This patch makes SW acquire the PHY semaphore before issuing a device reset. Signed-off-by: Wei Dai --- drivers/n

[dpdk-dev] [PATCH 3/4] net/ixgbe/base: add MAC X550em/X557 LED on|off support

2017-04-17 Thread Wei Dai
This patch updates ixgbe_led_[on|off]_t_X550em for MAC or PHY connected LEDs. To support both MAC or PHY connected LEDs, both MAC and PHY led control registers are configured. Signed-off-by: Wei Dai --- drivers/net/ixgbe/base/ixgbe_x550.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(

Re: [dpdk-dev] Q on IXGBE and I40E vector Tx processing

2017-04-17 Thread Ravi Kerur
Hi Konstantin, On Sun, Apr 16, 2017 at 3:26 PM, Ananyev, Konstantin < konstantin.anan...@intel.com> wrote: > > Hi Ravi, > > > > > Hi, > > > > The reason I am asking I because I have tried different combinations of > > scalar and vector Tx and Rx processing for both IXGBE and I40E with > > followi

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix possible overflow

2017-04-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, April 11, 2017 3:43 PM > To: dev@dpdk.org > Cc: Doherty, Declan; sta...@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] app/crypto-perf: fix possible overflow > > In the latency test, when number of enqueued operation

Re: [dpdk-dev] [PATCH] crypto/qat: fix incomplete capabilities

2017-04-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, April 13, 2017 5:35 PM > To: Jain, Deepak K; Trahe, Fiona; Griffin, John > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] crypto/qat: fix incomplete capabilit

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix queue pair configuration

2017-04-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, April 17, 2017 9:32 PM > To: Zhang, Roy Fan; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] crypto/scheduler: fix queue pair configuration > > > > > -Original Message- > > From: Zhang, Roy Fan > > Sen

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix queue pair configuration

2017-04-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, April 10, 2017 4:01 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; sta...@dpdk.org > Subject: [PATCH] crypto/scheduler: fix queue pair configuration > > This patch fixes the queue pair configuration for the scheduler PMD. >

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix crypto operation resubmission

2017-04-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, April 10, 2017 3:57 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; sta...@dpdk.org > Subject: [PATCH] app/test-crypto-perf: fix crypto operation resubmission > > This patch fixes the crypto operation resubmission problem in

Re: [dpdk-dev] [PATCH v5] crypto/scheduler: add mode specific option support

2017-04-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Wednesday, April 05, 2017 5:07 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Doherty, Declan > Subject: [PATCH v5] crypto/scheduler: add mode specific option support > > Some scheduling modes may need extra options to be configured

[dpdk-dev] [PATCH] app/testpmd: consolidate two duplicate ifdefs into one.

2017-04-17 Thread Rami Rosen
Cnsolidate the duplicate #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES into one #ifdef. Signed-off-by: Rami Rosen --- app/test-pmd/rxonly.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c index dcc8346..dcd1d85 100644 --- a/app/test-pmd/rxonly.c +++

Re: [dpdk-dev] Unable to send ping requests using pktgen-dpdk

2017-04-17 Thread Safiyat Reza
On 17 April 2017 at 21:25, Wiles, Keith wrote: > Comments below: > > > On Apr 17, 2017, at 8:07 AM, Safiyat Reza wrote: > > > > Hi, > > > > I am trying to ping a remote machine (within the same network) via port 0 > > using the command > > > > Pktgen> ping4 0 > > > > But the packet that is recei

Re: [dpdk-dev] Unable to send ping requests using pktgen-dpdk

2017-04-17 Thread Wiles, Keith
Comments below: > On Apr 17, 2017, at 8:07 AM, Safiyat Reza wrote: > > Hi, > > I am trying to ping a remote machine (within the same network) via port 0 > using the command > > Pktgen> ping4 0 > > But the packet that is received on the remote machine is not a ping packet. > Upon investigation

[dpdk-dev] [PATCH 2/2] eventdev: fix build for clang 4

2017-04-17 Thread Ferruh Yigit
build error: .../lib/librte_eventdev/rte_eventdev.c:371:6: error: logical not is only applied to the left hand side of this bitwise operator [-Werror,-Wlogical-not-parentheses] if (!dev_conf->event_dev_cfg & RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT) ^ Added parentheses after the '!' to evaluat

[dpdk-dev] [PATCH 1/2] mk: fix build for clang 4

2017-04-17 Thread Ferruh Yigit
clang 4 gives "taking address of packed member may result in an unaligned pointer value" warnings in a few locations [1]. Disabled "-Waddress-of-packed-member" warning for clang >= 4 [1] build errors: .../lib/librte_eal/common/eal_common_memzone.c:275:25: error: taking address of packed member 'm

[dpdk-dev] [PATCH] devtools: add git log checks for vsi, lsc, crc

2017-04-17 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- devtools/check-git-log.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index 8449d4f..910daba 100755 --- a/devtools/check-git-log.sh +++ b/devtools/check-git-log.sh @@ -121,10 +121,12 @@ bad=$(echo "$h

[dpdk-dev] Unable to send ping requests using pktgen-dpdk

2017-04-17 Thread Safiyat Reza
Hi, I am trying to ping a remote machine (within the same network) via port 0 using the command Pktgen> ping4 0 But the packet that is received on the remote machine is not a ping packet. Upon investigation using dpdkcap (https://github.com/dpdkcap/dpdkcap) and tcpdump, the packet dpdkcap outpu

Re: [dpdk-dev] [PATCH] net/i40e: downgrade error print

2017-04-17 Thread Ferruh Yigit
On 4/17/2017 7:53 AM, Wenzhuo Lu wrote: > When deleting the default MAC VLAN filter, it's > expected that it may fail. > So downgrade the error print from warning to > debug. > > Signed-off-by: Wenzhuo Lu Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix AEAD tests when AAD is zero

2017-04-17 Thread Pablo de Lara
For AEAD algorithms, additional authenticated data (AAD) can be passed, but it is optional, so its size can be zero. However, it is required to set this length to zero in the crypto operation to avoid undefined behaviour. Fixes: 617a7949c98a ("examples/l2fwd-crypto: parse AAD parameter") Signed-o

Re: [dpdk-dev] [PATCH] net/i40e: downgrade log message

2017-04-17 Thread Ferruh Yigit
On 4/14/2017 11:11 AM, Bernard Iremonger wrote: > Change level of log message from ERR to DEBUG and reword it, > in the i40e_dev_consistent_tunnel_filter_set() function. > > Signed-off-by: Bernard Iremonger Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] dev Digest, Vol 139, Issue 35

2017-04-17 Thread reshma sarat
Yes, as you said I had copied the header files to a location that is in some way packagable with your application. But it didn't work even after I had copied the rte_config.h file. Now I have removed the header files from the location and included them using -I directives in the makefile of my appl

Re: [dpdk-dev] [PATCH 0/2] net/virtio: support to turn on/off the traffic flow

2017-04-17 Thread Yang, Zhiyong
Hi, yuanhan: Sorry for the delay reply due to my annual leave. > -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Thursday, April 6, 2017 12:00 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; maxime.coque...@redhat.com > Subject: Re: [PATCH 0/2] net/v

Re: [dpdk-dev] clang compilation errors with clang 4.0

2017-04-17 Thread Yuanhan Liu
On Fri, Apr 14, 2017 at 04:55:53PM +0100, Bruce Richardson wrote: > Hi all, > > just a heads-up that there are compilation errors showing up with > compiling DPDK with clang 4.0 release. Here are some of the errors I am > seeing. Volunteers to do patches for some of them welcome. > > Regards, > /

[dpdk-dev] [PATCH] vhost: fix use after free

2017-04-17 Thread Yuanhan Liu
A "return" is missing on error, which could lead to a "use after free" issue (about var "conn"). Fixes: 65388b43f592 ("vhost: fix fd leaks for vhost-user server mode") Coverity issue: 143476 Reported-by: John McNamara Signed-off-by: Yuanhan Liu --- lib/librte_vhost/socket.c | 1 + 1 file chang