Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Thomas Monjalon
2017-04-13 12:11, Shreyansh Jain: > On Thursday 13 April 2017 01:25 AM, Olivier MATZ wrote: > > Hi, > > > > On Wed, 12 Apr 2017 14:31:56 +0200 > > Thomas Monjalon wrote: > > > >> 2017-04-12 11:31, Richardson, Bruce: > >>> > > [...] > > >> > >> I think the default mempool could be linked. > >> I

Re: [dpdk-dev] [PATCH v5 07/14] ring: make bulk and burst fn return vals consistent

2017-04-12 Thread Wang, Zhihong
Hi Bruce, This patch changes the behavior and causes some existing code to malfunction, e.g. bond_ethdev_stop() will get stuck here: while (rte_ring_dequeue(port->rx_ring, &pkt) != -ENOENT) rte_pktmbuf_free(pkt); Another example in test/test/virtual_pmd.c: virtual_ethdev_stop().

Re: [dpdk-dev] [PATCH v4 07/21] eal/vfio: adding vfio utility functions in map file

2017-04-12 Thread Shreyansh Jain
On Wednesday 12 April 2017 07:19 PM, Ferruh Yigit wrote: On 4/11/2017 2:37 PM, Hemant Agrawal wrote: adding extra vfio utility functions to map file. They will be used by other vfio supported buses like fslmc bus for NXP DPAA2 devices Signed-off-by: Hemant Agrawal <...> @@ -184,6 +184,9 @@

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Shreyansh Jain
On Thursday 13 April 2017 01:25 AM, Olivier MATZ wrote: Hi, On Wed, 12 Apr 2017 14:31:56 +0200 Thomas Monjalon wrote: 2017-04-12 11:31, Richardson, Bruce: [...] I think the default mempool could be linked. I don't know how easy it is to transform CONFIG_RTE_MBUF_DEFAULT_MEMPOOL

[dpdk-dev] [PATCH] ethdev: fix compilation issue with strict flags

2017-04-12 Thread Shahaf Shuler
Compilation error seen while compiling mlx5 in debug mode under RHEL 7.3: rte_ethdev.h:1670:7: error: type of bit-field 'state' is a GCC extension [-Werror=pedantic] Address it by removing the unnecessary bit-field width limitation. Fixes: d52268a8b24b ("ethdev: expose device states") Signe

[dpdk-dev] [PATCH v2] doc: add known igb_uio issue for i40e

2017-04-12 Thread Qiming Yang
When insmod "igb_uio" with "intr_mode=legacy and test link status interrupt. Since INTx interrupt is not supported by X710/XL710/XXV710, it will cause Input/Output error when reading file descriptor. Signed-off-by: Qiming Yang Acked-by Jingjing Wu --- v2 changes: * move the description to rel_no

[dpdk-dev] [PATCH] ethtool: disable promiscuous mode by default

2017-04-12 Thread Qi Zhang
Disable promiscuous mode by default since VLAN filter does not work when promiscuous mode is enabled. Signed-off-by: Qi Zhang --- examples/ethtool/ethtool-app/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c inde

Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-12 Thread Yuanhan Liu
On Thu, Apr 13, 2017 at 10:18:43AM +0800, Tan, Jianfeng wrote: > > > On 4/13/2017 9:58 AM, Yuanhan Liu wrote: > >On Fri, Apr 07, 2017 at 07:57:40AM +, Jianfeng Tan wrote: > >>After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled > >>by default. Actually, that's my point. The vhost

[dpdk-dev] [PATCH v2] net/i40e: fix VF link status update

2017-04-12 Thread Qi Zhang
VF link status rely on PF's notification, so when PF link status be updated, it should notify VF to update link status also. Current implementation only cover part of the situation when PF's link status is updated, call i40e_notify_all_vfs_link_status in i4e_dev_link_update will cover all situatio

Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-12 Thread Yuanhan Liu
On Thu, Apr 13, 2017 at 10:18:43AM +0800, Tan, Jianfeng wrote: > > > On 4/13/2017 9:58 AM, Yuanhan Liu wrote: > >On Fri, Apr 07, 2017 at 07:57:40AM +, Jianfeng Tan wrote: > >>After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled > >>by default. However, virtio-user vtpci does not s

Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-12 Thread Tan, Jianfeng
On 4/13/2017 9:58 AM, Yuanhan Liu wrote: On Fri, Apr 07, 2017 at 07:57:40AM +, Jianfeng Tan wrote: After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled by default. However, virtio-user vtpci does not support to get MTU from device yet, i.e., vtpci_read_dev_config(MTU) fails. Pl

Re: [dpdk-dev] [PATCH] net/virtio-user: fix cannot get initialized

2017-04-12 Thread Yuanhan Liu
On Fri, Apr 07, 2017 at 07:57:40AM +, Jianfeng Tan wrote: > After the introduction of vhost MTU, VIRTIO_NET_F_MTU is enabled > by default. However, virtio-user vtpci does not support to get > MTU from device yet, i.e., vtpci_read_dev_config(MTU) fails. > Plus, struct virtio_net_config is define

Re: [dpdk-dev] [PATCH v2] net/vhost: stop dev in close and address mem leak

2017-04-12 Thread Yuanhan Liu
On Thu, Apr 06, 2017 at 05:26:37PM -0700, Sagar Abhang wrote: > Move the call to stop the device inside the close routine because close > needs to stop the device if it isn't stopped. > > Free the allocated queue buffers in close instead of doing so in remove. > Original code had these clean ups i

Re: [dpdk-dev] [PATCH] net/virtio: fix queue notify

2017-04-12 Thread Yuanhan Liu
On Wed, Apr 12, 2017 at 02:39:25PM -0700, Stephen Hemminger wrote: > On Tue, 11 Apr 2017 03:44:28 -0700 > Xiao Wang wrote: > > > According to spec, we should write virtqueue index into the notify > > address, rather than 1. Besides, some HW backend may rely on the data > > written to identify whi

Re: [dpdk-dev] [PATCH 1/2] eal/ppc: fix mmap for memory initialization

2017-04-12 Thread Chao Zhu
Sergio, Thanks for the comments! On POWER, if it doesn't specify the MAP_HUGETLB flag when doing mapping, it may get the addresses from other regions. However, the address space size of hugepages is exactly the same as the value specified by user when doing initialization. There will be not enough

[dpdk-dev] Minutes of tech-board meeting 2017-04-10

2017-04-12 Thread Yuanhan Liu
Hi all, Here is the meeting notes for the last DPDK technical board meeting held on 2017-04-10. Please note that meetings are open to all to attend. Any topics to be referred to the tech board for discussion at that meeting should be emailed to techbo...@dpdk.org. Normally, it's a bi-weekly meeti

Re: [dpdk-dev] [PATCH v2] eal: redefine logtype values

2017-04-12 Thread Stephen Hemminger
On Wed, 12 Apr 2017 16:35:32 +0100 Pablo de Lara wrote: > + /* register legacy log types */ > + __rte_log_register("eal", RTE_LOGTYPE_EAL); > + __rte_log_register("malloc",RTE_LOGTYPE_MALLOC); > + __rte_log_register("ring", RTE_LOGTYPE_RING); > + __rte_log_regis

Re: [dpdk-dev] [PATCH] net/virtio: fix queue notify

2017-04-12 Thread Stephen Hemminger
On Tue, 11 Apr 2017 03:44:28 -0700 Xiao Wang wrote: > According to spec, we should write virtqueue index into the notify > address, rather than 1. Besides, some HW backend may rely on the data > written to identify which queue need to serve. > > Fixes: 6ba1f63b5ab0 ("virtio: support specificatio

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Olivier MATZ
Hi, On Wed, 12 Apr 2017 14:31:56 +0200 Thomas Monjalon wrote: > 2017-04-12 11:31, Richardson, Bruce: > > > > > -Original Message- > > > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > > > Sent: Wednesday, April 12, 2017 12:02 PM > > > To: Richardson, Bruce > > > Cc: Thomas Mon

Re: [dpdk-dev] [PATCH v2] eal: redefine logtype values

2017-04-12 Thread Olivier MATZ
Hi Pablo, On Wed, 12 Apr 2017 16:35:32 +0100 Pablo de Lara wrote: > After the changes in commit c1b5fa94a46f > ("eal: support dynamic log types"), logtype is not treated as a > bitmask, but a decimal value. Therefore, values have to be > converted. > > Fixes: c1b5fa94a46f ("eal: support dynami

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new xstats API add retrieving by ID

2017-04-12 Thread Thomas Monjalon
> --- a/app/proc_info/main.c > +++ b/app/proc_info/main.c > " --stats: to display port statistics, enabled by default\n" > " --xstats: to display extended port statistics, disabled by " > "default\n" > - " --metrics: to display derive

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: panic when destroying a queue in use

2017-04-12 Thread Adrien Mazarguil
On Wed, Apr 12, 2017 at 05:48:40PM +0100, Ferruh Yigit wrote: > On 4/11/2017 4:21 PM, Nelio Laranjeiro wrote: > > Since the queue release API does not allow failures (return value is void) > > and the flow API does not allow a queue to be released as long as a flow > > rule depends on it, the only

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix flow queues array allocation

2017-04-12 Thread Ferruh Yigit
On 4/12/2017 4:02 PM, Ferruh Yigit wrote: > On 4/11/2017 4:21 PM, Nelio Laranjeiro wrote: >> Flow queues array offset is not properly computed causing all sorts of >> issues. Address it by making the rte_flow structure less complex. >> >> Fixes: 360663e1df46 ("net/mlx5: prepare support for RSS act

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: panic when destroying a queue in use

2017-04-12 Thread Ferruh Yigit
On 4/11/2017 4:21 PM, Nelio Laranjeiro wrote: > Since the queue release API does not allow failures (return value is void) > and the flow API does not allow a queue to be released as long as a flow > rule depends on it, the only rational decision to avoid undefined behavior > is to panic in this si

Re: [dpdk-dev] [PATCH v2 00/42] Remove struct eth_driver

2017-04-12 Thread Stephen Hemminger
On Tue, 11 Apr 2017 17:44:07 +0200 Gaetan Rivet wrote: > I rebased the following work of Jan: > > This series is removing the PCI specific struct eth_driver from rte_ether. The > PCI drivers are changed to use the newly introduced header-only helpers > instead. Although the virtual drivers did n

Re: [dpdk-dev] [PATCH v13 0/7] rte_bus_pci

2017-04-12 Thread Stephen Hemminger
On Tue, 11 Apr 2017 13:07:27 +0200 Gaetan Rivet wrote: > I have rebased the work done by Shreyansh and Thomas to follow > the bus abstraction introduced in v17.02 for the PCI bus > implementation. > This series is only a partial version of the previous one, because > some of the patches have alre

Re: [dpdk-dev] [PATCH] net/i40e: reset NIC core

2017-04-12 Thread Iremonger, Bernard
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, April 12, 2017 3:11 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Lu, Wenzhuo > ; Iremonger, Bernard > > Subject: [PATCH] net/i40e: reset NIC core > > After a cloud filter has been replaced, to restore the NIC to it origina

[dpdk-dev] [PATCH v2] eal: redefine logtype values

2017-04-12 Thread Pablo de Lara
After the changes in commit c1b5fa94a46f ("eal: support dynamic log types"), logtype is not treated as a bitmask, but a decimal value. Therefore, values have to be converted. Fixes: c1b5fa94a46f ("eal: support dynamic log types") Signed-off-by: Pablo de Lara --- Changes in v2: - Used new RTE_LO

[dpdk-dev] [PATCH v2] net/i40e: fix to ensure vector mode is not used

2017-04-12 Thread Bernard Iremonger
In rx vector mode, the QinQ VLAN tag is not stripped. When hw_vlan_extend is set for QinQ ensure that rx vector mode is not selected. Fixes: 5b2d37858d32 ("net/i40e: fix single VLAN tag to be outer VLAN tag") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- Changes in v2: Rebased to la

Re: [dpdk-dev] [PATCH v12 02/22] doc: add DPAA2 NIC details

2017-04-12 Thread Ferruh Yigit
On 4/11/2017 2:49 PM, Hemant Agrawal wrote: > This patch adds the NXP dpaa2 architecture and pmd details > in the Network interfaces section. > > Signed-off-by: Hemant Agrawal > Acked-by: John McNamara > --- > MAINTAINERS| 1 + > doc/guides/nics/dpaa2.rst

Re: [dpdk-dev] [PATCH v2 00/10] doc: consolidate common part among PMD docs

2017-04-12 Thread Ferruh Yigit
On 4/11/2017 7:56 PM, Shijith Thotton wrote: > Steps for compiling PMDs and running testpmd in Linux are common among > drivers. So it can be moved to a new document and be referred from other > driver documentations. > > This patchset adds a new section for compiling and testing a PMD in > Networ

Re: [dpdk-dev] [PATCH] eal: redefine logtype values

2017-04-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, April 12, 2017 4:16 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH] eal: redefine logtype values > > 2017-04-12 15:14, Pablo de L

Re: [dpdk-dev] [PATCH] eal: redefine logtype values

2017-04-12 Thread Thomas Monjalon
2017-04-12 15:14, Pablo de Lara: > After the changes in commit c1b5fa94a46f > ("eal: support dynamic log types"), logtype is not treated as a > bitmask, but a decimal value. Therefore, values have to be > converted. > > Fixes: c1b5fa94a46f ("eal: support dynamic log types") > > Signed-off-by: Pab

Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used

2017-04-12 Thread Iremonger, Bernard
Hi Qi, > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Wednesday, April 12, 2017 12:43 PM > > To: Iremonger, Bernard ; > > dev@dpdk.org > > Cc: Xing, Beilei ; Lu, Wenzhuo > > ; Zhang, Qi ; > > Iremonger, Bernard > > Subject: RE: [dp

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix flow queues array allocation

2017-04-12 Thread Ferruh Yigit
On 4/11/2017 4:21 PM, Nelio Laranjeiro wrote: > Flow queues array offset is not properly computed causing all sorts of > issues. Address it by making the rte_flow structure less complex. > > Fixes: 360663e1df46 ("net/mlx5: prepare support for RSS action rule") > > Signed-off-by: Nelio Laranjeiro

[dpdk-dev] [PATCH] net/i40e: notify VF when link status be updated

2017-04-12 Thread Qi Zhang
VF link status rely on PF's notification, so when PF link status be updated, it should notify VF to update link status also. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_et

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shreyansh Jain > Sent: Wednesday, April 12, 2017 12:02 PM > To: Richardson, Bruce > Cc: Thomas Monjalon ; john miller > ; dev@dpdk.org; > olivier.m...@6wind.com > Subject: Re: [dpdk-dev] error in testpmd when CO

Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used

2017-04-12 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, April 12, 2017 3:08 PM > To: Iremonger, Bernard ; Zhang, Qi Z > ; dev@dpdk.org > Cc: Xing, Beilei ; Lu, Wenzhuo > ; Zhang, Qi > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not > used > > O

Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used

2017-04-12 Thread Zhang, Qi Z
Hi Bernard: > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, April 12, 2017 10:08 PM > To: Iremonger, Bernard ; Zhang, Qi Z > ; dev@dpdk.org > Cc: Xing, Beilei ; Lu, Wenzhuo > ; Zhang, Qi > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not > used >

[dpdk-dev] [PATCH] eal: redefine logtype values

2017-04-12 Thread Pablo de Lara
After the changes in commit c1b5fa94a46f ("eal: support dynamic log types"), logtype is not treated as a bitmask, but a decimal value. Therefore, values have to be converted. Fixes: c1b5fa94a46f ("eal: support dynamic log types") Signed-off-by: Pablo de Lara --- lib/librte_eal/common/include/rt

[dpdk-dev] [PATCH] maintainers: update for ena PMD

2017-04-12 Thread Marcin Wojtas
Following changes of the ENA driver ownership in Amazon and Semihalf (Jakub and Jan no longer work in the company), update driver's maintainers list. Special thanks to Jan Medala and Jakub Palider for their support and development. Signed-off-by: Marcin Wojtas --- MAINTAINERS | 6 +++--- 1 file

[dpdk-dev] [PATCH] net/i40e: reset NIC core

2017-04-12 Thread Bernard Iremonger
After a cloud filter has been replaced, to restore the NIC to it original state a reset of the NIC core is needed. A core reset has been added to the eth_i40e_dev_init function. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --g

[dpdk-dev] [PATCH v2] crypto/scheduler: fix Doxygen comments

2017-04-12 Thread Fan Zhang
This patch adds the missing doxygen comments and updated inline comments to cryptodev scheduler Fixes: d58a3f312545 ("crypto/scheduler: add documentation") Signed-off-by: Fan Zhang --- v2: - fixed typo doc/api/doxy-api-index.md | 3 +- doc/api/doxy-api.conf

Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used

2017-04-12 Thread Ferruh Yigit
On 4/12/2017 2:54 PM, Iremonger, Bernard wrote: > Hi Qi, > > > > > -Original Message- From: Zhang, Qi Z Sent: Wednesday, April 12, 2017 12:43 PM To: Iremonger, Bernard ; dev@dpdk.org Cc: Xing, Beilei ; Lu, Wenzhuo ; Zhang, Qi ; Iremonger, Bernard >>>

Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs

2017-04-12 Thread Thomas Monjalon
2017-04-12 13:47, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2017-04-12 13:11, De Lara Guarch, Pablo: > > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > > Sent: Wednesday, April 12, 2017 11:38 AM > > > > 2017-04-12 09:26, De Lara Guarch,

Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used

2017-04-12 Thread Iremonger, Bernard
Hi Qi, > > > -Original Message- > > > From: Zhang, Qi Z > > > Sent: Wednesday, April 12, 2017 12:43 PM > > > To: Iremonger, Bernard ; dev@dpdk.org > > > Cc: Xing, Beilei ; Lu, Wenzhuo > > > ; Zhang, Qi ; Iremonger, > > > Bernard > > > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to e

Re: [dpdk-dev] [PATCH v12 00/22] NXP DPAA2 PMD

2017-04-12 Thread Ferruh Yigit
On 4/11/2017 2:49 PM, Hemant Agrawal wrote: > This patches has been split from DPAA2 PMD v8 series [2] as per > comments received on ML [3].) > > The patch series adds NXP’s QorIQ-Layerscape DPAA2 Architecture based > network SoC PMD. This version of the driver supports NXP LS208xA, > LS204xA and

Re: [dpdk-dev] [PATCH v3] NXP DPAA2 External Mempool Driver

2017-04-12 Thread Ferruh Yigit
On 4/11/2017 2:42 PM, Hemant Agrawal wrote: > (This patches has been split from DPAA2 PMD v8 series [1] as per > comments received on ML [2].) > > This patch implements the HW mempool offload driver for packets buffers > using the FSLMC provided DPBP object. > > The new pool is being configured u

Re: [dpdk-dev] [PATCH v4 07/21] eal/vfio: adding vfio utility functions in map file

2017-04-12 Thread Ferruh Yigit
On 4/11/2017 2:37 PM, Hemant Agrawal wrote: > adding extra vfio utility functions to map file. > They will be used by other vfio supported buses like fslmc bus > for NXP DPAA2 devices > > Signed-off-by: Hemant Agrawal <...> > @@ -184,6 +184,9 @@ DPDK_17.02 { > rte_bus_register; > rt

Re: [dpdk-dev] [PATCH v4 00/21] NXP DPAA2 FSLMC Bus driver

2017-04-12 Thread Ferruh Yigit
On 4/11/2017 2:37 PM, Hemant Agrawal wrote: > (This patches has been split from DPAA2 PMD v8 series [1] as per > comments received on ML [2].) > > For V3 - please check at [3]. > > The patchset introduces NXP’s QorIQ-Layerscape DPAA2 Architecture based > fsl-mc bus driver. This version of the dri

Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs

2017-04-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, April 12, 2017 2:29 PM > To: De Lara Guarch, Pablo > Cc: Olivier Matz; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs > > 2017-04-12 13:11, De Lara Guarch, Pablo: >

Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs

2017-04-12 Thread Thomas Monjalon
2017-04-12 13:11, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > Sent: Wednesday, April 12, 2017 11:38 AM > > 2017-04-12 09:26, De Lara Guarch, Pablo: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > > > > > > > > The objective of this

Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs

2017-04-12 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, April 12, 2017 11:38 AM > To: De Lara Guarch, Pablo > Cc: Olivier Matz; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs > > 2017-04-12 09:26, De Lara Guarc

[dpdk-dev] [PATCH v9 3/3] app/testpmd: add CL for ptype mapping configure

2017-04-12 Thread Qi Zhang
Add below command line to configure ptype mapping. ptype mapping get . ptype mapping replace. ptype mapping reset . ptype mapping update . Signed-off-by: Qi Zhang --- v6: - Update testpmd_func.rst. v5: - Rebase to dpdk-next-net v3: - Fix compile issue when CONFIG_RTE_LIBRTE_I40E_PMD=

[dpdk-dev] [PATCH v9 2/3] net/i40e: configurable PTYPE mapping

2017-04-12 Thread Qi Zhang
The patch adds 4 APIs to support configurable PTYPE mapping for i40e device. rte_pmd_i40e_ptype_mapping_get. rte_pmd_i40e_ptype_mapping_replace. rte_pmd_i40e_ptype_mapping_reset. rte_pmd_i40e_ptype_mapping_update. The mapping from hardware defined packet type to software defined packet type can be

[dpdk-dev] [PATCH v9 1/3] net/i40e: enable per dev PTYPE mapping table

2017-04-12 Thread Qi Zhang
The mapping from hardware defined packet type to software defined packet type is static for i40e device, the patch let each ethdev to to have their own copy of mapping table, this give the possibility that different ethdev can be set different PTYPE mapping rule which is the requirement to support

[dpdk-dev] [PATCH v9 0/3] net/i40e: configurable PTYPE mapping

2017-04-12 Thread Qi Zhang
The patch set create new APIs that help to change the mapping from hardware defined packet type to software defined packet type for i40e NICs. Keep these APIs private is because currently they are only meaningful for devices that support dynamic PTYPE configuration, which may not be a general devic

Re: [dpdk-dev] I350 jumbo frame transmission

2017-04-12 Thread Bruce Richardson
On Wed, Apr 12, 2017 at 02:01:41PM +0100, Bruce Richardson wrote: > On Wed, Apr 12, 2017 at 06:21:01PM +0530, Karthikraj palanichamy wrote: > > Hi, > > > > I am using I350 card. The API rte_eth_dev_info_get() updated the parameter > > 'max_rx_pktlen' in 'struct rte_eth_dev_info' as 16384. > > > >

Re: [dpdk-dev] I350 jumbo frame transmission

2017-04-12 Thread Bruce Richardson
On Wed, Apr 12, 2017 at 06:21:01PM +0530, Karthikraj palanichamy wrote: > Hi, > > I am using I350 card. The API rte_eth_dev_info_get() updated the parameter > 'max_rx_pktlen' in 'struct rte_eth_dev_info' as 16384. > > But when I try transmission with multiple segments, I could not transmit > more

Re: [dpdk-dev] I350 jumbo frame transmission

2017-04-12 Thread Karthikraj palanichamy
But I could receive frames upto 16384 bytes. If 'max_rx_pktlen' is meant only for reception, then is there any way I could get the maximum tx capability? On 04/12/2017 06:21 PM, Karthikraj palanichamy wrote: Hi, I am using I350 card. The API rte_eth_dev_info_get() updated the parameter 'ma

[dpdk-dev] I350 jumbo frame transmission

2017-04-12 Thread Karthikraj palanichamy
Hi, I am using I350 card. The API rte_eth_dev_info_get() updated the parameter 'max_rx_pktlen' in 'struct rte_eth_dev_info' as 16384. But when I try transmission with multiple segments, I could not transmit more than 9732 bytes. I tried with testpmd and getting the same results.ie) couldn't

Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used

2017-04-12 Thread Zhang, Qi Z
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, April 12, 2017 8:30 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Xing, Beilei ; Lu, Wenzhuo > ; Zhang, Qi > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not > used > > Hi Qi, > > > -Original

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Thomas Monjalon
2017-04-12 11:31, Richardson, Bruce: > > > -Original Message- > > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > > Sent: Wednesday, April 12, 2017 12:02 PM > > To: Richardson, Bruce > > Cc: Thomas Monjalon ; john miller > > ; dev@dpdk.org; olivier.m...@6wind.com > > Subject: RE: [

Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used

2017-04-12 Thread Iremonger, Bernard
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, April 12, 2017 12:43 PM > To: Iremonger, Bernard ; dev@dpdk.org > Cc: Xing, Beilei ; Lu, Wenzhuo > ; Zhang, Qi ; Iremonger, > Bernard > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not > used > >

Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used

2017-04-12 Thread Zhang, Qi Z
Hi Bernard: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Tuesday, April 11, 2017 11:01 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Lu, Wenzhuo > ; Zhang, Qi ; Iremonger, > Bernard > Subject: [dpdk-dev] [PATCH] net/i40e: fix to ensure

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Neil Horman
On Wed, Apr 12, 2017 at 12:25:34PM +0200, Thomas Monjalon wrote: > 2017-04-12 11:05, Bruce Richardson: > > On Wed, Apr 12, 2017 at 04:52:47AM +, Shreyansh Jain wrote: > > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > > 2017-04-11 14:02, john miller: > > > > > > > > > > We are

Re: [dpdk-dev] [PATCH v3] NXP DPAA2 External Mempool Driver

2017-04-12 Thread Ferruh Yigit
On 4/11/2017 2:42 PM, Hemant Agrawal wrote: > (This patches has been split from DPAA2 PMD v8 series [1] as per > comments received on ML [2].) > > This patch implements the HW mempool offload driver for packets buffers > using the FSLMC provided DPBP object. > > The new pool is being configured u

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Richardson, Bruce
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Wednesday, April 12, 2017 12:02 PM > To: Richardson, Bruce > Cc: Thomas Monjalon ; john miller > ; dev@dpdk.org; olivier.m...@6wind.com > Subject: RE: [dpdk-dev] error in testpmd when > CONFIG_RTE_BUILD_S

Re: [dpdk-dev] [PATCH v2 38/42] ethdev: remove unused ethdev PCI probe/remove

2017-04-12 Thread Neil Horman
On Wed, Apr 12, 2017 at 07:24:26AM -0400, Neil Horman wrote: > On Tue, Apr 11, 2017 at 05:44:45PM +0200, Gaetan Rivet wrote: > > From: Jan Blunck > > > > This removes the now unused rte_eth_dev_pci_probe() and > > rte_eth_dev_pci_remove() functions. > > > > Signed-off-by: Jan Blunck > > --- > >

Re: [dpdk-dev] [PATCH v2 38/42] ethdev: remove unused ethdev PCI probe/remove

2017-04-12 Thread Neil Horman
On Tue, Apr 11, 2017 at 05:44:45PM +0200, Gaetan Rivet wrote: > From: Jan Blunck > > This removes the now unused rte_eth_dev_pci_probe() and > rte_eth_dev_pci_remove() functions. > > Signed-off-by: Jan Blunck > --- > lib/librte_ether/rte_ethdev.c | 97 > --

Re: [dpdk-dev] [PATCH v2 0/4] Ena PMD fixes

2017-04-12 Thread Ferruh Yigit
On 4/10/2017 11:20 PM, Jakub Palider wrote: > On Mon, Apr 10, 2017 at 4:28 PM, Marcin Wojtas wrote: <...> >> Michal Krawczyk (4): >> net/ena: fix incorrect Rx descriptors allocation >> net/ena: fix delayed cleanup of Rx descriptors >> net/ena: cleanup if refilling of rx descriptors fails >>

Re: [dpdk-dev] [PATCH] net/i40e: enable statistic reset for VF

2017-04-12 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, April 12, 2017 7:08 PM > To: Zhang, Qi Z > Subject: RE: [PATCH] net/i40e: enable statistic reset for VF > > -Original Message- > From: Zhang, Qi Z > Sent: Friday, February 24, 2017 2:27 AM > To: Wu, Jingjing; Zhang, Helin

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, April 12, 2017 11:42 AM > To: Shreyansh Jain > Cc: Thomas Monjalon ; john miller > ; > dev@dpdk.org; olivier.m...@6wind.com > Subject: Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y > >

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Shreyansh Jain
> -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, April 12, 2017 4:12 PM > To: Shreyansh Jain > Cc: Thomas Monjalon ; john miller > ; dev@dpdk.org; olivier.m...@6wind.com > Subject: Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHA

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Bruce Richardson
On Wed, Apr 12, 2017 at 11:38:55AM +0100, Bruce Richardson wrote: > On Wed, Apr 12, 2017 at 10:33:10AM +, Shreyansh Jain wrote: > > My bad - I was too quick in replying - some clarification beneath. > > > > > -Original Message- > > > From: Shreyansh Jain > > > Sent: Wednesday, April 12

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Bruce Richardson
On Wed, Apr 12, 2017 at 10:33:10AM +, Shreyansh Jain wrote: > My bad - I was too quick in replying - some clarification beneath. > > > -Original Message- > > From: Shreyansh Jain > > Sent: Wednesday, April 12, 2017 3:55 PM > > To: 'Bruce Richardson' > > Cc: Thomas Monjalon ; john mill

Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs

2017-04-12 Thread Thomas Monjalon
2017-04-12 09:26, De Lara Guarch, Pablo: > Hi Olivier, > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > > > > The objective of this patchset is to introduce a framework to > > support dynamic log types in EAL. It also provides one example of use > > (in i40e). > > > > Feat

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Shreyansh Jain
My bad - I was too quick in replying - some clarification beneath. > -Original Message- > From: Shreyansh Jain > Sent: Wednesday, April 12, 2017 3:55 PM > To: 'Bruce Richardson' > Cc: Thomas Monjalon ; john miller > ; dev@dpdk.org; olivier.m...@6wind.com > Subject: RE: [dpdk-dev] error in

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shreyansh Jain > Sent: Wednesday, April 12, 2017 11:26 AM > To: Richardson, Bruce > Cc: Thomas Monjalon ; john miller > ; dev@dpdk.org; > olivier.m...@6wind.com > Subject: Re: [dpdk-dev] error in testpmd when CO

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Shreyansh Jain
> -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, April 12, 2017 3:35 PM > To: Shreyansh Jain > Cc: Thomas Monjalon ; john miller > ; dev@dpdk.org; olivier.m...@6wind.com > Subject: Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHA

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Thomas Monjalon
2017-04-12 11:05, Bruce Richardson: > On Wed, Apr 12, 2017 at 04:52:47AM +, Shreyansh Jain wrote: > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > > 2017-04-11 14:02, john miller: > > > > > > > > We are seeing an issue when running from the head of the master branch > > > > in

Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y

2017-04-12 Thread Bruce Richardson
On Wed, Apr 12, 2017 at 04:52:47AM +, Shreyansh Jain wrote: > > -Original Message- > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > Sent: Wednesday, April 12, 2017 12:58 AM > > To: john miller > > Cc: dev@dpdk.org; olivier.m...@6wind.com; Shreyansh Jain > > > > Subject

Re: [dpdk-dev] [PATCH] net/i40e: disable init and driver logs by default

2017-04-12 Thread Bruce Richardson
On Wed, Apr 12, 2017 at 04:12:18AM +0100, Lu, Wenzhuo wrote: > Hi, > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Helin > > Sent: Friday, April 7, 2017 10:03 AM > > To: Richardson, Bruce > > Cc: Olivier Matz; dev@dpdk.org; Wu, Jingjing; Yigit, F

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: fix adding invalid MAC addr

2017-04-12 Thread Nélio Laranjeiro
Hi, note, please use the --thread option in addition of the in-reply-to to new series. Small comments inline, On Wed, Apr 12, 2017 at 05:02:24PM +0800, Wei Dai wrote: >[...] > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index ff903e6..91fc4c4 100644 > --- a/drivers/net/mlx4/

[dpdk-dev] [PATCH] app/crypto-perf: fix AEAD tests when AAD is zero

2017-04-12 Thread Pablo de Lara
For AEAD algorithms, additional authenticated data (AAD) can be passed, but it is optional, so its size can be zero. Therefore, test can be run if no memory is allocated. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Pablo de Lara --- app/test-cr

Re: [dpdk-dev] [PATCH v3 0/8] eal: dynamic logs

2017-04-12 Thread De Lara Guarch, Pablo
Hi Olivier, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Tuesday, April 04, 2017 5:41 PM > To: dev@dpdk.org > Cc: david.march...@6wind.com; Richardson, Bruce; > thomas.monja...@6wind.com; Wiles, Keith; > step...@networkplumber.org > Subje

[dpdk-dev] [PATCH v3 3/3] app/testpmd: add a command to add many MAC addrs

2017-04-12 Thread Wei Dai
This patch is added to introduce a testpmd command which is used to add more than one MAC addresses one time. This command can simplify the test for the change where the type of return value of adding MAC address. Normally a MAC address may fails to be added only after many MAC addresses have been

[dpdk-dev] [PATCH v3 1/3] ethdev: fix adding invalid MAC addr

2017-04-12 Thread Wei Dai
some customers find adding mac addr to VF sometimes can fail, but it is still stored in dev->data->mac_addrs[ ]. So this can lead to some errors that assumes the non-zero entry in dev->data->mac_addrs[ ] is valid. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Wei

[dpdk-dev] [PATCH v3 0/3] MAC address fail to be added shouldn't be stored

2017-04-12 Thread Wei Dai
Current ethdev always stores MAC address even it fails to be added. Other function may regard the failed MAC address valid and lead to some errors. So There is a need to check if the addr is added successfully or not and discard it if it fails. In 3rd patch, add a command "add_more_mac_addr port_i

[dpdk-dev] [PATCH v3 2/3] doc: change type of return value of adding MAC addr

2017-04-12 Thread Wei Dai
Add following lines in section of API change in release note. If a MAC address fails to be added without this change, it is still stored and may be regarded as a valid one. This may lead to errors in application. The type of return value of eth_mac_addr_add_t in rte_ethdev.h is changed. Any specif

[dpdk-dev] [PATCH] net/ixgbe: fix generic filter return info is not readable

2017-04-12 Thread Wei Zhao
Fix generic filter return info is not readable when repeat to create a rule. Fixes: 72c135a89f8 ("net/ixgbe: create consistent filter") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_flow.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/

Re: [dpdk-dev] [PATCH v5 2/3] net/e1000: new xstats API add ID support for e1000

2017-04-12 Thread Van Haaren, Harry
> From: Jastrzebski, MichalX K > Sent: Tuesday, April 11, 2017 5:37 PM > To: dev@dpdk.org > Cc: Jain, Deepak K ; Van Haaren, Harry > ; > Piasecki, JacekX ; Kozak, KubaX > > Subject: [PATCH v5 2/3] net/e1000: new xstats API add ID support for e1000 > > From: Jacek Piasecki > > To achieve funct

Re: [dpdk-dev] [PATCH v5 3/3] net/ixgbe: new xstats API add ID support for ixgbe

2017-04-12 Thread Van Haaren, Harry
> From: Jastrzebski, MichalX K > Sent: Tuesday, April 11, 2017 5:37 PM > To: dev@dpdk.org > Cc: Jain, Deepak K ; Van Haaren, Harry > ; > Piasecki, JacekX ; Kozak, KubaX > > Subject: [PATCH v5 3/3] net/ixgbe: new xstats API add ID support for ixgbe > > From: Jacek Piasecki > > To achieve funct

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new xstats API add retrieving by ID

2017-04-12 Thread Van Haaren, Harry
> From: Jastrzebski, MichalX K > Sent: Tuesday, April 11, 2017 5:37 PM > To: dev@dpdk.org > Cc: Jain, Deepak K ; Van Haaren, Harry > ; > Piasecki, JacekX ; Kozak, KubaX > ; Kulasek, > TomaszX > Subject: [PATCH v5 1/3] ethdev: new xstats API add retrieving by ID > > From: Jacek Piasecki > > Ex

Re: [dpdk-dev] [PATCH v8 2/3] net/i40e: configurable PTYPE mapping

2017-04-12 Thread Ferruh Yigit
On 4/7/2017 4:25 AM, Qi Zhang wrote: > The patch adds 4 APIs to support configurable > PTYPE mapping for i40e device. > rte_pmd_i40e_ptype_mapping_get. > rte_pmd_i40e_ptype_mapping_replace. > rte_pmd_i40e_ptype_mapping_reset. > rte_pmd_i40e_ptype_mapping_update. > The mapping from hardware defined

[dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2017-04-12 Thread Laurent Hardy
In case of fiber and link speed set to 1Gb at peer side (with autoneg or with defined speed), link status could be not properly updated at time cable is plugged-in. Indeed if cable was not plugged when device has been configured and started then link status will not be updated properly with new spe

[dpdk-dev] [PATCH v2] net/tap: add support for fixed mac addresses

2017-04-12 Thread Pascal Mazon
Support for a fixed MAC address for testing with the last octet incrementing by one for each interface defined with the new 'mac=fixed' string on the --vdev option. The default option is still to randomize the MAC address for each tap interface. Signed-off-by: Keith Wiles Signed-off-by: Pascal Ma

Re: [dpdk-dev] [PATCH 4/4] net/ena: calculate partial checksum if DF bit is disabled

2017-04-12 Thread Jan Mędala
I would recommend to check if packet type is IPv4 before processing IPv4 header for DF flag. This patch can break logic and go to unknown state when mbuf will contain IPv6 packet. I believe that in case of IPv6 pkt the loop should be skipped to next mbuf, if exists. Best regards, Jan

Re: [dpdk-dev] [PATCH v2 0/4] Ena PMD fixes

2017-04-12 Thread Jan M?dala
Acked-by: Jan Medala Jan

Re: [dpdk-dev] [PATCH 1/4] net/ena: fix incorrect Rx descriptors allocation

2017-04-12 Thread Jakub Palider
Looks good to me but please, check commnt on patch 2/4. Moving the "-1" indexing fix from patch 2/4 into 1/4 will reflect all related changes in one place. But this is not a functional change, so may go in current shape as well. Jakub On Fri, Apr 7, 2017 at 12:48 PM, Marcin Wojtas wrote: > From

  1   2   >