[dpdk-dev] [PATCH] net/i40e/base: add README file

2017-04-01 Thread Jingjing Wu
Add README file in base to track the base code modification. Signed-off-by: Jingjing Wu --- drivers/net/i40e/base/README | 59 1 file changed, 59 insertions(+) create mode 100644 drivers/net/i40e/base/README diff --git a/drivers/net/i40e/base/README

[dpdk-dev] [PATCH] doc: fix description on intel VFs

2017-04-01 Thread Jingjing Wu
This patch corrects the description on Physical and Virtual Function Infrastructure of Intel NICs. The RSS part description should belong to ixgbe but not i40e. This patch also add more notes to describe the queue number on Intel X710/XL710 NICs. Fixes: b9fcaeec5fc0 ("doc: add ixgbe VF RSS guide")

[dpdk-dev] [RFC 2/2] doc: include PMD build and run file in liquidio doc

2017-04-01 Thread Shijith Thotton
Include build_and_run.inc instead of instructions to build PMD and run testpmd in liquidio driver documentation. Signed-off-by: Shijith Thotton --- doc/guides/nics/liquidio.rst | 85 ++-- 1 file changed, 2 insertions(+), 83 deletions(-) diff --git a/doc/g

[dpdk-dev] [RFC 1/2] doc: add doc with steps to build PMD and run testpmd

2017-04-01 Thread Shijith Thotton
Add a new document with steps to build PMDs and launch a sample test application, "testpmd". It can be included in other PMD documentations or be referred. Suggested-by: Ferruh Yigit Signed-off-by: Shijith Thotton --- doc/guides/nics/build_and_run.inc | 110 +

[dpdk-dev] [RFC 0/2] doc: consolidate common part among PMD docs

2017-04-01 Thread Shijith Thotton
Steps to build PMD and to run sample application are common among drivers. So those instructions can be moved to a new file. It is possible to include this file in driver documentations or be referred using a label. RFC has two parts: 1. Introduce new doc file. 2. Make use of the file in liquidio

Re: [dpdk-dev] [PATCH v7 00/22] next-eventdev: event/sw software eventdev

2017-04-01 Thread Jerin Jacob
On Thu, Mar 30, 2017 at 08:30:28PM +0100, Harry van Haaren wrote: > This is the v7 patchset of the software eventdev PMD. > Changes include the following, see patch for context > and details; > > - Docs patch now consistently uses eventdev (Anatoly) > - Reworded "root cause" to "reason" for readab

Re: [dpdk-dev] [PATCH] doc: add eventdev library to 17.05 release notes

2017-04-01 Thread Jerin Jacob
On Fri, Mar 31, 2017 at 02:54:10PM +, Van Haaren, Harry wrote: > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Friday, March 31, 2017 3:20 PM > > To: dev@dpdk.org > > Cc: thomas.monja...@6wind.com; Richardson, Bruce > > ; Van Haaren, > > Harry ; hemant.agra...@nxp.com;

[dpdk-dev] vfio: failed to select IOMMU type

2017-04-01 Thread Andrew Rybchenko
Hi, after the following commit (it was picked up by dpdk-next-net recently), I have problems with VFIO: === commit 94c0776b1badd1ee715d60f07391058f23494365 Author: Alejandro Lucero Date: Wed Mar 29 10:54:50 2017 +0100 vfio: support hotplug Current device hotplug is just supported b

Re: [dpdk-dev] [PATCH v4 00/22] vhost: generic vhost API

2017-04-01 Thread Yuanhan Liu
On Sat, Apr 01, 2017 at 03:22:38PM +0800, Yuanhan Liu wrote: > This patchset makes DPDK vhost library generic enough, so that we could > build other vhost-user drivers on top of it. For example, SPDK (Storage > Performance Development Kit) is trying to enable vhost-user SCSI. > > The basic idea is

Re: [dpdk-dev] [PATCH] vhost: remove a hack on queue allocation

2017-04-01 Thread Yuanhan Liu
On Sat, Apr 01, 2017 at 04:32:58PM +0800, Yuanhan Liu wrote: > On Wed, Mar 22, 2017 at 04:56:12PM +0800, Yuanhan Liu wrote: > > On Wed, Mar 22, 2017 at 09:41:07AM +0100, Maxime Coquelin wrote: > > > > > > > > > On 03/02/2017 07:16 AM, Yuanhan Liu wrote: > > > >We used to allocate queues based on

Re: [dpdk-dev] [PATCH] vhost: remove a hack on queue allocation

2017-04-01 Thread Yuanhan Liu
On Wed, Mar 22, 2017 at 04:56:12PM +0800, Yuanhan Liu wrote: > On Wed, Mar 22, 2017 at 09:41:07AM +0100, Maxime Coquelin wrote: > > > > > > On 03/02/2017 07:16 AM, Yuanhan Liu wrote: > > >We used to allocate queues based on the index from SET_VRING_CALL > > >request: if corresponding queue hasn't

Re: [dpdk-dev] [PATCH v4 06/22] vhost: introduce API to fetch negotiated features

2017-04-01 Thread Maxime Coquelin
On 04/01/2017 09:22 AM, Yuanhan Liu wrote: Signed-off-by: Yuanhan Liu --- v4: use parameter to store the returned features and return -1 on error --- lib/librte_vhost/rte_vhost_version.map | 1 + lib/librte_vhost/rte_virtio_net.h | 12 lib/librte_vhost/vhost.c

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: change command line of getting profile info

2017-04-01 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Saturday, April 1, 2017 3:57 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/2] app/testpmd: change command line of > getting profile info > > This patch changes

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: change command line of loading profile

2017-04-01 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Saturday, April 1, 2017 3:57 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/2] app/testpmd: change command line of > loading profile > > This patch changes CLI o

[dpdk-dev] [PATCH 0/2] MAC address fail to be added shouldn't be stored

2017-04-01 Thread Wei Dai
Current ethdev always stores MAC address even it fails to be added. Other function may regard the failed MAC address valid and lead to some errors. So There is a need to check if the addr is added successfully or not and discard it if it fails. In 2nd patch, add a command "add_more_mac_addr port_i

[dpdk-dev] [PATCH 2/2] app/testpmd: add a command to add many MAC addrs

2017-04-01 Thread Wei Dai
Signed-off-by: Wei Dai --- app/test-pmd/cmdline.c | 55 ++ 1 file changed, 55 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 47f935d..8dab30e 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -639

[dpdk-dev] [PATCH 1/2] ethdev: fix adding invalid MAC addr

2017-04-01 Thread Wei Dai
some customers find adding mac addr to VF sometimes can fail, but it is still stored in dev->data->mac_addrs[ ]. So this can lead to some errors that assumes the non-zero entry in dev->data->mac_addrs[ ] is valid. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Wei

[dpdk-dev] [PATCH v2 2/2] app/testpmd: change command line of getting profile info

2017-04-01 Thread Beilei Xing
This patch changes CLI of getting loaded profile info list from "get ddp list (port_id)" to "ddp get list (port_id)" which is more consistent with other CLIs. Signed-off-by: Beilei Xing --- app/test-pmd/cmdline.c | 42 +- 1 file changed, 21 insertions(+),

[dpdk-dev] [PATCH v2 0/2] change command line for ddp

2017-04-01 Thread Beilei Xing
This patch set changes CLI for ddp to align with other CLIs. v2 changes: Change structure name and function name. Beilei Xing (2): app/testpmd: change command line of loading profile app/testpmd: change command line of getting profile info app/test-pmd/cmdline.c | 84 ++

[dpdk-dev] [PATCH v2 1/2] app/testpmd: change command line of loading profile

2017-04-01 Thread Beilei Xing
This patch changes CLI of loading profile from "add ddp (port_id) (profile_path)" to "ddp add (port_id) (profile_path)" which is more consistent with other CLIs. Signed-off-by: Beilei Xing --- app/test-pmd/cmdline.c | 42 +- 1 file changed, 21 insertions(+

Re: [dpdk-dev] [PATCH v2 1/3] lib/librte_ether: remove requirement of aligned RETA size

2017-04-01 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Helin > Sent: Friday, March 31, 2017 3:34 PM > To: Thomas Monjalon; Yongseok Koh; Yigit, Ferruh; Ananyev, Konstantin > Cc: dev@dpdk.org; adrien.mazarg...@6wind.com; > nelio.laranje...@6wind.com > Subject

[dpdk-dev] [PATCH v4 22/22] examples/vhost: demonstrate the new generic vhost APIs

2017-04-01 Thread Yuanhan Liu
Now DPDK vhost lib has been generic enough, that it can be used to implement any vhost-user drivers. For example, this patch implements a very simple vhost-user net driver, mainly for demonstrating how to use those generic vhost APIs. And when the --builtin-net-driver option is used, the example

[dpdk-dev] [PATCH v4 21/22] vhost: do not destroy device on repeat mem table message

2017-04-01 Thread Yuanhan Liu
It doesn't make any sense to invoke destroy_device() callback at while handling SET_MEM_TABLE message. >From the vhost-user spec, it's the GET_VRING_BASE message indicates the end of a vhost device: the destroy_device() should be invoked from there (luckily, we already did that). Signed-off-by: Y

[dpdk-dev] [PATCH v4 19/22] vhost: rename header file

2017-04-01 Thread Yuanhan Liu
Rename "rte_virtio_net.h" to "rte_vhost.h", to not let it be virtio net specific. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 9 - doc/guides/rel_notes/release_17_05.rst | 3 + drivers/net/vhost/rte_eth_vhost.c | 2 +- drivers/

[dpdk-dev] [PATCH v4 18/22] vhost: introduce API to start a specific driver

2017-04-01 Thread Yuanhan Liu
We used to use rte_vhost_driver_session_start() to trigger the vhost-user session. It takes no argument, thus it's a global trigger. And it could be problematic. The issue is, currently, rte_vhost_driver_register(path, flags) actually tries to put it into the session loop (by fdset_add). However,

[dpdk-dev] [PATCH v4 20/22] vhost: workaround the build dependency on mbuf header

2017-04-01 Thread Yuanhan Liu
rte_mbuf struct is something more likely will be used only in vhost-user net driver, while we have made vhost-user generic enough that it can be used for implementing other drivers (such as vhost-user SCSI), they have also include . Otherwise, the build will be broken. We could workaround it by us

[dpdk-dev] [PATCH v4 15/22] vhost: rename virtio-net to vhost

2017-04-01 Thread Yuanhan Liu
Rename "virtio-net" to "vhost" in the API comments and vhost prog guide. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- doc/guides/prog_guide/vhost_lib.rst | 6 +++--- lib/librte_vhost/rte_virtio_net.h | 14 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff

[dpdk-dev] [PATCH v4 07/22] vhost: export vhost vring info

2017-04-01 Thread Yuanhan Liu
Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- v2: - fix off-by-one check - add API comments --- lib/librte_vhost/rte_vhost_version.map | 1 + lib/librte_vhost/rte_virtio_net.h | 26 ++ lib/librte_vhost/vhost.c | 30 ++

[dpdk-dev] [PATCH v4 16/22] vhost: add features changed callback

2017-04-01 Thread Yuanhan Liu
Features could be changed after the feature negotiation. For example, VHOST_F_LOG_ALL will be set/cleared at the start/end of live migration, respecitively. Thus, we need a new callback to inform the application on such change. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- doc/gui

[dpdk-dev] [PATCH v4 17/22] vhost: export APIs for live migration support

2017-04-01 Thread Yuanhan Liu
Export few APIs for the vhost-user driver to log the guest memory writes, which is a must for live migration support. This patch basically moves vhost_log_write() and vhost_log_used_vring() into vhost.h and then add an wrapper (the public API) to them. Signed-off-by: Yuanhan Liu Reviewed-by: Max

[dpdk-dev] [PATCH v4 14/22] vhost: rename device ops struct

2017-04-01 Thread Yuanhan Liu
rename "virtio_net_device_ops" to "vhost_device_ops", to not let it be virtio-net specific. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- doc/guides/prog_guide/vhost_lib.rst| 2 +- doc/guides/rel_notes/release_17_05.rst | 3 +++ drivers/net/vhost/rte_eth_vhost.c | 2 +- e

[dpdk-dev] [PATCH v4 09/22] vhost: turn queue pair to vring

2017-04-01 Thread Yuanhan Liu
The queue pair is very virtio-net specific, other devices don't have such concept. To make it generic, we should log the number of vrings instead of the number of queue pairs. This patch just does a simple convert, a later patch would export the number of vrings to applications. Signed-off-by: Yu

[dpdk-dev] [PATCH v4 13/22] vhost: do not include net specific headers

2017-04-01 Thread Yuanhan Liu
Include it internally, at vhost.h. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- v2: - update release note --- doc/guides/rel_notes/release_17_05.rst | 7 +++ examples/vhost/main.h | 2 ++ lib/librte_vhost/rte_virtio_net.h | 4 lib/librte_vhost/vhos

[dpdk-dev] [PATCH v4 10/22] vhost: export the number of vrings

2017-04-01 Thread Yuanhan Liu
We used to use rte_vhost_get_queue_num() for telling how many vrings. However, the return value is the number of "queue pairs", which is very virtio-net specific. To make it generic, we should return the number of vrings instead, and let the driver do the proper translation. Say, virtio-net driver

[dpdk-dev] [PATCH v4 11/22] vhost: move the device ready check at proper place

2017-04-01 Thread Yuanhan Liu
Currently, we check vq->desc, vq->kickfd and vq->callfd to know whether a virtio device is ready or not. However, we only do it when handling SET_VRING_KICK message, which could be wrong if a vhost-user frontend send SET_VRING_KICK first and SET_VRING_CALL later. To work for all possible vhost-use

[dpdk-dev] [PATCH v4 12/22] vhost: drop the Rx and Tx queue macro

2017-04-01 Thread Yuanhan Liu
They are virtio-net specific and should be defined inside the virtio-net driver. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- v2: - update release note --- doc/guides/rel_notes/release_17_05.rst | 6 ++ drivers/net/vhost/rte_eth_vhost.c | 2 ++ examples/tep_termination/

[dpdk-dev] [PATCH v4 06/22] vhost: introduce API to fetch negotiated features

2017-04-01 Thread Yuanhan Liu
Signed-off-by: Yuanhan Liu --- v4: use parameter to store the returned features and return -1 on error --- lib/librte_vhost/rte_vhost_version.map | 1 + lib/librte_vhost/rte_virtio_net.h | 12 lib/librte_vhost/vhost.c | 13 + 3 files changed, 26 inser

[dpdk-dev] [PATCH v4 08/22] vhost: export API to translate gpa to vva

2017-04-01 Thread Yuanhan Liu
Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- lib/librte_vhost/rte_vhost_version.map | 1 + lib/librte_vhost/rte_virtio_net.h | 28 lib/librte_vhost/vhost.h | 19 --- lib/librte_vhost/virtio_net.c | 23 ++

[dpdk-dev] [PATCH v4 05/22] vhost: export guest memory regions

2017-04-01 Thread Yuanhan Liu
Some vhost-user driver may need this info to setup its own page tables for GPA (guest physical addr) to HPA (host physical addr) translation. SPDK (Storage Performance Development Kit) is one example. Besides, by exporting this memory info, we could also export the gpa_to_vva() as an inline functi

[dpdk-dev] [PATCH v4 03/22] vhost: use new APIs to handle features

2017-04-01 Thread Yuanhan Liu
Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- v3: fix comment typo --- examples/tep_termination/main.c| 4 +++- examples/vhost/main.c | 43 +- lib/librte_vhost/rte_vhost_version.map | 3 --- lib/librte_vhost/rte_virtio_net

[dpdk-dev] [PATCH v4 04/22] vhost: make notify ops per vhost driver

2017-04-01 Thread Yuanhan Liu
Assume there is an application both support vhost-user net and vhost-user scsi, the callback should be different. Making notify ops per vhost driver allow application define different set of callbacks for different driver. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- v2: - check

[dpdk-dev] [PATCH v4 01/22] vhost: introduce driver features related APIs

2017-04-01 Thread Yuanhan Liu
Introduce few APIs to set/get/enable/disable driver features. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- doc/guides/prog_guide/vhost_lib.rst| 10 +++- lib/librte_vhost/rte_vhost_version.map | 4 ++ lib/librte_vhost/rte_virtio_net.h | 53 lib/librt

[dpdk-dev] [PATCH v4 02/22] net/vhost: remove feature related APIs

2017-04-01 Thread Yuanhan Liu
The rte_eth_vhost_feature_disable/enable/get APIs are just a wrapper of rte_vhost_feature_disable/enable/get. However, the later are going to be refactored; it's going to take an extra parameter (socket_file path), to let it be per-device. Instead of changing those vhost-pmd APIs to adapt to the n

[dpdk-dev] [PATCH v4 00/22] vhost: generic vhost API

2017-04-01 Thread Yuanhan Liu
This patchset makes DPDK vhost library generic enough, so that we could build other vhost-user drivers on top of it. For example, SPDK (Storage Performance Development Kit) is trying to enable vhost-user SCSI. The basic idea is, let DPDK vhost be a vhost-user agent. It stores all the info about th