Re: [dpdk-dev] [PATCH] maintainers: claim responsability for xen

2017-02-16 Thread Vincent JARDIN
Le 16/02/2017 à 14:36, Konrad Rzeszutek Wilk a écrit : Is it time now to officially remove Dom0 support? So we do have an prototype implementation of netback but it is waiting for review of xen-devel to the spec. And I believe the implementation does utilize some of the dom0 parts of code in DP

Re: [dpdk-dev] [PATCH 6/7] net/virtio: Add MTU feature support

2017-02-16 Thread Maxime Coquelin
Hi Aaron, On 02/16/2017 08:31 PM, Aaron Conole wrote: Maxime Coquelin writes: This patch implements support for the Virtio MTU feature. When negotiated, the host shares its maximum supported MTU, which is used as initial MTU and as maximum MTU the application can set. Signed-off-by: Maxime C

Re: [dpdk-dev] [PATCH 6/7] net/virtio: Add MTU feature support

2017-02-16 Thread Aaron Conole
Maxime Coquelin writes: > This patch implements support for the Virtio MTU feature. > When negotiated, the host shares its maximum supported MTU, > which is used as initial MTU and as maximum MTU the application > can set. > > Signed-off-by: Maxime Coquelin > --- > doc/guides/nics/features/virt

Re: [dpdk-dev] rte_sched library performance question

2017-02-16 Thread Dumitrescu, Cristian
Hi Zoltan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zoltan Kiss > Sent: Thursday, February 16, 2017 3:14 PM > To: dev@dpdk.org > Subject: [dpdk-dev] rte_sched library performance question > > Hi, > > I'm experimenting a little bit with the scheduler lib

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-16 Thread Jan Blunck
On Thu, Feb 16, 2017 at 2:48 PM, Olivier Matz wrote: > On Mon, 6 Feb 2017 18:41:27 +, "Ananyev, Konstantin" > wrote: >> > >> > The main changes are: >> > - reorder structure to increase vector performance on some non-ia >> > platforms. >> > - add a 64bits timestamp field in the 1st cache li

Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset

2017-02-16 Thread Olivier Matz
Hi Wei, On Thu, 9 Feb 2017 14:50:05 +, "Dai, Wei" wrote: > > -Original Message- > > From: Dai, Wei > > Sent: Thursday, February 9, 2017 10:38 PM > > To: 'Olivier Matz' ; dev@dpdk.org; Zhang, > > Helin ; Ananyev, Konstantin > > > > Cc: Guo Fengtian ; sta...@dpdk.org > > Subject: RE: [

[dpdk-dev] [PATCH v2] net/ixgbe: ensure link status is updated

2017-02-16 Thread Olivier Matz
From: Laurent Hardy In case of fiber and link speed set to 1Gb at peer side (with autoneg or with defined speed), link status could be not properly updated at time cable is plugged-in. Indeed if cable was not plugged when device has been configured and started then link status will not be updated

[dpdk-dev] [PATCH] examples: ethtool: Link against librte_pmd_ixgbe if necessary

2017-02-16 Thread Markos Chandras
The librte_ethtool library depends on librte_pmd_ixgbe if that pmd driver is enabled so we need to link against it when we compile the ethtool application. It fixes the following build problem: /usr/lib64/gcc/x86_64-suse-linux/6/../../../../x86_64-suse-linux/bin/ld: warning: librte_pmd_ixgbe.so.1,

Re: [dpdk-dev] [PATCH] maintainers: claim responsability for xen

2017-02-16 Thread Jan Blunck
On Thu, Feb 16, 2017 at 2:36 PM, Konrad Rzeszutek Wilk wrote: > On Thu, Feb 16, 2017 at 12:06:18PM +0100, Thomas Monjalon wrote: >> >> Any news about Xen dom0 status in DPDK? >> >> I think there is not enough interest for Xen dom0 in the DPDK community. >> Last time we talked about, it was because

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-16 Thread Olivier Matz
On Thu, 16 Feb 2017 15:46:19 +, Bruce Richardson wrote: > On Thu, Feb 16, 2017 at 02:48:07PM +0100, Olivier Matz wrote: > > Hi Konstantin, > > > > Thanks for the feedback. > > Comments inline. > > > > > > On Mon, 6 Feb 2017 18:41:27 +, "Ananyev, Konstantin" > > wrote: > > > Hi Olivie

Re: [dpdk-dev] [PATCH 6/7] eal: add struct rte_vdev_device

2017-02-16 Thread Jan Blunck
On Wed, Feb 15, 2017 at 6:11 PM, Ferruh Yigit wrote: > On 2/15/2017 10:02 AM, Jan Blunck wrote: >> This adds the rte_vdev_device structure which embeds a generic rte_device. >> >> Signed-off-by: Jan Blunck > > <...> > >> >> +struct rte_vdev_device { >> + TAILQ_ENTRY(rte_vdev_device) next;

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-16 Thread Bruce Richardson
On Thu, Feb 16, 2017 at 02:48:07PM +0100, Olivier Matz wrote: > Hi Konstantin, > > Thanks for the feedback. > Comments inline. > > > On Mon, 6 Feb 2017 18:41:27 +, "Ananyev, Konstantin" > wrote: > > Hi Olivier, > > Looks good in general, some comments from me below. > > Thanks > > Konstanti

Re: [dpdk-dev] [PATCH] prefetch second cacheline of mbufs on alloc

2017-02-16 Thread Olivier Matz
On Wed, 15 Feb 2017 09:44:35 +0100, Thomas Monjalon wrote: > Do we need to discuss again the prefetch calls inside DPDK > or can we definitely close this kind of request? > mbuf: http://dpdk.org/patch/4678/ > ethdev: http://dpdk.org/patch/8867/ > About the mbuf prefetch, I suggest th

[dpdk-dev] rte_sched library performance question

2017-02-16 Thread Zoltan Kiss
Hi, I'm experimenting a little bit with the scheduler library, and I got some performance numbers which seems to be worse than what I've expected. I'm sending 64 bytes packets on a 10G interface to a separate thread, and my simple test program (based on the qos_sched example) does the following:

Re: [dpdk-dev] [PATCH v1] doc: add template release notes for 17.05

2017-02-16 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, February 15, 2017 2:55 PM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] doc: add template release notes for > 17.05 > > 2017-02-15 12:38, John McNamara: > >

[dpdk-dev] [PATCH v2 3/5] mk: add new test-basic make rule

2017-02-16 Thread Ferruh Yigit
Since "make test" and "make test-build" does dependency resolving, they check for all dependent components (lib and drivers) which takes a few seconds. This is a good feature during development, but if the target is only running unit test, that step is unnecessary, it is possible to compile once a

[dpdk-dev] [PATCH v2 5/5] doc: document test related make rules in make help

2017-02-16 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- doc/build-sdk-quick.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt index 967ff09..8673b11 100644 --- a/doc/build-sdk-quick.txt +++ b/doc/build-sdk-quick.txt @@ -9,6 +9,8 @@ Build commands install

[dpdk-dev] [PATCH v2 4/5] mk: rename test related make rules

2017-02-16 Thread Ferruh Yigit
Make rules renamed to a common syntax, test-x: fast_test-> test-fast ring_test-> test-ring mempool_test -> test-mempool perf_test-> test-perf These are to run various sub-set of the unit tests. Not touched to make rules that are already following the syntax: test-basic test-build test

[dpdk-dev] [PATCH v2 1/5] test: move tests to separate folder

2017-02-16 Thread Ferruh Yigit
This is to logically group unit tests into their own folder, separating them from "app" folder. Hopefully this will make the unit test in DPDK more visible. Following binaries moved to "test" folder: cmdline-test test-acl test-pipeline test<-- various DPDK unit tests Signed-off-by: F

[dpdk-dev] [PATCH v2 2/5] mk: do not build tests by default

2017-02-16 Thread Ferruh Yigit
Don't build tests with default "make" command. Require explicit command to build tests because not everybody interested in running unit tests. Following changes done in make rules: "make test-build" <--- Added "make test"<--- Updated functionality (build + run basic tests) Now "make tes

Re: [dpdk-dev] [PATCH] maintainers: claim responsability for xen

2017-02-16 Thread Konrad Rzeszutek Wilk
On Thu, Feb 16, 2017 at 12:06:18PM +0100, Thomas Monjalon wrote: > 2016-11-11 04:49, Tan, Jianfeng: > > Hi Thomas and Konrad, > > > > On 11/11/2016 2:59 AM, Konrad Rzeszutek Wilk wrote: > > > On Wed, Nov 9, 2016 at 5:03 PM, Thomas Monjalon wrote: > > >> 2016-11-07 07:38, Jianfeng Tan: > > >>> As s

Re: [dpdk-dev] i40e queues per VF

2017-02-16 Thread Thomas Monjalon
2017-02-16 13:58, Wu, Jingjing: > From: Thomas Monjalon > > > > Hi, > > > > When reading the documentation, it is not easy to understand the capability > > of > > i40evf for the number of queues. > > > > First, please could you explain why we need a build-time config option? > > In the doc, the

Re: [dpdk-dev] i40e queues per VF

2017-02-16 Thread Wu, Jingjing
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Tuesday, February 14, 2017 6:07 PM > To: Zhang, Helin ; Wu, Jingjing > Cc: Mcnamara, John ; dev@dpdk.org > Subject: i40e queues per VF > > Hi, > > When reading the documentation, it is not easy to u

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-02-16 Thread Ilya Maximets
On 16.02.2017 16:55, Ilya Maximets wrote: > Hi, > > On 16.02.2017 16:26, Tan, Jianfeng wrote: >> Hi, >> >>> -Original Message- >>> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >>> Sent: Thursday, February 16, 2017 9:01 PM >>> To: dev@dpdk.org; David Marchand; Gonzalez Monroy, Serg

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-02-16 Thread Ilya Maximets
Hi, On 16.02.2017 16:26, Tan, Jianfeng wrote: > Hi, > >> -Original Message- >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Thursday, February 16, 2017 9:01 PM >> To: dev@dpdk.org; David Marchand; Gonzalez Monroy, Sergio >> Cc: Heetae Ahn; Yuanhan Liu; Tan, Jianfeng; Neil

[dpdk-dev] [PATCH] app/crypto-perf: fix invalid latency for QAT PMD

2017-02-16 Thread Slawomir Mrozowicz
Fixes invalid latency result when using the performance application and hardware QAT PMD. It occurred when the number of processed packets was higher then the size of the internal QAT PMD ring buffer and the buffer was overflowed. Fixed by correcting the registration of the enqueued packets and fre

Re: [dpdk-dev] [RFC 0/8] mbuf: structure reorganization

2017-02-16 Thread Olivier Matz
Hi Konstantin, Thanks for the feedback. Comments inline. On Mon, 6 Feb 2017 18:41:27 +, "Ananyev, Konstantin" wrote: > Hi Olivier, > Looks good in general, some comments from me below. > Thanks > Konstantin > > > > > The main changes are: > > - reorder structure to increase vector perform

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-02-16 Thread Bruce Richardson
On Thu, Feb 16, 2017 at 04:01:10PM +0300, Ilya Maximets wrote: > Currently EAL allocates hugepages one by one not paying > attention from which NUMA node allocation was done. > > Such behaviour leads to allocation failure if number of > available hugepages for application limited by cgroups > or h

Re: [dpdk-dev] [PATCHv7 00/47] NXP DPAA2 PMD

2017-02-16 Thread Bruce Richardson
On Thu, Feb 16, 2017 at 08:22:49AM -0500, Neil Horman wrote: > On Thu, Feb 16, 2017 at 06:08:59AM +0530, Hemant Agrawal wrote: > > The patch series adds NXP’s QorIQ-Layerscape DPAA2 Architecture based > > fsl-mc bus driver and network SoC PMD. This version of the driver > > supports NXP LS208xA, L

Re: [dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-02-16 Thread Tan, Jianfeng
Hi, > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Thursday, February 16, 2017 9:01 PM > To: dev@dpdk.org; David Marchand; Gonzalez Monroy, Sergio > Cc: Heetae Ahn; Yuanhan Liu; Tan, Jianfeng; Neil Horman; Pei, Yulong; Ilya > Maximets; sta...@dpdk.org >

Re: [dpdk-dev] [PATCHv7 00/47] NXP DPAA2 PMD

2017-02-16 Thread Neil Horman
On Thu, Feb 16, 2017 at 06:08:59AM +0530, Hemant Agrawal wrote: > The patch series adds NXP’s QorIQ-Layerscape DPAA2 Architecture based > fsl-mc bus driver and network SoC PMD. This version of the driver > supports NXP LS208xA, LS204xA and LS108x families Network SoCs. > > DPAA2, or Data Path Acc

Re: [dpdk-dev] [PATCH] maintainers: claim responsability for xen

2017-02-16 Thread Vincent JARDIN
Le 16/02/2017 à 12:06, Thomas Monjalon a écrit : The request (6 month ago) was to give more time for feedbacks: http://dpdk.org/ml/archives/dev/2016-July/044847.html Is it time now to officially remove Dom0 support? yes

[dpdk-dev] [PATCH] mem: balanced allocation of hugepages

2017-02-16 Thread Ilya Maximets
Currently EAL allocates hugepages one by one not paying attention from which NUMA node allocation was done. Such behaviour leads to allocation failure if number of available hugepages for application limited by cgroups or hugetlbfs and memory requested not only from the first socket. Example:

Re: [dpdk-dev] [PATCH] log: remove old symbols from map

2017-02-16 Thread Ferruh Yigit
On 2/16/2017 8:50 AM, Thomas Monjalon wrote: > When removing log history functions, the map has not been updated. > > Fixes: d7e61ad3ae36 ("log: remove deprecated history dump") > > Reported-by: Olivier Matz > Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2017-02-16 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Richardson, Bruce > Sent: Thursday, February 16, 2017 9:14 AM > To: Yigit, Ferruh > Cc: Thomas Monjalon ; Iremonger, Bernard > ; Ananyev, Konstantin > ; Doherty, Declan > ; DPDK > Subject: Re: [dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock

[dpdk-dev] [PATCH v2] app/crypto-perf: fix for segfault when bad optype is used with gcm alghorithms

2017-02-16 Thread Daniel Mrzyglod
When somebody use bad --optype with aead alghorithms segmentation fault could happen. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Daniel Mrzyglod --- Changes for v2: - fix checkpatch error related with whitespace - fix spelling error How to

Re: [dpdk-dev] [PATCH] maintainers: claim responsability for xen

2017-02-16 Thread Thomas Monjalon
2016-11-11 04:49, Tan, Jianfeng: > Hi Thomas and Konrad, > > On 11/11/2016 2:59 AM, Konrad Rzeszutek Wilk wrote: > > On Wed, Nov 9, 2016 at 5:03 PM, Thomas Monjalon wrote: > >> 2016-11-07 07:38, Jianfeng Tan: > >>> As some users are still using xen as the hypervisor, I suggest to > >>> continue su

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix for segfault when bad optype is used with gcm alghorithms

2017-02-16 Thread De Lara Guarch, Pablo
Hi Daniel, > -Original Message- > From: Mrzyglod, DanielX T > Sent: Thursday, February 16, 2017 10:49 AM > To: Mrozowicz, SlawomirX; Doherty, Declan; De Lara Guarch, Pablo > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [PATCH] app/crypto-perf: fix for segfault when bad optype is used >

Re: [dpdk-dev] [PATCH v10 0/7] Expanded statistics reporting

2017-02-16 Thread Thomas Monjalon
2017-02-03 10:33, Remy Horton: > This patchset extends statistics reporting to include peak and > average data-rate metrics. It comes in two parts: a statistics > reporting library, and a bitrate calculation library that uses > it. This structure is intended to seperate statistic reporting > from e

[dpdk-dev] [PATCH] app/crypto-perf: fix for segfault when bad optype is used with gcm alghorithms

2017-02-16 Thread Daniel Mrzyglod
When somebody use bad --optype with aead alghorithms segmentation fault could happen. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Daniel Mrzyglod --- How to reproduce: AESNI_GCM: ./build/app/dpdk-test-crypto-perf -c 0xc0 --vdev crypto_aesni_gcm

Re: [dpdk-dev] [PATCH 3/4] mk: add new test-run make rule

2017-02-16 Thread Thomas Monjalon
2017-02-16 10:21, Ferruh Yigit: > On 2/16/2017 9:26 AM, Thomas Monjalon wrote: > > 2017-02-15 15:26, Ferruh Yigit: > >> --- a/mk/rte.sdkroot.mk > >> +++ b/mk/rte.sdkroot.mk > >> @@ -92,8 +92,8 @@ default: all > >> config showconfigs showversion showversionum: > >>$(Q)$(MAKE) -f $(RTE_SDK)/mk/r

Re: [dpdk-dev] [PATCH v2] eventdev: clarify nb_links and nb_unlinks description

2017-02-16 Thread Bruce Richardson
On Tue, Feb 14, 2017 at 09:35:13AM +0530, Jerin Jacob wrote: > On Mon, Feb 13, 2017 at 09:52:53AM -0600, Gage Eads wrote: > > This commit clarifies the usage of nb_links and nb_unlinks when passing > > a NULL pointer as the queues argument. > > > > Signed-off-by: Gage Eads > > Acked-by: Jerin Ja

Re: [dpdk-dev] [PATCH 3/4] mk: add new test-run make rule

2017-02-16 Thread Ferruh Yigit
On 2/16/2017 9:26 AM, Thomas Monjalon wrote: > 2017-02-15 15:26, Ferruh Yigit: >> --- a/mk/rte.sdkroot.mk >> +++ b/mk/rte.sdkroot.mk >> @@ -92,8 +92,8 @@ default: all >> config showconfigs showversion showversionum: >> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@ >> >> -.PHONY: test fas

Re: [dpdk-dev] [PATCH 2/4] mk: do not build tests by default

2017-02-16 Thread Ferruh Yigit
On 2/16/2017 8:53 AM, Thomas Monjalon wrote: > 2017-02-15 17:30, Ferruh Yigit: >> On 2/15/2017 4:58 PM, Thomas Monjalon wrote: >>> 2017-02-15 15:26, Ferruh Yigit: +.PHONY: test-buid +test-build: + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig + $(Q)$(MAKE) -f $(RTE

Re: [dpdk-dev] i40e queues per VF

2017-02-16 Thread Xu, Qian Q
Helin/Jingjing Could you give some answers here? Thx. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, February 14, 2017 6:07 PM > To: Zhang, Helin ; Wu, Jingjing > Cc: Mcnamara, John ; dev@dpdk.org > Subject: [dpdk-dev] i40e qu

Re: [dpdk-dev] [PATCH 3/4] mk: add new test-run make rule

2017-02-16 Thread Thomas Monjalon
2017-02-15 15:26, Ferruh Yigit: > --- a/mk/rte.sdkroot.mk > +++ b/mk/rte.sdkroot.mk > @@ -92,8 +92,8 @@ default: all > config showconfigs showversion showversionum: > $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@ > > -.PHONY: test fast_test ring_test mempool_test perf_test coverage > -t

Re: [dpdk-dev] [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions

2017-02-16 Thread Bruce Richardson
On Wed, Feb 15, 2017 at 06:01:45PM +, Ferruh Yigit wrote: > On 6/16/2016 7:38 PM, thomas.monjalon at 6wind.com (Thomas Monjalon) wrote: > > 2016-06-16 16:41, Iremonger, Bernard: > >> Hi Thomas, > >> > >>> 2016-06-16 15:32, Bruce Richardson: > On Mon, Jun 13, 2016 at 01:28:08PM +0100, Irem

Re: [dpdk-dev] [PATCH 1/4] test: move tests to separate folder

2017-02-16 Thread Bruce Richardson
On Wed, Feb 15, 2017 at 03:26:29PM +, Ferruh Yigit wrote: > This is to logically group unit tests into their own folder separating > them from "app" folder. > > Hopefully this will make the unit test in DPDK more visible. > > Following binaries moved to "test" folder: > cmdline-test > test-ac

Re: [dpdk-dev] [PATCH 3/4] mk: add new test-run make rule

2017-02-16 Thread Bruce Richardson
On Wed, Feb 15, 2017 at 05:41:08PM +, Ferruh Yigit wrote: > On 2/15/2017 5:07 PM, Bruce Richardson wrote: > > On Wed, Feb 15, 2017 at 03:26:31PM +, Ferruh Yigit wrote: > >> Since "make test" and "make test-build" does dependency resolving, they > >> check for all dependent components (lib a

Re: [dpdk-dev] [PATCH 2/4] mk: do not build tests by default

2017-02-16 Thread Thomas Monjalon
2017-02-15 17:30, Ferruh Yigit: > On 2/15/2017 4:58 PM, Thomas Monjalon wrote: > > 2017-02-15 15:26, Ferruh Yigit: > >> +.PHONY: test-buid > >> +test-build: > >> + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig > >> + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk test > > > > Why not r

[dpdk-dev] [PATCH] log: remove old symbols from map

2017-02-16 Thread Thomas Monjalon
When removing log history functions, the map has not been updated. Fixes: d7e61ad3ae36 ("log: remove deprecated history dump") Reported-by: Olivier Matz Signed-off-by: Thomas Monjalon --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 3 --- lib/librte_eal/linuxapp/eal/rte_eal_version.map |