On 1/31/2017 1:52 AM, Thomas Monjalon wrote:
2017-01-24 13:35, Ferruh Yigit:
On 1/24/2017 7:34 AM, Jianfeng Tan wrote:
We announced ABI changes to remove iomem and ioport mapping in
igb_uio. But it has potential backward compatibility issue: cannot
run old version DPDK on modified igb_uio.
T
: Tuesday, January 31, 2017 6:17 PM, Ferruh Yigit:
> On 1/31/2017 11:45 AM, Shahaf Shuler wrote:
> > Trying to query the link status through new kernel ioctl API
> > ETHTOOL_GLINKSETTINGS was always failing due to kernel bug.
> > The bug was fixed on version 4.9
> > this patch uses the legacy ioctl
> On Jan 31, 2017, at 10:39 AM, Pascal Mazon wrote:
>
> On 01/31/2017 05:06 PM, Wiles, Keith wrote:>
>> Looking at the changes to set the link up/down and the adding the two
>> functions. I noticed in the stop/start routines I was set the link in DPDK
>> and not adjusting the interface link. S
Hi Harry,
Looks like the function names in *_version.map don't quite match those in the
eventdev header.
+int
+rte_event_dev_xstats_names_get(uint8_t dev_id,
+ struct rte_event_dev_xstat_name *xstats_names,
+ unsigned int size)
+int
+rte_event_dev_xstats_get(uint8_t dev_id, const
For Linux kernel 4.0 and newer, the ability to obtain
physical page frame numbers for unprivileged users from
/proc/self/pagemap was removed. Instead, when an IOMMU
is present, simply choose our own DMA addresses instead.
Signed-off-by: Ben Walker
---
lib/librte_eal/common/eal_private.h | 1
For Linux kernel 4.0 and newer, the ability to obtain
physical page frame numbers for unprivileged users from
/proc/self/pagemap was removed. Instead, when an IOMMU
is present, simply choose our own DMA addresses instead.
Signed-off-by: Ben Walker
---
lib/librte_eal/common/eal_private.h | 1
> On Jan 31, 2017, at 10:58 AM, Stephen Hemminger
> wrote:
>
> On Tue, 31 Jan 2017 13:07:37 +
> Ferruh Yigit wrote:
>
>> On 1/31/2017 9:42 AM, Pascal Mazon wrote:
>>> Signed-off-by: Pascal Mazon
>>> ---
>>
>> looks good to me.
>>
>
> Agreed, almost all uses of INFO as log level are
On Tue, 31 Jan 2017 13:07:37 +
Ferruh Yigit wrote:
> On 1/31/2017 9:42 AM, Pascal Mazon wrote:
> > Signed-off-by: Pascal Mazon
> > ---
>
> looks good to me.
>
Agreed, almost all uses of INFO as log level are wrong!
Either the message is reporting a problem should be NOTICE, WARN, ERR
or
On Tue, 31 Jan 2017 09:33:45 +
Bruce Richardson wrote:
> On Mon, Jan 30, 2017 at 01:38:00PM -0500, Aaron Conole wrote:
> > Stephen Hemminger writes:
> >
> > > On Fri, 27 Jan 2017 16:47:40 +
> > > Bruce Richardson wrote:
> > >
> > >> On Fri, Jan 27, 2017 at 08:33:46AM -0800, Stephen
On 27/01/17 13:16, Pablo de Lara wrote:
AESNI MB now supports authentication only operations,
but the array containing all the possible digest lengths
was not updated to reflect the new algorithm NULL_HASH,
causing an "Out-of-bounds access".
Coverity issue: 140977
Fixes: 8772c3f713e2 ("crypto/ae
On 01/31/2017 05:06 PM, Wiles, Keith wrote:>
Looking at the changes to set the link up/down and the adding the two
functions. I noticed in the stop/start routines I was set the link in DPDK and
not adjusting the interface link. Should the stop/start routine also do the
same thing?
Well, my
From: Bruce Richardson
Signed-off-by: Bruce Richardson
Signed-off-by: Harry van Haaren
---
drivers/event/sw/sw_evdev.c | 118
1 file changed, 118 insertions(+)
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index e352a5c..60
On 1/31/2017 11:45 AM, Shahaf Shuler wrote:
> Trying to query the link status through new kernel ioctl API
> ETHTOOL_GLINKSETTINGS was always failing due to kernel bug.
> The bug was fixed on version 4.9
> this patch uses the legacy ioctl API for lower kernels.
>
> Fixes: 188408719888 ("net/mlx5:
From: Bruce Richardson
Since the sw driver is a standalone lookaside device that has no HW
requirements, we can provide a set of unit tests that test its
functionality across the different queue types and with different input
scenarios.
This also adds the tests to be automatically run by autotes
From: Bruce Richardson
Add support for xstats to report out on the state of the eventdev.
Useful for debugging and for unit tests, as well as observability
at runtime and performance tuning of apps to work well with the
scheduler.
Signed-off-by: Bruce Richardson
Signed-off-by: Harry van Haaren
From: Bruce Richardson
add the event enqueue, dequeue and release functions to the eventdev.
These also include tracking of stats for observability in the load of
the scheduler.
Internally in the enqueue function, the various types of enqueue
operations, to forward an existing event, to send a ne
From: Bruce Richardson
Add in the scheduling function which takes the events from the
producer queues and buffers them before scheduling them to consumer
queues. The scheduling logic includes support for atomic, reordered,
and parallel scheduling of flows.
Signed-off-by: Bruce Richardson
Signed
From: Bruce Richardson
Signed-off-by: Bruce Richardson
Signed-off-by: Harry van Haaren
---
drivers/event/sw/sw_evdev.c | 74 +
1 file changed, 74 insertions(+)
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index 17b5e49..e35
From: Bruce Richardson
Signed-off-by: Bruce Richardson
Signed-off-by: Harry van Haaren
---
drivers/event/sw/sw_evdev.c | 68 +
1 file changed, 68 insertions(+)
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index 0b26fcb..693
From: Bruce Richardson
Add in the data-structures for the ports used by workers to send
packets to/from the scheduler. Also add in the functions to
create/destroy those ports.
Signed-off-by: Bruce Richardson
Signed-off-by: Harry van Haaren
---
drivers/event/sw/event_ring.h | 179 +
From: Bruce Richardson
Signed-off-by: Bruce Richardson
Signed-off-by: Harry van Haaren
---
drivers/event/sw/sw_evdev.c | 32
1 file changed, 32 insertions(+)
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index b657eb4..ceca865 100644
-
From: Bruce Richardson
Add in the data structures for the event queues, and the eventdev
functions to create and destroy those queues.
Signed-off-by: Bruce Richardson
Signed-off-by: Harry van Haaren
---
drivers/event/sw/iq_ring.h | 176
drivers/ev
From: Bruce Richardson
Signed-off-by: Bruce Richardson
Signed-off-by: Harry van Haaren
---
drivers/event/sw/sw_evdev.c | 15 +++
drivers/event/sw/sw_evdev.h | 11 +++
2 files changed, 26 insertions(+)
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
i
From: Bruce Richardson
Add in APIs for extended stats so that eventdev implementations can report
out information on their internal state. The APIs are based on, but not
identical to, the equivalent ethdev functions.
Signed-off-by: Bruce Richardson
Signed-off-by: Harry van Haaren
---
lib/libr
From: Bruce Richardson
Since eventdev uses event structures rather than working directly on
mbufs, there is no actual dependencies on the mbuf library. The
inclusion of an mbuf pointer element inside the event itself does not
require the inclusion of the mbuf header file. Similarly the pci
header
From: Bruce Richardson
Add in the info_get function to return details on the queues, flow,
prioritization capabilities, etc. that this device has.
Signed-off-by: Bruce Richardson
Signed-off-by: Harry van Haaren
---
drivers/event/sw/sw_evdev.c | 23 +++
drivers/event/sw/sw_
From: Bruce Richardson
This adds the minimal changes to allow a SW eventdev implementation to
be compiled, linked and created at run time. The eventdev does nothing,
but can be created via vdev on commandline, e.g.
sudo ./x86_64-native-linuxapp-gcc/app/test --vdev=event_sw0
...
PMD: Creati
The following patchset adds software eventdev implementation
to the next-eventdev tree.
This implementation is based on the previous software eventdev
v1 patchset, now with comments addressed:
1) xstats api return values changed to be consistent
2) xstats api [out] added to appropriate values
3) x
A configuration structure for the MARK action must always be specified.
Fixes: ea3bc3b1df94 ("net/mlx5: support mark flow action")
Signed-off-by: Nelio Laranjeiro
Acked-by: Adrien Mazarguil
---
drivers/net/mlx5/mlx5_flow.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --gi
> On Jan 31, 2017, at 9:44 AM, Pascal Mazon wrote:
>
> On 01/31/2017 04:44 PM, Wiles, Keith wrote:
>>
>>> On Jan 31, 2017, at 9:38 AM, Yigit, Ferruh wrote:
>>>
>>> On 1/31/2017 3:30 PM, Pascal Mazon wrote:
On 01/31/2017 04:28 PM, Ferruh Yigit wrote:
> On 1/31/2017 2:23 PM, Pascal Maz
Adding a flow when the port is stopped ends in an inconsistent situation
where the queue can receive traffic when it should not.
Record new rules and apply them as soon as the port is started.
Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions")
Signed-off-by: Nelio Laranjeiro
Default masks were introduced in the API after its implementation in this
PMD.
Signed-off-by: Nelio Laranjeiro
Acked-by: Adrien Mazarguil
---
drivers/net/mlx5/mlx5_flow.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net
On 01/31/2017 04:44 PM, Wiles, Keith wrote:
On Jan 31, 2017, at 9:38 AM, Yigit, Ferruh wrote:
On 1/31/2017 3:30 PM, Pascal Mazon wrote:
On 01/31/2017 04:28 PM, Ferruh Yigit wrote:
On 1/31/2017 2:23 PM, Pascal Mazon wrote:
On 01/31/2017 02:06 PM, Ferruh Yigit wrote:> On 1/31/2017 9:42 AM,
P
> On Jan 31, 2017, at 9:38 AM, Yigit, Ferruh wrote:
>
> On 1/31/2017 3:30 PM, Pascal Mazon wrote:
>> On 01/31/2017 04:28 PM, Ferruh Yigit wrote:
>>> On 1/31/2017 2:23 PM, Pascal Mazon wrote:
On 01/31/2017 02:06 PM, Ferruh Yigit wrote:> On 1/31/2017 9:42 AM,
Pascal Mazon wrote:
>> d
On Tue, Jan 31, 2017 at 01:45:29PM +0200, Shahaf Shuler wrote:
> Trying to query the link status through new kernel ioctl API
> ETHTOOL_GLINKSETTINGS was always failing due to kernel bug.
> The bug was fixed on version 4.9
> this patch uses the legacy ioctl API for lower kernels.
>
> Fixes: 188408
On Tue, Jan 31, 2017 at 03:13:38PM +0200, Shahaf Shuler wrote:
> Query the link status can end up in an inconsist state where the port is
> down but it is reporting speed. For that another query is scheduled for a
> later time.
> A race condition is possible between the scheduled call and other lin
On 1/31/2017 3:30 PM, Pascal Mazon wrote:
> On 01/31/2017 04:28 PM, Ferruh Yigit wrote:
>> On 1/31/2017 2:23 PM, Pascal Mazon wrote:
>>> On 01/31/2017 02:06 PM, Ferruh Yigit wrote:> On 1/31/2017 9:42 AM,
>>> Pascal Mazon wrote:
> dev->data->name contains "net_tap", the device driver name.
On 01/31/2017 04:28 PM, Ferruh Yigit wrote:
On 1/31/2017 2:23 PM, Pascal Mazon wrote:
On 01/31/2017 02:06 PM, Ferruh Yigit wrote:> On 1/31/2017 9:42 AM,
Pascal Mazon wrote:
dev->data->name contains "net_tap", the device driver name.
I see what patch does, just as a note to commit log:
AFAIK,
On 1/31/2017 2:23 PM, Pascal Mazon wrote:
> On 01/31/2017 02:06 PM, Ferruh Yigit wrote:> On 1/31/2017 9:42 AM,
> Pascal Mazon wrote:
>>> dev->data->name contains "net_tap", the device driver name.
>>
>> I see what patch does, just as a note to commit log:
>>
>> AFAIK, "dev->data->name" is device n
> On Jan 31, 2017, at 9:14 AM, Yigit, Ferruh wrote:
>
> On 1/31/2017 2:52 PM, Wiles, Keith wrote:
>>
>>> On Jan 31, 2017, at 3:42 AM, Pascal Mazon wrote:
>>>
>>> dev->data->name contains "net_tap", the device driver name.
>>> dev->data->dev_private->name contains the actual iface name,
>>> e.
On 1/31/2017 2:52 PM, Wiles, Keith wrote:
>
>> On Jan 31, 2017, at 3:42 AM, Pascal Mazon wrote:
>>
>> dev->data->name contains "net_tap", the device driver name.
>> dev->data->dev_private->name contains the actual iface name,
>> e.g. "dtap0".
>>
>> In tun_alloc() especially, we want to use the la
_LDLIBS is for internal usage, convert to LDLIBS usage.
Signed-off-by: Ferruh Yigit
---
app/test-pmd/Makefile | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
index a1500bb..7e52eb8 100644
--- a/app/test-pmd/Makefile
++
Some PMDs provide device specific APIs. Bond and xenvirt are existing
samples for this.
And since these are PMD libraries, there are two options on how to link
them for shared library build:
1- They can be linked to all applications by default, using common
rte.app.mk file.
2- They can be explic
During app build with static library, some libraries wrapped with
--whole-archive compiler flag.
Wrapped libraries are mainly PMD libraries, this is required because PMD
APIs not called directly but run through callbacks registered via
constructor functions.
Also some set of libraries, depends to
> On Jan 31, 2017, at 3:42 AM, Pascal Mazon wrote:
>
> dev->data->name contains "net_tap", the device driver name.
> dev->data->dev_private->name contains the actual iface name,
> e.g. "dtap0".
>
> In tun_alloc() especially, we want to use the latter. Otherwise the
> netdevice would be wrongly
On 1/31/2017 2:16 PM, Thomas Monjalon wrote:
> 2017-01-31 12:14, Ferruh Yigit:
>> Same PMDs provide device specific APIs. Bond and xenvirt are existing
>> samples for this.
>
> s/Same/Some/
>
>> And since these are PMD libraries, there are two options on how to link
>> them.
>>
>> 1- They can be
Hi Olivier,
Reply inline.
On Tue, Jan 31, 2017 at 11:31:51AM +0100, Olivier Matz wrote:
> Hi Santosh,
>
> I guess this patch is targeted for 17.05, right?
>
Yes.
> Please see some other comments below.
>
> On Fri, 20 Jan 2017 20:43:41 +0530,
> wrote:
> > From: Santosh Shukla
> >
> > HW poo
On 01/31/2017 02:21 PM, Ferruh Yigit wrote:
On 1/31/2017 9:42 AM, Pascal Mazon wrote:
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 59 +++
1 file changed, 59 insertions(+)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/r
On 01/31/2017 02:06 PM, Ferruh Yigit wrote:> On 1/31/2017 9:42 AM,
Pascal Mazon wrote:
dev->data->name contains "net_tap", the device driver name.
I see what patch does, just as a note to commit log:
AFAIK, "dev->data->name" is device name, and for this case it is
"net_tap#", like "net_tap0",
On 1/31/2017 2:10 PM, Thomas Monjalon wrote:
> 2017-01-31 11:59, Ferruh Yigit:
>> There is already a block for crypto libraries, move the PMD library to
>> that block.
>>
>> This prevents extra ifdef check for cryptodev.
>
> That's why I thought also when reading this patch:
> http://dpdk.or
2017-01-31 12:14, Ferruh Yigit:
> Same PMDs provide device specific APIs. Bond and xenvirt are existing
> samples for this.
s/Same/Some/
> And since these are PMD libraries, there are two options on how to link
> them.
>
> 1- They can be fully included to all applications, using common
> rte.app
2017-01-31 11:59, Ferruh Yigit:
> There is already a block for crypto libraries, move the PMD library to
> that block.
>
> This prevents extra ifdef check for cryptodev.
That's why I thought also when reading this patch:
http://dpdk.org/commit/dbb336407
Then I've read its message:
"Differ
2017-01-31 11:59, Ferruh Yigit:
> During app build with static library, some libraries wrapped with
> --whole-archive compiler flag.
>
> Wrapped libraries are mainly PMD libraries, this is required because PMD
> APIs not directly called but run through callbacks registered via
> constructor functi
On Tue, Jan 31, 2017 at 02:27:18PM +0100, Olivier Matz wrote:
> On Tue, 31 Jan 2017 12:10:50 +, Bruce Richardson
> wrote:
> > On Tue, Jan 31, 2017 at 11:41:42AM +, Bruce Richardson wrote:
> > > On Tue, Jan 31, 2017 at 11:53:49AM +0100, Olivier Matz wrote:
> > > > On Wed, 25 Jan 2017 17:2
On Tue, Jan 31, 2017 at 01:13:11PM +, Mcnamara, John wrote:
>
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Monday, January 30, 2017 3:50 PM
> > To: Horton, Remy
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v9 1
On Tue, 31 Jan 2017 12:10:50 +, Bruce Richardson
wrote:
> On Tue, Jan 31, 2017 at 11:41:42AM +, Bruce Richardson wrote:
> > On Tue, Jan 31, 2017 at 11:53:49AM +0100, Olivier Matz wrote:
> > > On Wed, 25 Jan 2017 17:29:18 +, "Ananyev, Konstantin"
> > > wrote:
> > > > > > > Bonus qu
On 1/31/2017 9:42 AM, Pascal Mazon wrote:
> Signed-off-by: Pascal Mazon
> ---
> drivers/net/tap/rte_eth_tap.c | 59
> +++
> 1 file changed, 59 insertions(+)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 734e3a57921
On 1/31/2017 9:42 AM, Pascal Mazon wrote:
> The probe parses for user-defined iface name. Let's use that value.
>
> Signed-off-by: Pascal Mazon
looks good to me.
On 1/31/2017 9:42 AM, Pascal Mazon wrote:
> There's no point in having a different internal MAC address than the one
> provided by the kernel when creating the netdevice.
Agree that this is not required, but also not a defect, worth learning
author's intention before deciding.
>
> Signed-off-by:
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, January 30, 2017 3:50 PM
> To: Horton, Remy
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v9 1/7] lib: add information metrics
> library
>
> Hi Remy,
>
> > This patch adds
Query the link status can end up in an inconsist state where the port is
down but it is reporting speed. For that another query is scheduled for a
later time.
A race condition is possible between the scheduled call and other link
status interrupt handlers. When the scheduled query by-pass those han
On 1/31/2017 9:42 AM, Pascal Mazon wrote:
> Signed-off-by: Pascal Mazon
> ---
looks good to me.
On 1/31/2017 9:42 AM, Pascal Mazon wrote:
> dev->data->name contains "net_tap", the device driver name.
I see what patch does, just as a note to commit log:
AFAIK, "dev->data->name" is device name, and for this case it is
"net_tap#", like "net_tap0", "net_tap1" ...
"dev->data_drv_name" is the dr
Add KNI PMD which wraps librte_kni for ease of use.
KNI PMD can be used as any regular PMD to send / receive packets to the
Linux networking stack.
Signed-off-by: Ferruh Yigit
Reviewed-by: Yong Wang
---
v8:
* Don't try to link against librte_pmd_kni if librte_kni is disabled
v7:
* Add depende
_LDLIBS is for internal usage, convert to LDLIBS usage.
Signed-off-by: Ferruh Yigit
---
app/test-pmd/Makefile | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile
index a1500bb..7e52eb8 100644
--- a/app/test-pmd/Makefile
++
Same PMDs provide device specific APIs. Bond and xenvirt are existing
samples for this.
And since these are PMD libraries, there are two options on how to link
them.
1- They can be fully included to all applications, using common
rte.app.mk file by default.
2- They can be explicitly linked to ap
On Tue, Jan 31, 2017 at 11:41:42AM +, Bruce Richardson wrote:
> On Tue, Jan 31, 2017 at 11:53:49AM +0100, Olivier Matz wrote:
> > On Wed, 25 Jan 2017 17:29:18 +, "Ananyev, Konstantin"
> > wrote:
> > > > > > Bonus question:
> > > > > > * Do we know how widely used the enq_bulk/deq_bulk func
There is already a block for crypto libraries, move the PMD library to
that block.
This prevents extra ifdef check for cryptodev.
Signed-off-by: Ferruh Yigit
---
mk/rte.app.mk | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index aeadbc3..a4
During app build with static library, some libraries wrapped with
--whole-archive compiler flag.
Wrapped libraries are mainly PMD libraries, this is required because PMD
APIs not directly called but run through callbacks registered via
constructor functions.
Also some set of libraries, depends to
Trying to query the link status through new kernel ioctl API
ETHTOOL_GLINKSETTINGS was always failing due to kernel bug.
The bug was fixed on version 4.9
this patch uses the legacy ioctl API for lower kernels.
Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds")
CC: sta...@dpdk.org
On Tue, Jan 31, 2017 at 11:53:49AM +0100, Olivier Matz wrote:
> On Wed, 25 Jan 2017 17:29:18 +, "Ananyev, Konstantin"
> wrote:
> > > > > Bonus question:
> > > > > * Do we know how widely used the enq_bulk/deq_bulk functions
> > > > > are? They are useful for unit tests, so they do have uses, b
On 1/13/2017 4:12 PM, Ferruh Yigit wrote:
> On 1/13/2017 4:01 PM, Jerin Jacob wrote:
>> On Fri, Jan 13, 2017 at 03:57:59PM +, Ferruh Yigit wrote:
>>> On 1/13/2017 3:53 PM, Thomas Monjalon wrote:
2017-01-13 08:51, Jerin Jacob:
> On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wro
On Wed, 25 Jan 2017 17:29:18 +, "Ananyev, Konstantin"
wrote:
> > > > Bonus question:
> > > > * Do we know how widely used the enq_bulk/deq_bulk functions
> > > > are? They are useful for unit tests, so they do have uses, but
> > > > I think it would be good if we harmonized the return values
>
Hi Santosh,
On Tue, 17 Jan 2017 19:01:23 +0530, Santosh Shukla
wrote:
> Hi Hemant,
>
> On Wed, Jan 18, 2017 at 12:12:56AM +0530, Hemant Agrawal wrote:
> > When possible, replace the uses of rte_mempool_create() with
> > the helper provided in librte_mbuf: rte_pktmbuf_pool_create().
> >
> > This
Hi Santosh,
On Mon, 16 Jan 2017 21:00:37 +0530, Santosh Shukla
wrote:
> Hi Olivier,
>
>
> On Mon, Sep 19, 2016 at 03:42:42PM +0200, Olivier Matz wrote:
> > When possible, replace the uses of rte_mempool_create() with
> > the helper provided in librte_mbuf: rte_pktmbuf_pool_create().
> >
> > Th
Hi Santosh,
I guess this patch is targeted for 17.05, right?
Please see some other comments below.
On Fri, 20 Jan 2017 20:43:41 +0530,
wrote:
> From: Santosh Shukla
>
> HW pool manager e.g. Cavium SoC need s/w to program start and
> end address of pool. Currently there is no such api in ext-m
Hi Hemant,
Sorry for the delay.
On Fri, 20 Jan 2017 12:41:20 +0530, Hemant Agrawal
wrote:
> When possible, replace the uses of rte_mempool_create() with
> the helper provided in librte_mbuf: rte_pktmbuf_pool_create().
>
> This is the preferred way to create a mbuf pool.
>
> This also updates t
The probe parses for user-defined iface name. Let's use that value.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index f8b07b4a8fa1..734e3a5792
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 59 +++
1 file changed, 59 insertions(+)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 734e3a579219..9b6bbff5fd81 100644
--- a/drivers/net/tap/rte_eth_tap.c
There's no point in having a different internal MAC address than the one
provided by the kernel when creating the netdevice.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/dr
pmd->fds[0], pmd->rxq[0] and pmd->txq[0] are set a couple of lines after
the for loop that initializes them to -1.
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte
Signed-off-by: Pascal Mazon
---
drivers/net/tap/rte_eth_tap.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 8faf08551b9e..4cc1767da5e8 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/
dev->data->name contains "net_tap", the device driver name.
dev->data->dev_private->name contains the actual iface name,
e.g. "dtap0".
In tun_alloc() especially, we want to use the latter. Otherwise the
netdevice would be wrongly named "net_tap". Furthermore, creating
several tap vdev would point
On Mon, Jan 30, 2017 at 01:38:00PM -0500, Aaron Conole wrote:
> Stephen Hemminger writes:
>
> > On Fri, 27 Jan 2017 16:47:40 +
> > Bruce Richardson wrote:
> >
> >> On Fri, Jan 27, 2017 at 08:33:46AM -0800, Stephen Hemminger wrote:
> >> > On Fri, 27 Jan 2017 09:57:03 -0500
> >> > Aaron Conole
84 matches
Mail list logo
