Re: [dpdk-dev] [PATCH v5] app/testpmd: supported offload capabilities query

2017-01-13 Thread Yang, Qiming
HI, Pablo > ... > > > + > > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_CKSUM) { > > + printf("RX TCP checksum: "); > > + if (dev->data->dev_conf.rxmode.hw_ip_checksum) > > + printf("on\n"); > > + else > > +

Re: [dpdk-dev] [PATCH v8 00/25] Support VFD on i40e

2017-01-13 Thread John Fastabend
On 17-01-11 06:51 AM, JOSHI, KAUSTUBH (KAUSTUBH) wrote: > Also, the kernel drivers have no concept of passing VF messages to upstream > "decision making” (or policy enforcement) software like VFd. > > On Jan 11, 2017, at 9:49 AM, Kaustubh Joshi > mailto:kaust...@research.att.com>> wrote: > > W

Re: [dpdk-dev] [PATCH v5 00/29] Support VFD and DPDK PF + kernel VF on i40e

2017-01-13 Thread John Fastabend
On 17-01-11 07:47 PM, Chen, Jing D wrote: > Hi, Vincent, > >> -Original Message- >> From: Vincent JARDIN [mailto:vincent.jar...@6wind.com] >> Sent: Tuesday, January 10, 2017 9:30 PM >> To: Scott Daniels ; dev@dpdk.org >> Cc: kaust...@research.att.com; az5...@att.com; Chen, Jing D >> >> Su

Re: [dpdk-dev] [PATCH v3 3/8] crypto/armv8: add PMD optimized for ARMv8 processors

2017-01-13 Thread Zbigniew Bodek
On 13.01.2017 08:57, Hemant Agrawal wrote: On 1/4/2017 11:03 PM, zbigniew.bo...@caviumnetworks.com wrote: From: Zbigniew Bodek This patch introduces crypto poll mode driver using ARMv8 cryptographic extensions. CPU compatibility with this driver is detected in run-time and virtual crypto dev

Re: [dpdk-dev] [PATCH v3 3/8] crypto/armv8: add PMD optimized for ARMv8 processors

2017-01-13 Thread Zbigniew Bodek
On 13.01.2017 08:41, Jianbo Liu wrote: On 12 January 2017 at 21:12, Zbigniew Bodek wrote: Hello Jianbo Liu, Thanks for the review. Please check my answers in-line. Kind regards Zbigniew On 06.01.2017 03:45, Jianbo Liu wrote: On 5 January 2017 at 01:33, wrote: From: Zbigniew Bodek

Re: [dpdk-dev] [PATCH v3 0/8] Add crypto PMD optimized for ARMv8

2017-01-13 Thread Zbigniew Bodek
Hello Hemant, Thank you for your remarks and comments. Please check my answer below. Kind regards Zbigniew On 13.01.2017 09:07, Hemant Agrawal wrote: On 1/4/2017 11:03 PM, zbigniew.bo...@caviumnetworks.com wrote: From: Zbigniew Bodek Introduce crypto poll mode driver using ARMv8 cryptograph

Re: [dpdk-dev] [PATCH v9 00/26] Support VFD on i40e - EXPERIMENTAL

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 6:52 AM, Wenzhuo Lu wrote: > 1, VF Daemon (VFD) > VFD is an idea to control all the VFs from PF. > As we need to support the scenario kernel PF + DPDK VF, DPDK follows > the interface between kernel PF + kernel VF. > We don't want to introduce too many new messages between PF and VF. >

Re: [dpdk-dev] [PATCH] kvargs: make pointers in string arrays const

2017-01-13 Thread Thomas Monjalon
2017-01-13 18:44, Olivier Matz: > On Thu, 12 Jan 2017 16:18:27 +, Bruce Richardson > wrote: > > Change the parameters of functions from const char *valid[] to > > const char * const valid[]. This additional const is needed to > > allow us to fix some checkpatch warnings, as well as being good

Re: [dpdk-dev] [PATCH v3 15/29] crypto/qat: use eal I/O device memory read/write API

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 4:21 PM, Jerin Jacob wrote: > On Fri, Jan 13, 2017 at 03:50:59PM +, Ferruh Yigit wrote: >> On 1/13/2017 2:57 PM, Jerin Jacob wrote: >>> On Fri, Jan 13, 2017 at 11:32:29AM +, Ferruh Yigit wrote: On 1/13/2017 8:17 AM, Jerin Jacob wrote: > On Thu, Jan 12, 2017 at 07:09:22

Re: [dpdk-dev] [PATCH v1] doc: add guidelines on stable and lts releases

2017-01-13 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Friday, January 13, 2017 4:29 PM > To: Mcnamara, John > Cc: dev@dpdk.org; Liu, Yuanhan > Subject: Re: [PATCH v1] doc: add guidelines on stable and lts releases > > 2017-01-13 13:14, Mcnamara, John: >

Re: [dpdk-dev] [PATCH] kvargs: make pointers in string arrays const

2017-01-13 Thread Olivier Matz
On Thu, 12 Jan 2017 16:18:27 +, Bruce Richardson wrote: > Change the parameters of functions from const char *valid[] to > const char * const valid[]. This additional const is needed to > allow us to fix some checkpatch warnings, as well as being good > programming practice. > > For the check

Re: [dpdk-dev] [RFC 0/9] get Rx and Tx used descriptors

2017-01-13 Thread Richardson, Bruce
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, January 13, 2017 4:44 PM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Ananyev, Konstantin > ; Lu, Wenzhuo ; Zhang, > Helin ; Richardson, Bruce > > Subject: Re: [dpdk-dev] [RFC 0/9] get Rx and

Re: [dpdk-dev] [RFC 0/9] get Rx and Tx used descriptors

2017-01-13 Thread Olivier Matz
Hi, On Thu, 24 Nov 2016 10:54:12 +0100, Olivier Matz wrote: > This RFC patchset introduces a new ethdev API function > rte_eth_tx_queue_count() which is the tx counterpart of > rte_eth_rx_queue_count(). It implements this API on some > Intel drivers for reference, and it also optimizes the > impl

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Thomas Monjalon
2017-01-12 13:16, Jerin Jacob: > By introducing explicit -lrte_pmd_ixgbe link request in > testpmd Makefile,"-Wl,-lrte_pmd_ixgbe" provided twice, and linker > removes the duplication by keeping only first occurrence. > This moves "-Wl,-lrte_pmd_ixgbe" out of "-Wl,--whole-archive" flag > and makes s

Re: [dpdk-dev] [PATCH v1] doc: add guidelines on stable and lts releases

2017-01-13 Thread Thomas Monjalon
2017-01-13 13:14, Mcnamara, John: > Just a reminder that DPDK 16.07 was a stable release, 16.11 is a stable > release and it will also become the 2 year LTS release. There should be a roadmap for the stable releases, giving end of life dates. What about updating this page? http://dpdk.org/dev/roa

Re: [dpdk-dev] [PATCH v3 15/29] crypto/qat: use eal I/O device memory read/write API

2017-01-13 Thread Jerin Jacob
On Fri, Jan 13, 2017 at 03:50:59PM +, Ferruh Yigit wrote: > On 1/13/2017 2:57 PM, Jerin Jacob wrote: > > On Fri, Jan 13, 2017 at 11:32:29AM +, Ferruh Yigit wrote: > >> On 1/13/2017 8:17 AM, Jerin Jacob wrote: > >>> On Thu, Jan 12, 2017 at 07:09:22PM +, Ferruh Yigit wrote: > Hi Jeri

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 4:01 PM, Jerin Jacob wrote: > On Fri, Jan 13, 2017 at 03:57:59PM +, Ferruh Yigit wrote: >> On 1/13/2017 3:53 PM, Thomas Monjalon wrote: >>> 2017-01-13 08:51, Jerin Jacob: On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: > On 1/12/2017 1:58 PM, Jerin Jacob wrot

Re: [dpdk-dev] [PATCH] scripts: skip capitalization check for commit prefixes

2017-01-13 Thread Thomas Monjalon
2017-01-13 13:02, Bruce Richardson: > The prefix in the commit title must be a valid component name and is > checked in separate checks. For capitalization, just check the part after > the colon. This is already done for most capitalization checks, just make > the remainder consistent with this. >

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Jerin Jacob
On Fri, Jan 13, 2017 at 04:53:46PM +0100, Thomas Monjalon wrote: > 2017-01-13 08:51, Jerin Jacob: > > On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: > > > On 1/12/2017 1:58 PM, Jerin Jacob wrote: > > > > On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > > > >> 2017-0

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Jerin Jacob
On Fri, Jan 13, 2017 at 03:57:59PM +, Ferruh Yigit wrote: > On 1/13/2017 3:53 PM, Thomas Monjalon wrote: > > 2017-01-13 08:51, Jerin Jacob: > >> On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: > >>> On 1/12/2017 1:58 PM, Jerin Jacob wrote: > On Thu, Jan 12, 2017 at 10:26:08AM

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 3:53 PM, Thomas Monjalon wrote: > 2017-01-13 08:51, Jerin Jacob: >> On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: >>> On 1/12/2017 1:58 PM, Jerin Jacob wrote: On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > 2017-01-12 13:16, Jerin Jacob:

Re: [dpdk-dev] [PATCH v6 00/18] net/ixgbe: Consistent filter API

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 8:12 AM, Wei Zhao wrote: > The patches mainly finish following functions: > 1) Store and restore all kinds of filters. > 2) Parse all kinds of filters. > 3) Add flow validate function. > 4) Add flow create function. > 5) Add flow destroy function. > 6) Add flow flush function. > <...>

Re: [dpdk-dev] [PATCH] app/testpmd: fix static build link ordering

2017-01-13 Thread Thomas Monjalon
2017-01-13 08:51, Jerin Jacob: > On Thu, Jan 12, 2017 at 03:27:30PM +, Ferruh Yigit wrote: > > On 1/12/2017 1:58 PM, Jerin Jacob wrote: > > > On Thu, Jan 12, 2017 at 10:26:08AM +0100, Thomas Monjalon wrote: > > >> 2017-01-12 13:16, Jerin Jacob: > > >>> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) >

Re: [dpdk-dev] [PATCH v3 2/8] lib: add cryptodev type for the upcoming ARMv8 PMD

2017-01-13 Thread Zbigniew Bodek
On 13.01.2017 09:16, Hemant Agrawal wrote: On 1/4/2017 11:03 PM, zbigniew.bo...@caviumnetworks.com wrote: From: Zbigniew Bodek Add type and name for ARMv8 crypto PMD Signed-off-by: Zbigniew Bodek --- lib/librte_cryptodev/rte_cryptodev.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [dpdk-dev] [PATCH v3 15/29] crypto/qat: use eal I/O device memory read/write API

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 2:57 PM, Jerin Jacob wrote: > On Fri, Jan 13, 2017 at 11:32:29AM +, Ferruh Yigit wrote: >> On 1/13/2017 8:17 AM, Jerin Jacob wrote: >>> On Thu, Jan 12, 2017 at 07:09:22PM +, Ferruh Yigit wrote: Hi Jerin, On 1/12/2017 9:17 AM, Jerin Jacob wrote: <...> >>

Re: [dpdk-dev] [PATCH v4 5/6] example: distributor app showing burst api

2017-01-13 Thread Bruce Richardson
On Mon, Jan 09, 2017 at 07:50:47AM +, David Hunt wrote: > Signed-off-by: David Hunt > --- > examples/distributor/main.c | 508 > ++-- > 1 file changed, 390 insertions(+), 118 deletions(-) > check-git-log complains a bit about the title of the patch, a

[dpdk-dev] [PATCH v5 0/3] Chained Mbufs support in SW PMDs

2017-01-13 Thread Tomasz Kulasek
This patch set adds support of scattered-gather list for SW PMDs. As of now, application needs to reserve continuous block of memory for mbufs which is not always the case. Hence needed to support chaining of mbufs which are smaller in size but can be used if chained. Above work involves: --

Re: [dpdk-dev] [PATCH v5] mbuf: add a function to linearize a packet

2017-01-13 Thread Kulasek, TomaszX
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, January 13, 2017 16:33 > To: Kulasek, TomaszX > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: Re: [PATCH v5] mbuf: add a function to linearize a packet > > On Thu, 12 Jan 2017 10:40:44 +0100,

Re: [dpdk-dev] [PATCH 0/2] make a couple eth_dev_ops const

2017-01-13 Thread Thomas Monjalon
2017-01-12 21:54, Ferruh Yigit: > On 1/12/2017 7:12 PM, Stephen Hemminger wrote: > > Really trivial patches. > > Patches are not in patchwork, and not in the mail list. > > > I also consider this a litmus test of how long it takes DPDK > > project to merge trivial maintaince patches. This is a n

Re: [dpdk-dev] [PATCH v4 5/6] example: distributor app showing burst api

2017-01-13 Thread Bruce Richardson
On Mon, Jan 09, 2017 at 07:50:47AM +, David Hunt wrote: > Signed-off-by: David Hunt > --- > examples/distributor/main.c | 508 > ++-- > 1 file changed, 390 insertions(+), 118 deletions(-) > > diff --git a/examples/distributor/main.c b/examples/distrib

Re: [dpdk-dev] [PATCH v4] mempool: use cache in single producer or consumer mode

2017-01-13 Thread Thomas Monjalon
2017-01-13 16:23, Olivier Matz: > On Wed, 11 Jan 2017 02:25:28 +, Wenfeng Liu > wrote: > > Currently we will check mempool flags when we put/get objects from > > mempool. However, this makes cache useless when mempool is SC|SP, > > SC|MP, MC|SP cases. > > This patch makes cache available in ab

Re: [dpdk-dev] [PATCH v4 3/6] test: unit tests for new distributor burst api

2017-01-13 Thread Bruce Richardson
On Mon, Jan 09, 2017 at 07:50:45AM +, David Hunt wrote: > Signed-off-by: David Hunt > --- > app/test/test_distributor.c | 501 > ++-- > 1 file changed, 392 insertions(+), 109 deletions(-) > check-git-log script complains about your capitalization of t

Re: [dpdk-dev] [PATCH v4 2/6] lib: add distributor vector flow matching

2017-01-13 Thread Bruce Richardson
On Mon, Jan 09, 2017 at 07:50:44AM +, David Hunt wrote: > Signed-off-by: David Hunt > --- > lib/librte_distributor/Makefile| 4 + > lib/librte_distributor/rte_distributor_burst.c | 11 +- > lib/librte_distributor/rte_distributor_match_sse.c | 113 >

Re: [dpdk-dev] [PATCH v5] mbuf: add a function to linearize a packet

2017-01-13 Thread Olivier Matz
On Thu, 12 Jan 2017 10:40:44 +0100, Tomasz Kulasek wrote: > This patch adds function rte_pktmbuf_linearize to let crypto PMD > coalesce chained mbuf before crypto operation and extend their > capabilities to support segmented mbufs when device cannot handle > them natively. > > Included unit test

[dpdk-dev] [PATCH v5 3/3] test: add sgl unit tests for crypto devices

2017-01-13 Thread Tomasz Kulasek
This patch provides unit tests for set of cipher/hash combinations covering currently implemented crypto PMD's and allowing to verify scatter gather support. Signed-off-by: Daniel Mrzyglod Signed-off-by: Tomasz Kulasek --- app/test/test_cryptodev.c | 386 ++- a

[dpdk-dev] [PATCH v5 1/3] crypto: add sgl support in sw PMDs

2017-01-13 Thread Tomasz Kulasek
This patch introduces RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER feature flag informing that selected crypto device supports segmented mbufs natively and doesn't need to be coalesced before crypto operation. While using segmented buffers in crypto devices may have unpredictable results, for PMDs which d

[dpdk-dev] [PATCH v5 2/3] crypto: add sgl support in openssl PMD

2017-01-13 Thread Tomasz Kulasek
Signed-off-by: Tomasz Kulasek --- doc/guides/cryptodevs/openssl.rst|3 +- drivers/crypto/openssl/rte_openssl_pmd.c | 329 +++--- 2 files changed, 259 insertions(+), 73 deletions(-) diff --git a/doc/guides/cryptodevs/openssl.rst b/doc/guides/cryptodevs/opens

Re: [dpdk-dev] [PATCH v4] mempool: use cache in single producer or consumer mode

2017-01-13 Thread Olivier Matz
On Wed, 11 Jan 2017 02:25:28 +, Wenfeng Liu wrote: > Currently we will check mempool flags when we put/get objects from > mempool. However, this makes cache useless when mempool is SC|SP, > SC|MP, MC|SP cases. > This patch makes cache available in above cases and improves > performance. > > S

Re: [dpdk-dev] [PATCH v4 1/6] lib: distributor performance enhancements

2017-01-13 Thread Bruce Richardson
On Mon, Jan 09, 2017 at 07:50:43AM +, David Hunt wrote: > Now sends bursts of up to 8 mbufs to each worker, and tracks > the in-flight flow-ids (atomic scheduling) > > New file with a new api, similar to the old API except with _burst > at the end of the function names > > Signed-off-by: Davi

Re: [dpdk-dev] [PATCH] net/nfp: fix VLAN offload flags check

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 3:16 PM, Ferruh Yigit wrote: > From: Olivier Matz > > Fix typo when checking that no VLAN offload flags are passed at port > initialization. > > By the way, also fix a typo in the log. > > Fixes: d4a27a3b092a ("nfp: add basic features") > > Signed-off-by: Olivier Matz > Acked-by:

[dpdk-dev] [PATCH] net/nfp: fix VLAN offload flags check

2017-01-13 Thread Ferruh Yigit
From: Olivier Matz Fix typo when checking that no VLAN offload flags are passed at port initialization. By the way, also fix a typo in the log. Fixes: d4a27a3b092a ("nfp: add basic features") Signed-off-by: Olivier Matz Acked-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 6 +++--- 1

Re: [dpdk-dev] [PATCH v3 15/29] crypto/qat: use eal I/O device memory read/write API

2017-01-13 Thread Jerin Jacob
On Fri, Jan 13, 2017 at 11:32:29AM +, Ferruh Yigit wrote: > On 1/13/2017 8:17 AM, Jerin Jacob wrote: > > On Thu, Jan 12, 2017 at 07:09:22PM +, Ferruh Yigit wrote: > >> Hi Jerin, > >> > >> On 1/12/2017 9:17 AM, Jerin Jacob wrote: > >> <...> > >> > >>> +#include > >>> + > >>> /* CSR write m

Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

2017-01-13 Thread Alejandro Lucero
I was assuming in my acked answer, that the patch had followed usual path and automatic compilation did not fail. But I forgot about the NFP PMD not being enabled by default :-) Hopefully, this will change if this just sent patch is accepted: http://www.dpdk.org/ml/archives/dev/2017-January/0548

Re: [dpdk-dev] [RFC PATCH 00/11] generalise rte_ring to allow different datatypes

2017-01-13 Thread Bruce Richardson
On Fri, Jan 13, 2017 at 03:23:34PM +0100, Olivier Matz wrote: > Hi Bruce, > > On Wed, 11 Jan 2017 15:05:14 +, Bruce Richardson > wrote: > > The rte_ring library in DPDK provides an excellent high-performance > > mechanism which can be used for passing pointers between cores and > > for other

[dpdk-dev] [PATCH v4 5/8] net/virtio_user: add vhost kernel support

2017-01-13 Thread Jianfeng Tan
This patch add support vhost kernel as the backend for virtio_user. Three main hook functions are added: - vhost_kernel_setup() to open char device, each vq pair needs one vhostfd; - vhost_kernel_ioctl() to communicate control messages with vhost kernel module; - vhost_kernel_enable_q

[dpdk-dev] [PATCH v4 8/8] doc: add guide to use virtio_user as exceptional path

2017-01-13 Thread Jianfeng Tan
Signed-off-by: Jianfeng Tan --- .../img/virtio_user_as_excpetional_path.png| Bin 0 -> 38600 bytes doc/guides/prog_guide/index.rst| 1 + .../prog_guide/virtio_user_as_exceptional_path.rst | 104 + 3 files changed, 105 insertions(+) create mode 10

[dpdk-dev] [PATCH v4 7/8] net/virtio_user: enable multiqueue with vhost kernel

2017-01-13 Thread Jianfeng Tan
With vhost kernel, to enable multiqueue, we need backend device in kernel support multiqueue feature. Specifically, with tap as the backend, as linux/Documentation/networking/tuntap.txt shows, we check if tap supports IFF_MULTI_QUEUE feature. And for vhost kernel, each queue pair has a vhost fd, a

Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

2017-01-13 Thread Olivier Matz
On Fri, 13 Jan 2017 13:17:17 +, Ferruh Yigit wrote: > On 1/13/2017 12:48 PM, Olivier Matz wrote: > > On Fri, 13 Jan 2017 12:03:01 +, Ferruh Yigit > > wrote: > >> On 1/12/2017 1:04 PM, Olivier Matz wrote: > >>> Fix typo when checking that no Vlan offload flags are passed at > >>> port

[dpdk-dev] [PATCH v4 4/8] net/virtio_user: abstract virtio user backend ops

2017-01-13 Thread Jianfeng Tan
Add a struct virtio_user_backend_ops to abstract three kinds of backend operations: - setup, create the unix socket connection; - send_request, sync messages with backend; - enable_qp, enable some queue pair. Signed-off-by: Jianfeng Tan --- drivers/net/virtio/virtio_user/vhost.h

Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 12:48 PM, Olivier Matz wrote: > On Fri, 13 Jan 2017 12:03:01 +, Ferruh Yigit > wrote: >> On 1/12/2017 1:04 PM, Olivier Matz wrote: >>> Fix typo when checking that no Vlan offload flags are passed at port >>> initialization. >>> >>> By the way, also fix a typo in the log. >>> >>> F

[dpdk-dev] [PATCH v4 6/8] net/virtio_user: enable offloading

2017-01-13 Thread Jianfeng Tan
When used with vhost kernel backend, we can offload at both directions. - From vhost kernel to virtio_user, the offload is enabled so that DPDK app can trust the flow is checksum-correct; and if DPDK app sends it through another port, the checksum needs to be recalculated or offloaded

Re: [dpdk-dev] [PATCH v1] doc: add guidelines on stable and lts releases

2017-01-13 Thread Mcnamara, John
> -Original Message- > From: Mcnamara, John > Sent: Friday, January 13, 2017 1:06 PM > To: dev@dpdk.org > Cc: Liu, Yuanhan ; thomas.monja...@6wind.com; > Mcnamara, John > Subject: [PATCH v1] doc: add guidelines on stable and lts releases > > Add document explaining the current Stable and

[dpdk-dev] [PATCH v1] doc: add guidelines on stable and lts releases

2017-01-13 Thread John McNamara
Add document explaining the current Stable and LTS process. Signed-off-by: John McNamara --- V1: For background see previous discussions on Stable and LTS releses: http://dpdk.org/ml/archives/dev/2016-July/044848.html http://dpdk.org/ml/archives/dev/2016-June/040256.html doc/guides/contr

Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

2017-01-13 Thread Ferruh Yigit
On 1/12/2017 1:04 PM, Olivier Matz wrote: > Fix typo when checking that no Vlan offload flags are passed at port > initialization. > > By the way, also fix a typo in the log. > > Fixes: d4a27a3b092a ("nfp: add basic features") > > Signed-off-by: Olivier Matz > --- > drivers/net/nfp/nfp_net.c |

Re: [dpdk-dev] [PATCH v3 15/29] crypto/qat: use eal I/O device memory read/write API

2017-01-13 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Friday, January 13, 2017 11:47 AM > To: Yigit, Ferruh > Cc: Jerin Jacob ; dev@dpdk.org; Ananyev, > Konstantin ; > thomas.monja...@6wind.com; jianbo@linaro.org; vikto...@rehivetech.com; > santosh.shu...@caviumnetworks.com; Griff

[dpdk-dev] [PATCH] scripts: skip capitalization check for commit prefixes

2017-01-13 Thread Bruce Richardson
The prefix in the commit title must be a valid component name and is checked in separate checks. For capitalization, just check the part after the colon. This is already done for most capitalization checks, just make the remainder consistent with this. Signed-off-by: Bruce Richardson --- scripts

Re: [dpdk-dev] [RFC PATCH 00/11] generalise rte_ring to allow different datatypes

2017-01-13 Thread Olivier Matz
Hi Bruce, On Wed, 11 Jan 2017 15:05:14 +, Bruce Richardson wrote: > The rte_ring library in DPDK provides an excellent high-performance > mechanism which can be used for passing pointers between cores and > for other tasks such as buffering. However, it does have a number > of limitations: >

Re: [dpdk-dev] 17.05 Roadmap

2017-01-13 Thread Bruce Richardson
On Fri, Jan 13, 2017 at 10:24:01AM +, O'Driscoll, Tim wrote: > Below are the features that we're planning to submit for the 17.05 release. > We'll submit a patch to update the roadmap page with this info. > > It would be good if others are also willing to share their plans so that we > can b

Re: [dpdk-dev] [PATCH v5] app/testpmd: supported offload capabilities query

2017-01-13 Thread De Lara Guarch, Pablo
Hi Qiming, > -Original Message- > From: Yang, Qiming > Sent: Friday, January 13, 2017 9:40 AM > To: De Lara Guarch, Pablo; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v5] app/testpmd: supported offload > capabilities query > > Hi, Pablo > > -Original Message- > From: De Lara Gu

Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-01-13 Thread Olivier Matz
Hi, On Thu, 12 Jan 2017 14:55:54 +0100, Olivier MATZ wrote: > Hi, > > On Wed, 11 Jan 2017 20:51:58 +, "Rowden, Aaron F" > wrote: > > Hi Helin, > > > > I'm checking on this to see why it could be failing but I don’t > > think this is one part of formal validation. Intel modules are > > alwa

[dpdk-dev] [PATCH v6] app/testpmd: supported offload capabilities query

2017-01-13 Thread Qiming Yang
Add two new commands "show port cap " and "show port cap all"to diaplay what offload capabilities supported in ports. It will not only display all the capabilities of the port, but also the enabling condition for each capability in the running time. Signed-off-by: Qiming Yang Acked-by: Jingjing W

Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

2017-01-13 Thread Olivier Matz
On Fri, 13 Jan 2017 12:03:01 +, Ferruh Yigit wrote: > On 1/12/2017 1:04 PM, Olivier Matz wrote: > > Fix typo when checking that no Vlan offload flags are passed at port > > initialization. > > > > By the way, also fix a typo in the log. > > > > Fixes: d4a27a3b092a ("nfp: add basic features")

Re: [dpdk-dev] [PATCH] tools: add tags and cscope index file generation support

2017-01-13 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Friday, January 13, 2017 2:50 AM > To: Yigit, Ferruh > Cc: dev@dpdk.org; thomas.monja...@6wind.com > Subject: Re: [dpdk-dev] [PATCH] tools: add tags and cscope index file > generation support >

Re: [dpdk-dev] [PATCH 1/2] net/virtio: access interrupt handler directly

2017-01-13 Thread Yuanhan Liu
On Thu, Jan 12, 2017 at 02:03:19PM +0800, Yuanhan Liu wrote: > Since commit 0e1b45a284b4 ("ethdev: decouple interrupt handling from > PCI device"), intr_handle is stored at eth_dev struct, that we could > use it directly. Thus there is no need to get it from hw. > > Signed-off-by: Yuanhan Liu > -

[dpdk-dev] [PATCH v4 1/8] net/virtio_user: fix wrongly get/set features

2017-01-13 Thread Jianfeng Tan
Before the commit 86d59b21468a ("net/virtio: support LRO"), features in virtio PMD, is decided and properly set at device initialization and will not be changed. But afterward, features could be changed in virtio_dev_configure(), and will be re-negotiated if it's changed. In virtio_user, device fe

[dpdk-dev] [PATCH v4 0/8] virtio_user as an alternative exception path

2017-01-13 Thread Jianfeng Tan
v4: - Fix a clang compiling error by removing "NULL" line in the definition of vhost_msg_strings. This error does not show up when it's defined as a static variable, so not necessary to fix it in stable branch. - Query kernel to get how many regions are supported, default 64 regions.

[dpdk-dev] [PATCH v4 3/8] net/virtio_user: move vhost user specific code

2017-01-13 Thread Jianfeng Tan
To support vhost kernel as the backend of net_virtio_user in coming patches, we move vhost_user specific structs and macros into vhost_user.c, and only keep common definitions in vhost.h. Besides, remove VHOST_USER_MQ feature check. Signed-off-by: Jianfeng Tan --- drivers/net/virtio/virtio_user

[dpdk-dev] [PATCH v4 2/8] net/virtio_user: fix not properly reset device

2017-01-13 Thread Jianfeng Tan
virtio_user is not properly reset when users call vtpci_reset(), as it ignores VIRTIO_CONFIG_STATUS_RESET status in virtio_user_set_status(). This might lead to initialization failure as it starts to re-init the device before sending RESET messege to backend. Besides, previous callfds and kickfds

[dpdk-dev] [PATCH] config: build nfp pmd support by default

2017-01-13 Thread Alejandro Lucero
Because using a NFP PMD requires specific BSP installed, the PMD support was not the default option before. This was just for making people aware of such dependency, since there is no need for such a BSP for just compiling DPDK with NFP PMD support. Signed-off-by: Alejandro Lucero --- config/com

Re: [dpdk-dev] [PATCH v3 15/29] crypto/qat: use eal I/O device memory read/write API

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 8:17 AM, Jerin Jacob wrote: > On Thu, Jan 12, 2017 at 07:09:22PM +, Ferruh Yigit wrote: >> Hi Jerin, >> >> On 1/12/2017 9:17 AM, Jerin Jacob wrote: >> <...> >> >>> +#include >>> + >>> /* CSR write macro */ >>> -#define ADF_CSR_WR(csrAddr, csrOffset, val) \ >>> - (void)((*((vola

Re: [dpdk-dev] [PATCH v3 15/29] crypto/qat: use eal I/O device memory read/write API

2017-01-13 Thread Bruce Richardson
On Fri, Jan 13, 2017 at 11:40:06AM +, Ferruh Yigit wrote: > On 1/13/2017 8:17 AM, Jerin Jacob wrote: > > On Thu, Jan 12, 2017 at 07:09:22PM +, Ferruh Yigit wrote: > >> Hi Jerin, > >> > >> On 1/12/2017 9:17 AM, Jerin Jacob wrote: > >> <...> > >> > >>> +#include > >>> + > >>> /* CSR write m

Re: [dpdk-dev] [PATCH v3 18/29] net/cxgbe: use eal I/O device memory read/write API

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 8:37 AM, Jerin Jacob wrote: > On Thu, Jan 12, 2017 at 07:12:33PM +, Ferruh Yigit wrote: >> On 1/12/2017 9:17 AM, Jerin Jacob wrote: >> <...> >> >>> >>> -#define CXGBE_PCI_REG_WRITE(reg, value) ({ \ >>> - CXGBE_PCI_REG((reg)) = (value); }) >>> +#define CXGBE_PCI_REG_WRITE(reg, v

[dpdk-dev] [PATCH v7 4/6] net/ixgbe: add MACsec offload support

2017-01-13 Thread Tiwei Bie
MACsec (or LinkSec, 802.1AE) is a MAC level encryption/authentication scheme defined in IEEE 802.1AE that uses symmetric cryptography. This commit adds the MACsec offload support for ixgbe. Signed-off-by: Tiwei Bie Acked-by: Wenzhuo Lu --- doc/guides/nics/features/default.ini| 1 + do

[dpdk-dev] [PATCH v7 5/6] app/testpmd: add MACsec offload commands

2017-01-13 Thread Tiwei Bie
Below MACsec offload commands are added: - set macsec offload on encrypt on|off replay-protect on|off - set macsec offload off - set macsec sc tx|rx - set macsec sa tx|rx Also update the testpmd user guide. Signed-off-by: Tiwei Bie Acked-by: Wenzhuo Lu --- app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v7 6/6] doc: add ixgbe specific APIs

2017-01-13 Thread Tiwei Bie
Add information about the new ixgbe PMD APIs in the release notes. Signed-off-by: Tiwei Bie Acked-by: John McNamara --- doc/guides/rel_notes/release_17_02.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_17_02.rst b/doc/guides/rel_notes/release_17_02.rs

[dpdk-dev] [PATCH v7 3/6] ethdev: add MACsec offload capability flags

2017-01-13 Thread Tiwei Bie
If these flags are advertised by a PMD, the NIC supports the MACsec offload. The incoming MACsec traffics can be offloaded transparently after the MACsec offload is configured correctly by the application. And the application can set the PKT_TX_MACSEC flag in mbufs to enable the MACsec offload for

Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

2017-01-13 Thread Alejandro Lucero
Acked. Thanks! On Thu, Jan 12, 2017 at 1:04 PM, Olivier Matz wrote: > Fix typo when checking that no Vlan offload flags are passed at port > initialization. > > By the way, also fix a typo in the log. > > Fixes: d4a27a3b092a ("nfp: add basic features") > > Signed-off-by: Olivier Matz > --- >

Re: [dpdk-dev] [PATCH v3 15/29] crypto/qat: use eal I/O device memory read/write API

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 8:17 AM, Jerin Jacob wrote: > On Thu, Jan 12, 2017 at 07:09:22PM +, Ferruh Yigit wrote: >> Hi Jerin, >> >> On 1/12/2017 9:17 AM, Jerin Jacob wrote: >> <...> >> >>> +#include >>> + >>> /* CSR write macro */ >>> -#define ADF_CSR_WR(csrAddr, csrOffset, val) \ >>> - (void)((*((vola

[dpdk-dev] [PATCH v7 5/6] app/testpmd: add MACsec offload commands

2017-01-13 Thread Tiwei Bie
Below MACsec offload commands are added: - set macsec offload on encrypt on|off replay-protect on|off - set macsec offload off - set macsec sc tx|rx - set macsec sa tx|rx Also update the testpmd user guide. Signed-off-by: Tiwei Bie Acked-by: Wenzhuo Lu --- app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v7 4/6] net/ixgbe: add MACsec offload support

2017-01-13 Thread Tiwei Bie
MACsec (or LinkSec, 802.1AE) is a MAC level encryption/authentication scheme defined in IEEE 802.1AE that uses symmetric cryptography. This commit adds the MACsec offload support for ixgbe. Signed-off-by: Tiwei Bie Acked-by: Wenzhuo Lu --- doc/guides/nics/features/default.ini| 1 + do

[dpdk-dev] [PATCH v7 6/6] doc: add ixgbe specific APIs

2017-01-13 Thread Tiwei Bie
Add information about the new ixgbe PMD APIs in the release notes. Signed-off-by: Tiwei Bie Acked-by: John McNamara --- doc/guides/rel_notes/release_17_02.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_17_02.rst b/doc/guides/rel_notes/release_17_02.rs

[dpdk-dev] [PATCH v7 2/6] ethdev: add event type for MACsec

2017-01-13 Thread Tiwei Bie
This commit adds a below event type: - RTE_ETH_EVENT_MACSEC This event will occur when the PN counter in a MACsec connection reaches the exhaustion threshold. Signed-off-by: Tiwei Bie --- lib/librte_ether/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_eth

[dpdk-dev] [PATCH v7 0/6] Add MACsec offload support for ixgbe

2017-01-13 Thread Tiwei Bie
This patch set adds the MACsec offload support for ixgbe. The testpmd is also updated to support MACsec cmds. v2: - Update the documents for testpmd; - Update the release notes; - Reuse the functions provided by base code; v3: - Add the missing parts of MACsec mbuf flag and reorganize the patch s

[dpdk-dev] [PATCH v7 1/6] mbuf: add flag for MACsec

2017-01-13 Thread Tiwei Bie
Add a new Tx flag in mbuf, that can be set by applications to enable the MACsec offload for a packet to be transmitted. Signed-off-by: Tiwei Bie Acked-by: Olivier Matz --- doc/guides/rel_notes/release_17_02.rst | 5 + lib/librte_mbuf/rte_mbuf.c | 2 ++ lib/librte_mbuf/rte_mbuf.h

[dpdk-dev] [PATCH v7 3/6] ethdev: add MACsec offload capability flags

2017-01-13 Thread Tiwei Bie
If these flags are advertised by a PMD, the NIC supports the MACsec offload. The incoming MACsec traffics can be offloaded transparently after the MACsec offload is configured correctly by the application. And the application can set the PKT_TX_MACSEC flag in mbufs to enable the MACsec offload for

Re: [dpdk-dev] [PATCH v6 14/18] net/ixgbe: parse L2 tunnel filter

2017-01-13 Thread Ferruh Yigit
On 1/13/2017 8:13 AM, Wei Zhao wrote: > check if the rule is a L2 tunnel rule, and get the L2 tunnel info. > > Signed-off-by: Wei Zhao > Signed-off-by: Wenzhuo Lu > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 3 +- > drivers/net/ixgbe/ixgbe_flow.c | 216 > +

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-13 Thread Alejandro Lucero
I completely misread the patch, and I wrongly thought that code was linked to module removal, but I see this is not about that, but about releasing the /dev/uio file calling release function, what is done by the kernel when the process exits. So yes, the patch avoids the problem I talked about. H

Re: [dpdk-dev] [PATCH v3 25/29] net/nfp: use eal I/O device memory read/write API

2017-01-13 Thread Alejandro Lucero
On Fri, Jan 13, 2017 at 10:57 AM, Jerin Jacob < jerin.ja...@caviumnetworks.com> wrote: > On Fri, Jan 13, 2017 at 10:49:15AM +, Alejandro Lucero wrote: > > Thanks for that repo. It really makes things easier. > > > > I have run our NFP PMD unit tests using that repo, and this change seems > to

[dpdk-dev] [PATCH v7 1/6] mbuf: add flag for MACsec

2017-01-13 Thread Tiwei Bie
Add a new Tx flag in mbuf, that can be set by applications to enable the MACsec offload for a packet to be transmitted. Signed-off-by: Tiwei Bie Acked-by: Olivier Matz --- doc/guides/rel_notes/release_17_02.rst | 5 + lib/librte_mbuf/rte_mbuf.c | 2 ++ lib/librte_mbuf/rte_mbuf.h

[dpdk-dev] [PATCH v7 2/6] ethdev: add event type for MACsec

2017-01-13 Thread Tiwei Bie
This commit adds a below event type: - RTE_ETH_EVENT_MACSEC This event will occur when the PN counter in a MACsec connection reaches the exhaustion threshold. Signed-off-by: Tiwei Bie --- lib/librte_ether/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_eth

[dpdk-dev] [PATCH v7 0/6] Add MACsec offload support for ixgbe

2017-01-13 Thread Tiwei Bie
This patch set adds the MACsec offload support for ixgbe. The testpmd is also updated to support MACsec cmds. v2: - Update the documents for testpmd; - Update the release notes; - Reuse the functions provided by base code; v3: - Add the missing parts of MACsec mbuf flag and reorganize the patch s

Re: [dpdk-dev] [PATCH v3 25/29] net/nfp: use eal I/O device memory read/write API

2017-01-13 Thread Jerin Jacob
On Fri, Jan 13, 2017 at 10:49:15AM +, Alejandro Lucero wrote: > Thanks for that repo. It really makes things easier. > > I have run our NFP PMD unit tests using that repo, and this change seems to > work without no problem. > > Thanks again. Thanks Alejandro. Can I add you Acked by on your N

Re: [dpdk-dev] [PATCH v3 25/29] net/nfp: use eal I/O device memory read/write API

2017-01-13 Thread Alejandro Lucero
Thanks for that repo. It really makes things easier. I have run our NFP PMD unit tests using that repo, and this change seems to work without no problem. Thanks again. On Thu, Jan 12, 2017 at 1:40 PM, Jerin Jacob wrote: > On Thu, Jan 12, 2017 at 10:53:17AM +, Alejandro Lucero wrote: > >

Re: [dpdk-dev] [RFC] ethdev: abstraction layer for QoS hierarchical scheduler

2017-01-13 Thread Hemant Agrawal
On 11/30/2016 11:46 PM, Cristian Dumitrescu wrote: This RFC proposes an ethdev-based abstraction layer for Quality of Service (QoS) hierarchical scheduler. The goal of the abstraction layer is to provide a simple generic API that is agnostic of the underlying HW, SW or mixed HW-SW complex impleme

[dpdk-dev] 17.05 Roadmap

2017-01-13 Thread O'Driscoll, Tim
Below are the features that we're planning to submit for the 17.05 release. We'll submit a patch to update the roadmap page with this info. It would be good if others are also willing to share their plans so that we can build up a complete picture of what's planned for 17.05 and make sure there'

[dpdk-dev] A question about the function fill_vec_buf

2017-01-13 Thread wangyunjian
In function fill_vec_buf, it will happen uint32_t cast to uint16_t, when the *desc_chain_len is assigned by the len. This maybe result in data truncation. static inline int __attribute__((always_inline)) fill_vec_buf(struct virtio_net *dev, struct vhost_virtqueue *vq,

[dpdk-dev] [PATCH v2 3/4] net/i40e: parse more VF parameter and configure

2017-01-13 Thread Chen Jing D(Mark)
When VF requested to configure TX queue, a few parameters are missed to be configured in PF host. This change have more fields parsed and configured for TX context. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_pf.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff

[dpdk-dev] [PATCH v2 4/4] net/i40e: support Linux VF to configure IRQ link list

2017-01-13 Thread Chen Jing D(Mark)
i40e PF host only support to work with DPDK VF driver, Linux VF driver is not supported. This change will enhance in configuring IRQ link list. This Change will identify VF client by number of vector requested. DPDK VF will ask only single one while Linux VF will request at least 2. It will have d

[dpdk-dev] [PATCH v2 1/4] net/i40e: change version number to support Linux VF

2017-01-13 Thread Chen Jing D(Mark)
i40e PF host only support to work with DPDK VF driver, Linux VF driver is not supported. This change will enhance in version number returned. Current version info returned won't be able to be recognized by Linux VF driver, change to values that both DPDK VF and Linux driver can recognize. The exp

[dpdk-dev] [PATCH v2 2/4] net/i40e: return correct VSI id

2017-01-13 Thread Chen Jing D(Mark)
PF host didn't return correct VSI id to VF. This change fix it. Signed-off-by: Chen Jing D(Mark) --- drivers/net/i40e/i40e_pf.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index fa4af2b..fd83c16 100644 --- a/d

  1   2   >