[dpdk-dev] [PATCH v2] drivers/net:new PMD using tun/tap host interface

2016-09-21 Thread Wiles, Keith
Regards, Keith > On Sep 21, 2016, at 4:24 AM, Thomas Monjalon > wrote: > > 2016-09-21 10:13, Yuanhan Liu: >> On Wed, Sep 21, 2016 at 01:32:15AM +, Wiles, Keith wrote: >>> I only assumed this to work for Linux and not FreeBSD/NetBSD as the >>> handling of the opens on the tun device are di

[dpdk-dev] [PATCH] hash: Correctly set the compare function.

2016-09-21 Thread Thomas Monjalon
2016-09-19 18:36, De Lara Guarch, Pablo: > Commit titles start with lowercase ("correctly") and without a dot at the end. [...] > I think this is a fix, so probably it should contain the following "Fixes" > line in the commit message: > Fixes: 95da2f8e9c61 ("hash: customize compare function") [...

[dpdk-dev] [PATCH v2] meter: fix excess token bucket update in srtcm implementation

2016-09-21 Thread Thomas Monjalon
> > As per srTCM RFC 2697, we should be updating the E bucket only after the > > C bucket overflows. This patch fixes the current DPDK implementation, > > where we are updating both the buckets simultaneously at the same rate > > (CIR) which results in token accumulation rate of (2*CIR). > > > > S

[dpdk-dev] [PATCH v3] testpmd: fix crash when mempool allocation fails

2016-09-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Friday, September 09, 2016 2:42 AM > To: dev at dpdk.org; De Lara Guarch, Pablo > Cc: stable at dpdk.org > Subject: [PATCH v3] testpmd: fix crash when mempool allocation fails > > Avoid access to mempool

[dpdk-dev] [PATCH] app/testpmd: configure flowgen packet size though --txpkts

2016-09-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of > maciej.czekaj at caviumnetworks.com > Sent: Friday, August 26, 2016 4:47 AM > To: dev at dpdk.org > Cc: De Lara Guarch, Pablo; Maciej Czekaj > Subject: [dpdk-dev] [PATCH] app/testpmd: configure flowgen packet

[dpdk-dev] LPM6 next hop size

2016-09-21 Thread Stephen Hemminger
If you have 2G of huge memory and one 16M routes then the rules start to kill an application. Since huge memory is unpageable (pinned) then it is limited. On Wed, Sep 21, 2016 at 6:50 PM, Matthew Hall wrote: > On Wed, Sep 21, 2016 at 04:42:05PM -0700, Stephen Hemminger wrote: > > This was intent

[dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction

2016-09-21 Thread Thomas Monjalon
Hi, 2016-09-21 17:08, Karmarkar Suyash: > Hello, > > I corrected the fixes line, Can you please review the change and if no > further comments can you please let me know the next steps. Thanks. The Fixes lines is still not correct. The id ba885531ac26 do not exist. Please check your patch with

[dpdk-dev] [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC addresses tweaking

2016-09-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com] > Sent: Tuesday, July 26, 2016 8:56 AM > To: Richardson, Bruce; De Lara Guarch, Pablo > Cc: dev at dpdk.org; Maxime Coquelin > Subject: [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC > addres

[dpdk-dev] LPM6 next hop size

2016-09-21 Thread Thomas Monjalon
2016-09-21 10:29, Matthew Hall: > On Tue, Sep 20, 2016 at 10:11:04PM +0200, Thomas Monjalon wrote: > > Please, will you help reviewing this patch? > > Sure. > > 1. It adds a dependency on libbsd on Linux: bsd/sys/tree.h. Is this an > expected dependency of DPDK already? I use it in my code but n

[dpdk-dev] [PATCH] hash: Correctly set the compare function.

2016-09-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, September 21, 2016 2:29 PM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org; Masoud Hasanifard > Subject: Re: [dpdk-dev] [PATCH] hash: Correctly set the compare function. > > 2016-09-19

[dpdk-dev] [PATCH v3 2/2] crypto/qat: adding support for 3DES cipher algorithm

2016-09-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jain, Deepak K > Sent: Wednesday, September 21, 2016 3:00 AM > To: Trahe, Fiona; dev at dpdk.org > Cc: De Lara Guarch, Pablo; Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH v3 2/2] crypto/qat: adding support for 3DES > cipher algorithm > > > -Original Mess

[dpdk-dev] [PATCH v3 1/2] crypto/qat: code cleanup

2016-09-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jain, Deepak K > Sent: Wednesday, September 21, 2016 2:54 AM > To: Trahe, Fiona; dev at dpdk.org > Cc: De Lara Guarch, Pablo; Trahe, Fiona > Subject: RE: [dpdk-dev] [PATCH v3 1/2] crypto/qat: code cleanup > > > > > -Original Message- > > From: dev [

[dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization

2016-09-21 Thread Matej Vido
Hi Shreyansh, I have tested this patch-set with szedata2 driver and it works fine. Regards, Matej On 20.09.2016 14:41, Shreyansh Jain wrote: > Based on master (e15922d75) > > Background: > === > > It includes two different patch-sets floated on ML earlier: > * Original patch series is

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-09-21 Thread Jianbo Liu
On 21 September 2016 at 17:27, Wang, Zhihong wrote: > > >> -Original Message- >> From: Jianbo Liu [mailto:jianbo.liu at linaro.org] >> Sent: Wednesday, September 21, 2016 4:50 PM >> To: Maxime Coquelin >> Cc: Wang, Zhihong ; dev at dpdk.org; >> yuanhan.liu at linux.intel.com >> Subject: R

[dpdk-dev] [PATCH v4 3/3] app/testpmd: fix Tx offload on tunneling packet

2016-09-21 Thread Tan, Jianfeng
Hi Konstantin, On 9/19/2016 8:09 PM, Ananyev, Konstantin wrote: > Hi Jainfeng, > >> -Original Message- >> From: Tan, Jianfeng >> Sent: Monday, August 1, 2016 4:57 AM >> To: dev at dpdk.org >> Cc: thomas.monjalon at 6wind.com; De Lara Guarch, Pablo >> ; Ananyev, Konstantin >> ; Wu, Jingji

[dpdk-dev] I40 PMD VF failure

2016-09-21 Thread Gregory Etelson
Hello, Please check out I40 PMD VF initialization error I got . The error reproduces on each invocation Ethernet controller is X710 driver: i40e version: 1.5.16 firmware-version: 4.25 0x8000143f 0.0.0 DPDK-16.07 Thank you, Gregory EAL: Detected lcore 0 as core 0 on socket 0

[dpdk-dev] [PATCH] kni: add support for core_id param in single threaded mode

2016-09-21 Thread Ferruh Yigit
On 9/21/2016 6:15 PM, Vladyslav Buslov wrote: >> On 9/20/2016 7:36 PM, Stephen Hemminger wrote: >>> On Tue, 20 Sep 2016 21:16:37 +0300 >>> Vladyslav Buslov wrote: >>> @@ -123,6 +125,9 @@ static int __net_init kni_init_net(struct net *net) /* Clear the bit of device in use */ c

[dpdk-dev] [PATCH 1/3] kni: remove single mempool, single mem_chunk restriction

2016-09-21 Thread Thomas Monjalon
2016-08-25 12:30, Ferruh Yigit: > Use mempool buf_addr and buf_physaddr fields for address translation. > > Since each mbuf address calculated separately, the restriction of all > mbufs should come from a continuous memory restriction is no more valid. > > mbuf related FIFO's content changed, rx_

[dpdk-dev] [PATCH v6] net/virtio: add set_mtu in virtio

2016-09-21 Thread Dey
From: souvikdey33 Virtio interfaces do not currently allow the user to specify a particular Maximum Transmission Unit (MTU).Consequently, the MTU of Virtio interfaces is typically set to the Ethernet default value of 1500. This is problematic in the case of cloud deployments, in which a specif

[dpdk-dev] [PATCH v4 2/2] net/vhost: add pmd xstats

2016-09-21 Thread Yuanhan Liu
On Wed, Sep 21, 2016 at 06:05:55PM +0800, Zhiyong Yang wrote: > +static inline void > +vhost_count_multicast_broadcast(struct vhost_queue *vq, > + struct rte_mbuf **bufs, > + uint16_t count) Hmm.. why not just passing "struct rte_mbuf *mbuf"?

[dpdk-dev] [PATCH v4] tools: add crypto device details

2016-09-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jain, Deepak K > Sent: Wednesday, September 21, 2016 3:04 AM > To: De Lara Guarch, Pablo; dev at dpdk.org > Subject: RE: [PATCH v4] tools: add crypto device details > > > > -Original Message- > > From: De Lara Guarch, Pablo > > Sent: Tuesday, Septemb

[dpdk-dev] LPM6 next hop size

2016-09-21 Thread Matthew Hall
On Wed, Sep 21, 2016 at 04:42:05PM -0700, Stephen Hemminger wrote: > This was intentional because rte_malloc comes out of huge page area and that > resource is a critical resource. It could use rte_malloc() but that makes it > more likely to break when doing Policy Based routing or VRF. Can we get

[dpdk-dev] [PATCH v6] net/virtio: add set_mtu in virtio

2016-09-21 Thread Stephen Hemminger
On Thu, 22 Sep 2016 00:08:38 + "Dey, Souvik" wrote: > Answers inline. > > -- > Regards, > Souvik > > -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Wednesday, September 21, 2016 7:22 PM > To: Dey, Souvik > Cc: mark.b.kavanagh at intel.c

[dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash

2016-09-21 Thread Thomas Monjalon
2016-09-13 14:13, Ferruh Yigit: > On 9/11/2016 10:59 AM, zhouyangchao wrote: > > Signed-off-by: zhouyangchao > > There is a typo in the patch subject, I suggest: > kni: fix error rollback kernel crash > > Fixes: 9c61145ff6f9 ("kni: allow multiple threads") > > Acked-by: Ferruh Yigit Applied,

[dpdk-dev] [PATCH 0/2] Rename SNOW 3G/KASUMI references

2016-09-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, September 20, 2016 6:45 PM > To: dev at dpdk.org > Cc: Doherty, Declan; De Lara Guarch, Pablo > Subject: [PATCH 0/2] Rename SNOW 3G/KASUMI references > > In some of the documentation or code comments, there are > some mi

[dpdk-dev] [PATCH] kni: remove rte_panic exits from library

2016-09-21 Thread Thomas Monjalon
2016-09-02 10:51, Ferruh Yigit: > This also helps to remove stack backtrace when kernel module is not > inserted. > > Signed-off-by: Ferruh Yigit Applied, thanks

[dpdk-dev] [PATCH v2] kni: fix build with kernel 4.8

2016-09-21 Thread Thomas Monjalon
2016-09-09 22:33, De Lara Guarch, Pablo: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit > > Linux kernel v4.8 removes macro DEFINE_PCI_DEVICE_TABLE > > > > Linux: 7e9321599011 ("treewide: remove references to the now unnecessary > > DEFINE_PCI_DEVICE_TABLE") > > > > Replac

[dpdk-dev] [PATCH] crypto/qat: fix compile of qat on freebsd

2016-09-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Wednesday, September 21, 2016 10:37 AM > To: Jain, Deepak K; dev at dpdk.org > Cc: Gonzalez Monroy, Sergio; stable at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix c

[dpdk-dev] [PATCH] kni: fix build with kernel < v3.0

2016-09-21 Thread Thomas Monjalon
2016-09-16 17:09, Ferruh Yigit: > Compile error: > CC [M] .../build/lib/librte_eal/linuxapp/kni/igb_main.o > .../build/lib/librte_eal/linuxapp/kni/igb_main.c: > In function ?igb_check_swap_media?: > .../build/lib/librte_eal/linuxapp/kni/igb_main.c:1556:7: > error: variable ?link? set but not use

[dpdk-dev] [PATCH v4 1/2] net/vhost: add a new defined stats struct

2016-09-21 Thread Zhiyong Yang
The patch moves all stats counters to a new defined struct vhost_stats as follows, in order to manage all stats counters in a unified way and simplify the subsequent function implementation(vhost_dev_xstats_reset). Signed-off-by: Zhiyong Yang --- Changes in v4: A queue can be only used as TX or

[dpdk-dev] [PATCH v2] kni: support RHEL 7.3

2016-09-21 Thread Thomas Monjalon
2016-09-19 10:01, Ferruh Yigit: > On 9/16/2016 10:01 PM, Pablo de Lara wrote: > > Add support for RHEL 7.3, which uses kernel 3.10, > > but backported features from newer kernels. > > > > Signed-off-by: Pablo de Lara > > --- > > Acked-by: Ferruh Yigit Applied, thanks

[dpdk-dev] [PATCH] kni: fix compilation error when debug enabled

2016-09-21 Thread Thomas Monjalon
2016-09-15 13:06, Ferruh Yigit: > Fix build error with Linux kernel >= v4.7 > > Fix compile error because of Linux API change, 'trans_start' field > removed from 'struct net_device'. > > Linux: 9b36627acecd ("net: remove dev->trans_start") > > Signed-off-by: Ferruh Yigit Applied, thanks

[dpdk-dev] [PATCH v4 2/2] net/vhost: add pmd xstats

2016-09-21 Thread Zhiyong Yang
This feature adds vhost pmd extended statistics from per queue perspective in order to meet the requirements of the applications such as OVS etc. The statistics counters are based on RFC 2819 and RFC 2863 as follows: rx/tx_good_packets rx/tx_total_bytes rx/tx_missed_pkts rx/tx_broadcast_packets r

[dpdk-dev] [PATCH v4 0/2] net/vhost: add pmd xstats support

2016-09-21 Thread Zhiyong Yang
Subject: [PATCH v4 1/2] net/vhost: add a new defined stats struct The patch moves all stats counters to a new defined struct vhost_stats as follows, in order to manage all stats counters in a unified way and simplify the subsequent function implementation(vhost_dev_xstats_reset). Signed-off-by: Z

[dpdk-dev] [PATCH v4 0/2] net/vhost: add pmd xstats support

2016-09-21 Thread Zhiyong Yang
Patch 1 moves all stats counters to a new defined struct vhost_stats, in order to manage all stats counters in a consistent way. Changes in v4: A queue can be only used as TX or RX, So, we can use pkts instead of rx_pkts and tx_pkts, the same to rx_bytes and tx_bytes. Before modification: struct v

[dpdk-dev] [PATCH] kni: add support for core_id param in single threaded mode

2016-09-21 Thread Ferruh Yigit
On 9/20/2016 7:36 PM, Stephen Hemminger wrote: > On Tue, 20 Sep 2016 21:16:37 +0300 > Vladyslav Buslov wrote: > >> @@ -123,6 +125,9 @@ static int __net_init kni_init_net(struct net *net) >> /* Clear the bit of device in use */ >> clear_bit(KNI_DEV_IN_USE_BIT_NUM, &knet->device_in_use);

[dpdk-dev] [PATCH] crypto/qat: fix compile of qat on freebsd

2016-09-21 Thread De Lara Guarch, Pablo
> -Original Message- > From: Jain, Deepak K > Sent: Wednesday, September 21, 2016 4:23 AM > To: dev at dpdk.org > Cc: Gonzalez Monroy, Sergio; De Lara Guarch, Pablo; Jain, Deepak K > Subject: [PATCH] crypto/qat: fix compile of qat on freebsd > > Using sys/types.h instead of linux/types.h

[dpdk-dev] [PATCH] bnxt: Update MAINTAINERS file for bnxt driver

2016-09-21 Thread Ajit Khaparde
Add Ajit Khaparde as the maintainer of the bnxt PMD CC: Stephen Hurd Signed-off-by: Ajit Khaparde Reviewed-by: David Christensen --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7c33ad4..32df457 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2

[dpdk-dev] [PATCH 1/2] mempool: fix comments for mempool create functions

2016-09-21 Thread Ferruh Yigit
On 9/21/2016 4:04 PM, Olivier Matz wrote: > Hi Ferruh, > > Thanks for checking the API documentation. > Please see few comments below. > > On 09/20/2016 06:17 PM, Ferruh Yigit wrote: >> Fixes: 85226f9c526b ("mempool: introduce a function to create an empty pool") >> Fixes: d1d914ebbc25 ("mempool:

[dpdk-dev] [PATCH] kni: add support for core_id param in single threaded mode

2016-09-21 Thread Vladyslav Buslov
> On 9/20/2016 7:36 PM, Stephen Hemminger wrote: > > On Tue, 20 Sep 2016 21:16:37 +0300 > > Vladyslav Buslov wrote: > > > >> @@ -123,6 +125,9 @@ static int __net_init kni_init_net(struct net *net) > >>/* Clear the bit of device in use */ > >>clear_bit(KNI_DEV_IN_USE_BIT_NUM, &knet->device_

[dpdk-dev] [PATCH 2/2] mempool: fix comments for no contiguous flag

2016-09-21 Thread Ferruh Yigit
Hi Olivier, On 9/21/2016 4:12 PM, Olivier Matz wrote: > Hi Ferruh, > > On 09/20/2016 06:17 PM, Ferruh Yigit wrote: >> Fixes: ce94a51ff05c ("mempool: add flag for removing phys contiguous >> constraint") >> >> Signed-off-by: Ferruh Yigit >> --- >> lib/librte_mempool/rte_mempool.c | 4 +++- >> l

[dpdk-dev] [PATCH 2/2] mempool: fix comments for no contiguous flag

2016-09-21 Thread Olivier Matz
Hi Ferruh, On 09/20/2016 06:17 PM, Ferruh Yigit wrote: > Fixes: ce94a51ff05c ("mempool: add flag for removing phys contiguous > constraint") > > Signed-off-by: Ferruh Yigit > --- > lib/librte_mempool/rte_mempool.c | 4 +++- > lib/librte_mempool/rte_mempool.h | 3 +++ > 2 files changed, 6 inser

[dpdk-dev] [PATCH v6] net/virtio: add set_mtu in virtio

2016-09-21 Thread Dey
From: souvikdey33 Virtio interfaces do not currently allow the user to specify a particular Maximum Transmission Unit (MTU).Consequently, the MTU of Virtio interfaces is typically set to the Ethernet default value of 1500. This is problematic in the case of cloud deployments, in which a specif

[dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction

2016-09-21 Thread Karmarkar Suyash
Hello, I corrected the fixes line, Can you please review the change and if no further comments can you please let me know the next steps. Thanks. Regards Suyash Karmarkar -Original Message- From: Karmarkar Suyash Sent: Friday, September 16, 2016 12:02 PM To: dev at dpdk.org Cc: thomas.

[dpdk-dev] [PATCH 1/2] mempool: fix comments for mempool create functions

2016-09-21 Thread Olivier Matz
Hi Ferruh, Thanks for checking the API documentation. Please see few comments below. On 09/20/2016 06:17 PM, Ferruh Yigit wrote: > Fixes: 85226f9c526b ("mempool: introduce a function to create an empty pool") > Fixes: d1d914ebbc25 ("mempool: allocate in several memory chunks by default") > > Sig

[dpdk-dev] [PATCH v5] net/virtio: add set_mtu in virtio

2016-09-21 Thread Dey
From: Souvik Dey Virtio interfaces do not currently allow the user to specify a particular Maximum Transmission Unit (MTU).Consequently, the MTU of Virtio interfaces is typically set to the Ethernet default value of 1500. This is problematic in the case of cloud deployments, in which a specifi

[dpdk-dev] [PATCH v2]:rte_timer:timer lag issue correction

2016-09-21 Thread Karmarkar Suyash
For Periodic timers ,if the lag gets introduced, the current code added additional delay when the next peridoc timer was initialized by not taking into account the delay added, with this fix the code would start the next occurrence of timer keeping in account the lag added.Corrected the behavio

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

2016-09-21 Thread Jianbo Liu
Hi Maxime, On 22 August 2016 at 16:11, Maxime Coquelin wrote: > Hi Zhihong, > > On 08/19/2016 07:43 AM, Zhihong Wang wrote: >> >> This patch set optimizes the vhost enqueue function. >> ... > > My setup consists of one host running a guest. > The guest generates as much 64bytes packets as possi

[dpdk-dev] [PATCH] kni: add support for core_id param in single threaded mode

2016-09-21 Thread Stephen Hemminger
On Wed, 21 Sep 2016 19:23:47 +0100 Ferruh Yigit wrote: > On 9/21/2016 6:15 PM, Vladyslav Buslov wrote: > >> On 9/20/2016 7:36 PM, Stephen Hemminger wrote: > >>> On Tue, 20 Sep 2016 21:16:37 +0300 > >>> Vladyslav Buslov wrote: > >>> > @@ -123,6 +125,9 @@ static int __net_init kni_init_ne

[dpdk-dev] LPM6 next hop size

2016-09-21 Thread Stephen Hemminger
On Wed, 21 Sep 2016 10:29:05 -0700 Matthew Hall wrote: > 5. It uses "malloc" instead of standard DPDK allocators. That's bad for me > because I don't want to use libc malloc in my code. Only DPDK allocators and > jemalloc. This was intentional because rte_malloc comes out of huge page area and

[dpdk-dev] [PATCH v5] net/virtio: add set_mtu in virtio

2016-09-21 Thread Dey
From: Souvik Dey Virtio interfaces do not currently allow the user to specify a particular Maximum Transmission Unit (MTU).Consequently, the MTU of Virtio interfaces is typically set to the Ethernet default value of 1500. This is problematic in the case of cloud deployments, in which a specifi

[dpdk-dev] [PATCH v6] net/virtio: add set_mtu in virtio

2016-09-21 Thread Stephen Hemminger
On Wed, 21 Sep 2016 19:11:47 -0400 Dey wrote: > > + > +#define VLAN_TAG_SIZE 4/* 802.3ac tag (not DMA'd) */ > + > +static int virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) > +{ > + struct rte_eth_dev_info dev_info; > + uint32_t ether_hdr_len = ETHER_HDR_LEN + E

[dpdk-dev] rte_eth_link_get

2016-09-21 Thread Keren Hochman
Hi, rte_eth_link_get returns after up to 9 seconds. If its return that link_status is down does it necessary means that the port is bot connected or there is a problem with the network or maybe just no data was received? Thanks, Keren

[dpdk-dev] [PATCH v5] Signed-off-by: Souvik Dey

2016-09-21 Thread Dey
From: Souvik Dey Virtio interfaces do not currently allow the user to specify a particular Maximum Transmission Unit (MTU).Consequently, the MTU of Virtio interfaces is typically set to the Ethernet default value of 1500. This is problematic in the case of cloud deployments, in which a specifi

[dpdk-dev] [PATCH] bnxt: Update MAINTAINERS file for bnxt driver

2016-09-21 Thread Stephen Hurd
On Wed, Sep 21, 2016 at 3:27 PM, Ajit Khaparde wrote: > Add Ajit Khaparde as the maintainer of the bnxt PMD > > CC: Stephen Hurd > Signed-off-by: Ajit Khaparde > Reviewed-by: David Christensen > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINE

[dpdk-dev] [PATCH] net/mlx5: support Mellanox OFED 3.4

2016-09-21 Thread Nelio Laranjeiro
Some macros are renamed by Mellanox OFED 3.4. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/Makefile| 5 + drivers/net/mlx5/mlx5_prm.h | 6 ++ drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/Makefile b/dr

[dpdk-dev] [PATCH v4 3/3] app/testpmd: fix Tx offload on tunneling packet

2016-09-21 Thread Ananyev, Konstantin
Hi Jianfeng, > > Hi Konstantin, > > > On 9/19/2016 8:09 PM, Ananyev, Konstantin wrote: > > Hi Jainfeng, > > > >> -Original Message- > >> From: Tan, Jianfeng > >> Sent: Monday, August 1, 2016 4:57 AM > >> To: dev at dpdk.org > >> Cc: thomas.monjalon at 6wind.com; De Lara Guarch, Pablo >

[dpdk-dev] [PATCH] kni: add support for core_id param in single threaded mode

2016-09-21 Thread Ferruh Yigit
On 9/20/2016 7:16 PM, Vladyslav Buslov wrote: > Allow binding KNI thread to specific core in single threaded mode > by setting core_id and force_bind config parameters. > > Signed-off-by: Vladyslav Buslov Thanks Vladyslav! Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v5]net/virtio: add mtu set in virtio

2016-09-21 Thread Kavanagh, Mark B
> > Hi Souvik, There are some very basic errors in this patch, particularly with respect to format. Review comments are inline - please address same and resubmit the patch. I also recommend running $DPDK_DIR/utilities/checkpatch.py on any future submissions. Thanks, Mark > As a genera

[dpdk-dev] [PATCH] rte_delay_us can be replaced with user function

2016-09-21 Thread Thomas Monjalon
Hi, I think this feature should enter in the release 16.11. We just need to make sure it is implemented with the right API. Do you have any comment about managing several builtin handlers? 2016-09-13 22:04, Thomas Monjalon: > Hi, > > Sorry for late review. > This patch was in a summer hole :/ >

[dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id

2016-09-21 Thread Thomas Monjalon
2016-09-18 16:27, Yuanhan Liu: > On Wed, Sep 14, 2016 at 10:35:53AM +0200, Thomas Monjalon wrote: > > 2016-09-14 15:21, Yuanhan Liu: > > > On Wed, Sep 14, 2016 at 09:10:48AM +0200, Thomas Monjalon wrote: > > > > 2016-09-14 12:43, Yuanhan Liu: > > > > > On Tue, Sep 13, 2016 at 05:10:09PM +0200, Thom

[dpdk-dev] [PATCH 1/1 v2] eal: Fix misleading error messages, errno can't be trusted.

2016-09-21 Thread Jean Tourrilhes
lib/librte_eal/linuxapp/eal/eal.c| 14 +++--- lib/librte_eal/linuxapp/eal/eal_memory.c | 16 2 files changed, 23 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 3fb2188..5df9f6a 100644 --- a/l

[dpdk-dev] [PATCH] examples: fix ip_pipeline to load PMD driver correctly

2016-09-21 Thread Gowrishankar
From: Gowrishankar Muthukrishnan There is typo in init.c of ip_pipeline example due to which, invalid file path is added to -d option of EAL i.e path starting with =. Signed-off-by: Gowrishankar Muthukrishnan --- examples/ip_pipeline/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [PATCH v2 1/6] ethdev: add Tx preparation

2016-09-21 Thread Jerin Jacob
On Tue, Sep 20, 2016 at 09:06:42AM +, Ananyev, Konstantin wrote: > > Hi Jerin, Hi Konstantin, > > > > > > > > > > > > [...] > > > > > > > > + > > > > > +#ifdef RTE_ETHDEV_TX_PREP > > > > > > > > Sorry for being a bit late on that discussion, but what the point of > > > > having that config

[dpdk-dev] [PATCH v2] net/ixgbe: use queues assigned to PF instad of VF

2016-09-21 Thread Bruce Richardson
On Thu, Sep 08, 2016 at 12:55:00AM +, Lu, Wenzhuo wrote: > Hi, > > > -Original Message- > > From: Alex Zelezniak [mailto:alexz at att.com] > > Sent: Tuesday, August 30, 2016 9:23 AM > > To: dev at dpdk.org > > Cc: Lu, Wenzhuo; Yigit, Ferruh; stephen at networkplumber.org; azelezniak >

[dpdk-dev] [RFC] net/ixgbe: start rxtx after all nic config done.

2016-09-21 Thread Bruce Richardson
On Wed, Sep 21, 2016 at 10:28:39AM +0100, Ferruh Yigit wrote: > ... > > Subject: [dpdk-dev] [RFC] net/ixgbe: start rxtx after all nic config > done. > > if start rxtx before flow director config, will cause driver can't > receive packets from nic. > > Signed-off

[dpdk-dev] [PATCH v8 2/2] examples/ipsec-secgw: add sample configuration files

2016-09-21 Thread Fan Zhang
This patch adds two sample configuration files to ipsec-secgw sample application. The sample configuration files shows how to setup back-to-back systems that would forward traffic through an IPsec tunnel. Signed-off-by: Fan Zhang --- examples/ipsec-secgw/ep0.cfg | 160 +++

[dpdk-dev] [PATCH v8 1/2] examples/ipsec-secgw: add configuration file support

2016-09-21 Thread Fan Zhang
This patch adds the configuration file support to ipsec_secgw sample application. Instead of hard-coded rules, the users can specify their own SP, SA, and routing rules in the configuration file. An command line option "-f" is added to pass the configuration file location to the application. Confi

[dpdk-dev] [PATCH v8 0/2] examples/ipsec_secgw: add configuration file support

2016-09-21 Thread Fan Zhang
This patchset adds the configuration file supported to ipsec_secgw sample application. Two sample configuration files, ep0.cfg and ep1.cfg are also added to show how to configure two systems back-to-back that would forward traffic through an IPsec tunnel v8 change: - fix wrong inbound SA rule par

[dpdk-dev] [PATCH v2] net/i40e: fix dropping packets with Ethertype 0x88A8

2016-09-21 Thread Bruce Richardson
On Wed, Aug 17, 2016 at 03:09:43AM +, Wu, Jingjing wrote: > > > > -Original Message- > > From: Xing, Beilei > > Sent: Wednesday, August 17, 2016 9:58 AM > > To: Wu, Jingjing > > Cc: dev at dpdk.org; Xing, Beilei > > Subject: [PATCH v2] net/i40e: fix dropping packets with Ethertype 0x8

[dpdk-dev] [PATCH] crypto/qat: fix compile of qat on freebsd

2016-09-21 Thread Deepak Kumar Jain
Using sys/types.h instead of linux/types.h so as to compile QAT_PMD on freebsd. Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") Signed-off-by: Deepak Kumar Jain --- drivers/crypto/qat/qat_adf/icp_qat_fw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[dpdk-dev] [PATCH] net/enic: bad L4 checksum ptype set on ICMP packets

2016-09-21 Thread Bruce Richardson
On Wed, Aug 17, 2016 at 03:15:26PM -0700, John Daley wrote: > The bad L4 checksum flag was set on IP packets which were not > also TCP or UDP packets. This includes ICMP, IGMP and OSPF packets. > > L4 ptypes were being treated as bits instead of values within the > L4 mask causing the code to chec

[dpdk-dev] [PATCH] net/fm10k: fix MAC address remnant in switch

2016-09-21 Thread Bruce Richardson
On Fri, Aug 05, 2016 at 05:52:51AM +, Chen, Jing D wrote: > Hi, > > > -Original Message- > > From: Wang, Xiao W > > Sent: Friday, August 05, 2016 11:18 AM > > To: Chen, Jing D ; Lin, Xueqin > intel.com> > > Cc: dev at dpdk.org; Wang, Xiao W > > Subject: [PATCH] net/fm10k: fix MAC add

[dpdk-dev] [PATCH] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV

2016-09-21 Thread Remy Horton
On 26/08/2016 10:08, Bernard Iremonger wrote: > modify ixgbe_dcb_tx_hw_config function. > modify ixgbe_dev_mq_rx_configure function. > modify ixgbe_configure_dcb function. > > Signed-off-by: Rahul R Shah > Signed-off-by: Bernard Iremonger > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 9 -

[dpdk-dev] [PATCH 1/1] ixgbe: fix a log

2016-09-21 Thread Remy Horton
On 27/08/2016 04:28, Yunjian Wang wrote: > Signed-off-by: Yunjian Wang > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Remy Horton

[dpdk-dev] [PATCH 3/5] bnxt: Add support for new HWRM version

2016-09-21 Thread Bruce Richardson
On Mon, Aug 15, 2016 at 06:06:53PM -0500, Ajit Khaparde wrote: > Update HWRM specification to 1.3.0 release. > Hardware Resource Manager or HWRM in short, is a set of API provided > by the firmware running in the ASIC to manage the various resources. > > Signed-off-by: Ajit Khaparde > --- > driv

[dpdk-dev] [PATCH] net/enic: move link checking init to probe time

2016-09-21 Thread Bruce Richardson
On Tue, Aug 09, 2016 at 02:42:04PM -0700, Nelson Escobar wrote: > The enic DMAs link status information to the host and this requires a > little setup. This setup was being done as a result of calling > rte_eth_dev_start(). But applications expect to be able to check link > status before calling

[dpdk-dev] [PATCH v2] pcap: fix memory leak in jumbo frames

2016-09-21 Thread Bruce Richardson
On Tue, Sep 20, 2016 at 02:12:38PM +0100, Ferruh Yigit wrote: > Hi Dror, > > On 9/20/2016 1:08 PM, Dror Birkman wrote: > > If rte_pktmbuf_alloc() fails on any segment that is not the initial > > segment, previously allocated mbufs are not freed. > > > > Fixes: 6db141c91e1f ("pcap: support jumbo f

[dpdk-dev] [PATCH 1/1] eal: Fix misleading error messages, errno can't be trusted.

2016-09-21 Thread Jean Tourrilhes
lib/librte_eal/linuxapp/eal/eal.c| 14 +++--- lib/librte_eal/linuxapp/eal/eal_memory.c | 16 2 files changed, 23 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 3fb2188..f6907f5 100644 --- a/l

[dpdk-dev] [PATCH v3 0/6] net/mlx5: performance improvement

2016-09-21 Thread Bruce Richardson
On Tue, Sep 20, 2016 at 10:53:45AM +0200, Nelio Laranjeiro wrote: > - Rework structure elements to reduce their size. > - Removes a second useless loop in Tx burst function. > > This series should be applied on top of "net/mlx5: various fixes". > > Changes in v2: > > - rework serie to apply i

[dpdk-dev] [RFC] examples/ethtool: enhance ethtool app in i40e

2016-09-21 Thread Remy Horton
On 20/09/2016 08:30, Qiming Yang wrote: > Now, run the example/ethtool, the drvinfo can not show the fireware > information. From customer point of view, it should be better if we > can have the same as kernel version ethtool show the bus-info and > firmware-version. We need to add a variable in s

[dpdk-dev] [PATCH v4 3/3] app/test_pmd: add tests for new API's

2016-09-21 Thread Bernard Iremonger
add test for vf vlan anti spoof add test for vf mac anti spoof add test for vf vlan stripq add test for vf vlan insert add test for tx loopback add test for all queues drop enable bit add test for vf split drop enable bit add test for vf mac address add new API's to the testpmd guide Signed-off-by

[dpdk-dev] [PATCH v4 2/3] net/ixgbe: add functions for VF management

2016-09-21 Thread Bernard Iremonger
Add new functions to configure and manage VF's on an Intel 82559 NIC. add ixgbe_set_vf_vlan_anti_spoof function. add ixgbe_set_vf_mac_anti_spoof function. Signed-off-by: azelezniak add ixgbe_set_vf_vlan_insert function. add ixgbe_set_tx_loopback function. add ixgbe_set_all_queues_drop function.

[dpdk-dev] [PATCH v4 1/3] librte_ether: add API's for VF management

2016-09-21 Thread Bernard Iremonger
Add new API functions to configure and manage VF's on a NIC. add rte_eth_dev_set_vf_vlan_anti_spoof function. add rte_eth_dev_set_vf_mac_anti_spoof function. add rte_eth_dev_set_vf_vlan_stripq function. Signed-off-by: azelezniak add rte_eth_dev_set_vf_vlan_insert function. add rte_eth_dev_set_l

[dpdk-dev] [PATCH v4 0/3] add API's for VF management

2016-09-21 Thread Bernard Iremonger
This patchset contains new DPDK API's requested by AT&T for use with the Virtual Function Daemon (VFD). The need to configure and manage VF's on a NIC has grown to the point where AT&T have devloped a DPDK based tool, VFD, to do this. This patch set adds API extensions to DPDK VF configuration.

[dpdk-dev] [PATCH v2] nfp: unregister interrupt callback when closing

2016-09-21 Thread Bruce Richardson
On Fri, Sep 16, 2016 at 12:11:14PM +0100, Alejandro Lucero wrote: > With an app using hotplug feature, when a device is unplugged without > unregistering makes the interrupt handling unstable. > > Fixes: 6c53f87b3497 ("nfp: add link status interrupt") > > Signed-off-by: Alejandro Lucero Applied

[dpdk-dev] [PATCH v2] nfp: fixing bug when copying MAC address

2016-09-21 Thread Bruce Richardson
On Fri, Sep 16, 2016 at 12:11:04PM +0100, Alejandro Lucero wrote: > Fixes: defb9a5dd156 ("nfp: introduce driver initialization") > > Signed-off-by: Alejandro Lucero > --- > drivers/net/nfp/nfp_net.c | 4 ++-- Applied to dpdk-next-net/rel_16_11 /Bruce

[dpdk-dev] [PATCH v2] nfp: using random MAC address if not configured

2016-09-21 Thread Bruce Richardson
On Fri, Sep 16, 2016 at 12:10:48PM +0100, Alejandro Lucero wrote: > Signed-off-by: Alejandro Lucero > --- > drivers/net/nfp/nfp_net.c | 28 > 1 file changed, 16 insertions(+), 12 deletions(-) > Applied to dpdk-next-net/rel_16_11 /Bruce

[dpdk-dev] [PATCH 0/3] net/thunderx: add 81xx SoC support

2016-09-21 Thread Bruce Richardson
On Thu, Jul 21, 2016 at 07:31:44PM +0530, Jerin Jacob wrote: > CN81xx is four core version of ThunderX SoC. > > Added the support by adding new HW capability flag to select > the difference in runtime. > > Jerin Jacob (3): > net/thunderx: remove generic passx references from the driver > net/

[dpdk-dev] [PATCH] net/mlx: fix compile errors with ignore pedantic pragma

2016-09-21 Thread Bruce Richardson
On Tue, Sep 20, 2016 at 02:51:27PM +0200, Adrien Mazarguil wrote: > On Mon, Sep 19, 2016 at 04:26:05PM +0100, Bruce Richardson wrote: > > On Mon, Sep 19, 2016 at 04:59:59PM +0200, Adrien Mazarguil wrote: > > > Hi Bruce, > > > > > > On Mon, Sep 19, 2016 at 03:36:54PM +0100, Bruce Richardson wrote:

[dpdk-dev] lpm performance

2016-09-21 Thread 张伟
Got it. Thanks for your guidance! ? 2016-09-20 22:41:36?"Andriy Berestovskyy" ??? >AFAIR Intel hardware should do the 10Gbit/s line rate (i.e. ~14,8 >MPPS) with one flow and LPM quite easily. Sorry, I don't have numbers >to share at hand. > >Regarding the tool please see the pktgen-dpdk

[dpdk-dev] [PATCH 1/3] crypto/aesni_gcm: move pre-counter block to GCM driver

2016-09-21 Thread Kusztal, ArkadiuszX
Hi Pablo, GCM works with two IV length modes: First case if - If (len(IV) == 12B) => J0 = iv || 0^31 || 1 => Len = 16B And according to the API comments rte_crypto_sym.h: 435 (iv.data) * - For GCM mode, this is either the IV (if the length * is 96

[dpdk-dev] [RFC] vhost: Add indirect descriptors support to the TX path

2016-09-21 Thread Yuanhan Liu
On Fri, Aug 05, 2016 at 02:18:42PM +0200, Maxime Coquelin wrote: > > > On 08/03/2016 04:03 PM, Yuanhan Liu wrote: > >On Tue, Jul 12, 2016 at 04:32:12PM +0200, Maxime Coquelin wrote: > >>Indirect descriptors are usually supported by virtio-net devices, > >>allowing to dispatch a large number of la

[dpdk-dev] [PATCH 3/5] bnxt: Add support for new HWRM version

2016-09-21 Thread Ajit Khaparde
On Wed, Sep 21, 2016 at 6:07 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Mon, Aug 15, 2016 at 06:06:53PM -0500, Ajit Khaparde wrote: > > Update HWRM specification to 1.3.0 release. > > Hardware Resource Manager or HWRM in short, is a set of API provided > > by the firmware ru

[dpdk-dev] LPM6 next hop size

2016-09-21 Thread Matthew Hall
On Tue, Sep 20, 2016 at 10:11:04PM +0200, Thomas Monjalon wrote: > Please, will you help reviewing this patch? Sure. 1. It adds a dependency on libbsd on Linux: bsd/sys/tree.h. Is this an expected dependency of DPDK already? I use it in my code but not sure it's expected for everybody else. 2.

[dpdk-dev] [RFC] net/ixgbe: start rxtx after all nic config done.

2016-09-21 Thread Ferruh Yigit
... Subject: [dpdk-dev] [RFC] net/ixgbe: start rxtx after all nic config done. if start rxtx before flow director config, will cause driver can't receive packets from nic. Signed-off-by: wang wei >>> I think you're right. We should start rx/tx after the config is don

[dpdk-dev] [PATCH v6 0/6] vhost: optimize enqueue

2016-09-21 Thread Yuanhan Liu
Hi Maxime, Do you have more comments about this set? If no, I think I could merge it shortly. Thanks. --yliu On Mon, Sep 19, 2016 at 10:00:11PM -0400, Zhihong Wang wrote: > This patch set optimizes the vhost enqueue function. > > It implements the vhost logic from scratch into a single

[dpdk-dev] [PATCH v2] drivers/net:new PMD using tun/tap host interface

2016-09-21 Thread Thomas Monjalon
2016-09-21 10:13, Yuanhan Liu: > On Wed, Sep 21, 2016 at 01:32:15AM +, Wiles, Keith wrote: > > I only assumed this to work for Linux and not FreeBSD/NetBSD as the > > handling of the opens on the tun device are different then linux. I also > > only added it to the common_linux configuration f

[dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio

2016-09-21 Thread Yuanhan Liu
On Tue, Sep 20, 2016 at 06:42:02PM +, Dey, Souvik wrote: > I have already taken care of this in v5 of the patch , If possible please > review the same . I don't think so, otherwise I would not comment here. BTW, there is a format error: you used white space instead of TAB for indention. You

[dpdk-dev] [PATCH 2/2] kasumi: rename all KASUMI references

2016-09-21 Thread Jain, Deepak K
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, September 21, 2016 2:45 AM > To: dev at dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > > Subject: [dpdk-dev] [PATCH 2/2] kasumi: rename all KASUMI references > > KASU

  1   2   >