[dpdk-dev] [PATCH v2 3/3] maintainers: claim resposibility for ARMv7 and ARMv8

2015-12-03 Thread Jianbo Liu
Signed-off-by: Jianbo Liu --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4478862..f859985 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -124,10 +124,12 @@ F: doc/guides/sample_app_ug/multi_process.rst ARM v7 M: Jan Viktorin +M: Jianbo Liu

[dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a

2015-12-03 Thread Jianbo Liu
Implement vqtbl1q_u8 intrinsic function, which is not support in armv7-a. Signed-off-by: Jianbo Liu --- config/defconfig_arm-armv7a-linuxapp-gcc | 1 - lib/librte_acl/Makefile | 2 +- lib/librte_acl/rte_acl.c | 5 - lib/librte_ea

[dpdk-dev] [PATCH v2 1/3] eal/arm: use RTE_ARM_EAL_RDTSC_USE_PMU in rte_cycle_32.h

2015-12-03 Thread Jianbo Liu
CONFIG_* from config files can not be used in code. Signed-off-by: Jianbo Liu Acked-by: Jan Viktorin --- lib/librte_eal/common/include/arch/arm/rte_cycles_32.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/arch/arm/rte_cycles_32.h b/lib/librt

[dpdk-dev] [PATCH v2 0/3] support acl lib for armv7-a and a small fix

2015-12-03 Thread Jianbo Liu
This patchset includes a small fix in rte_cycle_32.h, and support ACL for armv7-a platform. v2: - select alg as RTE_ACL_CLASSIFY_NEON only when NEON is checked in cpuflags. - remove lpm/table/pipeline patch, and part of change will be merged into Jerin's. Jianbo Liu (3): eal/arm: use RTE_ARM_E

[dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a

2015-12-03 Thread Jerin Jacob
On Thu, Dec 03, 2015 at 11:02:55PM +0800, Jianbo Liu wrote: > Implement vqtbl1q_u8 intrinsic function, which is not support in armv7-a. > > Signed-off-by: Jianbo Liu Acked-by: Jerin Jacob > --- > config/defconfig_arm-armv7a-linuxapp-gcc | 1 - > lib/librte_acl/Makefile

[dpdk-dev] [PATCH 0/3 v2] Minor abi-validator improvements

2015-12-03 Thread Thomas Monjalon
2015-09-24 06:23, Neil Horman: > On Thu, Sep 24, 2015 at 10:50:56AM +0300, Panu Matilainen wrote: > > For giggles, tried running abi-validator between 2.0 and 2.1 on > > my Fedora 22 laptop, didn't work due to various build failures. > > With this patch series the following now succeeds: > > > > E

[dpdk-dev] [PATCH] tools: exit setup script without prompt

2015-12-03 Thread Thomas Monjalon
> > Exit tools/setup.sh script without prompting "Press enter to continue". > > > > The script can now be exited by typing the option number, "quit" or "q". > > > > Signed-off-by: John McNamara > > Acked-by: Harry van Haaren Applied, thanks

[dpdk-dev] dpdk 2.1 building failure on rhel 7.2 rc1

2015-12-03 Thread Thomas Monjalon
2015-12-03 18:31, Roberts, Lee A.: > When compiling DPDK 2.1.0 on RHEL 7.2, errors are encountered in > ../librte_eal/linuxapp/kni/ethtool/igb/igb_main.c. > The following changes can be applied relative to dpdk-2.2.0-rc2 to resolve > these issues. Thanks Please check how to submit a proper patch

[dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pipeline libs

2015-12-03 Thread Jerin Jacob
On Thu, Dec 03, 2015 at 12:42:13PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Sent: Thursday, December 03, 2015 12:17 PM > > To: Ananyev, Konstantin > > Cc: Thomas Monjalon; dev at dpdk.org; viktorin at r

[dpdk-dev] [PATCH v2 0/2] more basic tests

2015-12-03 Thread Thomas Monjalon
2015-11-23 02:40, Thomas Monjalon: > I use some scripts to make some basic checks before committing or > submitting some patches. > As they can be useful for every DPDK developers and especially for > new committers / tree owners, they are added to the scripts directory. > > The problem, when shar

[dpdk-dev] dpdk 2.1 building failure on rhel 7.2 rc1

2015-12-03 Thread Roberts, Lee A.
When compiling DPDK 2.1.0 on RHEL 7.2, errors are encountered in ../librte_eal/linuxapp/kni/ethtool/igb/igb_main.c. The following changes can be applied relative to dpdk-2.2.0-rc2 to resolve these issues. - Lee Roberts [root at dp91 lroberts]# diff

[dpdk-dev] [PATCH] virtio: fix link state regression

2015-12-03 Thread Stephen Hemminger
Support for link state interrupt was broken on virtio by commit bda66c418c85 ("ethdev: add device fields from PCI layer") This is caused because the actual value of drv_flags is not set until after the resource_init has figured out whether it is using UIO or direct I/O instructions. Signed-off-b

[dpdk-dev] [PATCH v3 00/13] standard make install

2015-12-03 Thread Thomas Monjalon
2015-12-03 15:31, Bruce Richardson: > On Thu, Dec 03, 2015 at 02:45:27PM +0100, Thomas Monjalon wrote: > > Following the recent discussions, this is a proposal to have a standard > > installation process while keeping compatibility with most of the old > > behaviours. [...] > > Local install exampl

[dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pipeline libs

2015-12-03 Thread Jerin Jacob
On Thu, Dec 03, 2015 at 11:02:07AM +, Ananyev, Konstantin wrote: Hi Konstantin, > Hi Jerin, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob > > Sent: Thursday, December 03, 2015 9:34 AM > > To: Thomas Monjalon > > Cc: dev at dpdk.org >

[dpdk-dev] Bug in ring-based pmd?

2015-12-03 Thread tom.barbe...@ulg.ac.be
Hi list, I try to make two DPDK process work together through a ring-based veth. The first one fills the ring with generated packets : ./bin/click -n 4 -c 0x1 --proc-type=auto --vdev=eth_ring_0 -- conf/flow/veth-out.click The second one reads them : ./bin/click -n 4 -c 0x2 --proc-type=auto --vde

[dpdk-dev] [PATCH v5 3/4] examples: add l3fwd-thread example in performance-thread

2015-12-03 Thread Betts, Ian
-Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Thursday, December 3, 2015 4:33 PM To: Betts, Ian Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 3/4] examples: add l3fwd-thread example in performance-thread On Thu, 3 Dec 2015 09:28:24 +

[dpdk-dev] [PATCH v5 2/4] examples: add lthread subsystem for performance-thread

2015-12-03 Thread Betts, Ian
On Thu, Dec 03, 2015 at 08:31:39AM -0800, Stephen Hemminger wrote: > On Thu, 3 Dec 2015 09:28:23 + > ibetts wrote: > > > +/* > > + * Atomically set a value and return the old value */ static > > +inline uint64_t atomic64_xchg(uint64_t *ptr, uint64_t val) > > +__attribute__ ((always_inli

[dpdk-dev] [PATCH 2/2] virtio: clean up space checks on xmit

2015-12-03 Thread Stephen Hemminger
The space check for transmit ring only needs a single conditional. I.e only need to recheck for space if there was no space in first check. This can help performance and simplifies loop. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_rxtx.c | 68 +

[dpdk-dev] [PATCH 1/2] virtio: make sure rcv mbuf initialized correctly

2015-12-03 Thread Stephen Hemminger
The virtio driver was not initializing all the fields in the receive mbuf. This would cause bugs where previous usage of mbuf would leave stale TCI and offload flags. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_rxtx.c | 4 1 file changed, 4 insertions(+) diff --git a/dri

[dpdk-dev] [PATCH 0/2] virtio: bugfix and cleanup

2015-12-03 Thread Stephen Hemminger
Fix for stale offload flags, and simplify transmit checks. Stephen Hemminger (2): virtio: make sure rcv mbuf initialized correctly virtio: clean up space checks on xmit drivers/net/virtio/virtio_rxtx.c | 72 ++-- 1 file changed, 33 insertions(+), 39 deleti

[dpdk-dev] [PATCH 3/3] vmxnet3: fix vlan_offload_set

2015-12-03 Thread Stephen Hemminger
From: Nachiketa Prachanda vmxnet3_dev_vlan_offload_set(dev, mask) was incorrectly treating the mask parameter as the bitmask for vlan_strip and vlan_filter, whereas the mask indicates only what has changed - the values for vlan_stripping and vlan_filter needs to be taken from dev_conf.rxmode. Si

[dpdk-dev] [PATCH 2/3] vmxnet3: don't clear vf_table on restart

2015-12-03 Thread Stephen Hemminger
From: "Charles (Chas) Williams" From: Charles (Chas) Williams During an MTU change, the adapter is restarted. If hardware VLAN offload is in use, this existing filter table would also be cleared. Instead, setup the shadow table once during device initialization and just update during restart.

[dpdk-dev] [PATCH 1/3] vmxnet3: support mult-segment receive

2015-12-03 Thread Stephen Hemminger
From: Stephen Hemminger The vmxnet3 interface specification supports having multiple receive rings. The first ring has buffers of BTYPE_HEAD which are used for the start of the packet, the second ring has buffers of type BTYPE_BODY which are used only if the received packet exceeds the available

[dpdk-dev] [PATCH 0/3] vmxnet3: bugfix and enhancements

2015-12-03 Thread Stephen Hemminger
A couple of fixes for vlan offload, and the patch to support multi-segment frames. Charles (Chas) Williams (1): vmxnet3: don't clear vf_table on restart Stephen Hemminger (2): vmxnet3: support mult-segment receive vmxnet3: fix vlan_offload_set drivers/net/vmxnet3/vmxnet3_ethdev.c | 60 +++

[dpdk-dev] [PATCH v5 2/4] examples: add lthread subsystem for performance-thread

2015-12-03 Thread Bruce Richardson
On Thu, Dec 03, 2015 at 08:31:39AM -0800, Stephen Hemminger wrote: > On Thu, 3 Dec 2015 09:28:23 + > ibetts wrote: > > > +/* > > + * Atomically set a value and return the old value > > + */ > > +static inline uint64_t > > +atomic64_xchg(uint64_t *ptr, uint64_t val) __attribute__ ((always_inl

[dpdk-dev] [PATCH v7 0/4] examples: add performance-thread

2015-12-03 Thread Kulasek, TomaszX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ian Betts > Sent: Thursday, December 3, 2015 17:21 > To: dev at dpdk.org > Cc: Betts, Ian > Subject: [dpdk-dev] [PATCH v7 0/4] examples: add performance-thread > > This patchset comprises a layer 3 forwarding

[dpdk-dev] [PATCH] hash: remove duplicated function in rte_hash_version.map

2015-12-03 Thread Pablo de Lara
rte_hash_create function was accidentally duplicated in DPDK_2.1 in rte_hash_version.map. Fixes: 473d1beb ("hash: allow to store data in hash table") Reported-by: Ferruh Yigit Signed-off-by: Pablo de Lara --- lib/librte_hash/rte_hash_version.map | 1 - 1 file changed, 1 deletion(-) diff --git

[dpdk-dev] [PATCH 1/2] doc: announce ABI change for cmdline buffer size

2015-12-03 Thread Mcnamara, John
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Friday, November 20, 2015 4:29 PM > To: Mcnamara, John; Nelio Laranjeiro; dev at dpdk.org > Cc: thomas.monjalon at 6wind.com; Lu, Wenzhuo > Subject: Re: [PATCH 1/2] doc: announce ABI change for cmdline bu

[dpdk-dev] [PATCH v7 4/4] examples: add pthread_shim example to performance thread

2015-12-03 Thread Ian Betts
This commit adds an example that illustrates how to implement a pthread shim with the lthread subsystem included in the performance thread example application. Signed-off-by: Ian Betts --- examples/performance-thread/Makefile | 2 + examples/performance-thread/pthread_shim/Makefi

[dpdk-dev] [PATCH v7 3/4] examples: add l3fwd-thread example in performance-thread

2015-12-03 Thread Ian Betts
This commit adds an L3 forwarding application to the performace-thread example. Signed-off-by: Ian Betts --- config/defconfig_x86_64-native-linuxapp-gcc |3 + config/defconfig_x86_64-native-linuxapp-icc |3 + examples/Makefile |1 + example

[dpdk-dev] [PATCH v7 2/4] examples: add lthread subsystem for performance-thread

2015-12-03 Thread Ian Betts
This commit adds the lightweight thread subsystem used by the performance-thread sample applications. Signed-off-by: Ian Betts --- .../performance-thread/common/arch/x86/atomic.h| 59 ++ examples/performance-thread/common/arch/x86/ctx.c | 93 +++ examples/performance-thread/common/arch/x8

[dpdk-dev] [PATCH v7 1/4] doc: add sample application guide for performance-thread

2015-12-03 Thread Ian Betts
This commit adds the sample application user guide for the performance thread sample application. Signed-off-by: Ian Betts --- .../sample_app_ug/img/performance_thread_1.svg | 799 + .../sample_app_ug/img/performance_thread_2.svg | 865 ++ doc/guides/sample_app_

[dpdk-dev] [PATCH v7 0/4] examples: add performance-thread

2015-12-03 Thread Ian Betts
This patchset comprises a layer 3 forwarding derivative intended to facilitate characterization of performance with different threading models, specifically:- 1. EAL threads running on different physical cores 2. EAL threads running on the same physical core 3. Lightweight threads running in an EA

[dpdk-dev] [PATCH] add README

2015-12-03 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, December 2, 2015 4:20 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] add README > > This project is missing a proper README which is used in other projects > and some

[dpdk-dev] [PATCH v2] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Panu Matilainen
In addition to git tags, support validating abi between any legal gitrevisions(7) syntaxes, such as "validate-abi.sh -1 . " "validate-abi.sh master mybranch " etc in addition to validating between tags. Makes it easier to run the validator for in-development work. Signed-off-by: Panu Matilainen A

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Arevalo, Mario Alfredo C
Hi Thomas, In general looks good :), I'm going to test this serie and sounds good the feedback from other developers, maybe I'm going to send a version number 9 in order to get a good way together :) Thanks :) Mario. From: Thomas Monjalon [thomas.monja..

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Mcnamara, John
> -Original Message- > From: Panu Matilainen [mailto:pmatilai at redhat.com] > Sent: Thursday, December 3, 2015 1:44 PM > To: Thomas Monjalon; Mcnamara, John > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] scripts: support any legal git revisions > as abi validation range > > On

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Panu Matilainen
On 12/03/2015 03:28 PM, Thomas Monjalon wrote: > 2015-12-03 12:14, Mcnamara, John: >> Also, if someone has some bandwidth it would be good to add an option >> to pass -j with an optional number to "make" in the script. > > We can use -j without any number: > "make will not limit the number of jobs

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Panu Matilainen
On 12/03/2015 02:14 PM, Mcnamara, John wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen >> Sent: Wednesday, December 2, 2015 4:51 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] scripts: support any legal git revisions as >> ab

[dpdk-dev] [PATCH v9 11/11] doc: Add information about new installation rules

2015-12-03 Thread Mario Carrillo
Information about variables and rules behaviour is added to documentation. Suggested-by: John McNamara Signed-off-by: Mario Carrillo --- doc/build-sdk-quick.txt | 23 +- doc/guides/freebsd_gsg/build_dpdk.rst | 60 +++ doc/guides/linux_gs

[dpdk-dev] [PATCH v9 10/11] mk: Add new install rule

2015-12-03 Thread Mario Carrillo
If "T" variable is defined, the installation process will have the current behaviour, else install rule will be called. Signed-off-by: Mario Carrillo --- mk/rte.sdkinstall.mk | 12 +++- mk/rte.sdkroot.mk| 4 ++-- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/mk/rte

[dpdk-dev] [PATCH v9 09/11] mk: Rename install rule as mbuild rule

2015-12-03 Thread Mario Carrillo
"install" rule with the current dpdk behaviour change its name by mbuild. Signed-off-by: Mario Carrillo --- mk/rte.sdkinstall.mk | 8 mk/rte.sdkroot.mk| 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index a67eba6..

[dpdk-dev] [PATCH v9 08/11] app: Change name to test binary

2015-12-03 Thread Mario Carrillo
This is order to test could be installed in a file herarchy and do not make a colision with test command in coreutils. Signed-off-by: Mario Carrillo --- app/test/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/Makefile b/app/test/Makefile index ec33e1a..184f

[dpdk-dev] [PATCH v9 07/11] mk: Add rule for installing runtime files

2015-12-03 Thread Mario Carrillo
Add hierarchy-file support to the DPDK libraries, modules, binary files, nic bind file, cpu layout file (tools) and documentation, when invoking "make install-fhs" (filesystem hierarchy standard) runtime files will be by default installed in: $(DESTDIR)/$(bindir) where bindir=$(exec_prefix)/bin (bi

[dpdk-dev] [PATCH v9 06/11] mk: Add rule for installing sdk files

2015-12-03 Thread Mario Carrillo
Add hierarchy-file support to the DPDK makefiles, scripts, examples, tools, config files and headers, when invoking "make install-sdk" makefiles, scripts, examples and config files will be installed in: $(DESTDIR)/$(sdkdir) and headers will be installed in: $(DESTDIR)/$(includedir) where sdkdir=$(d

[dpdk-dev] [PATCH v9 05/11] mk: Add rule for installing documentation

2015-12-03 Thread Mario Carrillo
Add hierarchy-file support to the DPDK documentation, when invoking "make install-doc" documentation files will be installed in: $(DESTDIR)/$(docdir) where docdir=$(datarootdir)/doc/dpdk datarootdir=$(prefix)/share prefix=/usr/local by default, you can override "prefix", "datarootdir" and "docdir"

[dpdk-dev] [PATCH v9 04/11] mk: Add rule for installing modules

2015-12-03 Thread Mario Carrillo
Add hierarchy-file support to the DPDK modules, when invoking "make install-mod" modules will be installed in: $(DESTDIR)/$(kerneldir) if RTE_EXEC_ENV=linuxapp then kerneldir=/lib/modules/$(uname -r)/extra/drivers/dpdk else kerneldir=/boot/modules by default, you can override "kerneldir" var. This

[dpdk-dev] [PATCH v9 03/11] mk: Add rule for installing libraries

2015-12-03 Thread Mario Carrillo
Add hierarchy-file support to the DPDK libraries, when invoking "make install-lib" libraries will be installed in: $(DESTDIR)/$(libdir) where libdir=$(exec_prefix)/usr/lib prefix=/usr/local and exec_prefix=$(prefix) by default, you can override prefix, exec_prefix and libdir vars. This hierarchy is

[dpdk-dev] [PATCH v9 02/11] mk: Add rule for installing app files

2015-12-03 Thread Mario Carrillo
Add hierarchy-file support to the DPDK app files, nic bind file and cpu layout file when invoking "make install-bin" app files will be installed in: $(DESTDIR)/$(bindir) where bindir=$(exec_prefix)/usr/local/bin prefix=/usr/local and exec_prefix=$(prefix) by default, you can override prefix, exec_p

[dpdk-dev] [PATCH v9 01/11] mk: Add rule for installing headers

2015-12-03 Thread Mario Carrillo
Add hierarchy-file support to the DPDK headers, when invoking "make install-headers" headers will be installed in: $(DESTDIR)/$(includedir) where includedir=$(prefix)/include/dpdk and prefix=/usr/local by default, you can override "prefix" and "includedir" vars. This hierarchy is based on: http://w

[dpdk-dev] [PATCH v9 00/11] Add installation rules for dpdk files.

2015-12-03 Thread Mario Carrillo
DPDK package lacks of a mechanism to install libraries, headers applications, kernel modules and sdk files to a file system tree. This patch set allows to install files based on the next proposal: http://www.freedesktop.org/software/systemd/man/file-hierarchy.html v9: When "make install-doc" is i

[dpdk-dev] [PATCH v2 10/12] mk: install examples

2015-12-03 Thread Panu Matilainen
On 12/03/2015 03:32 PM, Thomas Monjalon wrote: > 2015-12-03 15:19, Panu Matilainen: >> On 12/03/2015 07:02 AM, Thomas Monjalon wrote: >>> The examples are part of the installed documentation. >>> >>> Signed-off-by: Thomas Monjalon >>> --- >>>mk/rte.sdkinstall.mk | 1 + >>>1 file changed, 1

[dpdk-dev] [PATCH v3 00/13] standard make install

2015-12-03 Thread Bruce Richardson
On Thu, Dec 03, 2015 at 02:45:27PM +0100, Thomas Monjalon wrote: > Following the recent discussions, this is a proposal to have a standard > installation process while keeping compatibility with most of the old > behaviours. > > v2 changes: > - fix default build dir > - RTE_TARGET subdir in $(sdkd

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Panu Matilainen
On 12/03/2015 07:01 AM, Thomas Monjalon wrote: > Following the recent discussions, this is a proposal to have a standard > installation process while keeping compatibility with most of the old > behaviours. > > v2 changes: > - fix default build dir > - RTE_TARGET subdir in $(sdkdir). > - better ker

[dpdk-dev] [PATCH 1/5] vhost: refactor rte_vhost_dequeue_burst

2015-12-03 Thread Yuanhan Liu
On Wed, Dec 02, 2015 at 11:02:44PM -0800, Stephen Hemminger wrote: > On Thu, 3 Dec 2015 14:06:09 +0800 > Yuanhan Liu wrote: > > > +#define COPY(dst, src) do { > > \ > > + cpy_len = RTE_MIN(desc_avail, mbuf_avail); \ > > + r

[dpdk-dev] [PATCH v2 10/12] mk: install examples

2015-12-03 Thread Panu Matilainen
On 12/03/2015 07:02 AM, Thomas Monjalon wrote: > The examples are part of the installed documentation. > > Signed-off-by: Thomas Monjalon > --- > mk/rte.sdkinstall.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk > index 902a933..13fa819 10

[dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pipeline libs

2015-12-03 Thread Jerin Jacob
On Wed, Dec 02, 2015 at 05:57:10PM +0100, Thomas Monjalon wrote: > 2015-12-02 22:23, Jerin Jacob: > > On Wed, Dec 02, 2015 at 05:40:13PM +0100, Thomas Monjalon wrote: > > > 2015-12-02 20:04, Jerin Jacob: > > > > On Wed, Dec 02, 2015 at 09:13:51PM +0800, Jianbo Liu wrote: > > > > > On 2 December 201

[dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Panu Matilainen
On 12/03/2015 03:22 AM, Ferruh Yigit wrote: > Fixes following error (observed when versioning macros used): >LD libdpdk.so >/usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found >for symbol @DPDK_x.y > > Also resulting combined library contains symbol version information:

[dpdk-dev] [PATCH v3 13/13] maintainers: take responsibility for build system

2015-12-03 Thread Thomas Monjalon
Signed-off-by: Thomas Monjalon --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 460245b..eb7df3e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -44,7 +44,7 @@ F: doc/ Build System -M: Olivier Matz +M: Thomas Monjal

[dpdk-dev] [PATCH v3 12/13] pkg: update RPM with standard install

2015-12-03 Thread Thomas Monjalon
The "make install" is more standard now. So the recipe can be simplified. Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- pkg/dpdk.spec | 59 --- 1 file changed, 16 insertions(+), 43 deletions(-) diff --git a/pkg/dpdk.spec b/

[dpdk-dev] [PATCH v3 11/13] app/proc_info: rename binary with prefix

2015-12-03 Thread Thomas Monjalon
In order to be installed system-wise, this application needs a prefix. So it makes clear that it is DPDK related. Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- app/proc_info/Makefile | 2 +- doc/guides/sample_app_ug/proc_info.rst | 8 mk/rte.sdktest.mk

[dpdk-dev] [PATCH v3 10/13] mk: install examples

2015-12-03 Thread Thomas Monjalon
The examples are part of the installed documentation. Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- mk/rte.sdkinstall.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index ce077a4..c611d45 100644 --- a/mk/rte.sdkinstall.mk +++ b/

[dpdk-dev] [PATCH v3 09/13] mk: install doc

2015-12-03 Thread Thomas Monjalon
The HTML API and HTML/PDF guides may be installed if generated. Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- mk/rte.sdkinstall.mk | 14 ++ 1 file changed, 14 insertions(+) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index 0667b70..ce077a4 100644 --- a/m

[dpdk-dev] [PATCH v3 08/13] mk: install binding tool in sbin directory

2015-12-03 Thread Thomas Monjalon
sbin/dpdk_nic_bind is a symbolic link to tools/dpdk_nic_bind.py where some python objects may be generated. Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- mk/rte.sdkinstall.mk | 4 1 file changed, 4 insertions(+) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index

[dpdk-dev] [PATCH v3 07/13] mk: install kernel modules

2015-12-03 Thread Thomas Monjalon
Add kernel modules to "make install". Nothing is done if there is no kernel module compiled. When using "make install T=", the default path is the same as before. The Linux path is based on host kernel version. Suggested-by: Mario Carrillo Signed-off-by: Thomas Monjalon Acked-by: Panu Matilain

[dpdk-dev] [PATCH v3 06/13] mk: split install rule

2015-12-03 Thread Thomas Monjalon
Provides new sub-rules to install runtime and sdk separately. The build directory must be changed from BUILD_DIR to O in install rules to avoid a bad recursive effect (O being BUILD_DIR being O + T). Suggested-by: Mario Carrillo Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- mk/

[dpdk-dev] [PATCH v3 05/13] mk: introduce new install syntax

2015-12-03 Thread Thomas Monjalon
The old install command was: make install T=x86_64-native-linuxapp-gcc DESTDIR=install It still works and can be replaced by these more standard commands: make config T=x86_64-native-linuxapp-gcc 0=x86_64-native-linuxapp-gcc make O=x86_64-native-linuxapp-gcc make ins

[dpdk-dev] [PATCH v3 04/13] mk: install a standard cutomizable tree

2015-12-03 Thread Thomas Monjalon
The rule "install" follows these conventions: http://gnu.org/prep/standards/html_node/Directory-Variables.html http://gnu.org/prep/standards/html_node/DESTDIR.html The variable sdkdir has been added to the more standards ones, to configure the directory used with RTE_SDK when using the DPDK makefi

[dpdk-dev] [PATCH v3 03/13] mk: move installation procedure in install rule

2015-12-03 Thread Thomas Monjalon
The real installation was called "binary install" and was done after the build when DESTDIR was specified. Remove this limitation and move the code in install rule only. Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- mk/rte.sdkbuild.mk | 16 mk/rte.sdkinstall.mk

[dpdk-dev] [PATCH v3 02/13] mk: remove multi-target install

2015-12-03 Thread Thomas Monjalon
The multi-target install create some subdirectories with the target name which is not standard for a "make install" procedure. The uninstall procedure cannot be applied properly (without removing all files in a directory). It would need to pre-compute paths. As it is a packaging issue, it is remov

[dpdk-dev] [PATCH v3 01/13] mk: remove testall

2015-12-03 Thread Thomas Monjalon
It is not possible to test every configs on an unique machine. Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- doc/guides/prog_guide/dev_kit_root_make_help.rst | 13 -- mk/rte.sdkroot.mk| 4 -- mk/rte.sdktestall.mk |

[dpdk-dev] [PATCH v3 00/13] standard make install

2015-12-03 Thread Thomas Monjalon
Following the recent discussions, this is a proposal to have a standard installation process while keeping compatibility with most of the old behaviours. v2 changes: - fix default build dir - RTE_TARGET subdir in $(sdkdir). - better kerneldir defaults - fix dpdk_nic_bind symlink - always install d

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Thomas Monjalon
2015-12-03 15:39, Panu Matilainen: > > Also, if someone has some bandwidth it would be good to add an option > > to pass -j with an optional number to "make" in the script. > > Can do, although I'm still waiting fo my previous, semi-related > validate-abi patches from September to be applied...

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Thomas Monjalon
2015-12-03 15:26, Panu Matilainen: > On 12/03/2015 07:01 AM, Thomas Monjalon wrote: > > Following the recent discussions, this is a proposal to have a standard > > installation process while keeping compatibility with most of the old > > behaviours. > > > > v2 changes: > > - fix default build dir >

[dpdk-dev] [PATCH v2 10/12] mk: install examples

2015-12-03 Thread Thomas Monjalon
2015-12-03 15:19, Panu Matilainen: > On 12/03/2015 07:02 AM, Thomas Monjalon wrote: > > The examples are part of the installed documentation. > > > > Signed-off-by: Thomas Monjalon > > --- > > mk/rte.sdkinstall.mk | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/mk/rte.sdkinstall.

[dpdk-dev] [PATCH v3] examples/vhost: fix statistics error

2015-12-03 Thread Yuanhan Liu
On Thu, Dec 03, 2015 at 07:20:26AM +0800, Jianfeng Tan wrote: > This issue was discovered under the case of software vm2vm > fowarding. When pkts are received from virtio device 0 and > tx_route to virtio device 1, tx of device 0 is not updated. > > Signed-off-by: Jianfeng Tan > Tested-by: Qian X

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Thomas Monjalon
2015-12-03 12:14, Mcnamara, John: > Also, if someone has some bandwidth it would be good to add an option > to pass -j with an optional number to "make" in the script. We can use -j without any number: "make will not limit the number of jobs that can run simultaneously". It is a not so bad default

[dpdk-dev] [PATCH v2] examples/vhost: fix statistics error

2015-12-03 Thread Yuanhan Liu
On Thu, Dec 03, 2015 at 06:01:33AM +0800, Jianfeng Tan wrote: > This issue was discovered under the case of software vm2vm > fowarding. When pkts are received from virtio device 0 and > tx_route to virtio device 1, tx of device 0 is not updated. > > To fix this problem, we check each rx/tx branch

[dpdk-dev] [PATCH 5/5] vhost: don't use unlikely for VIRTIO_NET_F_MRG_RXBUF detection

2015-12-03 Thread Yuanhan Liu
VIRTIO_NET_F_MRG_RXBUF is a default feature supported by vhost. Adding unlikely for VIRTIO_NET_F_MRG_RXBUF detection doesn't make sense to me at all. Signed-off-by: Yuanhan Liu --- lib/librte_vhost/vhost_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/

[dpdk-dev] [PATCH 4/5] vhost: do not use rte_memcpy for virtio_hdr copy

2015-12-03 Thread Yuanhan Liu
First of all, rte_memcpy() is mostly useful for coping big packets by leveraging hardware advanced instructions like AVX. But for virtio net hdr, which is 12 bytes at most, invoking rte_memcpy() will not introduce any performance boost. And, to my suprise, rte_memcpy() is huge. Since rte_memcpy()

[dpdk-dev] [PATCH 3/5] vhost: refactor virtio_dev_merge_rx

2015-12-03 Thread Yuanhan Liu
Current virtio_dev_merge_rx just looks like the old rte_vhost_dequeue_burst, twisted logic, that you can see same code block in quite many places. However, the logic virtio_dev_merge_rx is quite similar to virtio_dev_rx. The big difference is that the meregeable one could allocate more than one av

[dpdk-dev] [PATCH 2/5] vhost: refactor virtio_dev_rx

2015-12-03 Thread Yuanhan Liu
This is a simple refactor, as there isn't any twisted logic in old code. Here I just broke the code and introduced two helper functions, reserve_avail_buf() and copy_mbuf_to_desc() to make the code more readable. It saves nearly 1K bytes of code size: # without this patch $ size /path/to/

[dpdk-dev] [PATCH 1/5] vhost: refactor rte_vhost_dequeue_burst

2015-12-03 Thread Yuanhan Liu
The current rte_vhost_dequeue_burst() implementation is a bit messy and logic twisted. And you could see repeat code here and there: it invokes rte_pktmbuf_alloc() 3 at three different places! However, rte_vhost_dequeue_burst() acutally does a simple job: copy the packet data from vring desc to mb

[dpdk-dev] [PATCH 0/5 for 2.3] vhost rxtx refactor

2015-12-03 Thread Yuanhan Liu
Vhost rxtx code is derived from vhost-switch example, which is very likely the most messy code in DPDK. Unluckily, the move also brings over the bad merits: twisted logic, bad comments. When I joined this team firstly, I was quite scared off by the messy and long vhost rxtx code. While adding the

[dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Ferruh Yigit
On Thu, Dec 03, 2015 at 11:18:27AM +, Ferruh Yigit wrote: > On Thu, Dec 03, 2015 at 09:18:49AM +0100, Christian Ehrhardt wrote: > > Hi Ferruh, > > some minor bash improvements that could be made in the next revision: > > > > On Thu, Dec 3, 2015 at 2:22 AM, Ferruh Yigit > > wrote: > > > diff

[dpdk-dev] [PATCH v4] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Ferruh Yigit
Fixes following error (observed when versioning macros used): LD libdpdk.so /usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found for symbol @DPDK_x.y Also resulting combined library contains symbol version information: $ readelf -a build/lib/libdpdk.so | grep rte_eal_ | grep

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Thursday, December 3, 2015 1:44 PM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] scripts: support any legal git revisions > as abi valid

[dpdk-dev] [PATCH v2] hash: move rte_hash_set_cmp_func() to ver DPDK_2.2.

2015-12-03 Thread Yu Nemo Wenbin
Also modified the comments of rte_hash_set_cmp_func(). Signed-off-by: Yu Nemo Wenbin --- lib/librte_hash/rte_hash.h | 4 ++-- lib/librte_hash/rte_hash_version.map | 8 +++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/r

[dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pipeline libs

2015-12-03 Thread Ananyev, Konstantin
> -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Thursday, December 03, 2015 12:17 PM > To: Ananyev, Konstantin > Cc: Thomas Monjalon; dev at dpdk.org; viktorin at rehivetech.com > Subject: Re: [dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pip

[dpdk-dev] [PATCH] cxgbe: explictly mark this as pci_driver

2015-12-03 Thread Rahul Lakkireddy
On Wednesday, December 12/02/15, 2015 at 14:16:18 -0800, Stephen Hemminger wrote: > The upcoming Hyper-V driver converts the pci_drv element > in struct eth_driver to a union. When vmbus is added the > pci_drv needs to be explicit. Easier to fix the issue > ahead of time. > > This is backwards c

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Wednesday, December 2, 2015 4:51 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] scripts: support any legal git revisions as > abi validation range > > In addition to git tags, sup

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Thomas Monjalon
2015-12-03 12:02, Thomas Monjalon: > 2015-12-03 10:57, Bruce Richardson: > > On Thu, Dec 03, 2015 at 06:01:57AM +0100, Thomas Monjalon wrote: > > > Following the recent discussions, this is a proposal to have a standard > > > installation process while keeping compatibility with most of the old > >

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Thomas Monjalon
2015-12-03 10:57, Bruce Richardson: > On Thu, Dec 03, 2015 at 06:01:57AM +0100, Thomas Monjalon wrote: > > Following the recent discussions, this is a proposal to have a standard > > installation process while keeping compatibility with most of the old > > behaviours. > > > How compatible are we lo

[dpdk-dev] [PATCH v3] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Ferruh Yigit
On Thu, Dec 03, 2015 at 03:22:39AM +0100, Thomas Monjalon wrote: > 2015-12-03 02:15, Ferruh Yigit: > > +ifeq ($(COMBINED_BUILD),1) > > include $(RTE_SDK)/mk/rte.sharelib.mk > > +endif > > I still don't understand what was the issue with this include but it > seems not related to versioning. > Ple

[dpdk-dev] [PATCH] app/test: fix of returning wrong value

2015-12-03 Thread Helin Zhang
In the KNI unit test, if all test cases passed, it should return with 0. This patch fixes the issue of returning wrong value. Fixes: fc27caaafd4b ("kni: remove deprecated functions") Signed-off-by: Helin Zhang --- app/test/test_kni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Ferruh Yigit
On Thu, Dec 03, 2015 at 09:18:49AM +0100, Christian Ehrhardt wrote: > Hi Ferruh, > some minor bash improvements that could be made in the next revision: > > On Thu, Dec 3, 2015 at 2:22 AM, Ferruh Yigit > wrote: > > diff --git a/scripts/merge_maps.sh b/scripts/merge_maps.sh > > new file mode 1007

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Bruce Richardson
On Thu, Dec 03, 2015 at 12:06:41PM +0100, Thomas Monjalon wrote: > 2015-12-03 12:02, Thomas Monjalon: > > 2015-12-03 10:57, Bruce Richardson: > > > On Thu, Dec 03, 2015 at 06:01:57AM +0100, Thomas Monjalon wrote: > > > > Following the recent discussions, this is a proposal to have a standard > > >

[dpdk-dev] [PATCH v2] scripts: add git hook scripts for checkpatch and auto doc generation

2015-12-03 Thread Thomas Monjalon
Ferruh, I have a lot of questions :) 2015-11-27 14:34, Ferruh Yigit: > --- a/scripts/checkpatches.sh > +++ b/scripts/checkpatches.sh > @@ -43,6 +43,7 @@ length=${DPDK_CHECKPATCH_LINE_LENGTH:-80} > > # override default Linux options > options="--no-tree" > +options="$options ${GIT_HOOK_OPTIONS}

[dpdk-dev] [PATCH] eal: don't crash if one pci device fails

2015-12-03 Thread David Marchand
On Thu, Dec 3, 2015 at 2:38 AM, Stephen Hemminger < stephen at networkplumber.org> wrote: > If there is a failure to setup one pci device, there maybe other > devices that can be initialized. Don't call rte_exit which > is a forced crash, pass the error back to the > application to decide what it

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Bruce Richardson
On Thu, Dec 03, 2015 at 12:02:42PM +0100, Thomas Monjalon wrote: > 2015-12-03 10:57, Bruce Richardson: > > On Thu, Dec 03, 2015 at 06:01:57AM +0100, Thomas Monjalon wrote: > > > Following the recent discussions, this is a proposal to have a standard > > > installation process while keeping compatib

  1   2   >