[dpdk-dev] [PATCH] librte: Link status interrupt race condition, IGB E1000

2015-10-25 Thread Thomas Monjalon
Wenzhuo, Please could you have a look? Thanks 2015-09-24 20:44, Tim Shearer: > I encountered an issue with DPDK 2.1.0 which occasionally causes the link > status interrupt callback not to be called after the interface is started for > the first time. I traced the problem back to the function >

[dpdk-dev] [PATCH] eal: change to prevent memory leak in eal debug

2015-10-25 Thread Thomas Monjalon
2015-09-21 17:00, Zhe Tao: > Free the memory allocated by the backtrace_symbols > to prevent the memory leak > > Signed-off-by: Zhe Tao Applied, with reverted comparisons: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test + if (NULL == symb

[dpdk-dev] [PATCH v5 7/7] virtio: pick simple rx/tx func

2015-10-25 Thread Huawei Xie
Changes in v4: Check merge-able feature when select simple rx/tx functions. simple rx/tx func is chose when merge-able rx is disabled and user specifies single segment and no offload support. Signed-off-by: Huawei Xie --- drivers/net/virtio/virtio_rxtx.c | 15 +++ 1 file changed, 1

[dpdk-dev] [PATCH v5 6/7] virtio: simple tx routine

2015-10-25 Thread Huawei Xie
Changes in v5: - call __rte_pktmbuf_prefree_seg to check refcnt when free mbufs Changes in v4: - move virtio_xmit_cleanup ahead to free descriptors earlier Changes in v3: - Remove return at the end of void function - Remove always_inline attribute for virtio_xmit_cleanup bulk free of mbufs when

[dpdk-dev] [PATCH v5 5/7] virtio: virtio vec rx

2015-10-25 Thread Huawei Xie
With fixed avail ring, we don't need to get desc idx from avail ring. virtio driver only has to deal with desc ring. This patch uses vector instruction to accelerate processing desc ring. Signed-off-by: Huawei Xie --- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxt

[dpdk-dev] [PATCH v5 4/7] virtio: fill RX avail ring with blank mbufs

2015-10-25 Thread Huawei Xie
fill avail ring with blank mbufs in virtio_dev_vring_start Signed-off-by: Huawei Xie --- drivers/net/virtio/Makefile | 2 +- drivers/net/virtio/virtio_rxtx.c| 6 ++- drivers/net/virtio/virtio_rxtx.h| 3 ++ drivers/net/virtio/virtio_rxtx_simple.c | 84 ++

[dpdk-dev] [PATCH v5 3/7] virtio: rx/tx ring layout optimization

2015-10-25 Thread Huawei Xie
Changes in V4: - fix the error in tx ring layout chart in this commit message. In DPDK based switching envrioment, mostly vhost runs on a dedicated core while virtio processing in guest VMs runs on different cores. Take RX for example, with generic implementation, for each guest buffer, a) virtio

[dpdk-dev] [PATCH v5 2/7] virtio: add software rx ring, fake_buf into virtqueue

2015-10-25 Thread Huawei Xie
Changes in v3: - Remove unnecessary NULL test for rte_free - Remove unnecessary assign of local var vq after free Add software RX ring in virtqueue. Add fake_mbuf in virtqueue for wraparound processing. Use global simple_rxtx to indicate whether simple rxtx is enabled Signed-off-by: Huawei Xie -

[dpdk-dev] [PATCH v5 1/7] virtio: add virtio_rxtx.h header file

2015-10-25 Thread Huawei Xie
Would move all rx/tx related declarations into this header file in future. Add RTE_VIRTIO_PMD_MAX_BURST. Signed-off-by: Huawei Xie --- drivers/net/virtio/virtio_ethdev.c | 1 + drivers/net/virtio/virtio_rxtx.c | 1 + drivers/net/virtio/virtio_rxtx.h | 34 ++

[dpdk-dev] [PATCH v5 0/7] virtio ring layout optimization and simple rx/tx processing

2015-10-25 Thread Huawei Xie
Changes in v5: - Call __rte_pktmbuf_prefree_seg to check refcnt when free mbufs Changes in v4: - Fix the error in virtio tx ring layout ascii chart in the commit message - Move virtio_xmit_cleanup ahead to free descriptors earlier - Test merge-able feature when select simple rx/tx functions Chang

[dpdk-dev] [PATCH v6 3/5] ethdev: redesign link speed config API

2015-10-25 Thread Marc Sune
While testing this patch with some XL710, it seems even with current HEAD, setting link speed into dev_conf to 10G does not work, it always takes autoneg with all speeds. Besides, this patch in particular should be tested for the rest of drivers which I don't have HW for. Regards marc 2015-10-25

[dpdk-dev] [PATCH v6 5/5] ethdev: add rte_eth_speed_to_bm_flag() to ver. map

2015-10-25 Thread Marc Sune
Added rte_eth_speed_to_bm_flag() to DPDK2.2 version map. Signed-off-by: Marc Sune --- lib/librte_ether/rte_ether_version.map | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_ether/rte_ether_version.map b/lib/librte_ether/rte_ether_version.map index 8345a6c..cbfe0c8 100644 --

[dpdk-dev] [PATCH v6 4/5] doc: update with link changes

2015-10-25 Thread Marc Sune
Add new features, ABI changes and resolved issues notice for the refactored link patch. Signed-off-by: Marc Sune --- doc/guides/rel_notes/release_2_2.rst | 23 +++ 1 file changed, 23 insertions(+) diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/rele

[dpdk-dev] [PATCH v6 3/5] ethdev: redesign link speed config API

2015-10-25 Thread Marc Sune
This patch redesigns the API to set the link speed/s configure for an ethernet port. Specifically: - it allows to define a set of advertised speeds for auto-negociation. - it allows to disable link auto-negociation (single fixed speed). - default: auto-negociate all supported speeds. Other chan

[dpdk-dev] [PATCH v6 2/5] ethdev: Fill speed capability bitmaps in the PMDs

2015-10-25 Thread Marc Sune
Added speed capabilities to all pmds supporting physical NICs: * e1000 * ixgbe * i40 * mlx4 * fm10k Signed-off-by: Marc Sune --- drivers/net/e1000/em_ethdev.c| 6 ++ drivers/net/e1000/igb_ethdev.c | 6 ++ drivers/net/fm10k/fm10k_ethdev.c | 3 +++ drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v6 1/5] ethdev: Added ETH_SPEED_CAP bitmap for ports

2015-10-25 Thread Marc Sune
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs. Signed-off-by: Marc Sune --- lib/librte_ether/rte_ethdev.h | 24 1 file changed, 24 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index 8a8c82b..951a423

[dpdk-dev] [PATCH v6 0/5] ethdev: add speed capabilities and refactor link API

2015-10-25 Thread Marc Sune
The current rte_eth_dev_info abstraction does not provide any mechanism to get the supported speed(s) of an ethdev. For some drivers (e.g. ixgbe), an educated guess could be done based on the driver's name (driver_name in rte_eth_dev_info), see: http://dpdk.org/ml/archives/dev/2013-August/000412.

[dpdk-dev] i40e: problem with rx packet drops not accounted in statistics

2015-10-25 Thread Arnon Warshavsky
Hi Helin I would like to add my input for this as well. I encountered the same issue, and as you suggested I updated to the latest fw and changed rx and tx ring sizes to 1024. Drop counters still do not increment as they should. I Inject 10mpps into an x710 nic (a 4 ports card, 10mpps on each po

[dpdk-dev] Inconsistent statistics counters for pmd_i40e

2015-10-25 Thread Arnon Warshavsky
Hi Eimar I had to build i40e driver from latest source , unload the one that came with my machine, load the one I built and only then I managed to get the "update available" when running the nvmupdate app. Machine was up from boot without running dpdk stuff (i.e no nic unbinding and such) prior to

[dpdk-dev] [PATCH v1 0/3] lpm: increase number of next hops for lpm (ipv4)

2015-10-25 Thread Vladimir Medvedkin
Hi all, Here my implementation Signed-off-by: Vladimir Medvedkin --- config/common_bsdapp | 1 + config/common_linuxapp | 1 + lib/librte_lpm/rte_lpm.c | 194 +-- lib/librte_lpm/rte_lpm.h | 163 +++ 4 file

[dpdk-dev] [PATCH] igb_uio: use existing PCI macros

2015-10-25 Thread Thomas Monjalon
2015-09-11 08:31, Mcnamara, John: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > 2015-09-10 20:33, Ferruh Yigit: > > > Correct, those macros available after kernel version >= 2.6.34. > > > ... > > > > Why should we support kernel older than 2.6.34? > > Do we need to

[dpdk-dev] [PATCH V2] igb_uio: remove unnecessary igbuio_get_uio_pci_dev()

2015-10-25 Thread Thomas Monjalon
2015-09-10 20:09, Ferruh Yigit: > Return value of igbuio_get_uio_pci_dev() is already kept in priv > variable > > Signed-off-by: Ferruh Yigit Applied, thanks

[dpdk-dev] [PATCH] mk: Quote $(KERNELCC) to allow ccache builds

2015-10-25 Thread Thomas Monjalon
> >> Signed-off-by: Simon Kagstrom > > Acked-by: Olivier Matz Applied, thanks

[dpdk-dev] [PATCH v4 4/7] virtio: fill RX avail ring with blank mbufs

2015-10-25 Thread Xie, Huawei
On 10/23/2015 1:56 PM, Tan, Jianfeng wrote: > On 10/23/2015 1:51 PM, Jianfeng wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Huawei Xie >> Sent: Thursday, October 22, 2015 8:10 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v4 4/7] virtio:

[dpdk-dev] C++ 98/03 rte_cpuflags.h compilation broken

2015-10-25 Thread Marc Sune
During the revision of an application I maintain that is currently using DPDK v1.7.1 and about to port it to 2.1.0, I realised that 2.1.0rc4 and above (at least) are broken when compiling applications without C++11 support: In file included from /home/marc/personal/xdpd/build/src/xdpd/drivers/gnu_

[dpdk-dev] [PATCH v4] mbuf/ip_frag: move mbuf chaining to common code

2015-10-25 Thread Thomas Monjalon
> > Chaining/segmenting mbufs can be useful in many places, so make it > > global. > > > > Signed-off-by: Simon Kagstrom > > Signed-off-by: Johan Faltstrom > > Acked-by: Olivier Matz Applied, thanks