[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

On 6/4/15, 7:58 AM, "Stephen Hemminger" wrote: >On Wed, 3 Jun 2015 02:09:39 + >"Andrew Harvey (agh)" wrote: > >> I believe that their is value in this interface for software stacks not >> based on Linux being moved toward DPDK that need simple operations like >> getting the mac address. Som

[dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > Sent: Thursday, June 4, 2015 2:56 PM > To: Wiles, Keith > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at > rte_eal_init time > > On Thu, Jun 04, 2015

[dpdk-dev] [PATCH 5/5] rte_sched: allow reading without clearing

> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Wednesday, May 27, 2015 7:10 PM > To: Dumitrescu, Cristian > Cc: dev at dpdk.org; Stephen Hemminger > Subject: [PATCH 5/5] rte_sched: allow reading without clearing > > The rte_sched statistics

[dpdk-dev] [PATCH 01/11] ip_pipeline: add parsing for config files with new syntax

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Monday, June 1, 2015 2:34 PM > To: Gajdzica, MaciejX T > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 01/11] ip_pipeline: add parsing for config > files with new syntax > >

[dpdk-dev] [RFC PATCH V2 4/4] i40e: call _clear_cmd() when error occurs

_clear_cmd() was not being called in failure situations, resulting in the next command also failing. Fix several typos. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev_vf.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_

[dpdk-dev] [RFC PATCH V2 3/4] i40e: increase ASQ_DELAY_MS to 100 in i40evf_wait_cmd_done()

Increase delay to avoid i40evf_read_pfmsg() failures. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev_vf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 843ab9b..c1add33 100

[dpdk-dev] [RFC PATCH V2 2/4] i40e: release vmdq vsi's in dev_close

Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 7bf9532..55fee6b 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/ne

[dpdk-dev] [RFC PATCH V2 1/4] i40e: changes to support PCI Port Hotplug

This patch depends on the Port Hotplug Framework. It implements the eth_dev_uninit functions for rte_i40e_pmd and rte_i40evf_pmd. Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c| 79 - drivers/net/i40e/i40e_ethdev_vf.c | 45

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-04 14:40, Bruce Richardson: > On Thu, Jun 04, 2015 at 02:39:17PM +0100, Bruce Richardson wrote: > > On Wed, Jun 03, 2015 at 02:18:55PM -0500, Jay Rolette wrote: > > > Don't need the 'safe' version of list_for_each_entry() if you aren't > > > deleting from the list as you iterate over it >

[dpdk-dev] [PATCH 1/9] kni: fix whitespace

2015-06-04 07:43, Stephen Hemminger: > From: Stephen Hemminger > > Ran this code base through a script which: > - removes trailing whitespace > - removes space before tabs > - removes blank lines at end of file > > Signed-off-by: Stephen Hemminger > --- > .../linuxapp/kni/ethtool/igb/e10

[dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time

On Thu, Jun 4, 2015 at 4:27 PM, Wiles, Keith wrote: > Hi Neil and Stephen, > > I agree this is not saving instructions and adding performance, but of > code clutter and providing a layered model for the developer. The > rte_eal_init() routine still exists and I was not trying to remove that > API

[dpdk-dev] [PATCH 1/3] kni: minor opto

On Thu, Jun 04, 2015 at 05:02:06PM +0200, Thomas Monjalon wrote: > 2015-06-04 14:40, Bruce Richardson: > > On Thu, Jun 04, 2015 at 02:39:17PM +0100, Bruce Richardson wrote: > > > On Wed, Jun 03, 2015 at 02:18:55PM -0500, Jay Rolette wrote: > > > > Don't need the 'safe' version of list_for_each_entr

[dpdk-dev] Mac ageing functionality.

Hello All, Does dpdk provide any kind of ageing functionality ( To be specific, Mac ageing functionality is what I'm looking for). If yes, please provide the pointers. Thanks -Avinash

[dpdk-dev] [PATCH v2 6/6] app/testpmd: show the hash key size

As querying hash key size in byte was supported, it can be shown in testpmd after getting the device information if not zero. Signed-off-by: Helin Zhang --- app/test-pmd/config.c | 4 1 file changed, 4 insertions(+) v2 changes: * Disabled the code changes by default, to avoid breaking ABI

[dpdk-dev] [PATCH v2 5/6] ixgbe: fill the hash key size

The correct hash key size in bytes should be filled into the 'struct rte_eth_dev_info', to support querying it. Signed-off-by: Helin Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 + 1 file changed, 5 insertions(+) v2 changes: * Disabled the code changes by default, to avoid breaking ABI co

[dpdk-dev] [PATCH v2 4/6] i40e: fill the hash key size

The correct hash key size in bytes should be filled into the 'struct rte_eth_dev_info', to support querying it. Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev.c| 4 drivers/net/i40e/i40e_ethdev_vf.c | 4 2 files changed, 8 insertions(+) v2 changes: * Disabled the code

[dpdk-dev] [PATCH v2 3/6] fm10k: fill the hash key size

The correct hash key size in bytes should be filled into the 'struct rte_eth_dev_info', to support querying it. Signed-off-by: Helin Zhang --- drivers/net/fm10k/fm10k_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) v2 changes: * Disabled the code changes by default, to avoid breaking ABI comp

[dpdk-dev] [PATCH v2 2/6] e1000: fill the hash key size

The correct hash key size in bytes should be filled into the 'struct rte_eth_dev_info', to support querying it. Signed-off-by: Helin Zhang --- drivers/net/e1000/igb_ethdev.c | 5 + 1 file changed, 5 insertions(+) v2 changes: * Disabled the code changes by default, to avoid breaking ABI comp

[dpdk-dev] [PATCH v2 1/6] ethdev: add an field for querying hash key size

To support querying hash key size per port, an new field of 'hash_key_size' was added in 'struct rte_eth_dev_info' for storing hash key size in bytes. Signed-off-by: Helin Zhang --- lib/librte_ether/rte_ethdev.h | 3 +++ 1 file changed, 3 insertions(+) v2 changes: * Disabled the code changes by

[dpdk-dev] [PATCH v2 0/6] query hash key size in byte

As different hardware has different hash key sizes, querying it (in byte) per port was asked by users. Otherwise there is no convenient way to know the size of hash key which should be prepared. v2 changes: * Disabled the code changes by default, to avoid breaking ABI compatibility. Helin Zhang (

[dpdk-dev] [PATCH] vhost: enable live migration

2015-06-01 04:47, Ouyang, Changchun: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Huawei Xie > > When we migrate VM, without this feature, qemu will report error: > > "migrate: Migration disabled: vhost lacks VHOST_F_LOG_ALL feature". > > Is this enough for vhost to support migrate V

[dpdk-dev] Running testpmd over KNI

Running testpmd as proc-type=auto now results in a SEGMENTATION FAULT!!! Now trying to debug the source of the memory leak!!! Actually I want to do this - Use the testpmd app to setup TX/RX traffic on the 2 NICs that have been now configured as Kernel-NICs. Is there an easier way to accomplish th

[dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time

Hmmm, replied in HTML. >On Thu, Jun 4, 2015 at 4:27 PM, Wiles, Keith > wrote: > >Hi Neil and Stephen, > >I agree this is not saving instructions and adding performance, but of >code clutter and providing a layered model for the developer. The >rte_eal_init() routine still exists and I was not tryi

[dpdk-dev] [PATCH v3] i40evf: fix of supporting jumbo frame

It wouldn't check the configured maximum packet length, and then the scattered receiving function wouldn't be selected at all even if it wants to receive a jumbo frame. The fix is to select the correct RX function according to the configurations. Signed-off-by: Helin Zhang --- drivers/net/i40e/i

[dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time

From: David Marchand mailto:david.march...@6wind.com>> Date: Thursday, June 4, 2015 at 9:43 AM To: Keith Wiles mailto:keith.wiles at intel.com>> Cc: Neil Horman mailto:nhorman at tuxdriver.com>>, "dev at dpdk.org" mailto:dev at dpdk.org>> Subject: Re: [dpdk-dev] [RFC PAT

[dpdk-dev] [PATCH 3/3] kni: rx loop was using the wrong counter

On Wed, Jun 03, 2015 at 02:18:57PM -0500, Jay Rolette wrote: > Loop processing packets dequeued from rx_q was using the number of > packets requested, not how many it actually received. > > Variable rename to make code a little more clear > > Signed-off-by: Jay Rolette s/more clear/clearer/ Ac

[dpdk-dev] [PATCH 2/3] kni: minor opto

On Wed, Jun 03, 2015 at 02:18:56PM -0500, Jay Rolette wrote: > No reason to check out many entries are in kni->rx_q prior to > actually pulling them from the fifo. You can't dequeue more than > are there anyway. Max entries to dequeue is either the max batch > size or however much space is availabl

[dpdk-dev] [PATCH 1/3] kni: minor opto

On Thu, Jun 04, 2015 at 02:39:17PM +0100, Bruce Richardson wrote: > On Wed, Jun 03, 2015 at 02:18:55PM -0500, Jay Rolette wrote: > > Don't need the 'safe' version of list_for_each_entry() if you aren't > > deleting from the list as you iterate over it > > > > Signed-off-by: Jay Rolette > > Acke

[dpdk-dev] [PATCH 1/3] kni: minor opto

On Wed, Jun 03, 2015 at 02:18:55PM -0500, Jay Rolette wrote: > Don't need the 'safe' version of list_for_each_entry() if you aren't deleting > from the list as you iterate over it > > Signed-off-by: Jay Rolette Acked-by: Bruce Richardson

[dpdk-dev] [PATCH v2] doc: add coding standards documentation

On Thu, Jun 04, 2015 at 11:49:49AM +0200, Thomas Monjalon wrote: > 2015-06-04 10:33, Bruce Richardson: > > On Wed, Jun 03, 2015 at 07:35:32PM +0200, Thomas Monjalon wrote: > > > 2015-06-03 14:58, Bruce Richardson: > > > > Add coding standards document to guides directory. This document > > > > codi

[dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time

Hi Neil and Stephen, On 6/4/15, 8:55 AM, "Neil Horman" wrote: >On Thu, Jun 04, 2015 at 11:50:33AM +, Wiles, Keith wrote: >> Hi Stephen >> >> On 6/3/15, 7:12 PM, "Stephen Hemminger" >>wrote: >> >> >On Wed, 3 Jun 2015 13:49:53 -0500 >> >Keith Wiles wrote: >> > >> >> +/* Launch threads, ca

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Andrew Harvey (agh) > Sent: Wednesday, June 3, 2015 3:10 AM > To: Thomas Monjalon; Wang, Liang-min > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide > ethtool-alike

[dpdk-dev] Running testpmd over KNI

Running --- ./testpmd -c7 -n3 --vdev=eth_pcap0,iface=vEth0 --vdev=eth_pcap1,iface=vEth1 -- -i --nb-cores=2 --nb-ports=2 --total-num-mbufs=1024 results in a EAL: Error - exiting with code: 1 Cause: Cannot create lock on '/var/run/.rte_config'. Is another primary process running?

[dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time

On 6/4/15 9:55 AM, Neil Horman wrote: > On Thu, Jun 04, 2015 at 11:50:33AM +, Wiles, Keith wrote: >> Hi Stephen >> >> On 6/3/15, 7:12 PM, "Stephen Hemminger" >> wrote: >> >>> On Wed, 3 Jun 2015 13:49:53 -0500 >>> Keith Wiles wrote: >>> +/* Launch threads, called at application init()

[dpdk-dev] [PATCH v3] i40evf: fix of supporting jumbo frame

2015-06-04 14:54, Helin Zhang: > It wouldn't check the configured maximum packet length, and then > the scattered receiving function wouldn't be selected at all even > if it wants to receive a jumbo frame. The fix is to select the > correct RX function according to the configurations. > > Signed-o

[dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time

Hi Stephen On 6/3/15, 7:12 PM, "Stephen Hemminger" wrote: >On Wed, 3 Jun 2015 13:49:53 -0500 >Keith Wiles wrote: > >> +/* Launch threads, called at application init() and parse app args. */ >> +int >> +rte_eal_init_parse(int argc, char **argv, >> +int (*parse)(int, char **)) >> +{

[dpdk-dev] [PATCH v2] doc: add coding standards documentation

2015-06-04 10:33, Bruce Richardson: > On Wed, Jun 03, 2015 at 07:35:32PM +0200, Thomas Monjalon wrote: > > 2015-06-03 14:58, Bruce Richardson: > > > Add coding standards document to guides directory. This document > > > codifies the current DPDK C coding conventions, to make it easier for > > > con

[dpdk-dev] [PATCH 0/8] ACL: various fixes and cleanups

Hi Konstantin, 2015-06-04 00:10, Konstantin Ananyev: > This patch-set is based on: > [PATCHv2 0/3] ACL: Fix bug in acl_merge_trie() and add a new test-case for it > to the UT. > > Konstantin Ananyev (8): > ACL: fix invalid rule wildness calculation for RTE_ACL_FIELD_TYPE_BITMASK > ACL: code cl

[dpdk-dev] [PATCHv2 0/3] ACL: Fix bug in acl_merge_trie() and add a new test-case for it to the UT

2015-06-03 18:45, Konstantin Ananyev: > v2: > - reorder code a bit to avoid gcc 5.1 warnings. > > Konstantin Ananyev (3): > ACL: fix a problem in acl_merge_trie > ACL: add new test case for ranges build > ACL: remove subtree_id calculations at build stage Applied, thanks

[dpdk-dev] [PATCH 0/3] get rid of unnecessary memset's

2015-06-03 14:13, Stephen Hemminger: > While looking at code is seems lots of drivers do not know the convention > that info_get and stats_get both clear the buffer for the caller. > > Stephen Hemminger (3): > bonding: remove useless memset > ethdev: remove useless memset > null: remove unne

[dpdk-dev] rte_eal_alarm_set() is affected by discontinuous jumps in the system time

On Thu, Jun 04, 2015 at 10:29:48AM +0800, Selmon Yang wrote: > Hi, Bruce, Jay, > > I am sorry that the patch in last mail is the wrong one, > please replace it with the attached one in this mail. > Thanks for the patch. Could you perhaps submit this using git send-email as an official patch, w

[dpdk-dev] [PATCH v2 1/6] ethdev: add an field for querying hash key size

Hi Helin, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Helin Zhang > Sent: Thursday, June 04, 2015 8:34 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/6] ethdev: add an field for querying hash key > size > > To support querying hash key size

[dpdk-dev] [PATCH v2] doc: add coding standards documentation

On Wed, Jun 03, 2015 at 07:35:32PM +0200, Thomas Monjalon wrote: > 2015-06-03 14:58, Bruce Richardson: > > Add coding standards document to guides directory. This document > > codifies the current DPDK C coding conventions, to make it easier for > > contributors to see the format their code should

[dpdk-dev] rte_eal_alarm_set() is affected by discontinuous jumps in the system time

Hi, Bruce, Jay, I am sorry that the patch in last mail is the wrong one, please replace it with the attached one in this mail. 2015-06-04 10:09 GMT+08:00 Selmon Yang : > Hi, Bruce, > > Thank you very much for your positive response. > The attachment is the patch. > Please have a look. > > Hi, Jay

[dpdk-dev] mempool with custom alignment

Thanks, Konstantin. On Thu, Jun 4, 2015 at 1:45 AM, Ananyev, Konstantin < konstantin.ananyev at intel.com> wrote: > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Dax Rawal > > Sent: Wednesday, June 03, 2015 7:30 PM > > To: dev at dpdk.org > > Subject

[dpdk-dev] [PATCH 0/8] ACL: various fixes and cleanups

Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, June 04, 2015 10:27 AM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/8] ACL: various fixes and cleanups > > Hi Konstantin, > > 2015-06-04 0

[dpdk-dev] rte_eal_alarm_set() is affected by discontinuous jumps in the system time

Hi, Bruce, Thank you very much for your positive response. The attachment is the patch. Please have a look. Hi, Jay, Thank you so much for your kindly reminding. However, due to I really like the alarm functionalities not to be affected. I guess I need to replace CLOCK_MONOTONIC_RAW with CLOCK_M

[dpdk-dev] Any chance someone could fix the SPF records for this mailing list?

2015-06-03 20:09, Matthew Hall: > 2015-06-03 19:54, Alexander Duyck: > > I have noticed a number of emails from this list are going to spam. It > > looks like it might be gmail filtering based on the fact that most of > > the list has a valid SPF based on an IPv4 address that reports out like > >

[dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time

On Thu, Jun 04, 2015 at 11:50:33AM +, Wiles, Keith wrote: > Hi Stephen > > On 6/3/15, 7:12 PM, "Stephen Hemminger" wrote: > > >On Wed, 3 Jun 2015 13:49:53 -0500 > >Keith Wiles wrote: > > > >> +/* Launch threads, called at application init() and parse app args. */ > >> +int > >> +rte_eal_in

[dpdk-dev] "Re: [RFC PATCH 0/2] dynamic memzones"

On 03/06/2015 20:13, Dax Rawal wrote: > Hi Sergio, > >TODOs: > > - Implement memzone_unreserve, simply call rte_malloc_free. > > - Implement mempool_delete, simply call rte_memzone_unreserve. > > - Init heaps with all available memsegs at once. > > - Review symbols in version map. > I do not see rt

[dpdk-dev] [PATCH 1/6] ethdev: add an field for querying hash key size

On Thu, Jun 04, 2015 at 09:00:33AM +0800, Helin Zhang wrote: > To support querying hash key size per port, an new field of > 'hash_key_size' was added in 'struct rte_eth_dev_info' for storing > hash key size in bytes. > > Signed-off-by: Helin Zhang > --- > lib/librte_ether/rte_ethdev.h | 1 + >

[dpdk-dev] [PATCH 6/6] app/testpmd: show the hash key size

As querying hash key size in byte was supported, it can be shown in testpmd after getting the device information if not zero. Signed-off-by: Helin Zhang --- app/test-pmd/config.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index f788ed5..80

[dpdk-dev] [PATCH 5/6] ixgbe: fill the hash key size

The correct hash key size in bytes should be filled into the 'struct rte_eth_dev_info', to support querying it. Signed-off-by: Helin Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev

[dpdk-dev] [PATCH 4/6] i40e: fill the hash key size

The correct hash key size in bytes should be filled into the 'struct rte_eth_dev_info', to support querying it. Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev.c| 2 ++ drivers/net/i40e/i40e_ethdev_vf.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_

[dpdk-dev] [PATCH 3/6] fm10k: fill the hash key size

The correct hash key size in bytes should be filled into the 'struct rte_eth_dev_info', to support querying it. Signed-off-by: Helin Zhang --- drivers/net/fm10k/fm10k_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c

[dpdk-dev] [PATCH 2/6] e1000: fill the hash key size

The correct hash key size in bytes should be filled into the 'struct rte_eth_dev_info', to support querying it. Signed-off-by: Helin Zhang --- drivers/net/e1000/igb_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c ind

[dpdk-dev] [PATCH 1/6] ethdev: add an field for querying hash key size

To support querying hash key size per port, an new field of 'hash_key_size' was added in 'struct rte_eth_dev_info' for storing hash key size in bytes. Signed-off-by: Helin Zhang --- lib/librte_ether/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_ethdev.h b/

[dpdk-dev] [PATCH 0/6] query hash key size in byte

As different hardware has different hash key size, querying it (in byte) per port was asked by users. Otherwise there is no convenient way to know the size of hash key should be prepared. Helin Zhang (6): ethdev: add an field for querying hash key size e1000: fill the hash key size fm10k: fi

[dpdk-dev] mempool with custom alignment

> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Dax Rawal > Sent: Wednesday, June 03, 2015 7:30 PM > To: dev at dpdk.org > Subject: [dpdk-dev] mempool with custom alignment > > Hi, > I use mempool APIs to allocate DMA-able descriptor ring and buffers so tha

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

On Wed, 3 Jun 2015 02:09:39 + "Andrew Harvey (agh)" wrote: > I believe that their is value in this interface for software stacks not > based on Linux being moved toward DPDK that need simple operations like > getting the mac address. Some of these stacks have a dearth of resources > availabl

[dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time

On Thu, 4 Jun 2015 09:55:42 -0400 Neil Horman wrote: > That said, I'm not sure theres much value in adding this to the API. For one, > it implies that dpdk arguments need to come first on the command line. While > all the example applications do that, theres no requirement that they do so, > a

[dpdk-dev] [PATCH 9/9] drivers: fix whitespace

From: Stephen Hemminger Note: ignored whitespace issues in base (external code). Signed-off-by: Stephen Hemminger --- drivers/net/e1000/em_rxtx.c | 1 - drivers/net/e1000/igb_rxtx.c| 1 - drivers/net/pcap/rte_eth_pcap.c | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --gi

[dpdk-dev] [PATCH 8/9] mk, scripts: remove useless blank lines

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- mk/rte.extapp.mk | 1 - mk/rte.extlib.mk | 1 - mk/rte.extobj.mk | 1 - mk/toolchain/gcc/rte.toolchain-compat.mk | 1 - mk/toolchain/icc/rte.toolchain-compat.mk |

[dpdk-dev] [PATCH 7/9] examples: fix whitespace

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- examples/cmdline/commands.c | 1 - .../dpdk_qat/config_files/shumway/dh89xxcc_qa_dev0.conf | 2 -- .../dpdk_qat/config_files/shumway/dh89xxcc_qa_dev1.conf | 2 -- .../dpdk_qat/config_files/stargo/dh89

[dpdk-dev] [PATCH 6/9] app: fix whitespace

From: Stephen Hemminger Fix trailing whitespace, space before tab and empty lines at end of file. Signed-off-by: Stephen Hemminger --- app/cmdline_test/cmdline_test.py | 3 +-- app/cmdline_test/cmdline_test_data.py | 1 - app/test-pmd/csumonly.c | 1 - app/test-pmd/mempoo

[dpdk-dev] [PATCH 5/9] lib: fix misc whitespace

From: Stephen Hemminger More places with trailing whitespace, and empty blank lines Signed-off-by: Stephen Hemminger --- lib/librte_compat/rte_compat.h | 8 lib/librte_hash/rte_fbk_hash.c | 1 - lib/librte_lpm/rte_lpm.c| 1 - lib/librte_malloc/malloc_heap.c | 1 - 4 files ch

[dpdk-dev] [PATCH 4/9] vhost: fix trailing whitespace

From: Stephen Hemminger Signed-off-by: Stephen Hemminger --- lib/librte_vhost/libvirt/qemu-wrap.py | 13 ++--- lib/librte_vhost/vhost_rxtx.c | 2 +- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/lib/librte_vhost/libvirt/qemu-wrap.py b/lib/librte_vhost/libvirt/

[dpdk-dev] [PATCH 3/9] cmdline: fix whitespace

From: Stephen Hemminger Get rid of trailing whitespace, etc. Signed-off-by: Stephen Hemminger --- lib/librte_cmdline/cmdline_cirbuf.c | 1 - lib/librte_cmdline/cmdline_parse.c | 1 - lib/librte_cmdline/cmdline_rdline.c | 1 - 3 files changed, 3 deletions(-) diff --git a/lib/librte_cmdline/cm

[dpdk-dev] [PATCH 2/9] eal: fix whitespace

From: Stephen Hemminger Eliminate trailing whitespace, space after tabs, and extra blank lines Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/contigmem/contigmem.c| 1 - lib/librte_eal/bsdapp/eal/Makefile | 1 - lib/librte_eal/bsdapp/eal/eal.c

[dpdk-dev] [PATCH 1/9] kni: fix whitespace

From: Stephen Hemminger Ran this code base through a script which: - removes trailing whitespace - removes space before tabs - removes blank lines at end of file Signed-off-by: Stephen Hemminger --- .../linuxapp/kni/ethtool/igb/e1000_api.c | 1 - .../linuxapp/kni/ethtool/igb/e

[dpdk-dev] [PATCH 0/9] whitespace cleanups

From: Stephen Hemminger Ran the current code base through a script which: - removes trailing whitespace - removes space before tabs - removes blank lines at end of file Stephen Hemminger (9): kni: fix whitespace eal: fix whitespace cmdline: fix whitespace vhost: fix trailing white

[dpdk-dev] [PATCH 8/8] ACL: add new test-cases into UT

Add several new test cases for ACL to cover different build configurations. Signed-off-by: Konstantin Ananyev --- app/test/test_acl.c | 431 +++- 1 file changed, 423 insertions(+), 8 deletions(-) diff --git a/app/test/test_acl.c b/app/test/test_ac

[dpdk-dev] [PATCH 7/8] ACL: fix remove ambiguity between rules at UT

Some test rules had equal priorityi for the same category. That can causes an ambiguity in build trie and test results. Specify different priority value for each rule from the same category. Signed-off-by: Konstantin Ananyev --- app/test/test_acl.h | 52 ++

[dpdk-dev] [PATCH 6/8] ACL: cleanup remove unused code from acl_bld.c

Signed-off-by: Konstantin Ananyev --- lib/librte_acl/acl_bld.c | 310 --- 1 file changed, 310 deletions(-) diff --git a/lib/librte_acl/acl_bld.c b/lib/librte_acl/acl_bld.c index e144503..83669ac 100644 --- a/lib/librte_acl/acl_bld.c +++ b/lib/librte_ac

[dpdk-dev] [PATCH 5/8] ACL: introduce RTE_ACL_MASKLEN_TO_BITMASK macro

Introduce new RTE_ACL_MASKLEN_TO_BITMASK macro, that will be used in several places inside librte_acl and it's UT. Simplify iand cleanup build_trie() code a bit. Signed-off-by: Konstantin Ananyev --- lib/librte_acl/acl_bld.c | 16 +++- lib/librte_acl/rte_acl.h | 3 +++ 2 files chang

[dpdk-dev] [PATCH 4/8] ACL: fix rebuilding a trie for subset of rules

When rebuilding a trie for limited rule-set, don't try to split the rule-set even further. Signed-off-by: Konstantin Ananyev --- lib/librte_acl/acl_bld.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/lib/librte_acl/acl_bld.c b/lib/librte_acl/acl_bld.c inde

[dpdk-dev] [PATCH 3/8] ACL: add function to check rte_acl_build() input parameters

Move check for build parameters into a separate function. Simplify acl_calc_wildness() function. Signed-off-by: Konstantin Ananyev --- lib/librte_acl/acl_bld.c | 107 --- 1 file changed, 54 insertions(+), 53 deletions(-) diff --git a/lib/librte_acl/ac

[dpdk-dev] [PATCH 2/8] ACL: code cleanup - use global RTE_LEN2MASK macro

Signed-off-by: Konstantin Ananyev --- app/test-acl/main.c| 3 ++- lib/librte_acl/acl_bld.c | 3 ++- lib/librte_acl/rte_acl.c | 3 ++- lib/librte_acl/rte_acl.h | 2 +- lib/librte_acl/rte_acl_osdep.h | 2 -- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git

[dpdk-dev] [PATCH 1/8] ACL: fix invalid rule wildness calculation for RTE_ACL_FIELD_TYPE_BITMASK

Signed-off-by: Konstantin Ananyev --- lib/librte_acl/acl_bld.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_acl/acl_bld.c b/lib/librte_acl/acl_bld.c index db23b7b..e2db9bf 100644 --- a/lib/librte_acl/acl_bld.c +++ b/lib/librte_acl/acl_bld.c @@ -1362,6 +136

[dpdk-dev] [PATCH 0/8] ACL: various fixes and cleanups

This patch-set is based on: [PATCHv2 0/3] ACL: Fix bug in acl_merge_trie() and add a new test-case for it to the UT. Konstantin Ananyev (8): ACL: fix invalid rule wildness calculation for RTE_ACL_FIELD_TYPE_BITMASK ACL: code cleanup - use global RTE_LEN2MASK macro ACL: add function to check rt