[dpdk-dev] [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call

2014-12-17 Thread Thomas Monjalon
Hi Neil, 2014-12-17 12:03, Neil Horman: > Back in: > > commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db > Author: Alan Carew > Date: Fri Dec 5 15:19:07 2014 +0100 > > cmdline: fix overflow on bsd > > The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. This > patch ma

[dpdk-dev] [PATCH 3/3] mk: fix link with CC

2014-12-17 Thread Thomas Monjalon
It appeared in commit 21cdc2e77a4ca999 ("fix 32-bit link with gcc") that linker options must be prefixed by -Wl, when using CC. So CPU_LDFLAGS is prefixed in rte.lib.mk. Then commit 815cfb7925bb6de ("fix link of combined shared library using CC") introduced another prefixing of CPU_LDFLAGS in rte.s

[dpdk-dev] [PATCH 2/3] mk: forbid multiple definitions

2014-12-17 Thread Thomas Monjalon
The option "-z muldefs" was set only if not using ld directly. By the way, this option seems to be a useless hack introduced with shared and combined libraries support (e25e4d7ef16b8aa84de). The clean approach is to remove it. Signed-off-by: Thomas Monjalon --- mk/rte.lib.mk | 5 ++--- mk/r

[dpdk-dev] [PATCH 1/3] mk: fix link examples to combined library

2014-12-17 Thread Thomas Monjalon
RTE_LIBNAME was defined only if BUILDING_RTE_SDK. So external applications like examples were trying to link with -l without any library name. This bug appeared after fixing link to combined library (removing link to separate libraries). Signed-off-by: Thomas Monjalon --- mk/rte.vars.mk | 9 +++

[dpdk-dev] [PATCH 0/3] mk: fix link options

2014-12-17 Thread Thomas Monjalon
When trying to fix the use of combined library, some bugs have been raised. This patchset fix and clean some link options. Thomas Monjalon (3): mk: fix link examples to combined library mk: forbid multiple definitions mk: fix link with CC mk/rte.app.mk | 5 ++--- mk/rte.lib.mk |

[dpdk-dev] Segmentation fault in rte_eal_hugepage_attach

2014-12-17 Thread Rick LaMont
> The most likely cause of failure in mapping the memory is that the range > requested is already used by another memory mapping in the processes address > space. Two possible paths to look at this: > 1) examine the /proc//maps file for the secondary process Brilliant advice, Bruce! This was indee

[dpdk-dev] pci_register_driver of igbuio_pci_driver

2014-12-17 Thread ratheesh kannoth
I could see that .id_table is assigned NULL in igbuio_pci_driver structure. if so Then pci_probe will be called for all devices right ? If some interfaces are already controlled some other kernel mode driver, how dpdk omits them out ? -Ratheesh

[dpdk-dev] Symmetric RSS Hashing in DPDK

2014-12-17 Thread Kamraan Nasim
Hi DPDK community, Any better RSS hash keys out there? --Kam On Wed, Dec 17, 2014 at 2:12 PM, Kamraan Nasim wrote: > > Thank you Jeriel. 0x00 0x01 works and I can get bi-directional symmetry > but you are right, it compromises the packet distribution. I am seeing > vastly different 5 tuples has

[dpdk-dev] [PATCH v2] mk: link combined shared lib using CC

2014-12-17 Thread Thomas Monjalon
2014-12-17 15:01, Thomas Monjalon: > 2014-12-17 10:41, Gonzalez Monroy, Sergio: > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > 2014-12-16 19:48, Thomas Monjalon: > > > > 2014-10-28 15:48, Sergio Gonzalez Monroy: > > > > > Fix: link combined shared lib using CC if LINK_USING

[dpdk-dev] [PATCH 10/17] librte_acl: add AVX2 as new rte_acl_classify() method

2014-12-17 Thread Ananyev, Konstantin
> From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Wednesday, December 17, 2014 3:33 PM > To: Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 10/17] librte_acl: add AVX2 as new > rte_acl_classify() method > > On Tue, Dec 16, 2014 at 04:16:48PM +, Ananyev,

[dpdk-dev] [PATCH RFC v2 07/12] lib/librte_vhost: async event and callback

2014-12-17 Thread Xie, Huawei
> > I got error from checkpatch.pl like followings. > > ERROR: trailing statements should be on next line > #74: FILE: lib/librte_vhost/vhost_user/fd_man.c:61: > + for (i = 0; i < pfdset->num && pfdset->fd[i].fd != fd; i++); Thanks. This is RFC, so maybe it is far from perfection, :). > > + i

[dpdk-dev] [PATCH 2/2] doc: removed intel legal blurb from testpmd_ug

2014-12-17 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Siobhan Butler > Sent: Wednesday, December 17, 2014 4:59 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] doc: removed intel legal blurb from testpmd_ug > > Removed Intel Legal blurb from TestPMD User

[dpdk-dev] [PATCH 1/2] doc: removed intel references from testpmd_ug

2014-12-17 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Siobhan Butler > Sent: Wednesday, December 17, 2014 4:59 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] doc: removed intel references from testpmd_ug > > Removed redundant Intel references from TestP

[dpdk-dev] [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support

2014-12-17 Thread Xie, Huawei
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Sunday, December 14, 2014 10:26 PM > To: Xie, Huawei; dev at dpdk.org > Cc: haifeng.lin at intel.com > Subject: Re: [PATCH RFC v2 00/12] lib/librte_vhost: vhost-user support > > Hi Xie, > > I've got warnin

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

2014-12-17 Thread Xie, Huawei
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Tuesday, December 16, 2014 9:22 PM > To: Xie, Huawei; dev at dpdk.org > Cc: Linhaifeng (haifeng.lin at huawei.com) > Subject: Re: [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support > > (2014/12/17 12

[dpdk-dev] [PATCH] fix bug can not build example application for missing link library

2014-12-17 Thread Marvin Liu
From: Yong Liu main.o: In function `rte_pktmbuf_free': main.c:(.text+0x9c): undefined reference to `per_lcore__lcore_id' Signed-off-by: Marvin liu --- mk/rte.app.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 5fc3118..b51d814 10

[dpdk-dev] [PATCH] test: fix macro by adding in missing "do" in do-while

2014-12-17 Thread Bruce Richardson
One of the test assertion macros was missing the "do" part of the do-while. This issue was picked up by clang reporting an empty while loop body for the closing while of the do-while pair. Signed-off-by: Bruce Richardson --- app/test/test.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [PATCH 2/2] doc: removed intel legal blurb from testpmd_ug

2014-12-17 Thread Siobhan Butler
Removed Intel Legal blurb from TestPMD User Guide. Signed-off-by: Siobhan Butler --- doc/guides/testpmd_app_ug/index.rst | 46 - 1 file changed, 46 deletions(-) diff --git a/doc/guides/testpmd_app_ug/index.rst b/doc/guides/testpmd_app_ug/index.rst index d1ad

[dpdk-dev] [PATCH 1/2] doc: removed intel references from testpmd_ug

2014-12-17 Thread Siobhan Butler
Removed redundant Intel references from TestPMD User Guide. Signed-off-by: Siobhan Butler --- doc/guides/testpmd_app_ug/build_app.rst | 4 ++-- doc/guides/testpmd_app_ug/intro.rst | 18 +- doc/guides/testpmd_app_ug/run_app.rst | 4 ++-- 3 files changed, 13 insertions(+),

[dpdk-dev] [PATCH 0/2] doc: remove intel dpdk references from testpmd_ug

2014-12-17 Thread Siobhan Butler
Removed Intel DPDK references from testpmd User Guide. Removed Intel legal blurb from testpmd User Guide. Siobhan Butler (2): doc: removed intel references from testpmd_ug doc: removed intel legal blurb from testpmd_ug doc/guides/testpmd_app_ug/build_app.rst | 4 +-- doc/guides/testpmd_app_

[dpdk-dev] [PATCH v4 8/8] doc: updating the list of sample apps in rel notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Added new and existing names of sample apps to list of sample apps in release notes. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/rel_description.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/rel_description.rst b/doc/guides/

[dpdk-dev] [PATCH v4 7/8] doc: updated resolved issues with old known issues

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Removed resolved issues from known issues section. Added new resolved issues to resolved issues section. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/known_issues.rst| 225 --- doc/guides/rel_notes/resolved_issues.rst | 171 +++

[dpdk-dev] [PATCH v4 6/8] doc: removed reference to Intel DPDK in Rel Notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Removed multiple references to Intel(R) DPDK where no longer relevant. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/faq.rst| 14 +++--- doc/guides/rel_notes/known_issues.rst | 30 ++--- doc/guides/rel_notes/rel_description.rst| 3

[dpdk-dev] [PATCH v4 5/8] doc: remove appendix a from release notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Removing Appendix A from Release Notes as Intel Licensing information is no longer relevant in this document. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/appendices.rst | 324 doc/guides/rel_notes/index.rst | 44 -

[dpdk-dev] [PATCH v4 4/8] doc: moved known issue 6.29 to resolved issues in rel notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/resolved_issues.rst | 30 ++ 1 file changed, 30 insertions(+) diff --git a/doc/guides/rel_notes/resolved_issues.rst b/doc/guides/rel_notes/resolved_issues.rst index f9ddb7f..66afc25 100644

[dpdk-dev] [PATCH v4 3/8] doc: added to known issue 6.10 and removed fixed issue 6.29 from rel_notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/known_issues.rst | 36 ++- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst index d26dcfa..1cf

[dpdk-dev] [PATCH v4 2/8] doc: added new features to release notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/new_features.rst | 24 1 file changed, 24 insertions(+) diff --git a/doc/guides/rel_notes/new_features.rst b/doc/guides/rel_notes/new_features.rst index a93aa3c..00895ce 100644 --- a/doc/guide

[dpdk-dev] [PATCH v4 1/8] doc: moved 1.7 new features to supported features for 1.8 in Rel_Notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/new_features.rst | 17 - doc/guides/rel_notes/supported_features.rst | 22 ++ 2 files changed, 22 insertions(+), 17 deletions(-) diff --git a/doc/guides/rel_notes/new_features.

[dpdk-dev] [PATCH v4 0/8] doc: patch set to update release notes

2014-12-17 Thread Pablo de Lara
New Features section: - Removed 1.7 New Features - Added 1.8.0 New Features Supported Features section: - Added 1.7 features to Supported Features Known Issues: - Added devices to Known issue "Not all varients of supported NIC types have been used in testing" - Removed known issue

[dpdk-dev] [PATCH 2/2] doc: remove intel legal blurb from sample app ug

2014-12-17 Thread Siobhan Butler
Removed Legal blurb from sample applications guide. Signed-off-by: Siobhan Butler --- doc/guides/sample_app_ug/index.rst | 35 --- 1 file changed, 35 deletions(-) diff --git a/doc/guides/sample_app_ug/index.rst b/doc/guides/sample_app_ug/index.rst index c3b50e2.

[dpdk-dev] [PATCH 1/2] doc: remove intel dpdk in sample app ug

2014-12-17 Thread Siobhan Butler
Removed redundant references to Intel(R) DPDK in Sample App UG. Signed-off-by: Siobhan Butler --- doc/guides/sample_app_ug/cmd_line.rst | 10 ++-- doc/guides/sample_app_ug/exception_path.rst| 8 ++-- doc/guides/sample_app_ug/hello_world.rst | 8 ++-- doc/guides/s

[dpdk-dev] [PATCH 0/2] doc: remove intel references from sample app ug

2014-12-17 Thread Siobhan Butler
Removed Intel(R) DPDK references from sample app guide. Removed Intel legal blurb from sample app guide. Siobhan Butler (2): doc: remove intel dpdk in sample app ug doc: remove intel legal blurb from sample app ug doc/guides/sample_app_ug/cmd_line.rst | 10 ++-- doc/guides/sampl

[dpdk-dev] mbuf: how to set data to NULL?

2014-12-17 Thread Bruce Richardson
On Wed, Dec 17, 2014 at 04:44:15PM +, Kavanagh, Mark B wrote: > Hi, > > DPDK 1.8.0 removes the data pointer from the mbuf structure, such that the > start of the data in the segment buffer must be calculated (i.e. buf_addr + > data_off = 'data'). > > Given this, what is the best approach to

[dpdk-dev] [PATCH v4 8/8] doc: updating the list of sample apps in rel notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Added new and existing names of sample apps to list of sample apps in release notes. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/rel_description.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/rel_description.rst b/doc/guides/

[dpdk-dev] [PATCH v4 7/8] doc: updated resolved issues with old known issues

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Removed resolved issues from known issues section. Added new resolved issues to resolved issues section. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/known_issues.rst| 225 --- doc/guides/rel_notes/resolved_issues.rst | 171 +++

[dpdk-dev] [PATCH v4 6/8] doc: removed reference to Intel DPDK in Rel Notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Removed multiple references to Intel(R) DPDK where no longer relevant. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/faq.rst| 14 +++--- doc/guides/rel_notes/known_issues.rst | 30 ++--- doc/guides/rel_notes/rel_description.rst| 3

[dpdk-dev] [PATCH v4 5/8] doc: remove appendix a from release notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Removing Appendix A from Release Notes as Intel Licensing information is no longer relevant in this document. Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/appendices.rst | 324 doc/guides/rel_notes/index.rst | 44 -

[dpdk-dev] [PATCH v4 4/8] doc: moved known issue 6.29 to resolved issues in rel notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/resolved_issues.rst | 30 ++ 1 file changed, 30 insertions(+) diff --git a/doc/guides/rel_notes/resolved_issues.rst b/doc/guides/rel_notes/resolved_issues.rst index f9ddb7f..66afc25 100644

[dpdk-dev] [PATCH v4 3/8] doc: added to known issue 6.10 and removed fixed issue 6.29 from rel_notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/known_issues.rst | 36 ++- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst index d26dcfa..1cf

[dpdk-dev] [PATCH v4 2/8] doc: added new features to release notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/new_features.rst | 24 1 file changed, 24 insertions(+) diff --git a/doc/guides/rel_notes/new_features.rst b/doc/guides/rel_notes/new_features.rst index a93aa3c..00895ce 100644 --- a/doc/guide

[dpdk-dev] [PATCH v4 1/8] doc: moved 1.7 new features to supported features for 1.8 in Rel_Notes

2014-12-17 Thread Pablo de Lara
From: Siobhan Butler Signed-off-by: Siobhan Butler --- doc/guides/rel_notes/new_features.rst | 17 - doc/guides/rel_notes/supported_features.rst | 22 ++ 2 files changed, 22 insertions(+), 17 deletions(-) diff --git a/doc/guides/rel_notes/new_features.

[dpdk-dev] [PATCH v4 0/8] doc: patch set to update release notes

2014-12-17 Thread Pablo de Lara
New Features section: - Removed 1.7 New Features - Added 1.8.0 New Features Supported Features section: - Added 1.7 features to Supported Features Known Issues: - Added devices to Known issue "Not all varients of supported NIC types have been used in testing" - Removed known issue

[dpdk-dev] mbuf: how to set data to NULL?

2014-12-17 Thread Kavanagh, Mark B
Hi, DPDK 1.8.0 removes the data pointer from the mbuf structure, such that the start of the data in the segment buffer must be calculated (i.e. buf_addr + data_off = 'data'). Given this, what is the best approach to set the mbuf data to NULL (previously mbuf.data = NULL)? As I see it, given a

[dpdk-dev] [PATCH 10/17] librte_acl: add AVX2 as new rte_acl_classify() method

2014-12-17 Thread Neil Horman
On Wed, Dec 17, 2014 at 07:22:06PM +, Ananyev, Konstantin wrote: > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Wednesday, December 17, 2014 3:33 PM > > To: Ananyev, Konstantin > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 10/17] librte_acl: add AVX2 as new > >

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-17 Thread Thomas Monjalon
Hi Jay, Please read http://dpdk.org/dev#send for submission guidelines. A description of why you do it would be welcome in the commit log. > +static int > +cmp_physaddr(const void *a, const void *b) > +{ > +#ifndef RTE_ARCH_PPC_64 > + const struct hugepage_file *p1 = (const struct hugepage_f

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-17 Thread Bruce Richardson
On Wed, Dec 17, 2014 at 09:07:45AM -0600, Jay Rolette wrote: > > > Comments shall be C-style (/* */). > > > > Single line comments ('//') have been part of the C standard since C99. Is > DPDK following C89 or is this just a style thing? If it is a style thing, a > link to a page with the rubric wo

[dpdk-dev] [PATCH v2] mk: link combined shared lib using CC

2014-12-17 Thread Thomas Monjalon
2014-12-17 10:41, Gonzalez Monroy, Sergio: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2014-12-16 19:48, Thomas Monjalon: > > > 2014-10-28 15:48, Sergio Gonzalez Monroy: > > > > Fix: link combined shared lib using CC if LINK_USING_CC is enabled. > > > > > > > > Signed-off-by

[dpdk-dev] i40e Non-Intel QSFP

2014-12-17 Thread Philip Clapham
Hi, While working with the i40e adaptor on dpdk-1.7.1 I've run into an issue where it only supports Intel QSFPs. There is a compilation option of CONFIG_RTE_LIBRTE_I40E_ALLOW_UNSUPPORTED_SFP which would seem to indicate that this is possible, but the flag (or a derivative) isn't referenced anywher

[dpdk-dev] [PATCH 0/5] fix compilation issues seen with clang-3.5

2014-12-17 Thread Bruce Richardson
On Wed, Dec 17, 2014 at 02:08:27PM +, Bruce Richardson wrote: > On Wed, Dec 17, 2014 at 01:55:20PM +0100, Olivier Matz wrote: > > This series are compilation fixes seen with clang-3.5 on linux. > > > > Olivier Matz (5): > > test-devargs: fix misplaced braces in strncmp call > > examples/l3

[dpdk-dev] [PATCH] ixgbe_vf: Fix getting link state

2014-12-17 Thread Thomas Monjalon
2014-12-17 13:22, Balazs Nemeth: > This patch fixes checking the link state of a virtual function. If the > state has already been checked, it does not need to be checked > again. Previously, get_link_status in the ixgbe_hw struct was > used to track if the information had already been updated, but

[dpdk-dev] Building 1.7.1 or 1.8.0-rc4 on latest CentOS 6.6 fails

2014-12-17 Thread Jincheng Miao
On Tue, Dec 16, 2014 at 11:12 PM, Barak Enat wrote: > Hi > > > > When building 1.7.1 or 1.8.0-rc4 on recent CentOS 6 (6.6) I got this error: > > > > In file included from > /home/makerpm/rpmbuild/BUILD/dpdk-1.8.0/lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_osdep.h:41, > > from >

[dpdk-dev] [PATCH v2] doc: fix setup menu options in linux gsg

2014-12-17 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Wednesday, December 17, 2014 1:11 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] doc: fix setup menu options in linux gsg > > From: Reshma Pattan > > v2 changes: > fixed se

[dpdk-dev] [PATCH] app/test lib/librte_pmd_af_packet: fix check for null & fix possible memory leak

2014-12-17 Thread Thomas Monjalon
Hi Daniel, 2014-12-17 12:56, Daniel Mrzyglod: > app/test/test_sched.c: > -Fix several checking for NULL pointer > lib/librte_pmd_af_packet/rte_eth_af_packet.c: > -Not munmaped queue area > -Fix several checking for NULL pointer These several fixes should be better explained and referenced if you

[dpdk-dev] Symmetric RSS Hashing in DPDK

2014-12-17 Thread Kamraan Nasim
Thank you Jeriel. 0x00 0x01 works and I can get bi-directional symmetry but you are right, it compromises the packet distribution. I am seeing vastly different 5 tuples hashed with the same value. Will let you know if I find a better alternative. --Kam On Tue, Dec 16, 2014 at 5:17 PM, Jeriel Smit

[dpdk-dev] [PATCH 0/5] fix compilation issues seen with clang-3.5

2014-12-17 Thread Bruce Richardson
On Wed, Dec 17, 2014 at 01:55:20PM +0100, Olivier Matz wrote: > This series are compilation fixes seen with clang-3.5 on linux. > > Olivier Matz (5): > test-devargs: fix misplaced braces in strncmp call > examples/l3fwd: fix compilation with clang 3.5 > examples/netmap: fix overflow in ioctl

[dpdk-dev] two tso related questions

2014-12-17 Thread Olivier MATZ
Hi Helmut, On 12/17/2014 08:17 AM, Helmut Sim wrote: > While working on TSO based solution I faced the following two questions: > > 1. > is there a maximum pkt_len to be used with TSO?, e.g. let's say if > seg_sz > is 1400 can the entire segmented pkt be 256K (higer than 64

[dpdk-dev] [PATCH 5/5] examples/vm_power_manager: fix initialization of cmdline token

2014-12-17 Thread Olivier Matz
Fix a typo: cmdline_parse_token_string_t was used in place of cmdline_parse_num_string_t. Seen with clang-3.5. Signed-off-by: Olivier Matz --- examples/vm_power_manager/vm_power_cli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vm_power_manager/vm_power_cli.c b

[dpdk-dev] [PATCH 4/5] examples/vm_power_manager: move -lvirt in LDLIBS

2014-12-17 Thread Olivier Matz
The argument -lvirt is a linker parameter, not a CFLAG. Signed-off-by: Olivier Matz --- examples/vm_power_manager/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/vm_power_manager/Makefile b/examples/vm_power_manager/Makefile index b0a1037..113dbc4 100644

[dpdk-dev] [PATCH 3/5] examples/netmap: fix overflow in ioctl operation

2014-12-17 Thread Olivier Matz
Compiling the netmap example with clang-3.5 triggered the following warning: compat_netmap.c:783:11: error: overflow converting case value to switch condition type (3225184658 to 18446744072639768978) [-Werror,-Wswitch] case NIOCREGIF: ^ Indeed, an ioctl va

[dpdk-dev] [PATCH 2/5] examples/l3fwd: fix compilation with clang 3.5

2014-12-17 Thread Olivier Matz
Fix the following error: error: unused function 'l3fwd_simple_forward' The l3fwd_simple_forward() is maybe unused, due to compilation options (APP_LOOKUP_METHOD, ENABLE_MULTI_BUFFER_OPTIMIZE). As the combinatorial is quite big, it looks simpler to add the __attribute__((unused)) on this function

[dpdk-dev] [PATCH 1/5] test-devargs: fix misplaced braces in strncmp call

2014-12-17 Thread Olivier Matz
One occurrence call to strncmp had the closing brace in the wrong place. Changing this form: if (strncmp(X, Y, sizeof(X) != 0)) which does a comparison of length 1, to if (strncmp(X, Y, sizeof(X)) != 0) which does the correct length comparison and then compares the result to zero in

[dpdk-dev] [PATCH 0/5] fix compilation issues seen with clang-3.5

2014-12-17 Thread Olivier Matz
This series are compilation fixes seen with clang-3.5 on linux. Olivier Matz (5): test-devargs: fix misplaced braces in strncmp call examples/l3fwd: fix compilation with clang 3.5 examples/netmap: fix overflow in ioctl operation examples/vm_power_manager: move -lvirt in LDLIBS examples/v

[dpdk-dev] [PATCH] i40e: fix of compile errors

2014-12-17 Thread Helin Zhang
Compile warning which is treated as error occurs on Oracle Linux (kernel 2.6.39, gcc 4.4.7) as below. Aliasing 'struct i40e_aqc_debug_reg_read_write' should be avoided. Use the elements inside that structure directly can fix the issue. lib/librte_pmd_i40e/i40e_ethdev.c: In function 'eth_i40e_dev_i

[dpdk-dev] [PATCH] ixgbe_vf: Fix getting link state

2014-12-17 Thread Balazs Nemeth
This patch fixes checking the link state of a virtual function. If the state has already been checked, it does not need to be checked again. Previously, get_link_status in the ixgbe_hw struct was used to track if the information had already been updated, but this field was always set to false. Sig

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

2014-12-17 Thread Tetsuya Mukawa
(2014/12/17 12:31), Tetsuya Mukawa wrote: > (2014/12/17 10:06), Xie, Huawei wrote: +{ + struct virtio_net *dev = get_device(ctx); + + /* We have to stop the queue (virtio) if it is running. */ + if (dev->flags & VIRTIO_DEV_RUNNING) + notify_ops->destroy_dev

[dpdk-dev] [PATCH v2] doc: fix setup menu options in linux gsg

2014-12-17 Thread Reshma Pattan
From: Reshma Pattan v2 changes: fixed setup menu options in linux gsg to keep in synch with setup.sh Signed-off-by: Reshma Pattan --- doc/guides/linux_gsg/quick_start.rst | 62 ++ 1 files changed, 33 insertions(+), 29 deletions(-) diff --git a/doc/gu

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-17 Thread Qiu, Michael
On 12/17/2014 7:01 PM, Ananyev, Konstantin wrote: > Hi Jay, > > From: Jay Rolette [mailto:rolette at infiniteio.com] > Sent: Tuesday, December 16, 2014 7:21 PM > To: Ananyev, Konstantin > Cc: Dev > Subject: Re: [dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() > with qsort() from stand

[dpdk-dev] test-pmd - Rx errors when using 2 cores per port

2014-12-17 Thread ran levi
Hello, I'm trying the test-pmd on intel 2 * Xeon 5650 2.67GHz 12 cores server. When I send 10G on one port handled by one core - i can get line rate (no misses). But when I use ip-rss and receive the traffic by 2 queues and 2 cores (on the same socket) - I get many rx-misses. [I can see the traff

[dpdk-dev] [PATCH] app/test lib/librte_pmd_af_packet: fix check for null & fix possible memory leak

2014-12-17 Thread Daniel Mrzyglod
app/test/test_sched.c: -Fix several checking for NULL pointer lib/librte_pmd_af_packet/rte_eth_af_packet.c: -Not munmaped queue area -Fix several checking for NULL pointer Signed-off-by: Daniel Mrzyglod --- app/test/test_sched.c| 2 ++ lib/librte_pmd_af_packet/rte_eth_af

[dpdk-dev] vmxnet3 and Linux FC20 OS platform, example directory could not compiled success

2014-12-17 Thread Thomas Monjalon
2014-12-17 08:59, Zhang, XiaonanX: > Hi Pablo and Thomas, >We use latest package DPDK-1.8-rc5, and we found some compiled errors, > > Our Test Environment setup as follows: > > - OS: Fedora20 3.11.10-301.fc20.x86_64 > - GCC: gcc version 4.8.2 20131017 (Red Hat 4.8.2-1) > - CPU: Intel(R) Xeon

[dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support

2014-12-17 Thread Tetsuya Mukawa
(2014/12/17 10:06), Xie, Huawei wrote: >>> +{ >>> + struct virtio_net *dev = get_device(ctx); >>> + >>> + /* We have to stop the queue (virtio) if it is running. */ >>> + if (dev->flags & VIRTIO_DEV_RUNNING) >>> + notify_ops->destroy_device(dev); >> I have an one concern about final

[dpdk-dev] [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call

2014-12-17 Thread Neil Horman
Back in: commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db Author: Alan Carew Date: Fri Dec 5 15:19:07 2014 +0100 cmdline: fix overflow on bsd The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. This patch makes the needed correction to avoid a build break Signed-off-

[dpdk-dev] [PATCH] fix bug can not build example application for missing link library

2014-12-17 Thread Thomas Monjalon
2014-12-17 10:47, Bruce Richardson: > On Wed, Dec 17, 2014 at 05:20:44PM +0800, Marvin Liu wrote: > > From: Yong Liu > > > > main.o: In function `rte_pktmbuf_free': > > main.c:(.text+0x9c): undefined reference to `per_lcore__lcore_id' > > > > Signed-off-by: Marvin liu > > Acked-by: Bruce Richa

[dpdk-dev] [PATCH v3 3/3] bond: eth_dev parameter used before NULL check in mac_address_get/set

2014-12-17 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c index 3db473b..bb4a537 100644 --- a/lib/librte_pmd_bond/rte_eth_bo

[dpdk-dev] [PATCH v3 2/3] bond: fix pci_id_table allocation check in rte_eth_bond_create

2014-12-17 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pmd_bond/rte_eth_bond_api.c b/lib/librte_pmd_bond/rte_eth_bond_api.c index b124784..c2a99a3 100644 --- a/lib/librte_pmd_bond/rte_eth_bond_api.c

[dpdk-dev] [PATCH v3 1/3] bond: add bounds check before assigning active slave count value

2014-12-17 Thread Declan Doherty
Signed-off-by: Declan Doherty --- lib/librte_pmd_bond/rte_eth_bond_api.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_pmd_bond/rte_eth_bond_api.c b/lib/librte_pmd_bond/rte_eth_bond_api.c index ef5ddf4..b124784 100644 --- a/lib/librte_pmd_bond/rte_eth_bond_api.c +++ b/lib/l

[dpdk-dev] [PATCH v3 0/3] bond: static analysis issues fix

2014-12-17 Thread Declan Doherty
-v3: Split patches -v2: Incorporates Pawel's comments regarding assertion's check on activate_slave array indexing Fixes for link bonding library identified by static analysis tool - Overflow assert for active_slaves array in activate_slave function - Allocation check of pci_id_table in rte_et

[dpdk-dev] [PATCH] mk: fix link to combined library

2014-12-17 Thread Thomas Monjalon
2014-12-17 10:38, Bruce Richardson: > On Wed, Dec 17, 2014 at 12:45:32AM +0100, Thomas Monjalon wrote: > > 2014-12-11 02:54, Hiroshi Shimamoto: > > > From: Hiroshi Shimamoto > > > > > > The application should be linked to the single combined library in the > > > condition that both of CONFIG_RTE_

[dpdk-dev] igb claiming device.

2014-12-17 Thread ratheesh kannoth
I used unbind option...not remove. Still i face this problem On Wed, Dec 17, 2014 at 11:02 AM, ratheesh kannoth wrote: > Hi list, > > I have enic driver compiled as part of kernel. when the system comes > up, it detects all the 4 vnics in mysystem ( say eth0, eth1, eth2, > eth3). I am removing e

[dpdk-dev] [PATCH] kni: fix build on RHEL6.5

2014-12-17 Thread Jincheng Miao
On 12/16/2014 11:21 PM, Thomas Monjalon wrote: > 2014-12-11 13:27, Jincheng Miao: >> RHEL6.5 kernel is based on 2.6.32. But there are two changing >> from 2.6.35: >> 1. socket struct is changed >> It wrappered previous wait_queue_head_t of socket to >> struct socket_wq. So for the kernel older than

[dpdk-dev] Building 1.7.1 or 1.8.0-rc4 on latest CentOS 6.6 fails

2014-12-17 Thread Thomas Monjalon
2014-12-17 14:21, Jincheng Miao: > On Tue, Dec 16, 2014 at 11:12 PM, Barak Enat wrote: > > It seems the assumption that skb_set_hash is missing in CentOS prior to > > version 7 is not valid anymore. > > Yes, you are right, this function skb_set_hash is added from Cent 6.6, > so some macro should

[dpdk-dev] [PATCH] mk: fix link to combined library

2014-12-17 Thread Hiroshi Shimamoto
> Subject: Re: [dpdk-dev] [PATCH] mk: fix link to combined library > > On Wed, Dec 17, 2014 at 11:43:51AM +0100, Thomas Monjalon wrote: > > 2014-12-17 10:38, Bruce Richardson: > > > On Wed, Dec 17, 2014 at 12:45:32AM +0100, Thomas Monjalon wrote: > > > > 2014-12-11 02:54, Hiroshi Shimamoto: > > >

[dpdk-dev] [PATCH] examples/vhost: Fix vlan offload issue

2014-12-17 Thread Thomas Monjalon
2014-12-17 00:51, Ouyang, Changchun: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2014-12-12 12:15, Ouyang Changchun: > > > The following commit break vm2vm hard mode test cases: > > > commit db4014f2b65cb31bf209cadd5bcec778ca137fe2 > > > Author: Huawei Xie > > > Date: Thu N

[dpdk-dev] igb claiming device.

2014-12-17 Thread ratheesh kannoth
Hi list, I have enic driver compiled as part of kernel. when the system comes up, it detects all the 4 vnics in mysystem ( say eth0, eth1, eth2, eth3). I am removing eth1, eth2 and eth3 thru sysfs remove entry ( https://www.kernel.org/doc/Documentation/filesystems/sysfs-pci.txt ). 1.After that i

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-17 Thread Ananyev, Konstantin
Hi Jay, From: Jay Rolette [mailto:role...@infiniteio.com] Sent: Tuesday, December 16, 2014 7:21 PM To: Ananyev, Konstantin Cc: Dev Subject: Re: [dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library Actually, I just relooked at the email I sent and it lo

[dpdk-dev] [PATCH] fix bug can not build example application for missing link library

2014-12-17 Thread Bruce Richardson
On Wed, Dec 17, 2014 at 05:20:44PM +0800, Marvin Liu wrote: > From: Yong Liu > > main.o: In function `rte_pktmbuf_free': > main.c:(.text+0x9c): undefined reference to `per_lcore__lcore_id' > > Signed-off-by: Marvin liu Acked-by: Bruce Richardson > --- > mk/rte.app.mk | 6 +++--- > 1 file ch

[dpdk-dev] DPDK RSS support for ixgbevf PMD

2014-12-17 Thread Vlad Zolotarov
On 12/17/14 03:03, Ouyang, Changchun wrote: > Hi , > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Tuesday, December 16, 2014 11:36 PM >> To: Thomas Monjalon >> Cc: dev at dpdk.org; Avi Kivity; Gleb Natapov >> Subject: Re: [dpdk-de

[dpdk-dev] [PATCH] mk: fix link to combined library

2014-12-17 Thread Bruce Richardson
On Wed, Dec 17, 2014 at 11:43:51AM +0100, Thomas Monjalon wrote: > 2014-12-17 10:38, Bruce Richardson: > > On Wed, Dec 17, 2014 at 12:45:32AM +0100, Thomas Monjalon wrote: > > > 2014-12-11 02:54, Hiroshi Shimamoto: > > > > From: Hiroshi Shimamoto > > > > > > > > The application should be linked t

[dpdk-dev] [PATCH] mk: fix link to combined library

2014-12-17 Thread Bruce Richardson
On Wed, Dec 17, 2014 at 10:38:16AM +, Bruce Richardson wrote: > On Wed, Dec 17, 2014 at 12:45:32AM +0100, Thomas Monjalon wrote: > > 2014-12-11 02:54, Hiroshi Shimamoto: > > > From: Hiroshi Shimamoto > > > > > > The application should be linked to the single combined library in the > > > cond

[dpdk-dev] [PATCH v2] mk: link combined shared lib using CC

2014-12-17 Thread Gonzalez Monroy, Sergio
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, December 16, 2014 11:43 PM > > 2014-12-16 19:48, Thomas Monjalon: > > 2014-10-28 15:48, Sergio Gonzalez Monroy: > > > If we set EXTRA_CFLAGS=-O0, build fails with following error: > > > > > > /usr/bin/ld: test: hidden s

[dpdk-dev] [PATCH] mk: fix link to combined library

2014-12-17 Thread Bruce Richardson
On Wed, Dec 17, 2014 at 12:45:32AM +0100, Thomas Monjalon wrote: > 2014-12-11 02:54, Hiroshi Shimamoto: > > From: Hiroshi Shimamoto > > > > The application should be linked to the single combined library in the > > condition that both of CONFIG_RTE_BUILD_COMBINE_LIB and > > CONFIG_RTE_BUILD_SHARE

[dpdk-dev] [PATCH 10/17] librte_acl: add AVX2 as new rte_acl_classify() method

2014-12-17 Thread Neil Horman
On Tue, Dec 16, 2014 at 04:16:48PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Monday, December 15, 2014 8:21 PM > > To: Ananyev, Konstantin > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 10/17]

[dpdk-dev] [PATCH] doc: remove intel legal info from freebsd-gsg

2014-12-17 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Siobhan Butler > Sent: Tuesday, December 16, 2014 10:57 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: remove intel legal info from freebsd-gsg > > Removed redundant legal blurb from FreeBSD GSG >

[dpdk-dev] [PATCH v2] doc: remove redundant intel references-freebsd gsg

2014-12-17 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Siobhan Butler > Sent: Tuesday, December 16, 2014 10:50 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] doc: remove redundant intel references-freebsd > gsg > > Updated the FreeBSD GSG to remove redun

[dpdk-dev] [PATCH v4] doc: add known issue for iommu and igb_uio

2014-12-17 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergio Gonzalez Monroy > Sent: Monday, December 15, 2014 10:33 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v4] doc: add known issue for iommu and igb_uio > > Known issue regarding iommu/VT-d and igb_ui

[dpdk-dev] [PATCH] doc: Add IBM Power description to linux guides

2014-12-17 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Chao Zhu > Sent: Saturday, December 13, 2014 3:06 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: Add IBM Power description to linux guides > > This patch added IBM ppc_64 descriptions, including arc

[dpdk-dev] Segmentation fault in rte_eal_hugepage_attach

2014-12-17 Thread Bruce Richardson
On Tue, Dec 16, 2014 at 11:12:36PM -0500, Rick LaMont wrote: > My DPDK application works fine when it's the primary process but crashes > whenever --proc-type=secondary. The segmentation fault occurs in this call > to mmap() within rte_eal_hugepage_attach(): > > /* > * fdzero is m

[dpdk-dev] two tso related questions

2014-12-17 Thread Helmut Sim
thanks. i will check this On Tue, Dec 16, 2014 at 4:04 PM, Alex Markuze wrote: > > > > On Tue, Dec 16, 2014 at 2:24 PM, Helmut Sim wrote: >> >> Thanks Alex, >> >> So i probably miss something... >> what you are saying is correct for IP segmentation where the segmentation >> is at the IP level, a

[dpdk-dev] [PATCH] replaced O(n^2) sort in sort_by_physaddr() with qsort() from standard library

2014-12-17 Thread Jay Rolette
Hi Thomas, Please read http://dpdk.org/dev#send for submission guidelines. > I did when I was figuring out how to submit the patch, but possible I'm missing something on the tools to get it to include the commit comment correctly. A description of why you do it would be welcome in the commit log

[dpdk-dev] vmxnet3 and Linux FC20 OS platform, example directory could not compiled success

2014-12-17 Thread Zhang, XiaonanX
Hi Pablo and Thomas, We use latest package DPDK-1.8-rc5, and we found some compiled errors, Our Test Environment setup as follows: - OS: Fedora20 3.11.10-301.fc20.x86_64 - GCC: gcc version 4.8.2 20131017 (Red Hat 4.8.2-1) - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz - NIC: Intel Corporati

  1   2   >