[dpdk-dev] [PATCH v2] Fix librte_pmd_pcap driver double stop error

2014-10-04 Thread Nicolás Pernas Maradei
From: Nicola?s Pernas Maradei librte_pmd_pcap driver was opening the pcap/interfaces only at init time and closing them only when the port was being stopped. This behaviour would cause problems (leading to segfault) if the user closed the port 2 times. The first time the pcap/interfaces would be

[dpdk-dev] [PATCH 1/2] Move the error check inside __mempool_check_cookies()

2014-10-04 Thread Wiles, Roger Keith
Self Nack this one and will resend the patch as a single patch. :-( On Oct 4, 2014, at 6:10 PM, Keith Wiles wrote: > Three places check for the return value from __mempool_get_bulk to be zero > and then call the debug routine __mempool_check_cookies(). The test is > not required if moved into th

[dpdk-dev] [PATCH] testpmd: print message if starting/stopping queue is not supported

2014-10-04 Thread Nicolás Pernas Maradei
Print an error message to the user when trying to start/stop a rx/tx queue and this function is not supported by the PMD driver. The patch does not check if the return value is -EINVAL because testpmd is already validating the port and queue id. Signed-off-by: Nicola?s Pernas Maradei --- app/tes

[dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error

2014-10-04 Thread Nicolás Pernas Maradei
Hi, You are correct, the parameters received in the driver are allocated in devargs_list (char *params variable). However, they already get strdup'd in rte_kvargs_parse(). This newly allocated string is part of kvlist and never freed up. The params variable is never used again so it can be fre

[dpdk-dev] [PATCH 1/1] Adding the routines rte_pktmbuf_alloc_bulk() and rte_pktmbuf_free_bulk()

2014-10-04 Thread Keith Wiles
Minor helper routines to mirror the mempool routines and remove the code from applications. The ixgbe_rxtx_vec.c routine could be changed to use the ret_pktmbuf_alloc_bulk() routine inplace of rte_mempool_get_bulk(). Signed-off-by: Keith Wiles --- lib/librte_mbuf/rte_mbuf.h | 77

[dpdk-dev] [PATCH 2/2] Adding the routines rte_pktmbuf_alloc_bulk() and rte_pktmbuf_free_bulk()

2014-10-04 Thread Keith Wiles
Minor helper routines to mirror the mempool routines and remove the code from applications. The ixgbe_rxtx_vec.c routine could be changed to use the ret_pktmbuf_alloc_bulk() routine inplace of rte_mempool_get_bulk(). Signed-off-by: Keith Wiles --- lib/librte_mbuf/rte_mbuf.h | 77

[dpdk-dev] [PATCH 1/2] Move the error check inside __mempool_check_cookies()

2014-10-04 Thread Keith Wiles
Three places check for the return value from __mempool_get_bulk to be zero and then call the debug routine __mempool_check_cookies(). The test is not required if moved into the debug routine. Minor cleanup and mostly does not effect performance, unless the is not removed by the compiler in the case