[dpdk-dev] [PATCH 3/3] testpmd: Add commands to test the functionality of setting TX rate for queue or VF

2014-05-22 Thread Ouyang Changchun
This patch adds commands in testpmd to test the functionality of setting TX rate for queue or VF. Signed-off-by: Ouyang Changchun --- app/test-pmd/cmdline.c | 153 + app/test-pmd/config.c | 44 ++ app/test-pmd/testpmd.h | 2 + 3 fi

[dpdk-dev] [PATCH 2/3] ixgbe: Implement the functionality of setting TX rate for queue or VF in IXGBE PMD

2014-05-22 Thread Ouyang Changchun
This patch implements the functionality of setting TX rate for queue or VF in IXGBE PMD. Signed-off-by: Ouyang Changchun --- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 110 lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 10 +++- 2 files changed, 119 insertions(+), 1 dele

[dpdk-dev] [PATCH 1/3] ether: Add API to support setting TX rate for queue and VF

2014-05-22 Thread Ouyang Changchun
This patch adds API to support setting TX rate for a queue and a VF. Signed-off-by: Ouyang Changchun --- lib/librte_ether/rte_ethdev.c | 63 +++ lib/librte_ether/rte_ethdev.h | 51 +++ 2 files changed, 114 insertions(+) dif

[dpdk-dev] [PATCH 0/3] Support setting TX rate for queue and VF

2014-05-22 Thread Ouyang Changchun
This patch series contains the 3 items: 1. Add API to support setting TX rate for a queue or a VF. 2. Implement the functionality of setting TX rate for queue or VF in IXGBE PMD. 3. Add commands in testpmd to test the functionality of setting TX rate for queue or VF. Ouyang Changchun (3): Add A

[dpdk-dev] [PATCH 4/4] acl: New sample l3fwd-acl.

2014-05-22 Thread Konstantin Ananyev
Demonstrates the use of the ACL library in the DPDK application to implement packet classification and L3 forwarding. Signed-off-by: Konstantin Ananyev --- examples/Makefile |1 + examples/l3fwd-acl/Makefile | 56 ++ examples/l3fwd-acl/main.c | 2048

[dpdk-dev] [PATCH 3/4] acl: New test-acl application.

2014-05-22 Thread Konstantin Ananyev
Introduce test-acl: Usage example and main test application for the ACL library. Provides IPv4/IPv6 5-tuple classification. Signed-off-by: Konstantin Ananyev --- app/Makefile |1 + app/test-acl/Makefile | 45 +++ app/test-acl/main.c | 1029 +++

[dpdk-dev] [PATCH 2/4] acl: update UT to reflect latest changes in the librte_acl.

2014-05-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- app/test/test_acl.c | 128 ++- 1 files changed, 85 insertions(+), 43 deletions(-) diff --git a/app/test/test_acl.c b/app/test/test_acl.c index 790cdf3..c171eac 100644 --- a/app/test/test_acl.c +++ b/app/test/t

[dpdk-dev] [PATCH 1/4] acl: Add ACL library (librte_acl) into DPDK.

2014-05-22 Thread Konstantin Ananyev
The ACL library is used to perform an N-tuple search over a set of rules with multiple categories and find the best match for each category. Signed-off-by: Konstantin Ananyev --- config/common_linuxapp |6 + lib/librte_acl/Makefile | 60 + lib/librte_acl/acl.h

[dpdk-dev] [PATCH 0/4] ACL library

2014-05-22 Thread Konstantin Ananyev
The ACL library is used to perform an N-tuple search over a set of rules with multiple categories and find the best match (highest priority) for each category. This code was previously released under a proprietary license, but is now being released under a BSD license to allow its integration w

[dpdk-dev] [PATCH] ethdev: add RX errors counter for missed, badcrc and badlen packets

2014-05-22 Thread David Marchand
From: Ivan Boule Split input error stats to have a better understanding of why packets have been dropped. Keep ierrors field untouched for backward compatibility. Signed-off-by: Ivan Boule Signed-off-by: David Marchand --- app/test-pmd/config.c | 24 +--- a

[dpdk-dev] DPDK Latency Issue

2014-05-22 Thread Jun Han
Hi all, I measured a roundtrip latency (using Spirent traffic generator) of sending 64B packets over a 10GbE to DPDK, and DPDK does nothing but simply forward back to the incoming port (l3fwd without any lookup code, i.e., dstport = port_id). However, to my surprise, the average latency was aroun

[dpdk-dev] [PATCH 2/2] l3fwd: reorganise and optimize l3fwd LPM code path.

2014-05-22 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- examples/l3fwd/main.c | 467 ++--- 1 files changed, 445 insertions(+), 22 deletions(-) diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 8ee1af9..29f115a 100755 --- a/examples/l3fwd/main.c +++ b/exa

[dpdk-dev] [PATCH 1/2] lpm: Introduce rte_lpm_lookupx4

2014-05-22 Thread Konstantin Ananyev
Introduce rte_lpm_lookupx4(): - Allows to lookup four IP addresses in an LPM table. - Uses SSE instrincts. Signed-off-by: Konstantin Ananyev --- app/test/test_lpm.c | 70 ++ lib/librte_eal/common/Makefile |1 + lib/librte_eal/commo

[dpdk-dev] [PATCH 0/2] L3FWD sample optimisation

2014-05-22 Thread Konstantin Ananyev
With latest HW and optimised RX/TX path there is a huge gap between tespmd iofwd and l3fwd performance results. So there is an attempt to optimise l3fwd LPM code path and reduce the gap: - Instead of processing each input packet up to completion - divide packet processing into several stage

[dpdk-dev] rte_pktmbuf_alloc fails

2014-05-22 Thread Thomas Monjalon
2014-04-17 17:00, Thomas Monjalon: > Hi Konstantin, > > 2014-04-07 08:53, Ananyev, Konstantin: > > Yep indeed, there is a bug in eth_pcap_tx() that can cause mbuf > > corruption. > > I think it should be something like that instead: > > > > --- a/lib/librte_pmd_pcap/rte_eth_pcap.c > > +++ b/lib/l

[dpdk-dev] [PATCH] Use proper mac type for 82576 VF

2014-05-22 Thread Thomas Monjalon
2014-05-22 15:39, Ananyev, Konstantin: > Hi Thomas, > I believe I already resent it with signed-off-by. Oh yes, you're right. Sorry for the noise. > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, May 22, 2014 4:33 PM > To: Ananyev, Kons

[dpdk-dev] [PATCH] fix for jumbo frame issue with DPDK VF

2014-05-22 Thread Thomas Monjalon
Hi Konstantin, 2014-05-06 11:48, Konstantin Ananyev: > When latest Linux ixgbe PF is used, and DPDK VF is used in DPDK application, > jumbo frames are not received. > Also - if Linux ixgbe PF has MTU set to 1500 (default), > then normal sized packets can be received by DPDK VF. > However, if Linux

[dpdk-dev] [PATCH] Use proper mac type for 82576 VF

2014-05-22 Thread Thomas Monjalon
Hi Konstantin, 2014-05-06 12:28, Konstantin Ananyev: > e1000_vfadapt type corresponds to 82576 VF devices, > check e1000_set_mac_type() for more details. You forgot "Signed-off-by:" line. Please resend. -- Thomas

[dpdk-dev] [PATCH 0/3] Support administrative link up and link down

2014-05-22 Thread Ivan Boule
Hi Changchun, On 05/22/2014 04:44 PM, Ouyang, Changchun wrote: > Hi Ivan > For this one, it seems long story for that... > In short, > Some customer have such kind of requirement, > they want to repeatedly start(rte_dev_start) and stop(rte_dev_stop) the port > for RX and TX, but they find > after

[dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessary definition and fix wrong referring in user space vhost zero copy patches

2014-05-22 Thread Thomas Monjalon
Hi Changchun, Please, it is preferred to answer below the question. 2014-05-20 01:14, Ouyang, Changchun: > So "[PMD] [VHOST]" in the title should be removed in the cover letter, > right? And in each separate patch letter, it could use "ixgbe:" or > "examples/vhost:", instead of "[PMD] [VHOST]" I

[dpdk-dev] [PATCH][Dom0 driver]Change the way of reserving memory in Dom0 driver

2014-05-22 Thread Thomas Monjalon
Hi Jijiang, Some cosmetic comments: Referring to previous patch about Xen Dom0, prefix "xen:" should be used in commit title. So it should be something like that: xen: reserve memory at init Maybe it could need to be splitted in 2 patches. So the other one would be: xen: reduce n

[dpdk-dev] DPDK Latency Issue

2014-05-22 Thread Shaw, Jeffrey B
Hello, > I measured a roundtrip latency (using Spirent traffic generator) of sending > 64B packets over a 10GbE to DPDK, and DPDK does nothing but simply forward > back to the incoming port (l3fwd without any lookup code, i.e., dstport = > port_id). > However, to my surprise, the average latenc

[dpdk-dev] [PATCH v2 00/17] add TSO support

2014-05-22 Thread Thomas Monjalon
There were many comments on the first version of this serie, and there is no comment on this second version. So I understand everyone is OK with it and it can be applied in the git tree. I'll wait 1 day more. Feel free to comment or acknowledge. -- Thomas

[dpdk-dev] [PATCH v2] kni: bug fix for compile issue in KNI on Fedora 18 with kernel 3.6.10

2014-05-22 Thread Thomas Monjalon
2014-05-22 11:35, Helin Zhang: > Error of "implicit-function-declaration" can be seen when building KNI > kernel module on Linux kernel 3.6.10 platform, as follows. > "x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: > In function \u2018igb_get_eee\u2019: > x86_64-native-

[dpdk-dev] compilation error with 1.6.0r2

2014-05-22 Thread Thomas Monjalon
Hi Prashant, 2014-05-15 20:14, Prashant Upadhyaya: > Hi, > > I recently picked the 1.6.0r2 from dpdk.org and tried to compile it the > usual way and ran into the following compilation error. > > I am aware I can sidestep these by getting the compiler to treat them as > warnings, but these did no

[dpdk-dev] [PATCH 0/3] RTE scheduler fixes

2014-05-22 Thread Thomas Monjalon
2014-05-14 09:25, Stephen Hemminger: > These patches address a number of issues found during development > and testing of QoS in Vyatta 5600 router. Acked-by: Thomas Monjalon Applied for version 1.7.0. Thanks -- Thomas

[dpdk-dev] [PATCH v2 00/17] add TSO support

2014-05-22 Thread Venkatesan, Venky
Thomas, It's because we haven't gotten to testing the patch yet, and figuring out all the problems. Putting it in and modifying MBUF needs a bit of time - one other option that I've looked at is to let the transmit offload parts (except for the VLAN) flow onto the second cache line. That doesn

[dpdk-dev] rte_pktmbuf_alloc fails

2014-05-22 Thread Ananyev, Konstantin
Hi Thomas, I planned to, but very unlikely that it would happen that week. Thanks Konstantin -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Thursday, May 22, 2014 4:47 PM To: Ananyev, Konstantin Cc: dev at dpdk.org Subject: Re: [dpdk-dev] rte_pktmbuf_all

[dpdk-dev] [PATCH 4/5] igb_uio: fix IRQ mode handling

2014-05-22 Thread Thomas Monjalon
Hi Stephen, 2014-05-14 09:34, Stephen Hemminger: > The igb_uio driver does not handle interrupt mode correctly. > It doesn't do the right thing and start with the most desired > mode and fall back to legacy modes as needed. I'm not sure to understand what you describe. > It also has a custom pci

[dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessary definition and fix wrong referring in user space vhost zero copy patches

2014-05-22 Thread Ouyang, Changchun
Hi, Thomas Thanks very much for your guiding! Best regards, Changchun -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Thursday, May 22, 2014 11:29 PM To: Ouyang, Changchun Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] [PMD] [VHOST] Revert unnecessar

[dpdk-dev] [PATCH] Use proper mac type for 82576 VF

2014-05-22 Thread Ananyev, Konstantin
Hi Thomas, I believe I already resent it with signed-off-by. Thanks Konstantin -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Thursday, May 22, 2014 4:33 PM To: Ananyev, Konstantin Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] Use proper mac type f

[dpdk-dev] [PATCH v2 13/16] Removed PCI ID table from igb_uio

2014-05-22 Thread Thomas Monjalon
2014-05-22 13:24, Burakov, Anatoly: > Hi Thomas, > > > I wonder if we could replace igb_uio by uio_pci_generic? > > Can it do DMA or IOMMU support? Not even VFIO does everything we need, you > may have noticed that I have to go to PCI config space to enable bus > mastering. I don't think that dri

[dpdk-dev] [PATCH v2 16/16] Adding support for VFIO to setup.sh

2014-05-22 Thread Thomas Monjalon
2014-05-19 16:51, Anatoly Burakov: > Support for loading/unloading VFIO drivers, binding/unbinding > devices to/from VFIO, also setting up correct userspace permissions. > > Signed-off-by: Anatoly Burakov > - ${RTE_SDK}/tools/igb_uio_bind.py --status > + ${RTE_SDK}/tools/

[dpdk-dev] [PATCH v2 15/16] Added support for VFIO drivers in dpdk_nic_bind.py

2014-05-22 Thread Thomas Monjalon
Please, could you remove trailing whitespaces from your patch? Thanks -- Thomas

[dpdk-dev] [PATCH 0/3] Support administrative link up and link down

2014-05-22 Thread Ivan Boule
On 05/22/2014 08:11 AM, Ouyang Changchun wrote: > This patch series contain the following 3 items: > 1. Add API to support administrative link up and down. > 2. Implement the functionality of administrative link up and down in IXGBE > PMD. > 3. Add command in testpmd to test the functionality of a

[dpdk-dev] [PATCH v2 13/16] Removed PCI ID table from igb_uio

2014-05-22 Thread Thomas Monjalon
2014-05-19 16:51, Anatoly Burakov: > Note that since igb_uio no longer has a PCI ID list, it can now be > bound to any device, not just those explicitly supported by DPDK. In > other words, it now behaves similar to PCI stub, VFIO and other generic > PCI drivers. I wonder if we could replace igb_u

[dpdk-dev] [PATCH v2 11/16] Make --no-huge use mmap instead of malloc

2014-05-22 Thread Thomas Monjalon
2014-05-19 16:51, Anatoly Burakov: > This makes it possible to run DPDK without hugepage memory when VFIO > is used, as VFIO uses virtual addresses to set up DMA mappings. > > Signed-off-by: Anatoly Burakov > - addr = malloc(internal_config.memory); > + addr = mmap(NULL,

[dpdk-dev] [PATCH v2 08/16] Add support for mapping devices through VFIO.

2014-05-22 Thread Thomas Monjalon
2014-05-22 12:37, Burakov, Anatoly: > > Yes, in some environments, it could be easier to be able to configure > > devices directly on application command line instead of having to call a > > python script. I think having a clear and extendable syntax to configure > > devices in command line could g

[dpdk-dev] [PATCH 0/3] Support administrative link up and link down

2014-05-22 Thread Ouyang, Changchun
Hi Ivan For this one, it seems long story for that... In short, Some customer have such kind of requirement, they want to repeatedly start(rte_dev_start) and stop(rte_dev_stop) the port for RX and TX, but they find after several times start and stop, the RX and TX can't work well even the port

[dpdk-dev] [PATCH v2 10/16] Added support for selecting VFIO interrupt type from EAL command-line

2014-05-22 Thread Thomas Monjalon
2014-05-19 16:51, Anatoly Burakov: > Unlike igb_uio, VFIO interrupt type is not set by kernel module > parameters but is set up via ioctl() calls at runtime. This warrants > a new EAL command-line parameter. It will have no effect if VFIO is > not compiled, but will set VFIO interrupt type to eithe

[dpdk-dev] [PATCH v2 08/16] Add support for mapping devices through VFIO.

2014-05-22 Thread Thomas Monjalon
2014-05-22 12:06, Burakov, Anatoly: > > We should discuss a way to request igb_uio or VFIO binding of a device. > > Why? The device can either be bound to VFIO or igb_uio. So unless you want > binding code in DPDK EAL (to avoid which the > pci_unbind/igb_uio_bind/dpdk_bind script was created in th

[dpdk-dev] [PATCH 3/3] testpmd: Add commands to test administrative link up and down of PMD

2014-05-22 Thread Ouyang Changchun
This patch adds commands to test the functionality of administrative link up and down of PMD in testpmd. Signed-off-by: Ouyang Changchun --- app/test-pmd/cmdline.c | 78 ++ app/test-pmd/testpmd.c | 14 + app/test-pmd/testpmd.h | 2 ++ 3 f

[dpdk-dev] [PATCH 2/3] ixgbe: Implement the functionality of administrative link up and down in IXGBE PMD

2014-05-22 Thread Ouyang Changchun
This patch implements the functionality of administrative link up and down in IXGBE PMD. Signed-off-by: Ouyang Changchun --- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 58 + 1 file changed, 58 insertions(+) diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/

[dpdk-dev] [PATCH 1/3] ether: Add API to support administrative link up and down

2014-05-22 Thread Ouyang Changchun
This patch addes API to support administrative link up and down. Signed-off-by: Ouyang Changchun --- lib/librte_ether/rte_ethdev.c | 38 ++ lib/librte_ether/rte_ethdev.h | 34 ++ 2 files changed, 72 insertions(+) diff --git a/l

[dpdk-dev] [PATCH 0/3] Support administrative link up and link down

2014-05-22 Thread Ouyang Changchun
This patch series contain the following 3 items: 1. Add API to support administrative link up and down. 2. Implement the functionality of administrative link up and down in IXGBE PMD. 3. Add command in testpmd to test the functionality of administrative link up and down of PMD. Ouyang Changchun (

[dpdk-dev] [PATCH v2 09/16] Enable VFIO device binding

2014-05-22 Thread Thomas Monjalon
2014-05-19 16:51, Anatoly Burakov: > Add support for binding VFIO devices if RTE_PCI_DRV_NEED_IGB_UIO > is set for this driver. Try VFIO first, if not mapped then try > IGB_UIO too. You have renamed RTE_PCI_DRV_NEED_IGB_UIO. Please update this log :) > --- a/lib/librte_eal/linuxapp/eal/eal_pci.c

[dpdk-dev] [PATCH v2 08/16] Add support for mapping devices through VFIO.

2014-05-22 Thread Thomas Monjalon
Hi Anatoly, It seems to be the main patch, so I have many comments. 2014-05-19 16:51, Anatoly Burakov: > VFIO is kernel 3.6+ only, and so is only compiled when DPDK config > option CONFIG_RTE_EAL_VFIO is enabled, and kernel 3.6 or higher is > detected, thus preventing compile failures on older ke

[dpdk-dev] [PATCH v2 13/16] Removed PCI ID table from igb_uio

2014-05-22 Thread Burakov, Anatoly
Hi Thomas, > I wonder if we could replace igb_uio by uio_pci_generic? Can it do DMA or IOMMU support? Not even VFIO does everything we need, you may have noticed that I have to go to PCI config space to enable bus mastering. I don't think that driver can do either of those things. Unless, of co

[dpdk-dev] [PATCH v2 08/16] Add support for mapping devices through VFIO.

2014-05-22 Thread Burakov, Anatoly
Hi Thomas, > Yes I agree. But I stopped on the name for another thing: it's not really > specific to vfio. Actually, vfio uses it for synchronization. But wouldn't it > be > more generic? OK, _mp_sync it is then. Best regards, Anatoly Burakov DPDK SW Engineer

[dpdk-dev] [PATCH v2 07/16] Add support for VFIO interrupts, add VFIO header

2014-05-22 Thread Burakov, Anatoly
Hi Thomas, > I don't know if there is something defined in a Linux header which could help > to check if VFIO is supported. But in general, it's better to check for a > macro > belonging to the feature instead of checking kernel version. Not sure VFIO defines any macros anywhere, but I'll look i

[dpdk-dev] [PATCH v2 07/16] Add support for VFIO interrupts, add VFIO header

2014-05-22 Thread Burakov, Anatoly
Hi Thomas, > In case VFIO is backported on older kernel, it would be better to check a > related macro instead of Linux version. Not sure I follow. What is the "related macro" you're referring to? Best regards, Anatoly Burakov DPDK SW Engineer

[dpdk-dev] [PATCH v2 08/16] Add support for mapping devices through VFIO.

2014-05-22 Thread Burakov, Anatoly
Hi Thomas, > Yes, in some environments, it could be easier to be able to configure devices > directly on application command line instead of having to call a python > script. > I think having a clear and extendable syntax to configure devices in command > line could greatly improve usability. But

[dpdk-dev] [PATCH v2 08/16] Add support for mapping devices through VFIO.

2014-05-22 Thread Burakov, Anatoly
Hi Thomas, > How did you test this feature? > Did you see some performance differences with igb_uio? The same way everything else is tested - bind a NIC to the driver and see if it works :-) As for performance differences, potentially it can be degraded a bit because of mandatory IOMMU involve

[dpdk-dev] [PATCH v2] kni: bug fix for compile issue in KNI on Fedora 18 with kernel 3.6.10

2014-05-22 Thread Helin Zhang
Error of "implicit-function-declaration" can be seen when building KNI kernel module on Linux kernel 3.6.10 platform, as follows. "x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/kni/igb_ethtool.c: In function \u2018igb_get_eee\u2019: x86_64-native-linuxapp-gcc/build/lib/librte_eal/linux

[dpdk-dev] [PATCH v2 07/16] Add support for VFIO interrupts, add VFIO header

2014-05-22 Thread Thomas Monjalon
2014-05-22 12:45, Burakov, Anatoly: > > In case VFIO is backported on older kernel, it would be better to check a > > related macro instead of Linux version. > > Not sure I follow. What is the "related macro" you're referring to? I don't know if there is something defined in a Linux header which

[dpdk-dev] Could DPDK be used for Openstack?

2014-05-22 Thread Choi, Sy Jong
Hi Mr. Kim, Please review version v1.0, which is going to be release soon. This version need patch up with openstack patch. https://01.org/packet-processing/intel%C2%AE-dpdk-vswitch-and-openstack-patches Regards, Choi, Sy Jong Platform Application Engineer -Original Message- From: de