[dpdk-dev] RX checksum offloading

2013-11-07 Thread Benson, Bryan
All, below is the validation of the submitted patch - I used the default rx free thresh (0) and 64 & it now works for both cases. Thank you! Bryan Benson -- Validation -- [bmbenson]~/1.3.1.1/DPDK% sudo ./x86_64-default-linuxapp-gcc/app/testpmd -c 0xFF00FF00 -n 4 -b :06:00.0 -- --portmask=0

[dpdk-dev] RX checksum offloading

2013-11-07 Thread Benson, Bryan
All, I have prepared a patch for the issue. If it is not in the correct format, please advise. I also changed the array to be uint32_t to be consistent with the other functions that pull the status flags. == PATCH BEGIN == >From 2ab73e88d92044c1d840f896d87e9a8cbcf29ce4 Mon Sep 17 00:00:00 2001

[dpdk-dev] TX IP checksum offloading

2013-11-07 Thread Benson, Bryan
Hi Daniel, I posted some findings yesterday that seem relevant. Try using the ol flags when you use an RX free threshold below 32. I am looking into what can be done to fix it for values of 32 and above. http://dpdk.org/ml/archives/dev/2013-November/000724.html Thanks, Bryan Benson

[dpdk-dev] TX IP checksum offloading

2013-11-07 Thread Daniel Kaminsky
Hi, Did anyone had an experience using the PKT_TX_IP_CKSUM flag? I have an application that generates IP traffic but whenever I try to set this flag on (*m->ol_flags = PKT_TX_IP_CKSUM)* the rte_mbuf nothing is sent out. Retrieving that statistics from the ethernet device show zero for opackets and

[dpdk-dev] RX checksum offloading

2013-11-07 Thread Thomas Monjalon
07/11/2013 10:06, Thomas Monjalon : > 07/11/2013 04:44, Benson, Bryan : > > RX queues=1 - RX desc=1024 - RX free threshold=16 > > > > -- Forward statistics for port 0 > > > > RX-total: 543761 Bad-ipcsum: 543558 Bad-l4csum: 0 > > > > -- Forward s

[dpdk-dev] [PATCH] config: remove unused KNI debug option

2013-11-07 Thread Thomas Monjalon
> > The option RTE_LIBRTE_KNI_DEBUG has no effect so it should be removed. > > The right options are: > > - RTE_KNI_KO_DEBUG > > - RTE_KNI_VHOST_DEBUG_RX > > - RTE_KNI_VHOST_DEBUG_TX > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Olivier Matz pushed -- Thomas

[dpdk-dev] [PATCH] eal: remove unused macro for blacklist

2013-11-07 Thread Thomas Monjalon
> > This macro was used for blacklist parsing but is not used anymore > > since commit 5a55b9ac91face71e9d665eecc716201d28745b0. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Olivier Matz pushed -- Thomas

[dpdk-dev] [PATCH v2] doc: add mbuf cloning functions in doxygen

2013-11-07 Thread Thomas Monjalon
> > Some functions are available only if RTE_MBUF_SCATTER_GATHER is enabled. > > So it must be configured for doxygen parser. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Olivier Matz pushed -- Thomas

[dpdk-dev] [PATCH] doc: fix doxygen parsing of __attribute__

2013-11-07 Thread Thomas Monjalon
07/11/2013 10:27, Olivier MATZ : > I think you should provide a pointer to the doxygen documentation > in the commit log to explain the modification. Maybe this one is > appropriate: > http://www.stack.nl/~dimitri/doxygen/manual/preprocessing.html > > About the patch itself, it looks good to me.

[dpdk-dev] [PATCH] config: remove unused KNI debug option

2013-11-07 Thread Olivier MATZ
Hi, On 10/30/2013 04:33 PM, Thomas Monjalon wrote: > The option RTE_LIBRTE_KNI_DEBUG has no effect so it should be removed. > The right options are: > - RTE_KNI_KO_DEBUG > - RTE_KNI_VHOST_DEBUG_RX > - RTE_KNI_VHOST_DEBUG_TX > > Signed-off-by: Thomas Monjalon Acked-by: Olivier Matz

[dpdk-dev] [PATCH] eal: remove unused macro for blacklist

2013-11-07 Thread Olivier MATZ
Hi, On 10/30/2013 04:34 PM, Thomas Monjalon wrote: > This macro was used for blacklist parsing but is not used anymore > since commit 5a55b9ac91face71e9d665eecc716201d28745b0. > > Signed-off-by: Thomas Monjalon Acked-by: Olivier Matz

[dpdk-dev] [PATCH v2] doc: add mbuf cloning functions in doxygen

2013-11-07 Thread Olivier MATZ
Hi, > Some functions are available only if RTE_MBUF_SCATTER_GATHER is enabled. > So it must be configured for doxygen parser. > > Signed-off-by: Thomas Monjalon Acked-by: Olivier Matz

[dpdk-dev] [PATCH] doc: fix doxygen parsing of __attribute__

2013-11-07 Thread Olivier MATZ
> > Ignore __attribute__ because it was wrongly parsed as an identifier. > > What about prefixing the title by "doc: " and remove the dot at the > end of the line ? Sorry, please ignore my first comment, it was not the title...

[dpdk-dev] [PATCH] doc: fix doxygen parsing of __attribute__

2013-11-07 Thread Olivier MATZ
Hi Thomas, > Ignore __attribute__ because it was wrongly parsed as an identifier. > > Signed-off-by: Thomas Monjalon What about prefixing the title by "doc: " and remove the dot at the end of the line ? > --- a/doc/doxy-api.conf > +++ b/doc/doxy-api.conf > @@ -47,9 +47,13 @@ INPUT

[dpdk-dev] RX checksum offloading

2013-11-07 Thread Thomas Monjalon
07/11/2013 04:44, Benson, Bryan : > RX queues=1 - RX desc=1024 - RX free threshold=16 > -- Forward statistics for port 0 > RX-total: 543761 Bad-ipcsum: 543558 Bad-l4csum: 0 > -- Forward statistics for port 1 > RX-total: 542226 Bad-ipcsum: 0

[dpdk-dev] RX checksum offloading

2013-11-07 Thread Benson, Bryan
Didn't realize attachments were stripped - here is the full text - sorry for the SPAM! == Full text of the rx checksum issues testing & validation == 0, 8, 16, 24, 28, 30, 31 are okay. Values above 32 are not (tested with 32, 64 and 128) [bmbenson]~/1.3.1.1/DPDK% sudo ./x86_64-default-linuxap

[dpdk-dev] RX checksum offloading

2013-11-07 Thread Benson, Bryan
All, The receive checksum issue seems to be caused by using a RX_FREE_THRESH value that is 32 or larger, as validated by the test-pmd application. I used 2 different packet types - bad IP checksum sent to port 0 and bad tcp checksum to port 1. The way I was sending the packets did not vary betwe

[dpdk-dev] RX checksum offloading

2013-11-07 Thread Benson, Bryan
All, Has anyone had any experience with hardware checksum offloads not working? It appears that the combination of settings we are using in our application may be the crux of the issue, as offloading test-pmd application in csum mode correctly identifies bad packets via the ol_flags. I am a bi