[GitHub] [incubator-doris] imay commented on issue #1753: Use crc32c checksum for segment v2

2019-09-06 Thread GitBox
imay commented on issue #1753: Use crc32c checksum for segment v2 URL: https://github.com/apache/incubator-doris/pull/1753#issuecomment-528740354 > @imay comments inline > > > Even if HashUtils::crc_hash doesn't generate standard CRC-32 checksum, the checksums should be equal. Becaus

[GitHub] [incubator-doris] imay merged pull request #1753: Use crc32c checksum for segment v2

2019-09-06 Thread GitBox
imay merged pull request #1753: Use crc32c checksum for segment v2 URL: https://github.com/apache/incubator-doris/pull/1753 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] xy720 commented on issue #1755: Remove author tag in our code

2019-09-06 Thread GitBox
xy720 commented on issue #1755: Remove author tag in our code URL: https://github.com/apache/incubator-doris/issues/1755#issuecomment-528765722 ok.I 'll do it. This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-doris] kangpinghuang commented on issue #1652: support filter with predicate in BetaRowset

2019-09-06 Thread GitBox
kangpinghuang commented on issue #1652: support filter with predicate in BetaRowset URL: https://github.com/apache/incubator-doris/issues/1652#issuecomment-528773506 I will split this job into several step: 1. I will move original v1's predicate logic to segment v2 to provide this feat

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #1652: support filter with predicate in BetaRowset

2019-09-06 Thread GitBox
kangpinghuang edited a comment on issue #1652: support filter with predicate in BetaRowset URL: https://github.com/apache/incubator-doris/issues/1652#issuecomment-528773506 I will split this job into several step: 1. I will move original v1's predicate logic to segment v2 to provide thi

[GitHub] [incubator-doris] chaoyli merged pull request #1750: Check rowset is useful atomicly

2019-09-06 Thread GitBox
chaoyli merged pull request #1750: Check rowset is useful atomicly URL: https://github.com/apache/incubator-doris/pull/1750 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] morningman merged pull request #1617: Add PreAgg Hint

2019-09-06 Thread GitBox
morningman merged pull request #1617: Add PreAgg Hint URL: https://github.com/apache/incubator-doris/pull/1617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] kangkaisen opened a new pull request #1756: Encapsulate HLL logic

2019-09-06 Thread GitBox
kangkaisen opened a new pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756 For https://github.com/apache/incubator-doris/pull/1610 Before I do "avoid serialize and deserialize from Scannode to Aggnode" work, I need to unify Bitmap and H

[GitHub] [incubator-doris] kangkaisen closed issue #1746: BE core when to_bitmap argument is invalid

2019-09-06 Thread GitBox
kangkaisen closed issue #1746: BE core when to_bitmap argument is invalid URL: https://github.com/apache/incubator-doris/issues/1746 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] xonze opened a new issue #1757: kafka routine load kafka consume failed Broker: Offset out of range

2019-09-07 Thread GitBox
xonze opened a new issue #1757: kafka routine load kafka consume failed Broker: Offset out of range URL: https://github.com/apache/incubator-doris/issues/1757 **使用kafka routine load数据过程中的Offset out of range问题** 可能由于大批量导入历史数据的原因,中间出现过个别机器有commit失败的情况,时间久了就会出现各个BE所分配的partition消费offset

[GitHub] [incubator-doris] morningman merged pull request #1471: Planner support push down predicates past agg, win and sort

2019-09-07 Thread GitBox
morningman merged pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1725: The null result of union stmt is incorrect

2019-09-08 Thread GitBox
EmmyMiao87 commented on issue #1725: The null result of union stmt is incorrect URL: https://github.com/apache/incubator-doris/issues/1725#issuecomment-529177921 ISSUES-1725: The result of union stmt whose child is outer join stmt is incorrect. Example: sql: (select k1 from empty

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1758: Bug-fix: error result of union stmt

2019-09-08 Thread GitBox
EmmyMiao87 opened a new pull request #1758: Bug-fix: error result of union stmt URL: https://github.com/apache/incubator-doris/pull/1758 ISSUES-1725: The result of union stmt whose child is outer join stmt is incorrect. Example: sql: (select k1 from empty) union all (select b.k1 k

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1725: The null result of union stmt is incorrect

2019-09-08 Thread GitBox
EmmyMiao87 commented on issue #1725: The null result of union stmt is incorrect URL: https://github.com/apache/incubator-doris/issues/1725#issuecomment-529188635 #1758 This is an automated message from the Apache Git Service

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1758: Bug-fix: error result of union stmt

2019-09-08 Thread GitBox
EmmyMiao87 commented on issue #1758: Bug-fix: error result of union stmt URL: https://github.com/apache/incubator-doris/pull/1758#issuecomment-529188624 #1725 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-doris] chaoyli opened a new issue #1759: Support multi-path in RowsetGraph

2019-09-08 Thread GitBox
chaoyli opened a new issue #1759: Support multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/issues/1759 Before, no used rowset will be removed from RowsetGraph after compaction. There will only one path from one version to another version. For example, (0,1), (1,

[GitHub] [incubator-doris] chaoyli commented on issue #1759: Support multi-path in RowsetGraph

2019-09-08 Thread GitBox
chaoyli commented on issue #1759: Support multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/issues/1759#issuecomment-529192011 To address this issue, rowset still remain in RowsetGraph after compaction. Instead, a new thread will collect these rowset at interval.

[GitHub] [incubator-doris] chaoyli opened a new pull request #1760: And multi-path in RowsetGraph

2019-09-08 Thread GitBox
chaoyli opened a new pull request #1760: And multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1760 1. Do not remove rowset from RowsetGraph after compaction. 2. Add a thread to collect unused rowsets at interval. 3. Remove code related with inc_version from

[GitHub] [incubator-doris] imay merged pull request #1758: Bug-fix: error result of union stmt

2019-09-08 Thread GitBox
imay merged pull request #1758: Bug-fix: error result of union stmt URL: https://github.com/apache/incubator-doris/pull/1758 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] morningman merged pull request #1760: Get rid of external_sorting when rowsets have already been filtered

2019-09-08 Thread GitBox
morningman merged pull request #1760: Get rid of external_sorting when rowsets have already been filtered URL: https://github.com/apache/incubator-doris/pull/1760 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] chaoyli commented on issue #1761: And multi-path in RowsetGraph

2019-09-08 Thread GitBox
chaoyli commented on issue #1761: And multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#issuecomment-529204388 #1759 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] chaoyli opened a new pull request #1761: And multi-path in RowsetGraph

2019-09-08 Thread GitBox
chaoyli opened a new pull request #1761: And multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761 1. Do not remove rowset from RowsetGraph after compaction 2. Collect unused rowset at interval 3. Remove inc_version and related code ---

[GitHub] [incubator-doris] chaoyli edited a comment on issue #1761: And multi-path in RowsetGraph

2019-09-08 Thread GitBox
chaoyli edited a comment on issue #1761: And multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#issuecomment-529204388 Related issue is #1759 This is an automated message from the Apache Git Se

[GitHub] [incubator-doris] morningman opened a new pull request #1762: Optimize some kinds of load jobs

2019-09-08 Thread GitBox
morningman opened a new pull request #1762: Optimize some kinds of load jobs URL: https://github.com/apache/incubator-doris/pull/1762 1. Support specifying label to Insert Into stmt. INSERT INTO tbl1 WITH LABEL label1 ...; 2. Return job' state corresponding to the existing labe

[GitHub] [incubator-doris] morningman opened a new issue #1763: Support specifying label in insert stmt

2019-09-08 Thread GitBox
morningman opened a new issue #1763: Support specifying label in insert stmt URL: https://github.com/apache/incubator-doris/issues/1763 In the current implementation, the user cannot specify a Label for the INSERT command, which can lead to some usage problems. When the user executes

[GitHub] [incubator-doris] imay opened a new pull request #1764: Move compare from RowCursor to row

2019-09-08 Thread GitBox
imay opened a new pull request #1764: Move compare from RowCursor to row URL: https://github.com/apache/incubator-doris/pull/1764 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] morningman commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-08 Thread GitBox
morningman commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322013467 ## File path: be/src/olap/olap_server.cpp ## @@ -40,11 +40,17 @@ namespace doris { volatile uint32_t g_sche

[GitHub] [incubator-doris] morningman commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-08 Thread GitBox
morningman commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322013202 ## File path: be/src/olap/tablet.h ## @@ -233,6 +228,7 @@ class Tablet : public std::enable_shared_from_this

[GitHub] [incubator-doris] morningman commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-08 Thread GitBox
morningman commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322013110 ## File path: be/src/olap/tablet.cpp ## @@ -702,8 +616,15 @@ void Tablet::calc_missed_versions_unlock(int64_

[GitHub] [incubator-doris] morningman commented on a change in pull request #1764: Move compare from RowCursor to row

2019-09-08 Thread GitBox
morningman commented on a change in pull request #1764: Move compare from RowCursor to row URL: https://github.com/apache/incubator-doris/pull/1764#discussion_r322013985 ## File path: be/src/olap/row.h ## @@ -67,6 +67,41 @@ int compare_row(const LhsRowType& lhs, const RhsR

[GitHub] [incubator-doris] morningman commented on issue #1757: kafka routine load kafka consume failed Broker: Offset out of range

2019-09-08 Thread GitBox
morningman commented on issue #1757: kafka routine load kafka consume failed Broker: Offset out of range URL: https://github.com/apache/incubator-doris/issues/1757#issuecomment-529214784 > 1. routine load过程中没有动态的考虑offset均衡问题,每个BE始终分配的那几个固定的partition We will find a way to balance the

[GitHub] [incubator-doris] yiguolei opened a new issue #1765: Should create init version in alter request v2

2019-09-08 Thread GitBox
yiguolei opened a new issue #1765: Should create init version in alter request v2 URL: https://github.com/apache/incubator-doris/issues/1765 In previous version, BE will not create init version(0,1) during create tablet in alter request because alter task will convert data from base tablet

[GitHub] [incubator-doris] wangbo opened a new issue #1766: v2 segment support string type using DictPageBuilder

2019-09-08 Thread GitBox
wangbo opened a new issue #1766: v2 segment support string type using DictPageBuilder URL: https://github.com/apache/incubator-doris/issues/1766 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-doris] yiguolei opened a new pull request #1767: Should create init rowset for alter task v2

2019-09-08 Thread GitBox
yiguolei opened a new pull request #1767: Should create init rowset for alter task v2 URL: https://github.com/apache/incubator-doris/pull/1767 #1765 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] imay commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
imay commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322049060 ## File path: be/src/exprs/hll_hash_function.cpp ## @@ -15,62 +15,34 @@ // specific language governing permissions and lim

[GitHub] [incubator-doris] imay commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
imay commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322046040 ## File path: be/src/olap/aggregate_func.h ## @@ -399,64 +399,43 @@ struct AggregateFuncTraits template <> struct Aggreg

[GitHub] [incubator-doris] imay commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
imay commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322048153 ## File path: be/src/exprs/hll_function.cpp ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-doris] imay commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
imay commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322049907 ## File path: be/src/olap/hll.h ## @@ -33,14 +33,339 @@ const static int HLL_REGISTERS_COUNT = 16384; // maximum size in b

[GitHub] [incubator-doris] imay commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
imay commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322049338 ## File path: be/src/olap/hll.h ## @@ -33,14 +33,339 @@ const static int HLL_REGISTERS_COUNT = 16384; // maximum size in b

[GitHub] [incubator-doris] imay commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
imay commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322044569 ## File path: be/src/exec/csv_scan_node.cpp ## @@ -672,14 +672,14 @@ void CsvScanNode::hll_hash(const char* src, int len,

[GitHub] [incubator-doris] imay commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
imay commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322048199 ## File path: be/src/exprs/hll_function.cpp ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-doris] imay commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
imay commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322049508 ## File path: be/src/olap/hll.h ## @@ -33,14 +33,339 @@ const static int HLL_REGISTERS_COUNT = 16384; // maximum size in b

[GitHub] [incubator-doris] imay commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
imay commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322049774 ## File path: be/src/olap/hll.h ## @@ -33,14 +33,339 @@ const static int HLL_REGISTERS_COUNT = 16384; // maximum size in b

[GitHub] [incubator-doris] imay opened a new pull request #1768: Assign schema_size from other Schema

2019-09-08 Thread GitBox
imay opened a new pull request #1768: Assign schema_size from other Schema URL: https://github.com/apache/incubator-doris/pull/1768 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] kangkaisen commented on issue #1768: Assign schema_size from other Schema

2019-09-08 Thread GitBox
kangkaisen commented on issue #1768: Assign schema_size from other Schema URL: https://github.com/apache/incubator-doris/pull/1768#issuecomment-529283998 +1,LGTM This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-doris] morningman commented on issue #1723: 元数据支持存储计算分离

2019-09-08 Thread GitBox
morningman commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-529284671 更新 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] imay merged pull request #1768: Assign schema_size from other Schema

2019-09-08 Thread GitBox
imay merged pull request #1768: Assign schema_size from other Schema URL: https://github.com/apache/incubator-doris/pull/1768 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322072786 ## File path: be/src/olap/hll.h ## @@ -33,14 +33,339 @@ const static int HLL_REGISTERS_COUNT = 16384; // maximum siz

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322072814 ## File path: be/src/olap/hll.h ## @@ -33,14 +33,339 @@ const static int HLL_REGISTERS_COUNT = 16384; // maximum siz

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322073638 ## File path: be/src/olap/hll.h ## @@ -33,14 +33,339 @@ const static int HLL_REGISTERS_COUNT = 16384; // maximum siz

[GitHub] [incubator-doris] morningman merged pull request #1767: Should create init rowset for alter task v2

2019-09-08 Thread GitBox
morningman merged pull request #1767: Should create init rowset for alter task v2 URL: https://github.com/apache/incubator-doris/pull/1767 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322074852 ## File path: be/src/olap/hll.h ## @@ -33,14 +33,339 @@ const static int HLL_REGISTERS_COUNT = 16384; // maximum siz

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322075254 ## File path: be/src/exprs/hll_hash_function.cpp ## @@ -15,62 +15,34 @@ // specific language governing permissions a

[GitHub] [incubator-doris] imay commented on a change in pull request #1762: Optimize some kinds of load jobs

2019-09-08 Thread GitBox
imay commented on a change in pull request #1762: Optimize some kinds of load jobs URL: https://github.com/apache/incubator-doris/pull/1762#discussion_r322074575 ## File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java ## @@ -81,6 +81,7 @@ public stati

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322076119 ## File path: be/src/exprs/hll_function.cpp ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322076164 ## File path: be/src/exprs/hll_function.cpp ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322076384 ## File path: be/src/olap/aggregate_func.h ## @@ -399,64 +399,43 @@ struct AggregateFuncTraits template <> struct

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic

2019-09-08 Thread GitBox
kangkaisen commented on a change in pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756#discussion_r322077118 ## File path: be/src/exec/csv_scan_node.cpp ## @@ -672,14 +672,14 @@ void CsvScanNode::hll_hash(const char* src, int

[GitHub] [incubator-doris] imay commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-08 Thread GitBox
imay commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322083559 ## File path: be/src/olap/tablet.cpp ## @@ -970,4 +878,42 @@ void Tablet::pick_candicate_rowsets_to_base_compactio

[GitHub] [incubator-doris] imay merged pull request #1764: Move compare from RowCursor to row

2019-09-08 Thread GitBox
imay merged pull request #1764: Move compare from RowCursor to row URL: https://github.com/apache/incubator-doris/pull/1764 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1738: add bloom filter index

2019-09-09 Thread GitBox
gaodayue commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r322046176 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -152,7 +153,12 @@ class BinaryPlainPageDecoder :

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1738: add bloom filter index

2019-09-09 Thread GitBox
gaodayue commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r322074028 ## File path: be/src/olap/rowset/segment_v2/bloom_filter_page.cpp ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1738: add bloom filter index

2019-09-09 Thread GitBox
gaodayue commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r322073137 ## File path: be/src/olap/rowset/segment_v2/bloom_filter_page.cpp ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1738: add bloom filter index

2019-09-09 Thread GitBox
gaodayue commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r322069777 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -137,6 +139,13 @@ Status SegmentWriter::_write_zo

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1738: add bloom filter index

2019-09-09 Thread GitBox
gaodayue commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r322077367 ## File path: gensrc/proto/segment_v2.proto ## @@ -145,6 +147,13 @@ message ShortKeyFooterPB { optional uint32 se

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1738: add bloom filter index

2019-09-09 Thread GitBox
gaodayue commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r322070106 ## File path: be/src/olap/rowset/segment_v2/column_writer.h ## @@ -42,7 +44,13 @@ struct ColumnWriterOptions { //

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1738: add bloom filter index

2019-09-09 Thread GitBox
gaodayue commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r322070220 ## File path: be/src/olap/rowset/segment_v2/column_writer.h ## @@ -42,7 +44,13 @@ struct ColumnWriterOptions { //

[GitHub] [incubator-doris] imay merged pull request #1756: Encapsulate HLL logic

2019-09-09 Thread GitBox
imay merged pull request #1756: Encapsulate HLL logic URL: https://github.com/apache/incubator-doris/pull/1756 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-09 Thread GitBox
yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322139214 ## File path: be/src/olap/olap_snapshot_converter.cpp ## @@ -129,20 +124,6 @@ OLAPStatus OlapSnapshotConverter

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-09 Thread GitBox
yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322138860 ## File path: be/src/olap/olap_snapshot_converter.cpp ## @@ -68,11 +68,6 @@ OLAPStatus OlapSnapshotConverter::

[GitHub] [incubator-doris] kangkaisen opened a new pull request #1769: Minot, fix segment v2 comment

2019-09-09 Thread GitBox
kangkaisen opened a new pull request #1769: Minot, fix segment v2 comment URL: https://github.com/apache/incubator-doris/pull/1769 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1770: Bug-fix: unknown column from the inline view

2019-09-09 Thread GitBox
EmmyMiao87 opened a new pull request #1770: Bug-fix: unknown column from the inline view URL: https://github.com/apache/incubator-doris/pull/1770 Revert code from PR-1617. The column who belongs to inline view need to be initialized by alias. --

[GitHub] [incubator-doris] gaodayue opened a new pull request #1771: segment_v2: writer magic number in footer instead of header

2019-09-09 Thread GitBox
gaodayue opened a new pull request #1771: segment_v2: writer magic number in footer instead of header URL: https://github.com/apache/incubator-doris/pull/1771 Writing magic number in footer can avoid one extra seek(0) when reading. --

[GitHub] [incubator-doris] imay merged pull request #1769: Minor, fix segment v2 comment

2019-09-09 Thread GitBox
imay merged pull request #1769: Minor, fix segment v2 comment URL: https://github.com/apache/incubator-doris/pull/1769 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-09 Thread GitBox
yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322169212 ## File path: be/src/olap/snapshot_manager.cpp ## @@ -438,14 +422,12 @@ OLAPStatus SnapshotManager::_create_sn

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-09 Thread GitBox
yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322176368 ## File path: be/src/olap/tablet_meta.cpp ## @@ -553,33 +523,6 @@ RowsetMetaSharedPtr TabletMeta::acquire_rs_

[GitHub] [incubator-doris] imay merged pull request #1770: Bug-fix: unknown column from the inline view

2019-09-09 Thread GitBox
imay merged pull request #1770: Bug-fix: unknown column from the inline view URL: https://github.com/apache/incubator-doris/pull/1770 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] morningman commented on a change in pull request #1762: Optimize some kinds of load jobs

2019-09-09 Thread GitBox
morningman commented on a change in pull request #1762: Optimize some kinds of load jobs URL: https://github.com/apache/incubator-doris/pull/1762#discussion_r322235523 ## File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java ## @@ -81,6 +81,7 @@ public

[GitHub] [incubator-doris] imay merged pull request #1762: Optimize some kinds of load jobs

2019-09-09 Thread GitBox
imay merged pull request #1762: Optimize some kinds of load jobs URL: https://github.com/apache/incubator-doris/pull/1762 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1734: Commit kafka offset in routine load

2019-09-09 Thread GitBox
HangyuanLiu commented on a change in pull request #1734: Commit kafka offset in routine load URL: https://github.com/apache/incubator-doris/pull/1734#discussion_r322360317 ## File path: be/src/runtime/routine_load/data_consumer.h ## @@ -133,6 +133,8 @@ class KafkaDataConsu

[GitHub] [incubator-doris] imay merged pull request #1771: segment_v2: writer magic number in footer instead of header

2019-09-09 Thread GitBox
imay merged pull request #1771: segment_v2: writer magic number in footer instead of header URL: https://github.com/apache/incubator-doris/pull/1771 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-09 Thread GitBox
yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322533801 ## File path: be/src/olap/schema_change.cpp ## @@ -1250,7 +1250,7 @@ OLAPStatus SchemaChangeHandler::_do_proc

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-09 Thread GitBox
yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322534043 ## File path: be/src/olap/snapshot_manager.cpp ## @@ -438,14 +422,12 @@ OLAPStatus SnapshotManager::_create_sn

[GitHub] [incubator-doris] imay commented on issue #1723: 元数据支持存储计算分离

2019-09-09 Thread GitBox
imay commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-529748789 > location:zone1.rack1#custom:tag1.tag2` 一般都是逗号、分号来分隔吧?这种方式太少见了,而且也不直观。 > ALTER SYSTEM ADD BACKNED "host:ip" > PROPERTIES( > "resource_tag" =

[GitHub] [incubator-doris] imay opened a new pull request #1772: Fix BE crash when schema changing with HLL column

2019-09-09 Thread GitBox
imay opened a new pull request #1772: Fix BE crash when schema changing with HLL column URL: https://github.com/apache/incubator-doris/pull/1772 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-doris] kangkaisen commented on issue #1772: Fix BE crash when schema changing with HLL column

2019-09-09 Thread GitBox
kangkaisen commented on issue #1772: Fix BE crash when schema changing with HLL column URL: https://github.com/apache/incubator-doris/pull/1772#issuecomment-529770423 +1. LGTM. This is an automated message from the Apache Git

[GitHub] [incubator-doris] imay merged pull request #1772: Fix BE crash when schema changing with HLL column

2019-09-09 Thread GitBox
imay merged pull request #1772: Fix BE crash when schema changing with HLL column URL: https://github.com/apache/incubator-doris/pull/1772 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-09 Thread GitBox
yiguolei commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322563769 ## File path: be/src/olap/tablet.cpp ## @@ -250,28 +228,35 @@ OLAPStatus Tablet::add_rowset(RowsetSharedPtr ro

[GitHub] [incubator-doris] morningman merged pull request #1734: Commit kafka offset in routine load

2019-09-09 Thread GitBox
morningman merged pull request #1734: Commit kafka offset in routine load URL: https://github.com/apache/incubator-doris/pull/1734 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] morningman commented on a change in pull request #1761: Add multi-path in RowsetGraph

2019-09-10 Thread GitBox
morningman commented on a change in pull request #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#discussion_r322582402 ## File path: be/src/olap/tablet.cpp ## @@ -702,8 +616,15 @@ void Tablet::calc_missed_versions_unlock(int64_

[GitHub] [incubator-doris] morningman commented on issue #1761: Add multi-path in RowsetGraph

2019-09-10 Thread GitBox
morningman commented on issue #1761: Add multi-path in RowsetGraph URL: https://github.com/apache/incubator-doris/pull/1761#issuecomment-529808650 in `src//olap/tablet.cpp`, the function `capture_consistent_versions()` which will print WANRNING log when version missing. But these is in crit

[GitHub] [incubator-doris] imay opened a new pull request #1773: Make CpuInfo::get_current_core work

2019-09-10 Thread GitBox
imay opened a new pull request #1773: Make CpuInfo::get_current_core work URL: https://github.com/apache/incubator-doris/pull/1773 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] morningman commented on issue #1723: 元数据支持存储计算分离

2019-09-10 Thread GitBox
morningman commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-529830088 > 一般都是逗号、分号来分隔吧?这种方式太少见了,而且也不直观。 那就不打平了,每个type 一行 > 这种方式太难使用了 这个其实不是必选项,用户依然可以按照之前的方式建表,无需感知tag --

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1773: Make CpuInfo::get_current_core work

2019-09-10 Thread GitBox
chaoyli commented on a change in pull request #1773: Make CpuInfo::get_current_core work URL: https://github.com/apache/incubator-doris/pull/1773#discussion_r322609128 ## File path: be/CMakeLists.txt ## @@ -287,6 +287,14 @@ execute_process( OUTPUT_VARIABLE LLVM_MODULE_L

[GitHub] [incubator-doris] imay commented on issue #1752: Create FieldList to reuse filed and schema

2019-09-10 Thread GitBox
imay commented on issue #1752: Create FieldList to reuse filed and schema URL: https://github.com/apache/incubator-doris/issues/1752#issuecomment-529848182 related to #1726 This is an automated message from the Apache Git Se

[GitHub] [incubator-doris] imay commented on issue #1743: compute skew when concurrent queries

2019-09-10 Thread GitBox
imay commented on issue #1743: compute skew when concurrent queries URL: https://github.com/apache/incubator-doris/issues/1743#issuecomment-529847988 related to #1726 This is an automated message from the Apache Git Service.

[GitHub] [incubator-doris] imay closed issue #1743: compute skew when concurrent queries

2019-09-10 Thread GitBox
imay closed issue #1743: compute skew when concurrent queries URL: https://github.com/apache/incubator-doris/issues/1743 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-doris] morningman opened a new pull request #1774: Add some basic class for tag system

2019-09-10 Thread GitBox
morningman opened a new pull request #1774: Add some basic class for tag system URL: https://github.com/apache/incubator-doris/pull/1774 Tag/TagSet/TagManager This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1775: add predicate filter(#1652)

2019-09-10 Thread GitBox
kangpinghuang opened a new pull request #1775: add predicate filter(#1652) URL: https://github.com/apache/incubator-doris/pull/1775 Support predicate filter when reading data in segment v2. Now just support vectorization predicate filter, later we will realize lazy materialization. ---

[GitHub] [incubator-doris] chaoyli merged pull request #1773: Make CpuInfo::get_current_core work

2019-09-10 Thread GitBox
chaoyli merged pull request #1773: Make CpuInfo::get_current_core work URL: https://github.com/apache/incubator-doris/pull/1773 This is an automated message from the Apache Git Service. To respond to the message, please log o

<    29   30   31   32   33   34   35   36   37   38   >