[GitHub] [incubator-doris] morningman merged pull request #1702: Limit the disk usage to avoid running out of disk capacity

2019-08-27 Thread GitBox
morningman merged pull request #1702: Limit the disk usage to avoid running out of disk capacity URL: https://github.com/apache/incubator-doris/pull/1702 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] morningman merged pull request #1644: Refactor DateLiteral class in FE

2019-08-27 Thread GitBox
morningman merged pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-doris] morningman commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-27 Thread GitBox
morningman commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318111308 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulation/SHOW TABLET.md ## @@ -

[GitHub] [incubator-doris] morningman commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-27 Thread GitBox
morningman commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318112418 ## File path: fe/src/main/java/org/apache/doris/qe/ShowExecutor.java ## @@ -1146,14 +1147,69 @@ private vo

[GitHub] [incubator-doris] morningman commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-27 Thread GitBox
morningman commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318111226 ## File path: fe/src/main/java/org/apache/doris/analysis/ShowTabletStmt.java ## @@ -79,10 +135,112 @@ publ

[GitHub] [incubator-doris] imay closed issue #1706: BE crash when inserting data

2019-08-27 Thread GitBox
imay closed issue #1706: BE crash when inserting data URL: https://github.com/apache/incubator-doris/issues/1706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318354371 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulation/SHOW TABLET.md ## @

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318354377 ## File path: fe/src/main/java/org/apache/doris/analysis/ShowTabletStmt.java ## @@ -79,10 +135,112 @@ p

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318357108 ## File path: fe/src/main/java/org/apache/doris/qe/ShowExecutor.java ## @@ -1146,14 +1147,69 @@ private

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647)

2019-08-27 Thread GitBox
gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#discussion_r318365380 ## File path: be/src/olap/rowset/segment_v2/segment_writer.h ## @@ -60,6 +60,8 @@ class SegmentWrite

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647)

2019-08-27 Thread GitBox
gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#discussion_r318366047 ## File path: be/src/olap/rowset/beta_rowset_writer.cpp ## @@ -84,6 +84,9 @@ OLAPStatus BetaRowsetWr

[GitHub] [incubator-doris] gaodayue commented on issue #1705: Limit V2 segment file row count (#1647)

2019-08-27 Thread GitBox
gaodayue commented on issue #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#issuecomment-525554010 In addition - `SegmentFooterPB.num_rows` should be changed from uint64 to uint32 - `segment_v2::SegmentWriter::_row_count` should b

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647)

2019-08-27 Thread GitBox
gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#discussion_r318366011 ## File path: be/src/olap/rowset/segment_v2/segment_writer.h ## @@ -82,6 +84,7 @@ class SegmentWrite

[GitHub] [incubator-doris] imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-27 Thread GitBox
imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-52249 @gaodayue Good proposal, I have some questions about this proposal. 1. If we support other type of index, for e

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318363048 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318358302 ## File path: be/src/olap/storage_engine.h ## @@ -196,6 +197,12 @@ class StorageEngine { // T

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318364245 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318366359 ## File path: be/src/olap/rowset/rowset_meta.h ## @@ -71,12 +74,15 @@ class RowsetMeta {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318360328 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318368417 ## File path: be/src/olap/rowset/unique_rowset_id_generator.cpp ## @@ -0,0 +1,50 @@ +// Licensed t

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318361481 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318365231 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318367344 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318360237 ## File path: be/src/olap/rowset/rowset_id_generator.h ## @@ -28,27 +28,17 @@ class OlapMeta; c

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318365672 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318360296 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318357984 ## File path: be/src/agent/agent_server.cpp ## @@ -426,7 +426,11 @@ void AgentServer::make_snapsho

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318368276 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318364183 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318363270 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318360367 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318366159 ## File path: be/src/olap/rowset/beta_rowset.cpp ## @@ -26,7 +26,7 @@ namespace doris { std::s

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318369258 ## File path: be/test/olap/rowset/unique_rowset_id_generator_test.cpp ## @@ -0,0 +1,101 @@ +// Lic

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort

2019-08-27 Thread GitBox
chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471#discussion_r318373022 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort

2019-08-27 Thread GitBox
chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471#discussion_r318373907 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java

[GitHub] [incubator-doris] imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-27 Thread GitBox
imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-525596953 And for `Encoding for integer dictionary`, I think it's OK to use one byte to store BitWidth. If we store BitWidth, last fram

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1695: Refactor alter job

2019-08-28 Thread GitBox
EmmyMiao87 commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318419537 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/BrokerLoadJob.java ## @@ -112,27 +109,31 @@ public static Br

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1695: Refactor alter job

2019-08-28 Thread GitBox
EmmyMiao87 commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318422857 ## File path: fe/src/main/java/org/apache/doris/load/BrokerFileGroup.java ## @@ -64,11 +64,11 @@ private List colum

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1695: Refactor alter job

2019-08-28 Thread GitBox
EmmyMiao87 commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318420886 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/BrokerLoadJob.java ## @@ -355,16 +356,24 @@ private void cre

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1695: Refactor alter job

2019-08-28 Thread GitBox
EmmyMiao87 commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318416602 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulation/BROKER LOAD.md ## @@ -133,7 +133,8 @

[GitHub] [incubator-doris] morningman opened a new pull request #1714: Fix bug that failed to get enough normal replica because path hash is not set.

2019-08-28 Thread GitBox
morningman opened a new pull request #1714: Fix bug that failed to get enough normal replica because path hash is not set. URL: https://github.com/apache/incubator-doris/pull/1714 Path Hash of a replica in metadata should be set immediately after replica is created. And we should not de

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

2019-08-28 Thread GitBox
morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318440101 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulation/BROKER LOAD.md ## @@ -133,7 +133,8 @

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

2019-08-28 Thread GitBox
morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318440410 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/BrokerLoadJob.java ## @@ -112,27 +109,31 @@ public static Br

[GitHub] [incubator-doris] morningman merged pull request #1687: add limit to show tablet(#1547)

2019-08-28 Thread GitBox
morningman merged pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] imay opened a new pull request #1715: Fix code's license

2019-08-28 Thread GitBox
imay opened a new pull request #1715: Fix code's license URL: https://github.com/apache/incubator-doris/pull/1715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1716: Avoid consistency problem when has no more data

2019-08-28 Thread GitBox
wuyunfeng opened a new pull request #1716: Avoid consistency problem when has no more data URL: https://github.com/apache/incubator-doris/pull/1716 When all result data returned, fetch_result blocked unexpected by `blocking_get` after multi invoking . Put sentinel nullptr for the Blocki

[GitHub] [incubator-doris] morningman merged pull request #1715: Fix code's license

2019-08-28 Thread GitBox
morningman merged pull request #1715: Fix code's license URL: https://github.com/apache/incubator-doris/pull/1715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318514390 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; // Colum

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318514769 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; // Colum

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318514906 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; // Colum

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318515815 ## File path: be/src/agent/agent_server.cpp ## @@ -426,7 +426,11 @@ void AgentServer::make_snapshot(TAg

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318516650 ## File path: be/src/olap/rowset/rowset_id_generator.h ## @@ -28,27 +28,17 @@ class OlapMeta; class

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318516616 ## File path: be/src/olap/storage_engine.h ## @@ -196,6 +197,12 @@ class StorageEngine { // TODO(y

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318516832 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to the A

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318517169 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to the A

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318517223 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to the A

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318517581 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; // Colum

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318517464 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; // Colum

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318518046 ## File path: be/src/olap/rowset/beta_rowset.cpp ## @@ -26,7 +26,7 @@ namespace doris { std::string

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318518722 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to the A

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318522038 ## File path: be/test/olap/rowset/unique_rowset_id_generator_test.cpp ## @@ -0,0 +1,101 @@ +// Licensed

[GitHub] [incubator-doris] yiguolei opened a new issue #1717: RowsetId should be unique globally.

2019-08-28 Thread GitBox
yiguolei opened a new issue #1717: RowsetId should be unique globally. URL: https://github.com/apache/incubator-doris/issues/1717 RowsetId is used to identify a batch load file in one replica so that it is unique in one replica[not tablet!!!] currenlty. Same rowsetid does not mean same dat

[GitHub] [incubator-doris] morningman merged pull request #1714: Fix bug that failed to get enough normal replica because path hash is not set.

2019-08-28 Thread GitBox
morningman merged pull request #1714: Fix bug that failed to get enough normal replica because path hash is not set. URL: https://github.com/apache/incubator-doris/pull/1714 This is an automated message from the Apache Git S

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1716: Avoid consistency problem when has no more data

2019-08-28 Thread GitBox
EmmyMiao87 commented on issue #1716: Avoid consistency problem when has no more data URL: https://github.com/apache/incubator-doris/pull/1716#issuecomment-525726064 Test for approve This is an automated message from the Apach

[GitHub] [incubator-doris] gaodayue opened a new pull request #1718: Basic implementation for BetaRowsetReader

2019-08-28 Thread GitBox
gaodayue opened a new pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-doris] morningman commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
morningman commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318595570 ## File path: be/src/olap/olap_define.h ## @@ -53,7 +53,7 @@ static constexpr uint32_t OLAP_COMPACTI

[GitHub] [incubator-doris] morningman commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
morningman commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318594351 ## File path: be/src/service/doris_main.cpp ## @@ -153,6 +154,7 @@ int main(int argc, char** argv) {

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318592775 ## File path: be/src/olap/rowset/segment_group.h ## @@ -48,11 +48,11 @@ namespace doris { class SegmentGro

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318585141 ## File path: be/test/olap/rowset/unique_rowset_id_generator_test.cpp ## @@ -0,0 +1,111 @@ +// Licensed to

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318592537 ## File path: be/src/olap/rowset/segment_writer.cpp ## @@ -213,6 +213,12 @@ OLAPStatus SegmentWriter::final

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318587826 ## File path: be/src/olap/storage_engine.h ## @@ -333,6 +340,8 @@ class StorageEngine { std::unique_pt

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318590670 ## File path: be/src/olap/rowset/unique_rowset_id_generator.cpp ## @@ -0,0 +1,50 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318590409 ## File path: be/src/olap/rowset/unique_rowset_id_generator.cpp ## @@ -0,0 +1,50 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318591288 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318596408 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; // Column un

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318595755 ## File path: be/src/olap/data_dir.cpp ## @@ -582,7 +576,9 @@ OLAPStatus DataDir::_convert_old_tablet() {

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318546557 ## File path: fe/src/main/java/org/apache/doris/task/SnapshotTask.java ## @@ -79,7 +79,7 @@ public TSnapsho

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318593211 ## File path: be/src/olap/rowset/rowset_meta_manager.h ## @@ -31,20 +31,20 @@ namespace doris { // Helper

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318592911 ## File path: be/src/olap/rowset/segment_group.h ## @@ -248,7 +248,7 @@ class SegmentGroup { int64_t

[GitHub] [incubator-doris] morningman commented on a change in pull request #1700: Partition pruning support Expr

2019-08-28 Thread GitBox
morningman commented on a change in pull request #1700: Partition pruning support Expr URL: https://github.com/apache/incubator-doris/pull/1700#discussion_r318618214 ## File path: fe/src/main/java/org/apache/doris/planner/RollupSelector.java ## @@ -57,47 +57,35 @@ public R

[GitHub] [incubator-doris] imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

2019-08-28 Thread GitBox
imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r318619645 ## File path: be/src/olap/rowset/beta_rowset_reader.cpp ## @@ -0,0 +1,111 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

2019-08-28 Thread GitBox
imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r318612462 ## File path: be/src/olap/rowset/beta_rowset.cpp ## @@ -40,19 +41,51 @@ OLAPStatus BetaRowset::init()

[GitHub] [incubator-doris] imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

2019-08-28 Thread GitBox
imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r318616210 ## File path: be/src/olap/rowset/beta_rowset_reader.cpp ## @@ -0,0 +1,111 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

2019-08-28 Thread GitBox
imay commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r318610737 ## File path: be/src/olap/rowset/alpha_rowset.cpp ## @@ -80,10 +82,9 @@ std::shared_ptr AlphaRowset::c

[GitHub] [incubator-doris] xy720 opened a new pull request #1719: Add english document for Doris official website

2019-08-28 Thread GitBox
xy720 opened a new pull request #1719: Add english document for Doris official website URL: https://github.com/apache/incubator-doris/pull/1719 1、Translated all documents except help documents with Baidu Translate Api 2、The Sphinx doctree has not been modified yet, I'll make it up in a l

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1720: fix delete bug

2019-08-28 Thread GitBox
kangpinghuang opened a new pull request #1720: fix delete bug URL: https://github.com/apache/incubator-doris/pull/1720 initialize the memory allocated for wrapper field variable content to 0, or it will lead to comparison bug. ---

[GitHub] [incubator-doris] chaoyli merged pull request #1720: fix delete bug

2019-08-28 Thread GitBox
chaoyli merged pull request #1720: fix delete bug URL: https://github.com/apache/incubator-doris/pull/1720 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-doris] kangkaisen opened a new pull request #1721: Make bitmap_union agg column support insert into

2019-08-28 Thread GitBox
kangkaisen opened a new pull request #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721 For https://github.com/apache/incubator-doris/pull/1610, make bitmap_union support insert into select. 1 Add a check for select * wit

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

2019-08-28 Thread GitBox
gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r318886759 ## File path: be/src/olap/rowset/alpha_rowset.cpp ## @@ -80,10 +82,9 @@ std::shared_ptr AlphaRowse

[GitHub] [incubator-doris] morningman merged pull request #1719: Add english document for Doris official website

2019-08-28 Thread GitBox
morningman merged pull request #1719: Add english document for Doris official website URL: https://github.com/apache/incubator-doris/pull/1719 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

2019-08-28 Thread GitBox
gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r318894947 ## File path: be/src/olap/rowset/beta_rowset_reader.cpp ## @@ -0,0 +1,111 @@ +// Licensed to the A

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

2019-08-28 Thread GitBox
gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r318898840 ## File path: be/src/olap/rowset/beta_rowset_reader.cpp ## @@ -0,0 +1,111 @@ +// Licensed to the A

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader

2019-08-28 Thread GitBox
gaodayue commented on a change in pull request #1718: Basic implementation for BetaRowsetReader URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r318894791 ## File path: be/src/olap/rowset/beta_rowset.cpp ## @@ -40,19 +41,51 @@ OLAPStatus BetaRowset::ini

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318911032 ## File path: be/src/olap/olap_define.h ## @@ -53,7 +53,7 @@ static constexpr uint32_t OLAP_COMPACTION

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318911786 ## File path: be/src/olap/rowset/unique_rowset_id_generator.cpp ## @@ -0,0 +1,50 @@ +// Licensed to the

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318911724 ## File path: be/test/olap/rowset/unique_rowset_id_generator_test.cpp ## @@ -0,0 +1,111 @@ +// Licensed

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318912372 ## File path: be/src/olap/rowset/segment_group.h ## @@ -48,11 +48,11 @@ namespace doris { class Segmen

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-28 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318912321 ## File path: be/src/olap/rowset/unique_rowset_id_generator.cpp ## @@ -0,0 +1,50 @@ +// Licensed to the

[GitHub] [incubator-doris] morningman opened a new pull request #1722: Use int64 when converting TIME type value

2019-08-29 Thread GitBox
morningman opened a new pull request #1722: Use int64 when converting TIME type value URL: https://github.com/apache/incubator-doris/pull/1722 TIME type value is saved in DOUBLE, so using int64 can extend the time range. Thi

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-29 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318914117 ## File path: be/src/olap/rowset/rowset_meta_manager.h ## @@ -31,20 +31,20 @@ namespace doris { // Hel

<    26   27   28   29   30   31   32   33   34   35   >