[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316638256 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -45,16 +47,21 @@ SegmentIterator::~Segm

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316638608 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -114,8 +124,51 @@ Status SegmentIterato

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316640552 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -114,8 +124,51 @@ Status SegmentIterato

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316644947 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -244,13 +297,41 @@ Status SegmentIterat

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316645858 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -156,18 +160,69 @@ Status ColumnReader::re

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316646454 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,303 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316646597 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,303 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316647781 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,303 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316652725 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -244,13 +297,41 @@ Status SegmentIterat

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316652932 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -244,13 +297,41 @@ Status SegmentIterat

[GitHub] [incubator-doris] kangkaisen opened a new pull request #1692: Minor, Update tablet-repair-and-balance doc

2019-08-22 Thread GitBox
kangkaisen opened a new pull request #1692: Minor, Update tablet-repair-and-balance doc URL: https://github.com/apache/incubator-doris/pull/1692 Minor, update tablet-repair-and-balance doc This is an automated message from th

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1693: Add config max_concurrent_task_num_per_be

2019-08-22 Thread GitBox
EmmyMiao87 opened a new pull request #1693: Add config max_concurrent_task_num_per_be URL: https://github.com/apache/incubator-doris/pull/1693 This config is used to control the max concurrent task num per be. The cluster max concurrent task num = max_concurrent_task_num_per_be * number

[GitHub] [incubator-doris] morningman commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-22 Thread GitBox
morningman commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r316677028 ## File path: fe/src/main/java/org/apache/doris/analysis/ShowTabletStmt.java ## @@ -68,6 +73,14 @@ public

[GitHub] [incubator-doris] imay merged pull request #1692: Minor, Update tablet-repair-and-balance doc

2019-08-22 Thread GitBox
imay merged pull request #1692: Minor, Update tablet-repair-and-balance doc URL: https://github.com/apache/incubator-doris/pull/1692 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] morningman commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
morningman commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316685404 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,283 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] morningman commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
morningman commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316684220 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,283 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316941521 ## File path: be/src/olap/rowset/segment_v2/ordinal_page_index.h ## @@ -97,10 +101,24 @@ class OrdinalPageInde

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316948465 ## File path: gensrc/proto/segment_v2.proto ## @@ -1,155 +1,162 @@ -// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316948518 ## File path: gensrc/proto/segment_v2.proto ## @@ -1,155 +1,162 @@ -// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316948190 ## File path: gensrc/proto/segment_v2.proto ## @@ -1,155 +1,162 @@ -// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316948315 ## File path: gensrc/proto/segment_v2.proto ## @@ -1,155 +1,162 @@ -// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316948796 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,283 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316948233 ## File path: gensrc/proto/segment_v2.proto ## @@ -1,155 +1,162 @@ -// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316943418 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_MASK =

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316944253 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_MASK =

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316949798 ## File path: be/src/olap/schema.cpp ## @@ -37,41 +37,53 @@ void Schema::copy_from(const Schema& other) { _col_

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316950191 ## File path: be/src/olap/schema.cpp ## @@ -37,41 +37,53 @@ void Schema::copy_from(const Schema& other) { _col_

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316942512 ## File path: docs/documentation/cn/sql-reference/sql-functions/aggregate-functions/bitmap.md ## @@ -0,0 +1,77 @@ +

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316943638 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_MASK =

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316945911 ## File path: fe/src/main/java/org/apache/doris/analysis/AggregateInfoBase.java ## @@ -150,6 +150,7 @@ private Tuple

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316943517 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_MASK =

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316948274 ## File path: be/src/olap/row_cursor.cpp ## @@ -184,30 +178,11 @@ OLAPStatus RowCursor::allocate_memory_for_string_

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316943782 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_MASK =

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316945182 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_MASK =

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316945672 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java ## @@ -536,6 +536,18 @@ private void

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316944752 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_MASK =

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316945733 ## File path: fe/src/main/java/org/apache/doris/catalog/Type.java ## @@ -213,6 +213,11 @@ public boolean isIntegerTy

[GitHub] [incubator-doris] kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-22 Thread GitBox
kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-524146905 Why bitmap index should be seperated from data file? Is there any situation where change index without changing dat

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316956631 ## File path: be/src/olap/wrapper_field.cpp ## @@ -37,6 +39,9 @@ WrapperField* WrapperField::create(const TabletColumn&

[GitHub] [incubator-doris] imay commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
imay commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316957003 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,100 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] imay merged pull request #1685: Add error msg when memory limit exceeded

2019-08-22 Thread GitBox
imay merged pull request #1685: Add error msg when memory limit exceeded URL: https://github.com/apache/incubator-doris/pull/1685 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316961659 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,283 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316961690 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,283 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316962347 ## File path: gensrc/proto/segment_v2.proto ## @@ -1,155 +1,162 @@ -// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316962352 ## File path: gensrc/proto/segment_v2.proto ## @@ -1,155 +1,162 @@ -// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316962422 ## File path: gensrc/proto/segment_v2.proto ## @@ -1,155 +1,162 @@ -// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316962499 ## File path: gensrc/proto/segment_v2.proto ## @@ -1,155 +1,162 @@ -// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316962469 ## File path: gensrc/proto/segment_v2.proto ## @@ -1,155 +1,162 @@ -// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316962512 ## File path: be/src/olap/rowset/segment_v2/row_ranges.h ## @@ -0,0 +1,283 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316962701 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,100 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-22 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r316962776 ## File path: be/src/olap/wrapper_field.cpp ## @@ -37,6 +39,9 @@ WrapperField* WrapperField::create(const Tabl

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316963886 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316963898 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316963970 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316963918 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316963936 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316964016 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316964030 ## File path: be/src/util/bitmap.h ## @@ -248,6 +250,144 @@ class Bitmap { static const int64_t BIT_INDEX_

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316964178 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java ## @@ -536,6 +536,18 @@ privat

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316964218 ## File path: fe/src/main/java/org/apache/doris/analysis/AggregateInfoBase.java ## @@ -150,6 +150,7 @@ privat

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316964191 ## File path: fe/src/main/java/org/apache/doris/catalog/Type.java ## @@ -213,6 +213,11 @@ public boolean isIn

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316964309 ## File path: be/src/olap/row_cursor.cpp ## @@ -184,30 +178,11 @@ OLAPStatus RowCursor::allocate_memory_for_

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316964490 ## File path: be/src/olap/schema.cpp ## @@ -37,41 +37,53 @@ void Schema::copy_from(const Schema& other) {

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316965331 ## File path: be/src/olap/schema.cpp ## @@ -37,41 +37,53 @@ void Schema::copy_from(const Schema& other) {

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316965331 ## File path: be/src/olap/schema.cpp ## @@ -37,41 +37,53 @@ void Schema::copy_from(const Schema& other) {

[GitHub] [incubator-doris] kangkaisen commented on issue #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on issue #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#issuecomment-524174380 Update for @imay comment. This is an automated message from the Apache Git Servi

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-22 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316976118 ## File path: be/src/olap/schema.cpp ## @@ -37,41 +37,53 @@ void Schema::copy_from(const Schema& other) {

[GitHub] [incubator-doris] wangbo opened a new pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-22 Thread GitBox
wangbo opened a new pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] kangkaisen commented on issue #1610: Add bitmap agg type and udaf

2019-08-23 Thread GitBox
kangkaisen commented on issue #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#issuecomment-524201201 Rebase the code and Fix UT. This is an automated message from the Apache Git Ser

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r316997548 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,21 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r316997325 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,21 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317002096 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -144,23 +141,16 @@ class Bi

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317003652 ## File path: be/src/util/faststring.h ## @@ -223,6 +223,10 @@ class faststring {

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r31604 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -224,8 +214,8 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r316998255 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,21 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r316993643 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,21 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r316998733 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -120,8 +117,8 @@ class Bina

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317008129 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,21 @@ class Binary

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317009430 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -120,8 +117,8 @@ class Binary

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317009469 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,21 @@ class Binary

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317009553 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -224,8 +214,8 @@ class Binary

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317009878 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -144,23 +141,16 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317010494 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,21 @@ class Bina

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317010870 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,21 @@ class Binary

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317011053 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,21 @@ class Binary

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317011861 ## File path: be/src/util/faststring.h ## @@ -223,6 +223,10 @@ class faststring {

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317058442 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,21 @@ class Binary

[GitHub] [incubator-doris] morningman opened a new pull request #1695: Refactor alter job

2019-08-23 Thread GitBox
morningman opened a new pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695 ISSUE #1613 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] morningman commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
morningman commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317160656 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,29 @@ class Bi

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317168559 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,29 @@ class Binary

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317168559 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,29 @@ class Binary

[GitHub] [incubator-doris] imay merged pull request #1693: Add config max_concurrent_task_num_per_be

2019-08-23 Thread GitBox
imay merged pull request #1693: Add config max_concurrent_task_num_per_be URL: https://github.com/apache/incubator-doris/pull/1693 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] imay merged pull request #1633: add zone map page(#1390)

2019-08-23 Thread GitBox
imay merged pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-23 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r317221911 ## File path: be/src/olap/row_cursor.cpp ## @@ -180,7 +180,7 @@ OLAPStatus RowCursor::allocate_memory_for_string_ty

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-23 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r317222329 ## File path: be/src/olap/field.h ## @@ -400,6 +400,11 @@ class BitmapAggField: public Field { _agg_info->i

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-23 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317336084 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -80,24 +80,21 @@ class Bina

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-23 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r317344492 ## File path: be/src/olap/row_cursor.cpp ## @@ -180,7 +180,7 @@ OLAPStatus RowCursor::allocate_memory_for_st

[GitHub] [incubator-doris] wutiangan opened a new issue #1696: multi sum distianct need return null, not zero

2019-08-24 Thread GitBox
wutiangan opened a new issue #1696: multi sum distianct need return null, not zero URL: https://github.com/apache/incubator-doris/issues/1696 mysql> select sum(distinct id), sum(distinct int_col) from alltypesagg; ++-+ | sum(DISTINC

[GitHub] [incubator-doris] morningman closed issue #1689: Concurrent stream/mini load request may both be committed successfully

2019-08-24 Thread GitBox
morningman closed issue #1689: Concurrent stream/mini load request may both be committed successfully URL: https://github.com/apache/incubator-doris/issues/1689 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-doris] gaodayue opened a new pull request #1698: refactor RowsetReaderContext

2019-08-25 Thread GitBox
gaodayue opened a new pull request #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698 This PR refactors RowsetReaderContext and adds more comments to help developers understand the read path. Tha main changes are - move index stream ca

<    24   25   26   27   28   29   30   31   32   33   >