[GitHub] [incubator-doris] imay opened a new pull request #1579: Switch MAKE_TEST off in build.sh

2019-08-03 Thread GitBox
imay opened a new pull request #1579: Switch MAKE_TEST off in build.sh URL: https://github.com/apache/incubator-doris/pull/1579 #1578 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] imay merged pull request #1579: Switch MAKE_TEST off in build.sh

2019-08-03 Thread GitBox
imay merged pull request #1579: Switch MAKE_TEST off in build.sh URL: https://github.com/apache/incubator-doris/pull/1579 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-doris] imay merged pull request #1575: Thrown TabletQuorumFailedException in commitTxn

2019-08-04 Thread GitBox
imay merged pull request #1575: Thrown TabletQuorumFailedException in commitTxn URL: https://github.com/apache/incubator-doris/pull/1575 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-doris] imay commented on a change in pull request #1574: Support multi partition column when creating table

2019-08-04 Thread GitBox
imay commented on a change in pull request #1574: Support multi partition column when creating table URL: https://github.com/apache/incubator-doris/pull/1574#discussion_r310384428 ## File path: be/src/exec/tablet_info.h ## @@ -114,16 +115,23 @@ class OlapTablePartKeyCompa

[GitHub] [incubator-doris] imay commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-04 Thread GitBox
imay commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310385429 ## File path: be/src/olap/base_compaction.h ## @@ -32,152 +33,45 @@ namespace

[GitHub] [incubator-doris] morningman opened a new issue #1580: Load failed when cluster balacing

2019-08-04 Thread GitBox
morningman opened a new issue #1580: Load failed when cluster balacing URL: https://github.com/apache/incubator-doris/issues/1580 **Describe the bug** When cluster is doing balance, load process's failure possibility is increasing. Error message shows " tablet has few replicas" or

[GitHub] [incubator-doris] morningman opened a new pull request #1581: Fix bug that cluster balance may cause load job failed

2019-08-04 Thread GitBox
morningman opened a new pull request #1581: Fix bug that cluster balance may cause load job failed URL: https://github.com/apache/incubator-doris/pull/1581 The bug is described in issue #1580 . And this patch will fix 2 cases of cluster balance 1. After finish adding the new replica

[GitHub] [incubator-doris] yuanlihan commented on issue #1569: Enable Partition Discovery for Broker Load

2019-08-04 Thread GitBox
yuanlihan commented on issue #1569: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/pull/1569#issuecomment-518015880 Add Partition Discover as a feature of Broker Load. For usage of this feature see diffs of related docs.

[GitHub] [incubator-doris] imay commented on a change in pull request #1568: initial implementation of BetaRowset

2019-08-04 Thread GitBox
imay commented on a change in pull request #1568: initial implementation of BetaRowset URL: https://github.com/apache/incubator-doris/pull/1568#discussion_r310387276 ## File path: gensrc/proto/olap_file.proto ## @@ -76,25 +76,26 @@ message RowsetMetaPB { required int6

[GitHub] [incubator-doris] imay commented on a change in pull request #1568: initial implementation of BetaRowset

2019-08-04 Thread GitBox
imay commented on a change in pull request #1568: initial implementation of BetaRowset URL: https://github.com/apache/incubator-doris/pull/1568#discussion_r310387212 ## File path: be/src/olap/rowset/rowset.h ## @@ -83,40 +97,47 @@ class Rowset : public std::enable_shared_f

[GitHub] [incubator-doris] morningman commented on a change in pull request #1566: Add switch for cost optimization

2019-08-04 Thread GitBox
morningman commented on a change in pull request #1566: Add switch for cost optimization URL: https://github.com/apache/incubator-doris/pull/1566#discussion_r310417280 ## File path: fe/src/main/java/org/apache/doris/analysis/SelectStmt.java ## @@ -379,8 +379,17 @@ public v

[GitHub] [incubator-doris] morningman commented on a change in pull request #1566: Add switch for cost optimization

2019-08-04 Thread GitBox
morningman commented on a change in pull request #1566: Add switch for cost optimization URL: https://github.com/apache/incubator-doris/pull/1566#discussion_r310417432 ## File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java ## @@ -192,6 +193,9 @@ @Vari

[GitHub] [incubator-doris] imay commented on a change in pull request #1569: Enable Partition Discovery for Broker Load

2019-08-04 Thread GitBox
imay commented on a change in pull request #1569: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/pull/1569#discussion_r310419374 ## File path: docs/help/Contents/Data Manipulation/broker_load.md ## @@ -352,15 +357,47 @@ )

[GitHub] [incubator-doris] imay commented on a change in pull request #1569: Enable Partition Discovery for Broker Load

2019-08-04 Thread GitBox
imay commented on a change in pull request #1569: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/pull/1569#discussion_r310419097 ## File path: docs/help/Contents/Data Manipulation/broker_load.md ## @@ -352,15 +357,47 @@ )

[GitHub] [incubator-doris] imay commented on a change in pull request #1569: Enable Partition Discovery for Broker Load

2019-08-04 Thread GitBox
imay commented on a change in pull request #1569: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/pull/1569#discussion_r310419733 ## File path: docs/help/Contents/Data Manipulation/broker_load.md ## @@ -352,15 +357,47 @@ )

[GitHub] [incubator-doris] imay commented on issue #1569: Enable Partition Discovery for Broker Load

2019-08-04 Thread GitBox
imay commented on issue #1569: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/pull/1569#issuecomment-518060800 > Add Partition Discover as a feature of Broker Load. > > For usage of this feature see diffs of related docs. @yuanlihan

[GitHub] [incubator-doris] kangpinghuang closed pull request #1196: optimize meta tool

2019-08-04 Thread GitBox
kangpinghuang closed pull request #1196: optimize meta tool URL: https://github.com/apache/incubator-doris/pull/1196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] yuanlihan commented on issue #1569: Enable Partition Discovery for Broker Load

2019-08-04 Thread GitBox
yuanlihan commented on issue #1569: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/pull/1569#issuecomment-518063159 > > Add Partition Discover as a feature of Broker Load. > > For usage of this feature see diffs of related docs. > > @yuanl

[GitHub] [incubator-doris] imay commented on a change in pull request #1566: Add switch for cost optimization

2019-08-04 Thread GitBox
imay commented on a change in pull request #1566: Add switch for cost optimization URL: https://github.com/apache/incubator-doris/pull/1566#discussion_r310421799 ## File path: fe/src/main/java/org/apache/doris/analysis/SelectStmt.java ## @@ -379,8 +379,17 @@ public void an

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1566: Add switch for cost optimization

2019-08-04 Thread GitBox
EmmyMiao87 commented on a change in pull request #1566: Add switch for cost optimization URL: https://github.com/apache/incubator-doris/pull/1566#discussion_r310422337 ## File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java ## @@ -287,59 +287,73 @@

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-04 Thread GitBox
yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310426546 ## File path: be/src/olap/base_compaction.cpp ## @@ -40,487 +39,264 @@ us

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-04 Thread GitBox
yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310427114 ## File path: be/src/olap/base_compaction.cpp ## @@ -40,487 +39,264 @@ us

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-04 Thread GitBox
yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310427251 ## File path: be/src/olap/base_compaction.cpp ## @@ -40,487 +39,264 @@ us

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-04 Thread GitBox
yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310428885 ## File path: be/src/olap/base_compaction.cpp ## @@ -40,487 +39,264 @@ us

[GitHub] [incubator-doris] yuanlihan opened a new issue #1582: Enable Partition Discovery for Broker Load

2019-08-04 Thread GitBox
yuanlihan opened a new issue #1582: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/issues/1582 **Can not parse partitioned columns and can not recursively list files when using Broker Load** When users try to load data from hdfs files writte

[GitHub] [incubator-doris] yuanlihan commented on issue #1569: Enable Partition Discovery for Broker Load

2019-08-04 Thread GitBox
yuanlihan commented on issue #1569: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/pull/1569#issuecomment-518075283 @imay I have added an issue about this [Enable Partition Discovery for Broker Load](https://github.com/apache/incubator-doris/issues

[GitHub] [incubator-doris] HangyuanLiu opened a new issue #1583: Support multiple time zone

2019-08-04 Thread GitBox
HangyuanLiu opened a new issue #1583: Support multiple time zone URL: https://github.com/apache/incubator-doris/issues/1583 **Is your feature request related to a problem? Please describe.** Support multiple time zone **Solution:** 1. Setting of time zone related parameters:

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310421963 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,259 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310424835 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,259 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310379840 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,191 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310420328 ## File path: be/src/olap/iterators.h ## @@ -21,10 +21,27 @@ namespace doris { +class RowCursor; class

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310435405 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,191 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310382403 ## File path: gensrc/proto/segment_v2.proto ## @@ -117,3 +121,39 @@ message FileFooterPB { repeated Meta

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310382189 ## File path: gensrc/proto/segment_v2.proto ## @@ -117,3 +121,39 @@ message FileFooterPB { repeated Meta

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310380914 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,191 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310380611 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,191 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310432065 ## File path: be/test/olap/rowset/segment_v2/segment_test.cpp ## @@ -0,0 +1,259 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310420328 ## File path: be/src/olap/iterators.h ## @@ -21,10 +21,27 @@ namespace doris { +class RowCursor; class

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1568: initial implementation of BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1568: initial implementation of BetaRowset URL: https://github.com/apache/incubator-doris/pull/1568#discussion_r310439423 ## File path: be/src/olap/rowset/rowset.h ## @@ -83,40 +97,47 @@ class Rowset : public std::enable_shar

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1568: initial implementation of BetaRowset

2019-08-04 Thread GitBox
gaodayue commented on a change in pull request #1568: initial implementation of BetaRowset URL: https://github.com/apache/incubator-doris/pull/1568#discussion_r310439466 ## File path: gensrc/proto/olap_file.proto ## @@ -76,25 +76,26 @@ message RowsetMetaPB { required

[GitHub] [incubator-doris] morningman opened a new issue #1584: Load job always fail after cancel a rollup job

2019-08-04 Thread GitBox
morningman opened a new issue #1584: Load job always fail after cancel a rollup job URL: https://github.com/apache/incubator-doris/issues/1584 **Describe the bug** Error happen when commit txn on FE: could not find table for tablet . **To Reproduce** This may happen when us

[GitHub] [incubator-doris] morningman opened a new pull request #1585: Fix bug that unable to delete replica if version is missing

2019-08-04 Thread GitBox
morningman opened a new pull request #1585: Fix bug that unable to delete replica if version is missing URL: https://github.com/apache/incubator-doris/pull/1585 If there is a redundant replica on BE which version is missing, the tablet report logic can not drop it correctly. ISSUE

[GitHub] [incubator-doris] imay commented on issue #1572: Add new format short key index

2019-08-04 Thread GitBox
imay commented on issue #1572: Add new format short key index URL: https://github.com/apache/incubator-doris/pull/1572#issuecomment-518099531 Close this PR, because this patch is contained in #1577 This is an automated messag

[GitHub] [incubator-doris] imay closed pull request #1572: Add new format short key index

2019-08-04 Thread GitBox
imay closed pull request #1572: Add new format short key index URL: https://github.com/apache/incubator-doris/pull/1572 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310450633 ## File path: be/src/olap/iterators.h ## @@ -21,10 +21,27 @@ namespace doris { +class RowCursor; class RowBl

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310450904 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,259 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310451747 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,259 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310452080 ## File path: be/test/olap/rowset/segment_v2/segment_test.cpp ## @@ -0,0 +1,259 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310452309 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,191 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310452664 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,191 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310452760 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,191 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310452975 ## File path: gensrc/proto/segment_v2.proto ## @@ -117,3 +121,39 @@ message FileFooterPB { repeated MetadataP

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-04 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310453621 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,191 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-04 Thread GitBox
yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310457893 ## File path: be/src/olap/base_compaction.cpp ## @@ -40,487 +39,264 @@ us

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-04 Thread GitBox
yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310458254 ## File path: be/src/olap/cumulative_compaction.cpp ## @@ -32,356 +32,121

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-05 Thread GitBox
yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310462451 ## File path: be/src/olap/cumulative_compaction.cpp ## @@ -32,356 +32,121

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310463498 ## File path: gensrc/proto/segment_v2.proto ## @@ -117,3 +121,39 @@ message FileFooterPB { repeated MetadataP

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-05 Thread GitBox
yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310463734 ## File path: be/src/olap/tablet.cpp ## @@ -736,6 +749,32 @@ OLAPStatus

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-05 Thread GitBox
yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310463898 ## File path: be/src/olap/tablet.cpp ## @@ -736,6 +749,32 @@ OLAPStatus

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-05 Thread GitBox
yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310465133 ## File path: be/src/olap/tablet.cpp ## @@ -933,4 +972,20 @@ OLAPStatus T

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-05 Thread GitBox
yiguolei commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310465850 ## File path: be/src/olap/base_compaction.cpp ## @@ -40,487 +39,264 @@ us

[GitHub] [incubator-doris] imay closed pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
imay closed pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-doris] imay opened a new pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
imay opened a new pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310476220 ## File path: be/test/olap/rowset/segment_v2/segment_test.cpp ## @@ -0,0 +1,259 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1568: initial implementation of BetaRowset

2019-08-05 Thread GitBox
kangpinghuang commented on a change in pull request #1568: initial implementation of BetaRowset URL: https://github.com/apache/incubator-doris/pull/1568#discussion_r310479122 ## File path: be/src/olap/rowset/beta_rowset.cpp ## @@ -0,0 +1,125 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1568: initial implementation of BetaRowset

2019-08-05 Thread GitBox
kangpinghuang commented on a change in pull request #1568: initial implementation of BetaRowset URL: https://github.com/apache/incubator-doris/pull/1568#discussion_r310474527 ## File path: be/src/olap/rowset/beta_rowset.cpp ## @@ -0,0 +1,125 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1568: initial implementation of BetaRowset

2019-08-05 Thread GitBox
kangpinghuang commented on a change in pull request #1568: initial implementation of BetaRowset URL: https://github.com/apache/incubator-doris/pull/1568#discussion_r310474380 ## File path: be/src/olap/rowset/beta_rowset.h ## @@ -0,0 +1,69 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] imay commented on issue #1582: Enable Partition Discovery for Broker Load

2019-08-05 Thread GitBox
imay commented on issue #1582: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/issues/1582#issuecomment-518130510 @yuanlihan I prefer first option. However I think there should be some change in your version. 1. we can still use `INF

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
gaodayue commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310482405 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,259 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310483722 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,259 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay merged pull request #1574: Support multi partition column when creating table

2019-08-05 Thread GitBox
imay merged pull request #1574: Support multi partition column when creating table URL: https://github.com/apache/incubator-doris/pull/1574 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-doris] imay merged pull request #1585: Fix bug that unable to delete replica if version is missing

2019-08-05 Thread GitBox
imay merged pull request #1585: Fix bug that unable to delete replica if version is missing URL: https://github.com/apache/incubator-doris/pull/1585 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1568: initial implementation of BetaRowset

2019-08-05 Thread GitBox
gaodayue commented on a change in pull request #1568: initial implementation of BetaRowset URL: https://github.com/apache/incubator-doris/pull/1568#discussion_r310493069 ## File path: be/src/olap/rowset/beta_rowset.cpp ## @@ -0,0 +1,125 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] imay commented on issue #1583: Support multiple time zone

2019-08-05 Thread GitBox
imay commented on issue #1583: Support multiple time zone URL: https://github.com/apache/incubator-doris/issues/1583#issuecomment-518148947 @HangyuanLiu I have a question. How can we get `system_time_zone`? How to keep the values on each node consistent. And I think this can

[GitHub] [incubator-doris] yuanlihan commented on issue #1582: Enable Partition Discovery for Broker Load

2019-08-05 Thread GitBox
yuanlihan commented on issue #1582: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/issues/1582#issuecomment-518150837 > @yuanlihan > > I prefer first option. However I think there should be some change in your version. > > 1. we can

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

2019-08-05 Thread GitBox
chaoyli commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r310505634 ## File path: be/src/olap/base_compaction.cpp ## @@ -40,487 +39,264 @@ usi

[GitHub] [incubator-doris] xy720 opened a new pull request #1586: Help document collation (integration of help and documentation documents)

2019-08-05 Thread GitBox
xy720 opened a new pull request #1586: Help document collation (integration of help and documentation documents) URL: https://github.com/apache/incubator-doris/pull/1586 1.Merges help and documentation folder 2.Adds 3 bash shell script to docs folder, they can 1).Separate documents b

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
kangpinghuang commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310489881 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,120 @@ +// Licensed to the Apache So

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
kangpinghuang commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310495981 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,172 @@ +// Licensed to the

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
kangpinghuang commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310493582 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,172 @@ +// Licensed to the

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
kangpinghuang commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310516447 ## File path: be/src/olap/storage_engine.h ## @@ -53,6 +52,7 @@ namespace doris { class Tablet; class

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
kangpinghuang commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310490040 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,120 @@ +// Licensed to the Apache So

[GitHub] [incubator-doris] HangyuanLiu commented on issue #1583: Support multiple time zone

2019-08-05 Thread GitBox
HangyuanLiu commented on issue #1583: Support multiple time zone URL: https://github.com/apache/incubator-doris/issues/1583#issuecomment-518190409 @imay I think system_time_zone is a parameter that represents the time zone of the machine, but the other variable "time_zone" is really ta

[GitHub] [incubator-doris] Youngwb opened a new pull request #1587: Set timezone variable in fe

2019-08-05 Thread GitBox
Youngwb opened a new pull request #1587: Set timezone variable in fe URL: https://github.com/apache/incubator-doris/pull/1587 This is part of support multiple time zone(Issue #1583 ), it just set the timezone variable in fe. something to notice: - systemTimeZone use system default tim

[GitHub] [incubator-doris] imay commented on issue #1582: Enable Partition Discovery for Broker Load

2019-08-05 Thread GitBox
imay commented on issue #1582: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/issues/1582#issuecomment-518195556 > > @yuanlihan > > I prefer first option. However I think there should be some change in your version. > > > > 1. we can sti

[GitHub] [incubator-doris] imay edited a comment on issue #1582: Enable Partition Discovery for Broker Load

2019-08-05 Thread GitBox
imay edited a comment on issue #1582: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/issues/1582#issuecomment-518195556 > > @yuanlihan > > I prefer first option. However I think there should be some change in your version. > > > > 1. we

[GitHub] [incubator-doris] imay commented on a change in pull request #1586: Help document collation (integration of help and documentation documents)

2019-08-05 Thread GitBox
imay commented on a change in pull request #1586: Help document collation (integration of help and documentation documents) URL: https://github.com/apache/incubator-doris/pull/1586#discussion_r310565512 ## File path: docs/documentation/cn/sql-reference/sql-statements/Utility/util_s

[GitHub] [incubator-doris] imay commented on a change in pull request #1586: Help document collation (integration of help and documentation documents)

2019-08-05 Thread GitBox
imay commented on a change in pull request #1586: Help document collation (integration of help and documentation documents) URL: https://github.com/apache/incubator-doris/pull/1586#discussion_r310566145 ## File path: docs/script/split.sh ## @@ -0,0 +1,73 @@ +#!/bin/bash +#

[GitHub] [incubator-doris] imay commented on a change in pull request #1586: Help document collation (integration of help and documentation documents)

2019-08-05 Thread GitBox
imay commented on a change in pull request #1586: Help document collation (integration of help and documentation documents) URL: https://github.com/apache/incubator-doris/pull/1586#discussion_r310566208 ## File path: docs/script/merge.sh ## @@ -0,0 +1,164 @@ +#!/bin/bash +

[GitHub] [incubator-doris] imay commented on a change in pull request #1586: Help document collation (integration of help and documentation documents)

2019-08-05 Thread GitBox
imay commented on a change in pull request #1586: Help document collation (integration of help and documentation documents) URL: https://github.com/apache/incubator-doris/pull/1586#discussion_r310566405 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulat

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1587: Set timezone variable in fe

2019-08-05 Thread GitBox
HangyuanLiu commented on a change in pull request #1587: Set timezone variable in fe URL: https://github.com/apache/incubator-doris/pull/1587#discussion_r310568646 ## File path: fe/src/main/java/org/apache/doris/qe/VariableMgr.java ## @@ -211,6 +244,12 @@ public static voi

[GitHub] [incubator-doris] imay commented on a change in pull request #1587: Set timezone variable in fe

2019-08-05 Thread GitBox
imay commented on a change in pull request #1587: Set timezone variable in fe URL: https://github.com/apache/incubator-doris/pull/1587#discussion_r310593135 ## File path: fe/src/main/java/org/apache/doris/qe/VariableMgr.java ## @@ -203,6 +209,33 @@ private static void check

[GitHub] [incubator-doris] imay commented on a change in pull request #1587: Set timezone variable in fe

2019-08-05 Thread GitBox
imay commented on a change in pull request #1587: Set timezone variable in fe URL: https://github.com/apache/incubator-doris/pull/1587#discussion_r310588284 ## File path: fe/src/main/java/org/apache/doris/qe/VariableMgr.java ## @@ -203,6 +209,33 @@ private static void check

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310598380 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,120 @@ +// Licensed to the Apache Software Fou

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310598739 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,172 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310601244 ## File path: be/src/olap/storage_engine.h ## @@ -53,6 +52,7 @@ namespace doris { class Tablet; class DataDir;

[GitHub] [incubator-doris] imay commented on a change in pull request #1577: Support Segment for BetaRowset

2019-08-05 Thread GitBox
imay commented on a change in pull request #1577: Support Segment for BetaRowset URL: https://github.com/apache/incubator-doris/pull/1577#discussion_r310601871 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,172 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay closed issue #1578: Compile BE with right MACRO after run-ut.sh

2019-08-05 Thread GitBox
imay closed issue #1578: Compile BE with right MACRO after run-ut.sh URL: https://github.com/apache/incubator-doris/issues/1578 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1566: Add switch for cost optimization

2019-08-05 Thread GitBox
chenhao7253886 commented on a change in pull request #1566: Add switch for cost optimization URL: https://github.com/apache/incubator-doris/pull/1566#discussion_r310653200 ## File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java ## @@ -287,59 +287,73

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1566: Add switch for cost optimization

2019-08-05 Thread GitBox
chenhao7253886 commented on a change in pull request #1566: Add switch for cost optimization URL: https://github.com/apache/incubator-doris/pull/1566#discussion_r310653369 ## File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java ## @@ -192,6 +193,9 @@ @

<    16   17   18   19   20   21   22   23   24   25   >