[GitHub] [incubator-doris] imay commented on a change in pull request #1522: Support setting replica status as bad manually

2019-07-21 Thread GitBox
imay commented on a change in pull request #1522: Support setting replica status as bad manually URL: https://github.com/apache/incubator-doris/pull/1522#discussion_r305623714 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -6139,5 +6140,47 @@ pu

[GitHub] [incubator-doris] imay commented on a change in pull request #1522: Support setting replica status as bad manually

2019-07-21 Thread GitBox
imay commented on a change in pull request #1522: Support setting replica status as bad manually URL: https://github.com/apache/incubator-doris/pull/1522#discussion_r305623295 ## File path: fe/src/main/java/org/apache/doris/analysis/AdminSetReplicaStatusStmt.java ## @@ -0

[GitHub] [incubator-doris] morningman closed issue #1440: non-sense segment is been generated

2019-07-21 Thread GitBox
morningman closed issue #1440: non-sense segment is been generated URL: https://github.com/apache/incubator-doris/issues/1440 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305649806 ## File path: be/src/olap/iterators.h ## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305649917 ## File path: be/src/olap/generic_iterators.h ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305649853 ## File path: be/src/olap/iterators.h ## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650025 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305649997 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650222 ## File path: be/src/olap/row_block2.h ## @@ -0,0 +1,110 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650191 ## File path: be/src/olap/row_block2.cpp ## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation (ASF) u

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650455 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650529 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650627 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay merged pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
imay merged pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
gaodayue commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305687268 ## File path: be/src/olap/row_block2.h ## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation (ASF

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
gaodayue commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305679199 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
gaodayue commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305669471 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
gaodayue commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305679231 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] wuyunfeng opened a new issue #1525: Expose data pruned-filter-scan ability for Integrating Spark and Doris

2019-07-22 Thread GitBox
wuyunfeng opened a new issue #1525: Expose data pruned-filter-scan ability for Integrating Spark and Doris URL: https://github.com/apache/incubator-doris/issues/1525 ### Background 1. Recently years, Machine Learning intensively are integrated to computing system such as Spark MLib fo

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-22 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305700627 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-22 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305700583 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-22 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305701273 ## File path: be/src/olap/row_block2.h ## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-22 Thread GitBox
imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305702566 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1505: Add timediff function

2019-07-22 Thread GitBox
imay commented on a change in pull request #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505#discussion_r305703865 ## File path: be/src/exprs/literal.cpp ## @@ -87,6 +87,11 @@ Literal::Literal(const TExprNode& node) : _value.date

[GitHub] [incubator-doris] imay commented on a change in pull request #1505: Add timediff function

2019-07-22 Thread GitBox
imay commented on a change in pull request #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505#discussion_r305705377 ## File path: be/src/runtime/result_writer.cpp ## @@ -104,6 +104,39 @@ Status ResultWriter::add_one_row(TupleRow* row) {

[GitHub] [incubator-doris] imay commented on a change in pull request #1505: Add timediff function

2019-07-22 Thread GitBox
imay commented on a change in pull request #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505#discussion_r305705198 ## File path: be/src/runtime/raw_value.cpp ## @@ -267,6 +267,7 @@ void RawValue::write(const void* value, void* dst, const

[GitHub] [incubator-doris] imay commented on a change in pull request #1505: Add timediff function

2019-07-22 Thread GitBox
imay commented on a change in pull request #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505#discussion_r305704769 ## File path: be/src/exprs/time_operators.h ## @@ -0,0 +1,48 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-doris] imay commented on a change in pull request #1505: Add timediff function

2019-07-22 Thread GitBox
imay commented on a change in pull request #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505#discussion_r305705811 ## File path: fe/src/main/java/org/apache/doris/catalog/Function.java ## @@ -480,6 +481,7 @@ public static String getUdfTyp

[GitHub] [incubator-doris] imay commented on a change in pull request #1505: Add timediff function

2019-07-22 Thread GitBox
imay commented on a change in pull request #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505#discussion_r305707087 ## File path: fe/src/main/java/org/apache/doris/catalog/PrimitiveType.java ## @@ -480,6 +486,7 @@ public static boolean isI

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1526: Add spark-doris-connector overview

2019-07-22 Thread GitBox
wuyunfeng opened a new pull request #1526: Add spark-doris-connector overview URL: https://github.com/apache/incubator-doris/pull/1526 spark-doris-connector architecture overview This is an automated message from the Apache Gi

[GitHub] [incubator-doris] wuyunfeng commented on issue #1526: Add spark-doris-connector overview

2019-07-22 Thread GitBox
wuyunfeng commented on issue #1526: Add spark-doris-connector overview URL: https://github.com/apache/incubator-doris/pull/1526#issuecomment-513680135 [architecture](https://github.com/apache/incubator-doris/issues/1525) This

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1527: Expose data pruned-filter-scan ability

2019-07-22 Thread GitBox
wuyunfeng opened a new pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527 This PR is related with [Spark-Doris-Connector](https://github.com/apache/incubator-doris/issues/1525). The First Step is Expose data pruned-fi

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-22 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305778667 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-22 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305779712 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-22 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305781309 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] wuyunfeng closed pull request #1527: Expose data pruned-filter-scan ability

2019-07-22 Thread GitBox
wuyunfeng closed pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1527: Expose data pruned-filter-scan ability

2019-07-22 Thread GitBox
wuyunfeng opened a new pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527 This PR is related with [Spark-Doris-Connector](https://github.com/apache/incubator-doris/issues/1525). The First Step is Expose data pruned-fi

[GitHub] [incubator-doris] morningman opened a new pull request #1528: Fix bug that user with LOAD_PRIV can see load job by SHOW LOAD stmt

2019-07-22 Thread GitBox
morningman opened a new pull request #1528: Fix bug that user with LOAD_PRIV can see load job by SHOW LOAD stmt URL: https://github.com/apache/incubator-doris/pull/1528 User should has LOAD_PRIV to use SHOW LOAD stmt, not SHOW_PRIV. -

[GitHub] [incubator-doris] imay closed pull request #1413: Add short key index builder, decoder, iterator

2019-07-22 Thread GitBox
imay closed pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] imay merged pull request #1528: Fix bug that user with LOAD_PRIV can see load job by SHOW LOAD stmt

2019-07-22 Thread GitBox
imay merged pull request #1528: Fix bug that user with LOAD_PRIV can see load job by SHOW LOAD stmt URL: https://github.com/apache/incubator-doris/pull/1528 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-doris] imay opened a new pull request #1529: Refactor agg

2019-07-22 Thread GitBox
imay opened a new pull request #1529: Refactor agg URL: https://github.com/apache/incubator-doris/pull/1529 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-22 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306099633 ## File path: be/src/olap/rowset/segment_v2/bitshuffle_page.h ## @@ -170,11 +148,11 @@ class BitshufflePageBuilder : public Pag

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1497: Add ALTER_TABLET task in be

2019-07-22 Thread GitBox
yiguolei commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r306106519 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external_s

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1497: Add ALTER_TABLET task in be

2019-07-22 Thread GitBox
yiguolei commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r306107406 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external_s

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1497: Add ALTER_TABLET task in be

2019-07-22 Thread GitBox
yiguolei commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r306107360 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external_s

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1497: Add ALTER_TABLET task in be

2019-07-22 Thread GitBox
yiguolei commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r306107791 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external_s

[GitHub] [incubator-doris] imay merged pull request #1505: Add timediff function

2019-07-22 Thread GitBox
imay merged pull request #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] morningman opened a new pull request #1530: Add more logs and metrics to trace the broker load process

2019-07-22 Thread GitBox
morningman opened a new pull request #1530: Add more logs and metrics to trace the broker load process URL: https://github.com/apache/incubator-doris/pull/1530 1. The Operator wants to known when the job being scheduled as PENDING and LOADING. And how long it takes to finish these sub st

[GitHub] [incubator-doris] morningman merged pull request #1497: Add ALTER_TABLET task in be

2019-07-23 Thread GitBox
morningman merged pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1531: add show load statement support offset

2019-07-23 Thread GitBox
HangyuanLiu opened a new pull request #1531: add show load statement support offset URL: https://github.com/apache/incubator-doris/pull/1531 add show load statement support offset such as `show load order by createtime desc limit 1,2` #1509 ---

[GitHub] [incubator-doris] imay commented on a change in pull request #1531: Show load statement support offset

2019-07-23 Thread GitBox
imay commented on a change in pull request #1531: Show load statement support offset URL: https://github.com/apache/incubator-doris/pull/1531#discussion_r306167202 ## File path: fe/src/main/java/org/apache/doris/qe/ShowExecutor.java ## @@ -740,8 +740,15 @@ private void han

[GitHub] [incubator-doris] chaoyli merged pull request #1524: Use different ID instead of table ID for base index of an OLAP table

2019-07-23 Thread GitBox
chaoyli merged pull request #1524: Use different ID instead of table ID for base index of an OLAP table URL: https://github.com/apache/incubator-doris/pull/1524 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-doris] HangyuanLiu commented on issue #1531: Show load statement support offset

2019-07-23 Thread GitBox
HangyuanLiu commented on issue #1531: Show load statement support offset URL: https://github.com/apache/incubator-doris/pull/1531#issuecomment-514112169 > Please add an example in SHOW LOAD help doc: > `docs/help/Contents/Data Manipulation/manipulation_stmt.md` OK

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1532: Fix rowset build validate failure

2019-07-23 Thread GitBox
kangpinghuang opened a new pull request #1532: Fix rowset build validate failure URL: https://github.com/apache/incubator-doris/pull/1532 The reason for validate failure is the cloned file's names may conflict and load segment read file througth cache and cache key is file name, so ind

[GitHub] [incubator-doris] kangpinghuang opened a new issue #1533: to make rowset id global unique

2019-07-23 Thread GitBox
kangpinghuang opened a new issue #1533: to make rowset id global unique URL: https://github.com/apache/incubator-doris/issues/1533 Now file name may conflict because the rowset id is unique only in tablet scope. And file will be cached and open file may open wrong file. So it is meaningf

[GitHub] [incubator-doris] imay closed issue #1494: Refactor storage types

2019-07-23 Thread GitBox
imay closed issue #1494: Refactor storage types URL: https://github.com/apache/incubator-doris/issues/1494 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306226386 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing perm

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r30640 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing perm

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306225251 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing perm

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306225679 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing perm

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306226909 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing perm

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
chaoyli commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306225950 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing perm

[GitHub] [incubator-doris] imay commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
imay commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306244425 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing permiss

[GitHub] [incubator-doris] imay commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
imay commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306245059 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing permiss

[GitHub] [incubator-doris] imay commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
imay commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306245676 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing permiss

[GitHub] [incubator-doris] imay commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
imay commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306245720 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing permiss

[GitHub] [incubator-doris] imay commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
imay commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306246635 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing permiss

[GitHub] [incubator-doris] imay commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
imay commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306245720 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing permiss

[GitHub] [incubator-doris] imay commented on a change in pull request #1529: Refactor storage aggregate framework

2019-07-23 Thread GitBox
imay commented on a change in pull request #1529: Refactor storage aggregate framework URL: https://github.com/apache/incubator-doris/pull/1529#discussion_r306249503 ## File path: be/src/olap/aggregate_func.h ## @@ -15,221 +15,283 @@ // specific language governing permiss

[GitHub] [incubator-doris] imay commented on a change in pull request #1530: Add more logs and metrics to trace the broker load process

2019-07-23 Thread GitBox
imay commented on a change in pull request #1530: Add more logs and metrics to trace the broker load process URL: https://github.com/apache/incubator-doris/pull/1530#discussion_r306251583 ## File path: be/src/exec/tablet_sink.cpp ## @@ -612,8 +616,17 @@ Status OlapTableSin

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-23 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r306253977 ## File path: be/src/exec/data_sink.cpp ## @@ -69,7 +71,14 @@ Status DataSink::create_data_sink(

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-23 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r306255085 ## File path: be/src/runtime/result_queue_mgr.cpp ## @@ -0,0 +1,81 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-23 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r306258135 ## File path: fe/src/main/java/org/apache/doris/http/rest/RestCountAction.java ## @@ -0,0 +1,141 @@ +// L

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-23 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r306255587 ## File path: be/src/service/backend_service.cpp ## @@ -245,4 +274,250 @@ void BackendService::submit_rou

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-23 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r306253761 ## File path: be/src/common/config.h ## @@ -406,6 +406,14 @@ namespace config { // If this configura

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-23 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r306257269 ## File path: fe/src/main/java/org/apache/doris/http/rest/RestQueryPlanAction.java ## @@ -0,0 +1,310 @@ +

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-23 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r306258215 ## File path: fe/src/main/java/org/apache/doris/http/rest/RestCountAction.java ## @@ -0,0 +1,141 @@ +// L

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-23 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r306257086 ## File path: fe/src/main/java/org/apache/doris/http/rest/RestCountAction.java ## @@ -0,0 +1,141 @@ +// L

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-23 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r306254636 ## File path: be/src/runtime/exec_env.cpp ## @@ -18,13 +18,20 @@ #include "runtime/exec_env.h" #inclu

[GitHub] [incubator-doris] imay commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
imay commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306268046 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software Foundatio

[GitHub] [incubator-doris] imay commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
imay commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306265357 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software Foundatio

[GitHub] [incubator-doris] imay commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
imay commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306261145 ## File path: be/src/olap/rowset/segment_v2/encoding_info.h ## @@ -22,18 +22,16 @@ #include "common/status.h" #include "gen_cpp/s

[GitHub] [incubator-doris] imay commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
imay commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306267641 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software Foundatio

[GitHub] [incubator-doris] imay commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
imay commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306265485 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software Foundatio

[GitHub] [incubator-doris] imay commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
imay commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306267151 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software Foundatio

[GitHub] [incubator-doris] imay commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
imay commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306260818 ## File path: be/src/olap/rowset/segment_v2/options.h ## @@ -17,20 +17,21 @@ #pragma once -#include "gen_cpp/segment_v2.pb.h"

[GitHub] [incubator-doris] imay commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
imay commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306265081 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software Foundatio

[GitHub] [incubator-doris] imay commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
imay commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306264602 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software Foundatio

[GitHub] [incubator-doris] imay commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
imay commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306266881 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software Foundatio

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306281246 ## File path: be/src/olap/rowset/segment_v2/options.h ## @@ -17,20 +17,21 @@ #pragma once -#include "gen_cpp/segment_

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306283872 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306283793 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306284125 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306284422 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306285289 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306285655 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-23 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306285694 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,223 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] morningman commented on a change in pull request #1530: Add more logs and metrics to trace the broker load process

2019-07-23 Thread GitBox
morningman commented on a change in pull request #1530: Add more logs and metrics to trace the broker load process URL: https://github.com/apache/incubator-doris/pull/1530#discussion_r306288450 ## File path: be/src/exec/tablet_sink.cpp ## @@ -612,8 +616,17 @@ Status OlapTa

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-23 Thread GitBox
chenhao7253886 commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r306276585 ## File path: fe/src/main/java/org/apache/doris/http/rest/RestQueryPlanAction.java ## @@ -0,0 +

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-23 Thread GitBox
chenhao7253886 commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r306287336 ## File path: fe/src/main/java/org/apache/doris/http/rest/RestTableSchemaAction.java ## @@ -0,

<    13   14   15   16   17   18   19   20   21   22   >