[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304749799 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,205 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304716291 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache So

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304706814 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304711343 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304713238 ## File path: be/src/olap/row_block2.h ## @@ -0,0 +1,77 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304714270 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.h ## @@ -0,0 +1,106 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304713931 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.h ## @@ -0,0 +1,106 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304714313 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.h ## @@ -0,0 +1,106 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304716734 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache So

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304713345 ## File path: be/src/olap/row_block2.h ## @@ -0,0 +1,77 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304708173 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304710679 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304713960 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.h ## @@ -0,0 +1,106 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] imay commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
imay commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304753942 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] [incubator-doris] imay commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
imay commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304754732 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] [incubator-doris] imay commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
imay commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304755077 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,205 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] HangyuanLiu closed pull request #1500: Add timediff function

2019-07-18 Thread GitBox
HangyuanLiu closed pull request #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-doris] chaoyli opened a new pull request #1502: Fix rollup bug when init RowCursor

2019-07-18 Thread GitBox
chaoyli opened a new pull request #1502: Fix rollup bug when init RowCursor URL: https://github.com/apache/incubator-doris/pull/1502 When doing rollup, seek_columns equals to the complete set of tablet's columns. There is no necessity to set it. -

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1503: Fix bug that single partition table get wrong partition type

2019-07-18 Thread GitBox
chenhao7253886 opened a new pull request #1503: Fix bug that single partition table get wrong partition type URL: https://github.com/apache/incubator-doris/pull/1503 This is an automated message from the Apache Git Service.

[GitHub] [incubator-doris] imay merged pull request #1502: Fix rollup bug when init RowCursor

2019-07-18 Thread GitBox
imay merged pull request #1502: Fix rollup bug when init RowCursor URL: https://github.com/apache/incubator-doris/pull/1502 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1504: Fix the duplicated request bug of mini load

2019-07-18 Thread GitBox
EmmyMiao87 opened a new pull request #1504: Fix the duplicated request bug of mini load URL: https://github.com/apache/incubator-doris/pull/1504 The function of miniLoadBegin will return the txn_id. If the backend sends the duplicated request to frontend, frontend will return the txn_id

[GitHub] [incubator-doris] chenhao7253886 merged pull request #1503: Fix bug that single partition table get wrong partition type

2019-07-18 Thread GitBox
chenhao7253886 merged pull request #1503: Fix bug that single partition table get wrong partition type URL: https://github.com/apache/incubator-doris/pull/1503 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1505: Add timediff function

2019-07-18 Thread GitBox
HangyuanLiu opened a new pull request #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505 Add timediff function This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-doris] chenhao7253886 commented on issue #1500: Add timediff function

2019-07-18 Thread GitBox
chenhao7253886 commented on issue #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500#issuecomment-512841713 If you only want to add timediff function, you need't import a new udf type. This i

[GitHub] [incubator-doris] chenhao7253886 commented on issue #1505: Add timediff function

2019-07-18 Thread GitBox
chenhao7253886 commented on issue #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505#issuecomment-512846057 I think that you need't import a new udf type to implement timediff. This is an aut

[GitHub] [incubator-doris] imay merged pull request #1504: Fix the duplicated request bug of mini load

2019-07-18 Thread GitBox
imay merged pull request #1504: Fix the duplicated request bug of mini load URL: https://github.com/apache/incubator-doris/pull/1504 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] morningman closed pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-18 Thread GitBox
morningman closed pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] morningman opened a new pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-18 Thread GitBox
morningman opened a new pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489 When query result reach limit, the Coordinator in FE will send a cancel request to BE to cancel the query. And when bei

[GitHub] [incubator-doris] morningman commented on issue #1501: reabalance may cause one tablet's 3 replicas scheduled to one machine

2019-07-18 Thread GitBox
morningman commented on issue #1501: reabalance may cause one tablet's 3 replicas scheduled to one machine URL: https://github.com/apache/incubator-doris/issues/1501#issuecomment-513050765 I will fix this bug This is an aut

[GitHub] [incubator-doris] morningman opened a new issue #1506: BE crash when closing OlapTableSink

2019-07-18 Thread GitBox
morningman opened a new issue #1506: BE crash when closing OlapTableSink URL: https://github.com/apache/incubator-doris/issues/1506 **Describe the bug** ``` Status OlapTableSink::close(RuntimeState* state, Status close_status) { SCOPED_TIMER(_profile->total_time_counter());

[GitHub] [incubator-doris] morningman opened a new pull request #1507: Fix bug that BE may crash when closing OlapTableSink

2019-07-18 Thread GitBox
morningman opened a new pull request #1507: Fix bug that BE may crash when closing OlapTableSink URL: https://github.com/apache/incubator-doris/pull/1507 The `_profile` in OlapTableSink may not be initialized if `prepare()` method is not called. So when close the OlapTableSink, we should

[GitHub] [incubator-doris] morningman opened a new issue #1508: Use different ID instead of table ID for base index of an OLAP table.

2019-07-18 Thread GitBox
morningman opened a new issue #1508: Use different ID instead of table ID for base index of an OLAP table. URL: https://github.com/apache/incubator-doris/issues/1508 In current implementation, the id of a base index of a OLAP table use the same id as table's id. Because in origin design

[GitHub] [incubator-doris] morningman merged pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-18 Thread GitBox
morningman merged pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] imay commented on a change in pull request #1505: Add timediff function

2019-07-18 Thread GitBox
imay commented on a change in pull request #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505#discussion_r305177722 ## File path: gensrc/script/gen_functions.py ## @@ -552,6 +554,7 @@ 'VARCHAR': 'string_val', 'DATE': 'datetime_val',

[GitHub] [incubator-doris] imay commented on a change in pull request #1505: Add timediff function

2019-07-18 Thread GitBox
imay commented on a change in pull request #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505#discussion_r305178263 ## File path: fe/src/main/java/org/apache/doris/analysis/IntLiteral.java ## @@ -89,6 +91,11 @@ public IntLiteral(long longV

[GitHub] [incubator-doris] imay commented on a change in pull request #1505: Add timediff function

2019-07-18 Thread GitBox
imay commented on a change in pull request #1505: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1505#discussion_r305179681 ## File path: be/src/runtime/result_writer.cpp ## @@ -105,7 +105,8 @@ Status ResultWriter::add_one_row(TupleRow* row) {

[GitHub] [incubator-doris] imay merged pull request #1507: Fix bug that BE may crash when closing OlapTableSink

2019-07-18 Thread GitBox
imay merged pull request #1507: Fix bug that BE may crash when closing OlapTableSink URL: https://github.com/apache/incubator-doris/pull/1507 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1488: Add administrator guide of load

2019-07-18 Thread GitBox
EmmyMiao87 commented on issue #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#issuecomment-513071715 1. 总文档中隐去transaction 的概念,用户不好理解。 2. 异步导入方式下,用户可以提交的最大job数量和同时能够running的job数量之间的关系,以及对应的两个配置要说明下(你只说了 desired\_max\_waiting\_jobs 这一个) 3

[GitHub] [incubator-doris] zhuyuncheng opened a new issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-18 Thread GitBox
zhuyuncheng opened a new issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509 🌹🌹 This is an automated message f

[GitHub] [incubator-doris] imay commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-18 Thread GitBox
imay commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513088212 We support both limit and offset. When there is an order by clause, offset will e

[GitHub] [incubator-doris] chaoyli opened a new pull request #1510: Fix rollup bug when init RowCursor in MergeContext

2019-07-18 Thread GitBox
chaoyli opened a new pull request #1510: Fix rollup bug when init RowCursor in MergeContext URL: https://github.com/apache/incubator-doris/pull/1510 When doing rollup, seek_columns equals to the complete set of tablet's columns. There is no necessity to set it.

[GitHub] [incubator-doris] morningman commented on issue #1510: Fix rollup bug when init RowCursor in MergeContext

2019-07-18 Thread GitBox
morningman commented on issue #1510: Fix rollup bug when init RowCursor in MergeContext URL: https://github.com/apache/incubator-doris/pull/1510#issuecomment-513100015 Related to #1502 This is an automated message from the A

[GitHub] [incubator-doris] zhuyuncheng edited a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-18 Thread GitBox
zhuyuncheng edited a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513103898 > We support both limit and offset. When there is an order by clause

[GitHub] [incubator-doris] WingsGo opened a new issue #1511: UDAF variable parameters support bug

2019-07-18 Thread GitBox
WingsGo opened a new issue #1511: UDAF variable parameters support bug URL: https://github.com/apache/incubator-doris/issues/1511 **Describe the bug** UDAF cannot identify variable parameters, **To Reproduce** if you write a udaf function with variable parameters such as

[GitHub] [incubator-doris] zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-18 Thread GitBox
zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513103898 > We support both limit and offset. When there is an order by clause, offse

[GitHub] [incubator-doris] chenhao7253886 opened a new issue #1512: EXPLAIN info does't include item whether the query hit the table's prefix index.

2019-07-18 Thread GitBox
chenhao7253886 opened a new issue #1512: EXPLAIN info does't include item whether the query hit the table's prefix index. URL: https://github.com/apache/incubator-doris/issues/1512 Add item to EXPLAIN for indexing whether the query hit the table's prefix index. ---

[GitHub] [incubator-doris] morningman merged pull request #1510: Fix rollup bug when init RowCursor in MergeContext

2019-07-18 Thread GitBox
morningman merged pull request #1510: Fix rollup bug when init RowCursor in MergeContext URL: https://github.com/apache/incubator-doris/pull/1510 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-doris] zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513121662 https://github.com/apache/incubator-doris/blob/master/fe/src/main/java/org

[GitHub] [incubator-doris] zhuyuncheng edited a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng edited a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513121662 https://github.com/apache/incubator-doris/blob/master/fe/src/main/j

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1513: Fix segment group add zone check bug and remove unused meta log

2019-07-19 Thread GitBox
kangpinghuang opened a new pull request #1513: Fix segment group add zone check bug and remove unused meta log URL: https://github.com/apache/incubator-doris/pull/1513 This is an automated message from the Apache Git Service

[GitHub] [incubator-doris] morningman opened a new pull request #1514: Fix bug that WrapperField does not consider HLL column type when creating

2019-07-19 Thread GitBox
morningman opened a new pull request #1514: Fix bug that WrapperField does not consider HLL column type when creating URL: https://github.com/apache/incubator-doris/pull/1514 This bug may cause BE crash when handling HLL column in some process. This bug is introduced by code merge. Versi

[GitHub] [incubator-doris] chenhao7253886 closed pull request #1491: Fix bug that <=> operator get wrong result

2019-07-19 Thread GitBox
chenhao7253886 closed pull request #1491: Fix bug that <=> operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1491 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-19 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305239672 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-19 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305227490 ## File path: be/src/olap/rowset/segment_v2/bitshuffle_page.h ## @@ -170,11 +148,11 @@ class BitshufflePageBuilder : public Pag

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-19 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305237002 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-19 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305250606 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-19 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305246433 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] imay opened a new pull request #1515: Add storage rowwise iterator

2019-07-19 Thread GitBox
imay opened a new pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515 Use RowwiseIterator to uniform all data fetch in storage engine. All objects in storage engine can be read in iterator format. For example: Segment, Rowset.

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-19 Thread GitBox
chenhao7253886 opened a new pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516 #1492 This is an automated message from the Apache Git Servic

[GitHub] [incubator-doris] imay merged pull request #1513: Fix segment group add zone check bug and remove unused meta log

2019-07-19 Thread GitBox
imay merged pull request #1513: Fix segment group add zone check bug and remove unused meta log URL: https://github.com/apache/incubator-doris/pull/1513 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] morningman commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-19 Thread GitBox
morningman commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r305267689 ## File path: be/src/exprs/binary_predicate.h ## @@ -41,8 +41,28 @@ class Binar

[GitHub] [incubator-doris] morningman commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-19 Thread GitBox
morningman commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r305267656 ## File path: be/src/exprs/binary_predicate.h ## @@ -41,8 +41,28 @@ class Binar

[GitHub] [incubator-doris] imay commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-19 Thread GitBox
imay commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r305270111 ## File path: be/src/exprs/binary_predicate.cpp ## @@ -468,12 +462,10 @@ DATETIME_BIN

[GitHub] [incubator-doris] morningman opened a new pull request #1517: Fix bug that replicas of a tablet may be located on same host

2019-07-19 Thread GitBox
morningman opened a new pull request #1517: Fix bug that replicas of a tablet may be located on same host URL: https://github.com/apache/incubator-doris/pull/1517 Doris supports deploying multi BE on one host. So when allocating BE for replicas of a tablet, we should select different ho

[GitHub] [incubator-doris] morningman opened a new pull request #1518: Add index.rst file for aggregation-function SQL reference docs

2019-07-19 Thread GitBox
morningman opened a new pull request #1518: Add index.rst file for aggregation-function SQL reference docs URL: https://github.com/apache/incubator-doris/pull/1518 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] imay commented on a change in pull request #1517: Fix bug that replicas of a tablet may be located on same host

2019-07-19 Thread GitBox
imay commented on a change in pull request #1517: Fix bug that replicas of a tablet may be located on same host URL: https://github.com/apache/incubator-doris/pull/1517#discussion_r305276350 ## File path: fe/src/main/java/org/apache/doris/clone/TabletScheduler.java ## @@ -

[GitHub] [incubator-doris] imay merged pull request #1518: Add index.rst file for aggregation-function SQL reference docs

2019-07-19 Thread GitBox
imay merged pull request #1518: Add index.rst file for aggregation-function SQL reference docs URL: https://github.com/apache/incubator-doris/pull/1518 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] imay merged pull request #1514: Fix bug that WrapperField does not consider HLL column type when creating

2019-07-19 Thread GitBox
imay merged pull request #1514: Fix bug that WrapperField does not consider HLL column type when creating URL: https://github.com/apache/incubator-doris/pull/1514 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] zhaomingzhu opened a new issue #1519: 创建表不支持timestamp类型吗?

2019-07-19 Thread GitBox
zhaomingzhu opened a new issue #1519: 创建表不支持timestamp类型吗? URL: https://github.com/apache/incubator-doris/issues/1519 比如 `modified` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP 不支持? This is an automated message from the Apac

[GitHub] [incubator-doris] imay commented on issue #1519: 创建表不支持timestamp类型吗?

2019-07-19 Thread GitBox
imay commented on issue #1519: 创建表不支持timestamp类型吗? URL: https://github.com/apache/incubator-doris/issues/1519#issuecomment-513179723 现在不支持timestamp,你可以使用datetime类型 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] imay commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
imay commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513182530 @zhuyuncheng I think you are right. Currently, we don't support offset in `SHO

[GitHub] [incubator-doris] imay edited a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
imay edited a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513182530 @zhuyuncheng I think you are right. Currently, we don't support offset

[GitHub] [incubator-doris] zhuyuncheng closed issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng closed issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509 This is an automated message from the

[GitHub] [incubator-doris] zhuyuncheng removed a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng removed a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513204022 > @zhuyuncheng > I think you are right. Currently, we don't supp

[GitHub] [incubator-doris] zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513204022 > @zhuyuncheng > I think you are right. Currently, we don't support offs

[GitHub] [incubator-doris] zhuyuncheng opened a new issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng opened a new issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509 🌹🌹 This is an automated message f

[GitHub] [incubator-doris] zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513204112 Let me try. @imay ---

[GitHub] [incubator-doris] imay opened a new issue #1520: Refactor storage aggregate_func.h

2019-07-19 Thread GitBox
imay opened a new issue #1520: Refactor storage aggregate_func.h URL: https://github.com/apache/incubator-doris/issues/1520 I want to refactor be/src/olap/aggregate_func.h. Current implementation have some problems. Now, Storage maintain two function map, one for aggregate function,

[GitHub] [incubator-doris] morningman opened a new issue #1521: Support setting replica status as bad manually

2019-07-20 Thread GitBox
morningman opened a new issue #1521: Support setting replica status as bad manually URL: https://github.com/apache/incubator-doris/issues/1521 Sometimes a replica is broken on BE, but FE does not notice that. In this case, we have to manually delete that replica on BE. If there are hu

[GitHub] [incubator-doris] morningman opened a new pull request #1522: Support setting replica status as bad manually

2019-07-20 Thread GitBox
morningman opened a new pull request #1522: Support setting replica status as bad manually URL: https://github.com/apache/incubator-doris/pull/1522 Sometimes a replica is broken on BE, but FE does not notice that. In this case, we have to manually delete that replica on BE. If there a

[GitHub] [incubator-doris] WingsGo opened a new pull request #1523: fix variable arguments bug in udaf

2019-07-20 Thread GitBox
WingsGo opened a new pull request #1523: fix variable arguments bug in udaf URL: https://github.com/apache/incubator-doris/pull/1523 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] morningman opened a new pull request #1524: Use different ID instead of table ID for base index of an OLAP table

2019-07-20 Thread GitBox
morningman opened a new pull request #1524: Use different ID instead of table ID for base index of an OLAP table URL: https://github.com/apache/incubator-doris/pull/1524 In current implementation, the id of a base index of a OLAP table use the same id as table's id. Because in origin de

[GitHub] [incubator-doris] morningman commented on a change in pull request #1524: Use different ID instead of table ID for base index of an OLAP table

2019-07-20 Thread GitBox
morningman commented on a change in pull request #1524: Use different ID instead of table ID for base index of an OLAP table URL: https://github.com/apache/incubator-doris/pull/1524#discussion_r305599970 ## File path: be/src/common/config.h ## @@ -208,7 +208,7 @@ namespace

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-21 Thread GitBox
chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r305608601 ## File path: be/src/exprs/binary_predicate.h ## @@ -41,8 +41,28 @@ class B

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-21 Thread GitBox
chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r305608919 ## File path: be/src/exprs/binary_predicate.cpp ## @@ -468,12 +462,10 @@ DA

[GitHub] [incubator-doris] morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be

2019-07-21 Thread GitBox
morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r305610008 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external

[GitHub] [incubator-doris] morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be

2019-07-21 Thread GitBox
morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r305610222 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external

[GitHub] [incubator-doris] morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be

2019-07-21 Thread GitBox
morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r305609913 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305616064 ## File path: be/src/olap/iterators.h ## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305616331 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305617249 ## File path: be/src/olap/row_block2.cpp ## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305616145 ## File path: be/src/olap/generic_iterators.h ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305616606 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305616092 ## File path: be/src/olap/iterators.h ## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
chaoyli commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305620137 ## File path: be/src/olap/row_block2.h ## @@ -0,0 +1,110 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
chaoyli commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305620450 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
chaoyli commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305621204 ## File path: be/src/olap/types.h ## @@ -33,54 +33,60 @@ #include "util/mem_util.hpp" #include "util/slice.h"

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
chaoyli commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305620914 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1515: Add storage rowwise iterator

2019-07-21 Thread GitBox
chaoyli commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305620857 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] imay merged pull request #1523: Fix variable arguments bug in UDAF

2019-07-21 Thread GitBox
imay merged pull request #1523: Fix variable arguments bug in UDAF URL: https://github.com/apache/incubator-doris/pull/1523 This is an automated message from the Apache Git Service. To respond to the message, please log on to

<    12   13   14   15   16   17   18   19   20   21   >