[GitHub] [incubator-doris] worker24h opened a new pull request #1476: We can set param 'load_memtable_bytes' with http header for stream load

2019-07-15 Thread GitBox
worker24h opened a new pull request #1476: We can set param 'load_memtable_bytes' with http header for stream load URL: https://github.com/apache/incubator-doris/pull/1476 We can set param 'load_memtable_bytes' with http header so that it can reduce Version count.

[GitHub] [incubator-doris] imay commented on a change in pull request #1476: We can set param 'load_memtable_bytes' with http header for stream load

2019-07-15 Thread GitBox
imay commented on a change in pull request #1476: We can set param 'load_memtable_bytes' with http header for stream load URL: https://github.com/apache/incubator-doris/pull/1476#discussion_r303313072 ## File path: be/src/http/action/stream_load.cpp ## @@ -328,6 +328,19 @@

[GitHub] [incubator-doris] imay commented on a change in pull request #1476: We can set param 'load_memtable_bytes' with http header for stream load

2019-07-15 Thread GitBox
imay commented on a change in pull request #1476: We can set param 'load_memtable_bytes' with http header for stream load URL: https://github.com/apache/incubator-doris/pull/1476#discussion_r303312293 ## File path: gensrc/thrift/PaloInternalService.thrift ## @@ -176,6 +176

[GitHub] [incubator-doris] chaoyli merged pull request #1475: Fix bug when doing linked schema change.

2019-07-15 Thread GitBox
chaoyli merged pull request #1475: Fix bug when doing linked schema change. URL: https://github.com/apache/incubator-doris/pull/1475 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] chaoyli opened a new pull request #1477: Add log for clone rowset

2019-07-15 Thread GitBox
chaoyli opened a new pull request #1477: Add log for clone rowset URL: https://github.com/apache/incubator-doris/pull/1477 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] chaoyli merged pull request #1477: Add log for clone rowset

2019-07-15 Thread GitBox
chaoyli merged pull request #1477: Add log for clone rowset URL: https://github.com/apache/incubator-doris/pull/1477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort

2019-07-15 Thread GitBox
chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471#discussion_r303338083 ## File path: fe/src/main/java/org/apache/doris/analysis/Expr.java ## @@ -

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort

2019-07-15 Thread GitBox
chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471#discussion_r303338185 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java

[GitHub] [incubator-doris] chaoyli opened a new pull request #1478: Merge refactor code into master

2019-07-15 Thread GitBox
chaoyli opened a new pull request #1478: Merge refactor code into master URL: https://github.com/apache/incubator-doris/pull/1478 1. Refactoring be is to clarify the structure the codes. Use unique id to indicate a rowset. 2. Naming rowset with tablet_id and version will lead to

[GitHub] [incubator-doris] HangyuanLiu closed pull request #1479: Timediff

2019-07-15 Thread GitBox
HangyuanLiu closed pull request #1479: Timediff URL: https://github.com/apache/incubator-doris/pull/1479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1480: Add timeout in stream load planner

2019-07-15 Thread GitBox
EmmyMiao87 opened a new pull request #1480: Add timeout in stream load planner URL: https://github.com/apache/incubator-doris/pull/1480 Mini load timeout needs to be added in plan options. The timeout property has been added in request of process put. Otherwise, the timeout of mini load is

[GitHub] [incubator-doris] yiguolei opened a new issue #1481: Refactor BE

2019-07-15 Thread GitBox
yiguolei opened a new issue #1481: Refactor BE URL: https://github.com/apache/incubator-doris/issues/1481 Current BE's structure is very complex. It is very difficult to maintain it so that we decide to refactor it. This is

[GitHub] [incubator-doris] yiguolei commented on issue #1481: Refactor BE

2019-07-15 Thread GitBox
yiguolei commented on issue #1481: Refactor BE URL: https://github.com/apache/incubator-doris/issues/1481#issuecomment-511373836 [ [be_refactor.pdf](https://github.com/apache/incubator-doris/files/3392130/be_refactor.pdf) ](url) -

[GitHub] [incubator-doris] yiguolei commented on issue #1478: Merge refactor code into master

2019-07-15 Thread GitBox
yiguolei commented on issue #1478: Merge refactor code into master URL: https://github.com/apache/incubator-doris/pull/1478#issuecomment-511374058 #1481 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] yiguolei edited a comment on issue #1481: Refactor BE

2019-07-15 Thread GitBox
yiguolei edited a comment on issue #1481: Refactor BE URL: https://github.com/apache/incubator-doris/issues/1481#issuecomment-511373836 [be_refactor.pdf](https://github.com/apache/incubator-doris/files/3392130/be_refactor.pdf) -

[GitHub] [incubator-doris] morningman closed pull request #1480: Add timeout in stream load planner

2019-07-15 Thread GitBox
morningman closed pull request #1480: Add timeout in stream load planner URL: https://github.com/apache/incubator-doris/pull/1480 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1480: Add timeout in stream load planner

2019-07-15 Thread GitBox
EmmyMiao87 opened a new pull request #1480: Add timeout in stream load planner URL: https://github.com/apache/incubator-doris/pull/1480 Mini load timeout needs to be added in plan options. The timeout property has been added in request of process put. Otherwise, the timeout of mini load is

[GitHub] [incubator-doris] imay merged pull request #1478: Merge refactor code into master

2019-07-15 Thread GitBox
imay merged pull request #1478: Merge refactor code into master URL: https://github.com/apache/incubator-doris/pull/1478 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-doris] chaoyli opened a new pull request #1482: Fix heap-buffer-overflow in split_part() function in StringFunctions

2019-07-15 Thread GitBox
chaoyli opened a new pull request #1482: Fix heap-buffer-overflow in split_part() function in StringFunctions URL: https://github.com/apache/incubator-doris/pull/1482 This is an automated message from the Apache Git Service.

[GitHub] [incubator-doris] imay opened a new pull request #1483: Remove unused code

2019-07-15 Thread GitBox
imay opened a new pull request #1483: Remove unused code URL: https://github.com/apache/incubator-doris/pull/1483 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-doris] chaoyli merged pull request #1483: Remove unused code

2019-07-15 Thread GitBox
chaoyli merged pull request #1483: Remove unused code URL: https://github.com/apache/incubator-doris/pull/1483 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] imay merged pull request #1480: Add timeout in stream load planner

2019-07-15 Thread GitBox
imay merged pull request #1480: Add timeout in stream load planner URL: https://github.com/apache/incubator-doris/pull/1480 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] imay commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level

2019-07-15 Thread GitBox
imay commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level URL: https://github.com/apache/incubator-doris/pull/1472#discussion_r303461517 ## File path: fe/src/main/java/org/apache/doris/analysis/RevokeStmt.java ## @@ -88,25 +88,3

[GitHub] [incubator-doris] imay commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level

2019-07-15 Thread GitBox
imay commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level URL: https://github.com/apache/incubator-doris/pull/1472#discussion_r303462700 ## File path: fe/src/main/java/org/apache/doris/mysql/privilege/PaloAuth.java ## @@ -338,6

[GitHub] [incubator-doris] imay merged pull request #1482: Fix heap-buffer-overflow in split_part() function in StringFunctions

2019-07-15 Thread GitBox
imay merged pull request #1482: Fix heap-buffer-overflow in split_part() function in StringFunctions URL: https://github.com/apache/incubator-doris/pull/1482 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-doris] morningman commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level

2019-07-15 Thread GitBox
morningman commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level URL: https://github.com/apache/incubator-doris/pull/1472#discussion_r303706941 ## File path: fe/src/main/java/org/apache/doris/analysis/RevokeStmt.java ## @@ -88,25

[GitHub] [incubator-doris] morningman commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level

2019-07-15 Thread GitBox
morningman commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level URL: https://github.com/apache/incubator-doris/pull/1472#discussion_r303707094 ## File path: fe/src/main/java/org/apache/doris/mysql/privilege/PaloAuth.java ## @@ -

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-15 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r303707000 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-15 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r303707165 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] morningman opened a new pull request #1484: Modify the result json format of mini load.

2019-07-15 Thread GitBox
morningman opened a new pull request #1484: Modify the result json format of mini load. URL: https://github.com/apache/incubator-doris/pull/1484 Mini load is now using stream load framework. But we should keep the mini load return behavior and result json format be same as old. So PUB

[GitHub] [incubator-doris] kangkaisen opened a new issue #1485: Add a Bitmap count distinct UDAF

2019-07-15 Thread GitBox
kangkaisen opened a new issue #1485: Add a Bitmap count distinct UDAF URL: https://github.com/apache/incubator-doris/issues/1485 Add a Bitmap count distinct UDAF base on RoaringBitmap. After simple test, **I find the bitmap count distinct is 2x~3x faster than default count distinct in so

[GitHub] [incubator-doris] kangkaisen opened a new issue #1486: Add a count distinct AggregateType

2019-07-15 Thread GitBox
kangkaisen opened a new issue #1486: Add a count distinct AggregateType URL: https://github.com/apache/incubator-doris/issues/1486 Add a count distinct AggregateType base on RoaringBitmap, I have done a initial version, which could improve the count distinct performance dramatically.

[GitHub] [incubator-doris] morningman closed pull request #1484: Modify the result json format of mini load.

2019-07-15 Thread GitBox
morningman closed pull request #1484: Modify the result json format of mini load. URL: https://github.com/apache/incubator-doris/pull/1484 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] morningman opened a new pull request #1487: Modify the result json format of mini load

2019-07-15 Thread GitBox
morningman opened a new pull request #1487: Modify the result json format of mini load URL: https://github.com/apache/incubator-doris/pull/1487 Mini load is now using stream load framework. But we should keep the mini load return behavior and result json format be same as old. So PUBL

[GitHub] [incubator-doris] imay commented on a change in pull request #1487: Modify the result json format of mini load

2019-07-16 Thread GitBox
imay commented on a change in pull request #1487: Modify the result json format of mini load URL: https://github.com/apache/incubator-doris/pull/1487#discussion_r303789164 ## File path: be/src/exec/tablet_sink.h ## @@ -168,6 +168,9 @@ class OlapTableSink : public DataSink

[GitHub] [incubator-doris] imay commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level

2019-07-16 Thread GitBox
imay commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level URL: https://github.com/apache/incubator-doris/pull/1472#discussion_r303817273 ## File path: docs/help/Contents/Account Management/help.md ## @@ -109,6 +109,7 @@ privileg

[GitHub] [incubator-doris] imay commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level

2019-07-16 Thread GitBox
imay commented on a change in pull request #1472: Support grant GRANT_PRIV on database or table level URL: https://github.com/apache/incubator-doris/pull/1472#discussion_r303819303 ## File path: fe/src/main/java/org/apache/doris/analysis/GrantStmt.java ## @@ -92,32 +91,51

[GitHub] [incubator-doris] morningman merged pull request #1487: Modify the result json format of mini load

2019-07-16 Thread GitBox
morningman merged pull request #1487: Modify the result json format of mini load URL: https://github.com/apache/incubator-doris/pull/1487 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] morningman merged pull request #1472: Support grant GRANT_PRIV on database or table level

2019-07-16 Thread GitBox
morningman merged pull request #1472: Support grant GRANT_PRIV on database or table level URL: https://github.com/apache/incubator-doris/pull/1472 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
EmmyMiao87 opened a new pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488 The catalogue of load docs: + load-manual.md broker-load-manual.md insert-into-manual.md stream-load-manual.md This commit a

[GitHub] [incubator-doris] morningman opened a new pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
morningman opened a new pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489 When query result reach limit, the Coordinator in FE will send a cancel request to BE to cancel the query. And when bei

[GitHub] [incubator-doris] yiguolei opened a new pull request #1490: Add partition id to tablet meta in be

2019-07-16 Thread GitBox
yiguolei opened a new pull request #1490: Add partition id to tablet meta in be URL: https://github.com/apache/incubator-doris/pull/1490 FE uses partition_id to publish version. BE should check whether all tablets related with this partition have the version. But Tablet in BE does not have

[GitHub] [incubator-doris] imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304190411 ## File path: fe/src/main/java/org/apache/doris/qe/Coordinator.java ## @@ -1

[GitHub] [incubator-doris] imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304191773 ## File path: fe/src/main/java/org/apache/doris/qe/Coordinator.java ## @@ -6

[GitHub] [incubator-doris] imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304191098 ## File path: be/src/runtime/fragment_mgr.cpp ## @@ -209,9 +209,12 @@ Status

[GitHub] [incubator-doris] imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304191576 ## File path: fe/src/main/java/org/apache/doris/rpc/BackendServiceProxy.java

[GitHub] [incubator-doris] imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304189958 ## File path: gensrc/proto/internal_service.proto ## @@ -116,6 +116,12 @@ me

[GitHub] [incubator-doris] imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304189361 ## File path: gensrc/proto/internal_service.proto ## @@ -116,6 +116,12 @@ me

[GitHub] [incubator-doris] morningman commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304195342 ## File path: gensrc/proto/internal_service.proto ## @@ -116,6 +116,12

[GitHub] [incubator-doris] morningman commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304195321 ## File path: gensrc/proto/internal_service.proto ## @@ -116,6 +116,12

[GitHub] [incubator-doris] morningman commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304195377 ## File path: fe/src/main/java/org/apache/doris/qe/Coordinator.java ##

[GitHub] [incubator-doris] morningman commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304196680 ## File path: be/src/runtime/fragment_mgr.cpp ## @@ -209,9 +209,12 @@

[GitHub] [incubator-doris] morningman commented on a change in pull request #1490: Add partition id to tablet meta in be

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1490: Add partition id to tablet meta in be URL: https://github.com/apache/incubator-doris/pull/1490#discussion_r304200443 ## File path: fe/src/main/java/org/apache/doris/task/UpdateTabletMetaInfoTask.java ## @@ -0,0 +1,69

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1491: Fix bug that <=> operator get wrong result

2019-07-16 Thread GitBox
chenhao7253886 opened a new pull request #1491: Fix bug that <=> operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1491 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally

2019-07-16 Thread GitBox
imay commented on a change in pull request #1489: Remove query status report from BE when query is cancelled normally URL: https://github.com/apache/incubator-doris/pull/1489#discussion_r304231166 ## File path: gensrc/proto/internal_service.proto ## @@ -114,8 +114,16 @@ me

[GitHub] [incubator-doris] morningman merged pull request #1490: Add partition id to tablet meta in be

2019-07-16 Thread GitBox
morningman merged pull request #1490: Add partition id to tablet meta in be URL: https://github.com/apache/incubator-doris/pull/1490 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] chenhao7253886 opened a new issue #1492: NULL's operator "<=>" get wrong result

2019-07-16 Thread GitBox
chenhao7253886 opened a new issue #1492: NULL's operator "<=>" get wrong result URL: https://github.com/apache/incubator-doris/issues/1492 now , the result of comparing null with other value by operator "<=>" is wrong, for example: mysql> select null <=> null; +-+ | NU

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304206746 ## File path: docs/documentation/cn/administrator-guide/load-data/broker-load-manual.md ## @@ -1,17 +1,8

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304204555 ## File path: docs/documentation/cn/administrator-guide/load-data/load-manual.md ## @@ -0,0 +1,256 @@ +#

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304204467 ## File path: docs/documentation/cn/administrator-guide/load-data/load-manual.md ## @@ -0,0 +1,256 @@ +#

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304204990 ## File path: docs/documentation/cn/administrator-guide/load-data/load-manual.md ## @@ -0,0 +1,256 @@ +#

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304241005 ## File path: docs/documentation/cn/administrator-guide/load-data/insert-into-manual.md ## @@ -0,0 +1,31

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304204271 ## File path: docs/documentation/cn/administrator-guide/load-data/load-manual.md ## @@ -0,0 +1,256 @@ +#

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304205982 ## File path: docs/documentation/cn/administrator-guide/load-data/load-manual.md ## @@ -0,0 +1,256 @@ +#

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304207411 ## File path: docs/documentation/cn/administrator-guide/load-data/broker-load-manual.md ## @@ -1,17 +1,8

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304204773 ## File path: docs/documentation/cn/administrator-guide/load-data/load-manual.md ## @@ -0,0 +1,256 @@ +#

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304205654 ## File path: docs/documentation/cn/administrator-guide/load-data/load-manual.md ## @@ -0,0 +1,256 @@ +#

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304205458 ## File path: docs/documentation/cn/administrator-guide/load-data/load-manual.md ## @@ -0,0 +1,256 @@ +#

[GitHub] [incubator-doris] morningman commented on a change in pull request #1488: Add administrator guide of load

2019-07-16 Thread GitBox
morningman commented on a change in pull request #1488: Add administrator guide of load URL: https://github.com/apache/incubator-doris/pull/1488#discussion_r304205161 ## File path: docs/documentation/cn/administrator-guide/load-data/load-manual.md ## @@ -0,0 +1,256 @@ +#

[GitHub] [incubator-doris] chenhao7253886 opened a new issue #1493: ifnull return wrong type value in aggregation function

2019-07-16 Thread GitBox
chenhao7253886 opened a new issue #1493: ifnull return wrong type value in aggregation function URL: https://github.com/apache/incubator-doris/issues/1493 The following query: mysql> select sum(ifnull(0.0,0)) from baseall'; ERROR 1064 (HY000): SUM requires a numeric parameter: sum(ifn

[GitHub] [incubator-doris] imay opened a new issue #1494: Refactor storage types

2019-07-17 Thread GitBox
imay opened a new issue #1494: Refactor storage types URL: https://github.com/apache/incubator-doris/issues/1494 Now we have repeated code in be/src/olap/types.h. Same code is written many times. So I want to refactor this file to reduce duplicate code --

[GitHub] [incubator-doris] imay commented on issue #1491: Fix bug that <=> operator get wrong result

2019-07-17 Thread GitBox
imay commented on issue #1491: Fix bug that <=> operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1491#issuecomment-512136194 I think your patch can make const's computation works well. But for non const computation, this predicate will return NULL too, which i

[GitHub] [incubator-doris] chenhao7253886 closed pull request #1471: Planner support push down predicates past agg, win and sort

2019-07-17 Thread GitBox
chenhao7253886 closed pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1471: Planner support push down predicates past agg, win and sort

2019-07-17 Thread GitBox
chenhao7253886 opened a new pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471 #1438 This is an automated message from the Apache Git Servi

[GitHub] [incubator-doris] chenhao7253886 opened a new issue #1495: Planner may push unsupported functions to mysql external table

2019-07-17 Thread GitBox
chenhao7253886 opened a new issue #1495: Planner may push unsupported functions to mysql external table URL: https://github.com/apache/incubator-doris/issues/1495 Planner may push unsupported functions to mysql external table, because some functions in doris can't supported by mysql, and

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1495: Planner may push unsupported functions to mysql external table

2019-07-17 Thread GitBox
EmmyMiao87 commented on issue #1495: Planner may push unsupported functions to mysql external table URL: https://github.com/apache/incubator-doris/issues/1495#issuecomment-512176677 please assign to me This is an automated

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1496: Add log to trace writer validate failure

2019-07-17 Thread GitBox
kangpinghuang opened a new pull request #1496: Add log to trace writer validate failure URL: https://github.com/apache/incubator-doris/pull/1496 AlphaRowsetWriter validate rowset failed when build rowset because rowset's num_rows is not equal to segment groups' num_rows when add_rowse

[GitHub] [incubator-doris] yiguolei commented on issue #1497: Add ALTER_TABLET task in be

2019-07-17 Thread GitBox
yiguolei commented on issue #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#issuecomment-512227454 #1429 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-doris] yiguolei opened a new pull request #1497: Add ALTER_TABLET task in be

2019-07-17 Thread GitBox
yiguolei opened a new pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] imay opened a new pull request #1498: Refactor types.h to reduce code and add UT

2019-07-17 Thread GitBox
imay opened a new pull request #1498: Refactor types.h to reduce code and add UT URL: https://github.com/apache/incubator-doris/pull/1498 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] imay commented on a change in pull request #1496: Add log to trace writer validate failure

2019-07-17 Thread GitBox
imay commented on a change in pull request #1496: Add log to trace writer validate failure URL: https://github.com/apache/incubator-doris/pull/1496#discussion_r304372185 ## File path: be/src/olap/rowset/alpha_rowset.h ## @@ -126,6 +126,10 @@ class AlphaRowset : public Rows

[GitHub] [incubator-doris] imay commented on a change in pull request #1497: Add ALTER_TABLET task in be

2019-07-17 Thread GitBox
imay commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r304407797 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external_sortin

[GitHub] [incubator-doris] Zerotoone opened a new issue #1499: Be break down and mostly can not be started

2019-07-17 Thread GitBox
Zerotoone opened a new issue #1499: Be break down and mostly can not be started URL: https://github.com/apache/incubator-doris/issues/1499 **Describe the bug** 1. Be break down and mostly can not be started 2. after repeatedly started, some be revover and back to alive 3. before

[GitHub] [incubator-doris] imay closed pull request #1498: Refactor types.h to reduce code and add UT

2019-07-17 Thread GitBox
imay closed pull request #1498: Refactor types.h to reduce code and add UT URL: https://github.com/apache/incubator-doris/pull/1498 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] imay opened a new pull request #1498: Refactor types.h to reduce code and add UT

2019-07-17 Thread GitBox
imay opened a new pull request #1498: Refactor types.h to reduce code and add UT URL: https://github.com/apache/incubator-doris/pull/1498 #1494 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] imay merged pull request #1496: Add log to trace writer validate failure

2019-07-17 Thread GitBox
imay merged pull request #1496: Add log to trace writer validate failure URL: https://github.com/apache/incubator-doris/pull/1496 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1500: Add timediff function

2019-07-17 Thread GitBox
HangyuanLiu opened a new pull request #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500 1. add a new udf type TimeVal 2.add new function timediff #1428 This is an automated messag

[GitHub] [incubator-doris] shgxwxl opened a new issue #1501: reabalance may cause one tablet's 3 replicas scheduled to one machine

2019-07-17 Thread GitBox
shgxwxl opened a new issue #1501: reabalance may cause one tablet's 3 replicas scheduled to one machine URL: https://github.com/apache/incubator-doris/issues/1501 **Describe the bug** 9 bes per machine one ip per machine reabalance may cause one tablet's 3 replicas sc

[GitHub] [incubator-doris] imay merged pull request #1498: Refactor types.h to reduce code and add UT

2019-07-17 Thread GitBox
imay merged pull request #1498: Refactor types.h to reduce code and add UT URL: https://github.com/apache/incubator-doris/pull/1498 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] imay commented on a change in pull request #1500: Add timediff function

2019-07-17 Thread GitBox
imay commented on a change in pull request #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500#discussion_r304731398 ## File path: be/src/udf/udf.h ## @@ -554,6 +554,34 @@ struct DoubleVal : public AnyVal { } }; +struct TimeVal : pu

[GitHub] [incubator-doris] imay commented on a change in pull request #1500: Add timediff function

2019-07-17 Thread GitBox
imay commented on a change in pull request #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500#discussion_r304731552 ## File path: fe/src/main/java/org/apache/doris/analysis/TimeLiteral.java ## @@ -0,0 +1,147 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay commented on a change in pull request #1500: Add timediff function

2019-07-17 Thread GitBox
imay commented on a change in pull request #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500#discussion_r304730873 ## File path: be/src/exec/olap_scanner.cpp ## @@ -414,7 +414,8 @@ void OlapScanner::_convert_row_to_tuple(Tuple* tuple) {

[GitHub] [incubator-doris] imay commented on a change in pull request #1500: Add timediff function

2019-07-17 Thread GitBox
imay commented on a change in pull request #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500#discussion_r304731516 ## File path: fe/src/main/java/org/apache/doris/analysis/TimeLiteral.java ## @@ -0,0 +1,147 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304711035 ## File path: be/src/olap/rowset/segment_v2/segment.cpp ## @@ -0,0 +1,198 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304716545 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache So

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304710453 ## File path: be/src/olap/rowset/segment_v2/segment.cpp ## @@ -0,0 +1,198 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304749410 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,205 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304722394 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache So

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304710581 ## File path: be/src/olap/rowset/segment_v2/segment.cpp ## @@ -0,0 +1,198 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304708671 ## File path: be/src/olap/segment_group.h ## @@ -124,7 +124,7 @@ class SegmentGroup { OLAPStatus find_prev_p

<    11   12   13   14   15   16   17   18   19   20   >