[GitHub] [incubator-doris] morningman opened a new pull request #1425: Revert "Cast the type of constant value in binary predicate to column type. (#1422)"

2019-07-03 Thread GitBox
morningman opened a new pull request #1425: Revert "Cast the type of constant value in binary predicate to column type. (#1422)" URL: https://github.com/apache/incubator-doris/pull/1425 This reverts commit 687f5a10868ce62d2d25d028152f84f3385b73f4, which may cause incorrect query results.

[GitHub] [incubator-doris] morningman merged pull request #1425: Revert "Cast the type of constant value in binary predicate to column type. (#1422)"

2019-07-03 Thread GitBox
morningman merged pull request #1425: Revert "Cast the type of constant value in binary predicate to column type. (#1422)" URL: https://github.com/apache/incubator-doris/pull/1425 This is an automated message from the Apache

[GitHub] [incubator-doris] morningman opened a new pull request #1426: Fix bug that publish task missing dbId parameter

2019-07-03 Thread GitBox
morningman opened a new pull request #1426: Fix bug that publish task missing dbId parameter URL: https://github.com/apache/incubator-doris/pull/1426 Without dbId parameter, the backend report version can not be updated when publish task report to FE, which may cause incorrect order o

[GitHub] [incubator-doris] ltylty opened a new issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris

2019-07-04 Thread GitBox
ltylty opened a new issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris URL: https://github.com/apache/incubator-doris/issues/1427 使用最新版的0.10版本。 Mysql6 之后的驱动类是com.mysql.cj.jdbc.Driver,连不上Doris。 需要使用MySQL5的驱动类com.mysql.jdbc.Driver。 -

[GitHub] [incubator-doris] imay commented on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris

2019-07-04 Thread GitBox
imay commented on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris URL: https://github.com/apache/incubator-doris/issues/1427#issuecomment-508373473 Can you upload error SQL? This is an automated message from the Apache Git S

[GitHub] [incubator-doris] imay merged pull request #1426: Fix bug that publish task missing dbId parameter

2019-07-04 Thread GitBox
imay merged pull request #1426: Fix bug that publish task missing dbId parameter URL: https://github.com/apache/incubator-doris/pull/1426 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] ltylty commented on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris

2019-07-04 Thread GitBox
ltylty commented on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris URL: https://github.com/apache/incubator-doris/issues/1427#issuecomment-508396940 @imay Caused by: java.sql.SQLNonTransientConnectionException: CLIENT_PLUGIN_AUTH is required at com.mysql.cj.jdbc.exceptions.S

[GitHub] [incubator-doris] imay commented on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris

2019-07-04 Thread GitBox
imay commented on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris URL: https://github.com/apache/incubator-doris/issues/1427#issuecomment-508403740 This problem is probably fixed by #1349 , you can try our master branch to see if it is fixed --

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-04 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r300366706 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-04 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r300357863 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-04 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r300385063 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.h ## @@ -0,0 +1,127 @@ +// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-04 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r300388968 ## File path: be/test/olap/rowset/segment_v2/binary_dict_page_test.cpp ## @@ -0,0 +1,230 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-04 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r300364605 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-04 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r300385330 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.h ## @@ -0,0 +1,127 @@ +// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-04 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r300368589 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-04 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r300365580 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] bd7ce opened a new issue #1428: 使用Power BI连接到doris时提示:MySQL: No matching function with signature:utc_timestamp().

2019-07-04 Thread GitBox
bd7ce opened a new issue #1428: 使用Power BI连接到doris时提示:MySQL: No matching function with signature:utc_timestamp(). URL: https://github.com/apache/incubator-doris/issues/1428 如题。貌似为缺乏 utc_timestamp()函数。 Power BI Desktop是个人免费使用的BI工具,建议增加支持。 -

[GitHub] [incubator-doris] morningman commented on issue #1428: 使用Power BI连接到doris时提示:MySQL: No matching function with signature:utc_timestamp().

2019-07-04 Thread GitBox
morningman commented on issue #1428: 使用Power BI连接到doris时提示:MySQL: No matching function with signature:utc_timestamp(). URL: https://github.com/apache/incubator-doris/issues/1428#issuecomment-508606004 Could you offer the full SQL? You may find it in fe.audit.log ---

[GitHub] [incubator-doris] morningman commented on issue #1416: ETL_SUBMIT_FAIL problem

2019-07-04 Thread GitBox
morningman commented on issue #1416: ETL_SUBMIT_FAIL problem URL: https://github.com/apache/incubator-doris/issues/1416#issuecomment-508606336 > 测试过程我我发现Load的性能不高,我在hdfs的一个目录下放了20G数据,22个文件,表字段150个,入库使用了1小时17分钟,这个性能对于一个MPP入库来说,感觉性能不太好。硬件配置上,doris使用万兆网,hadoop使用千兆网,SSD磁盘。性能有调优的空间吗? 这个测

[GitHub] [incubator-doris] morningman edited a comment on issue #1416: ETL_SUBMIT_FAIL problem

2019-07-04 Thread GitBox
morningman edited a comment on issue #1416: ETL_SUBMIT_FAIL problem URL: https://github.com/apache/incubator-doris/issues/1416#issuecomment-508606336 > 测试过程我我发现Load的性能不高,我在hdfs的一个目录下放了20G数据,22个文件,表字段150个,入库使用了1小时17分钟,这个性能对于一个MPP入库来说,感觉性能不太好。硬件配置上,doris使用万兆网,hadoop使用千兆网,SSD磁盘。性能有调优的空间吗?

[GitHub] [incubator-doris] morningman opened a new issue #1429: Refactor the process of ALTER job.

2019-07-04 Thread GitBox
morningman opened a new issue #1429: Refactor the process of ALTER job. URL: https://github.com/apache/incubator-doris/issues/1429 # Alter Job 重构 Alter Job 主要包括 Schema Change 和 Rollup 两类。 ## 当前问题 1. Job 执行慢 所有 task 下发给 BE 后,会在指定的线程池中排队处理。每一个 task 执行前,都要等当前 BE

[GitHub] [incubator-doris] morningman commented on issue #1393: Schema change job could not finished

2019-07-04 Thread GitBox
morningman commented on issue #1393: Schema change job could not finished URL: https://github.com/apache/incubator-doris/issues/1393#issuecomment-508607311 will be resolved in #1429 This is an automated message from the Apac

[GitHub] [incubator-doris] HangyuanLiu commented on issue #1428: 使用Power BI连接到doris时提示:MySQL: No matching function with signature:utc_timestamp().

2019-07-04 Thread GitBox
HangyuanLiu commented on issue #1428: 使用Power BI连接到doris时提示:MySQL: No matching function with signature:utc_timestamp(). URL: https://github.com/apache/incubator-doris/issues/1428#issuecomment-508609027 我可以帮组增加utc_timestamp()函数功能

[GitHub] [incubator-doris] ltylty commented on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris

2019-07-04 Thread GitBox
ltylty commented on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris URL: https://github.com/apache/incubator-doris/issues/1427#issuecomment-508612948 @imay com.mysql.cj.jdbc.Driver work fine on master branch, thank you. This

[GitHub] [incubator-doris] un-knower opened a new issue #1430: ##fe安装启动后,mysql是自带的吗

2019-07-04 Thread GitBox
un-knower opened a new issue #1430: ##fe安装启动后,mysql是自带的吗 URL: https://github.com/apache/incubator-doris/issues/1430 > “BE 节点需要先在 FE 中添加,才可加入集群。可以使用 mysql-client 连接到FE:./mysql-client -h host -P port -uroot” 看到这个很疑惑,需要单独安装mysql-client吗 -

[GitHub] [incubator-doris] un-knower closed issue #1430: ##fe安装启动后,mysql是自带的吗

2019-07-04 Thread GitBox
un-knower closed issue #1430: ##fe安装启动后,mysql是自带的吗 URL: https://github.com/apache/incubator-doris/issues/1430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] un-knower commented on issue #1430: ##fe安装启动后,mysql是自带的吗

2019-07-04 Thread GitBox
un-knower commented on issue #1430: ##fe安装启动后,mysql是自带的吗 URL: https://github.com/apache/incubator-doris/issues/1430#issuecomment-508613941 自装mysql-clicnt,执行mysql -h localhost -P 9030 -uroot成功登陆了mysql This is an automated mess

[GitHub] [incubator-doris] chenhao7253886 opened a new issue #1431: Simplify Query's Profile info

2019-07-04 Thread GitBox
chenhao7253886 opened a new issue #1431: Simplify Query's Profile info URL: https://github.com/apache/incubator-doris/issues/1431 Now it seems that Query's profiles exist some redundant infos, i will check it and decide if to simplify it. ---

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1432: Add percentile_approx aggregate function

2019-07-04 Thread GitBox
HangyuanLiu opened a new pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432 Add the percentile_approx function 1. Using the T-Digest algorithm to calculate the quantile calculation 2. The function is an approximation f

[GitHub] [incubator-doris] ltylty commented on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris

2019-07-04 Thread GitBox
ltylty commented on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris URL: https://github.com/apache/incubator-doris/issues/1427#issuecomment-508640890 有个bug,jdbc的url配置成 jdbc:mysql://{}:{}/{}?useUnicode=true&characterEncoding=UTF-8&serverTimezone=GMT%2B8 会报错 Caused by: java.sql.SQL

[GitHub] [incubator-doris] ltylty edited a comment on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris

2019-07-04 Thread GitBox
ltylty edited a comment on issue #1427: com.mysql.cj.jdbc.Driver驱动类连不上doris URL: https://github.com/apache/incubator-doris/issues/1427#issuecomment-508640890 @imay 有个bug,jdbc的url配置成 jdbc:mysql://{}:{}/{}?useUnicode=true&characterEncoding=UTF-8&serverTimezone=GMT%2B8 会报错 Caused

[GitHub] [incubator-doris] morningman opened a new pull request #1433: Add a configuration to modify the reverse time of load error log

2019-07-04 Thread GitBox
morningman opened a new pull request #1433: Add a configuration to modify the reverse time of load error log URL: https://github.com/apache/incubator-doris/pull/1433 Currently, the load error log on BE will be cleaned along with the intermediate data of load, configured by 'load_data_res

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1434: Add aggregate function doc

2019-07-05 Thread GitBox
HangyuanLiu opened a new pull request #1434: Add aggregate function doc URL: https://github.com/apache/incubator-doris/pull/1434 Add aggregate function doc This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] Youngwb opened a new pull request #1435: Fix spelling mistake

2019-07-05 Thread GitBox
Youngwb opened a new pull request #1435: Fix spelling mistake URL: https://github.com/apache/incubator-doris/pull/1435 fix spelling mistake bddje->bdbje This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] morningman commented on a change in pull request #1434: Add aggregate function doc

2019-07-05 Thread GitBox
morningman commented on a change in pull request #1434: Add aggregate function doc URL: https://github.com/apache/incubator-doris/pull/1434#discussion_r300580076 ## File path: docs/documentation/cn/sql-reference/sql-functions/aggregate-functions/count_distinct.md ## @@ -0

[GitHub] [incubator-doris] morningman commented on a change in pull request #1434: Add aggregate function doc

2019-07-05 Thread GitBox
morningman commented on a change in pull request #1434: Add aggregate function doc URL: https://github.com/apache/incubator-doris/pull/1434#discussion_r300587324 ## File path: docs/documentation/cn/sql-reference/sql-functions/aggregate-functions/var_pop.md ## @@ -0,0 +1,1

[GitHub] [incubator-doris] morningman commented on a change in pull request #1434: Add aggregate function doc

2019-07-05 Thread GitBox
morningman commented on a change in pull request #1434: Add aggregate function doc URL: https://github.com/apache/incubator-doris/pull/1434#discussion_r300586629 ## File path: docs/documentation/cn/sql-reference/sql-functions/aggregate-functions/stddev.md ## @@ -0,0 +1,19

[GitHub] [incubator-doris] morningman commented on a change in pull request #1434: Add aggregate function doc

2019-07-05 Thread GitBox
morningman commented on a change in pull request #1434: Add aggregate function doc URL: https://github.com/apache/incubator-doris/pull/1434#discussion_r300580803 ## File path: docs/documentation/cn/sql-reference/sql-functions/aggregate-functions/group_concat.md ## @@ -0,0

[GitHub] [incubator-doris] morningman commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-05 Thread GitBox
morningman commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r300588956 ## File path: be/test/exprs/percentile_approx_test.cpp ## @@ -0,0 +1,46 @@ +// Licensed to the Ap

[GitHub] [incubator-doris] wang-ye opened a new pull request #1436: Fix broken image link

2019-07-06 Thread GitBox
wang-ye opened a new pull request #1436: Fix broken image link URL: https://github.com/apache/incubator-doris/pull/1436 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-doris] morningman merged pull request #1436: Fix broken image link

2019-07-06 Thread GitBox
morningman merged pull request #1436: Fix broken image link URL: https://github.com/apache/incubator-doris/pull/1436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] morningman merged pull request #1435: Fix spelling mistake

2019-07-06 Thread GitBox
morningman merged pull request #1435: Fix spelling mistake URL: https://github.com/apache/incubator-doris/pull/1435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1437: Resolve the problem of accidental pause in RoutineLoadJob

2019-07-07 Thread GitBox
EmmyMiao87 opened a new pull request #1437: Resolve the problem of accidental pause in RoutineLoadJob URL: https://github.com/apache/incubator-doris/pull/1437 The issue is following: Request1: be aborts the txn. Attachment of txn is set. Attachment of txn is changed to nul

[GitHub] [incubator-doris] morningman commented on a change in pull request #1437: Resolve the problem of accidental pause in RoutineLoadJob

2019-07-07 Thread GitBox
morningman commented on a change in pull request #1437: Resolve the problem of accidental pause in RoutineLoadJob URL: https://github.com/apache/incubator-doris/pull/1437#discussion_r300858169 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java ###

[GitHub] [incubator-doris] morningman commented on issue #1428: 使用Power BI连接到doris时提示:MySQL: No matching function with signature:utc_timestamp().

2019-07-07 Thread GitBox
morningman commented on issue #1428: 使用Power BI连接到doris时提示:MySQL: No matching function with signature:utc_timestamp(). URL: https://github.com/apache/incubator-doris/issues/1428#issuecomment-509053704 > 我可以帮组增加utc_timestamp()函数功能 Nice! But notice that Doris does not support setting

[GitHub] [incubator-doris] morningman merged pull request #1437: Resolve the problem of accidental pause in RoutineLoadJob

2019-07-07 Thread GitBox
morningman merged pull request #1437: Resolve the problem of accidental pause in RoutineLoadJob URL: https://github.com/apache/incubator-doris/pull/1437 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] chenhao7253886 opened a new issue #1438: Predicates can't be pushed down through AggregationNode

2019-07-07 Thread GitBox
chenhao7253886 opened a new issue #1438: Predicates can't be pushed down through AggregationNode URL: https://github.com/apache/incubator-doris/issues/1438 **Describe the bug** A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior:

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1439: Modify bugs in sample variance and variance confusion

2019-07-07 Thread GitBox
HangyuanLiu opened a new pull request #1439: Modify bugs in sample variance and variance confusion URL: https://github.com/apache/incubator-doris/pull/1439 1 . variance same as var_pop 2. stddev same as stddev_pop This is

[GitHub] [incubator-doris] morningman merged pull request #1439: Fix bugs in sample variance and variance confusion

2019-07-07 Thread GitBox
morningman merged pull request #1439: Fix bugs in sample variance and variance confusion URL: https://github.com/apache/incubator-doris/pull/1439 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-doris] chaoyli opened a new issue #1440: non-sense segment is been generated

2019-07-08 Thread GitBox
chaoyli opened a new issue #1440: non-sense segment is been generated URL: https://github.com/apache/incubator-doris/issues/1440 When doing schema change, error occurs when flushing segment. ![image](https://user-images.githubusercontent.com/44767902/60794369-35bc1700-a19c-11e9-9018-9d6d

[GitHub] [incubator-doris] chaoyli commented on issue #1440: non-sense segment is been generated

2019-07-08 Thread GitBox
chaoyli commented on issue #1440: non-sense segment is been generated URL: https://github.com/apache/incubator-doris/issues/1440#issuecomment-509127679 Segment which size reaches OLAP_MAX_COLUMN_SEGMENT_FILE_SIZE will be flushed into disk. If the previous segment reach the threshold ju

[GitHub] [incubator-doris] chaoyli opened a new pull request #1441: Fix bug of generating non-sense segment when close ColumnDataWriter

2019-07-08 Thread GitBox
chaoyli opened a new pull request #1441: Fix bug of generating non-sense segment when close ColumnDataWriter URL: https://github.com/apache/incubator-doris/pull/1441 #1440 This is an automated message from the Apache Git Ser

[GitHub] [incubator-doris] morningman opened a new pull request #1442: Fix bug that unable to delete redundant replicas

2019-07-08 Thread GitBox
morningman opened a new pull request #1442: Fix bug that unable to delete redundant replicas URL: https://github.com/apache/incubator-doris/pull/1442 This can happen if the Doris cluster is deployed with all, for example, SSD medium, but create all tables with HDD storage medium propert

[GitHub] [incubator-doris] chaoyli merged pull request #1441: Fix bug of generating non-sense segment when close ColumnDataWriter

2019-07-08 Thread GitBox
chaoyli merged pull request #1441: Fix bug of generating non-sense segment when close ColumnDataWriter URL: https://github.com/apache/incubator-doris/pull/1441 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-doris] bigtreeliujie commented on issue #676: New SQL Optimizer

2019-07-08 Thread GitBox
bigtreeliujie commented on issue #676: New SQL Optimizer URL: https://github.com/apache/incubator-doris/issues/676#issuecomment-509161767 This is a huge improvement for doris! This is an automated message from the Apache Git S

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
EmmyMiao87 opened a new pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443 The new class named 'AuthorizationInfo' is used to save the auth info in jobs. The job doesn't need to retrieve the auth info by meta id which maybe throw th

[GitHub] [incubator-doris] morningman opened a new pull request #1444: Modify insert operation's behavior when all partitions have no data to load

2019-07-08 Thread GitBox
morningman opened a new pull request #1444: Modify insert operation's behavior when all partitions have no data to load URL: https://github.com/apache/incubator-doris/pull/1444 Before changing default insert operation to streaming load, if the select result of a insert stmt is empty, a

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load

2019-07-08 Thread GitBox
EmmyMiao87 commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load URL: https://github.com/apache/incubator-doris/pull/1444#discussion_r301047445 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/InsertLoadJo

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load

2019-07-08 Thread GitBox
EmmyMiao87 commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load URL: https://github.com/apache/incubator-doris/pull/1444#discussion_r301055605 ## File path: fe/src/main/java/org/apache/doris/transaction/Transaction

[GitHub] [incubator-doris] morningman commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
morningman commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301055381 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -367,29 +382,54 @@ public void

[GitHub] [incubator-doris] morningman commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
morningman commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301055939 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -185,6 +185,21 @@ public long

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301058545 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -185,6 +185,21 @@ public long

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301061694 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -367,29 +382,54 @@ public void

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301061694 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -367,29 +382,54 @@ public void

[GitHub] [incubator-doris] morningman commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load

2019-07-08 Thread GitBox
morningman commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load URL: https://github.com/apache/incubator-doris/pull/1444#discussion_r301100307 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/InsertLoadJo

[GitHub] [incubator-doris] morningman commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load

2019-07-08 Thread GitBox
morningman commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load URL: https://github.com/apache/incubator-doris/pull/1444#discussion_r301100346 ## File path: fe/src/main/java/org/apache/doris/transaction/Transaction

[GitHub] [incubator-doris] Xuxue1 opened a new pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
Xuxue1 opened a new pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445 Add string function split_part. Just like postgresql This is an automated message from the Apache

[GitHub] [incubator-doris] Xuxue1 opened a new pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
Xuxue1 opened a new pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445 Add string function split_part. Just like postgresql This is an automated message from the Apache

[GitHub] [incubator-doris] imay closed pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay closed pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-doris] chaoyli opened a new pull request #1446: Remove unused imported package in FE

2019-07-08 Thread GitBox
chaoyli opened a new pull request #1446: Remove unused imported package in FE URL: https://github.com/apache/incubator-doris/pull/1446 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] chaoyli merged pull request #1446: Remove unused imported package in FE

2019-07-08 Thread GitBox
chaoyli merged pull request #1446: Remove unused imported package in FE URL: https://github.com/apache/incubator-doris/pull/1446 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
chenhao7253886 commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301363914 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::mone

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-08 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r301364547 ## File path: be/test/exprs/percentile_approx_test.cpp ## @@ -0,0 +1,46 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-08 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r301364199 ## File path: be/src/util/tdigest.h ## @@ -0,0 +1,728 @@ +/* Review comment: you can add ASF head

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-08 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r301366914 ## File path: fe/src/main/java/org/apache/doris/catalog/FunctionSet.java ## @@ -957,6 +957,25 @@ privat

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-08 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r301364084 ## File path: be/src/exprs/aggregate_functions.cpp ## @@ -231,6 +232,81 @@ void AggregateFunctions::avg

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-08 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r301364484 ## File path: be/src/util/tdigest.h ## @@ -0,0 +1,728 @@ +/* + * Licensed to Derrick R. Burns under one

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368553 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368087 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368106 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368155 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368501 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368188 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368361 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368405 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay merged pull request #1444: Modify insert operation's behavior

2019-07-08 Thread GitBox
imay merged pull request #1444: Modify insert operation's behavior URL: https://github.com/apache/incubator-doris/pull/1444 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] imay commented on a change in pull request #1418: Set stmt support Expr

2019-07-08 Thread GitBox
imay commented on a change in pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r301371735 ## File path: fe/src/main/java/org/apache/doris/analysis/CastExpr.java ## @@ -250,6 +250,7 @@ public boolean canHashPartiti

[GitHub] [incubator-doris] imay merged pull request #1433: Add a configuration to modify the reverse time of load error log

2019-07-08 Thread GitBox
imay merged pull request #1433: Add a configuration to modify the reverse time of load error log URL: https://github.com/apache/incubator-doris/pull/1433 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] imay merged pull request #1442: Fix bug that unable to delete redundant replicas

2019-07-08 Thread GitBox
imay merged pull request #1442: Fix bug that unable to delete redundant replicas URL: https://github.com/apache/incubator-doris/pull/1442 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] Xuxue1 closed pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
Xuxue1 closed pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-doris] Xuxue1 commented on issue #1445: Add string function split_part

2019-07-08 Thread GitBox
Xuxue1 commented on issue #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#issuecomment-509467533 感谢指出问题, 我仔细修改下再提交。 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-doris] imay commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
imay commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301377754 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -236,6 +254,8 @@ protected void setJo

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1418: Set stmt support Expr

2019-07-08 Thread GitBox
chenhao7253886 commented on a change in pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r301381068 ## File path: fe/src/main/java/org/apache/doris/analysis/CastExpr.java ## @@ -250,6 +250,7 @@ public boolean can

[GitHub] [incubator-doris] imay merged pull request #1418: Set stmt support Expr

2019-07-08 Thread GitBox
imay merged pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1447: Fix bug that BE crashs when insert null value to the not null column

2019-07-08 Thread GitBox
chenhao7253886 opened a new pull request #1447: Fix bug that BE crashs when insert null value to the not null column URL: https://github.com/apache/incubator-doris/pull/1447 …mn can't be null This is an automated message from

[GitHub] [incubator-doris] morningman commented on a change in pull request #1447: Fix bug that BE crashs when insert null value to the not null column

2019-07-09 Thread GitBox
morningman commented on a change in pull request #1447: Fix bug that BE crashs when insert null value to the not null column URL: https://github.com/apache/incubator-doris/pull/1447#discussion_r301426993 ## File path: be/src/exec/olap_table_sink.cpp ## @@ -640,14 +640,25 @

[GitHub] [incubator-doris] morningman commented on a change in pull request #1447: Fix bug that BE crashs when insert null value to the not null column

2019-07-09 Thread GitBox
morningman commented on a change in pull request #1447: Fix bug that BE crashs when insert null value to the not null column URL: https://github.com/apache/incubator-doris/pull/1447#discussion_r301424891 ## File path: be/src/exec/olap_table_sink.cpp ## @@ -640,14 +640,25 @

[GitHub] [incubator-doris] imay commented on a change in pull request #1447: Fix bug that BE crashs when insert null value to the not null column

2019-07-09 Thread GitBox
imay commented on a change in pull request #1447: Fix bug that BE crashs when insert null value to the not null column URL: https://github.com/apache/incubator-doris/pull/1447#discussion_r301428707 ## File path: be/src/exec/olap_table_sink.cpp ## @@ -640,14 +640,25 @@ void

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1447: Fix bug that BE crashes when inserting null value to non-nullable columns

2019-07-09 Thread GitBox
EmmyMiao87 commented on a change in pull request #1447: Fix bug that BE crashes when inserting null value to non-nullable columns URL: https://github.com/apache/incubator-doris/pull/1447#discussion_r301443551 ## File path: be/src/exec/olap_table_sink.cpp ## @@ -640,14 +640

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1447: Fix bug that BE crashes when inserting null value to non-nullable columns

2019-07-09 Thread GitBox
chenhao7253886 commented on a change in pull request #1447: Fix bug that BE crashes when inserting null value to non-nullable columns URL: https://github.com/apache/incubator-doris/pull/1447#discussion_r301444866 ## File path: be/src/exec/olap_table_sink.cpp ## @@ -640,14

<    9   10   11   12   13   14   15   16   17   18   >