[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298922286 ## File path: be/src/olap/olap_index.h ## @@ -87,13 +83,11 @@ struct OLAPIndexOffset { //

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298908687 ## File path: be/src/olap/olap_index.h ## @@ -133,37 +127,35 @@ struct RowBlockPosition {

[GitHub] [incubator-doris] zttaotao2013 commented on issue #1416: ETL_SUBMIT_FAIL problem

2019-07-01 Thread GitBox
zttaotao2013 commented on issue #1416: ETL_SUBMIT_FAIL problem URL: https://github.com/apache/incubator-doris/issues/1416#issuecomment-507174285 改完后不再报上面那个错误了,但报了Broker etl failed:Memory limit exceeded的错误。 This is an automate

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-01 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298940249 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,183 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-01 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298941841 ## File path: be/src/olap/olap_index.h ## @@ -133,37 +127,35 @@ struct RowBlockPosition {

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-01 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298941806 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,183 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-01 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298942725 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,183 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-01 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298942828 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,183 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-01 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298942713 ## File path: be/src/olap/olap_index.h ## @@ -87,13 +83,11 @@ struct OLAPIndexOffset { // 唯一标识

[GitHub] [incubator-doris] imay commented on issue #1416: ETL_SUBMIT_FAIL problem

2019-07-01 Thread GitBox
imay commented on issue #1416: ETL_SUBMIT_FAIL problem URL: https://github.com/apache/incubator-doris/issues/1416#issuecomment-507178496 set exec_mem_limit = xxx xxx's unit is in bytes whose default value is 2GB This is a

[GitHub] [incubator-doris] zhaomingzhu commented on issue #1399: llvm 无法编译

2019-07-01 Thread GitBox
zhaomingzhu commented on issue #1399: llvm 无法编译 URL: https://github.com/apache/incubator-doris/issues/1399#issuecomment-507187131 sorry 依然报错。 使用你们docker 环境编译fe和自己设置环境编译FE,出现同样错误。 网络可以通,但是maven依赖包无法下载。 [ERROR] Plugin net.sourceforge.czt.dev:cup-maven-plugin:1.6-cdh or one of its d

[GitHub] [incubator-doris] zttaotao2013 commented on issue #1416: ETL_SUBMIT_FAIL problem

2019-07-01 Thread GitBox
zttaotao2013 commented on issue #1416: ETL_SUBMIT_FAIL problem URL: https://github.com/apache/incubator-doris/issues/1416#issuecomment-507193035 我用的是0.10.0-rc04版本,该版本支持“不需要全部加载到内存中”特性么? This is an automated message from the A

[GitHub] [incubator-doris] zhaomingzhu commented on issue #1399: llvm 无法编译

2019-07-01 Thread GitBox
zhaomingzhu commented on issue #1399: llvm 无法编译 URL: https://github.com/apache/incubator-doris/issues/1399#issuecomment-507206582 Thanks ,this problem has been solved by adding proxies for mvn config。 but compile BE code is error。 Question 3: ../olap/libOlap.a(utils.cpp.o):在函数‘boost

[GitHub] [incubator-doris] imay commented on issue #1416: ETL_SUBMIT_FAIL problem

2019-07-01 Thread GitBox
imay commented on issue #1416: ETL_SUBMIT_FAIL problem URL: https://github.com/apache/incubator-doris/issues/1416#issuecomment-507208871 > 我用的是0.10.0-rc04版本,该版本支持“不需要全部加载到内存中”特性么? This is supported in current master branch. not in 0.10.0 -

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-01 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298980096 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,64 @@ MemIndex::~MemIndex() { for

[GitHub] [incubator-doris] imay merged pull request #1173: load data from Parquet file (Issues #911)

2019-07-01 Thread GitBox
imay merged pull request #1173: load data from Parquet file (Issues #911) URL: https://github.com/apache/incubator-doris/pull/1173 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] zttaotao2013 commented on issue #1416: ETL_SUBMIT_FAIL problem

2019-07-01 Thread GitBox
zttaotao2013 commented on issue #1416: ETL_SUBMIT_FAIL problem URL: https://github.com/apache/incubator-doris/issues/1416#issuecomment-507212748 ok,3q This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r298984233 ## File path: be/src/olap/olap_index.h ## @@ -87,13 +83,11 @@ struct OLAPIndexOffset { //

[GitHub] [incubator-doris] kangpinghuang commented on issue #1408: Add dict encoding page

2019-07-01 Thread GitBox
kangpinghuang commented on issue #1408: Add dict encoding page URL: https://github.com/apache/incubator-doris/issues/1408#issuecomment-507220068 pls refer to PR #1409 This is an automated message from the Apache Git Service.

[GitHub] [incubator-doris] zttaotao2013 commented on issue #1416: ETL_SUBMIT_FAIL problem

2019-07-01 Thread GitBox
zttaotao2013 commented on issue #1416: ETL_SUBMIT_FAIL problem URL: https://github.com/apache/incubator-doris/issues/1416#issuecomment-507497496 测试过程我我发现Load的性能不高,我在hdfs的一个目录下放了20G数据,22个文件,表字段150个,入库使用了1小时17分钟,这个性能对于一个MPP入库来说,感觉性能不太好。硬件配置上,doris使用万兆网,hadoop使用千兆网,SSD磁盘。性能有调优的空间吗? -

[GitHub] [incubator-doris] zttaotao2013 commented on issue #1416: ETL_SUBMIT_FAIL problem

2019-07-01 Thread GitBox
zttaotao2013 commented on issue #1416: ETL_SUBMIT_FAIL problem URL: https://github.com/apache/incubator-doris/issues/1416#issuecomment-507499007 磁盘是HDD This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299028699 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299026166 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299028050 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299289567 ## File path: be/src/olap/rowset/segment_v2/encoding_info.h ## @@ -31,8 +34,6 @@ namespace segment_v2 { class PageBuilder;

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299287913 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299287706 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299038874 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299284866 ## File path: be/src/olap/rowset/segment_v2/options.h ## @@ -17,20 +17,19 @@ #pragma once -#include "gen_cpp/segment_v2.pb

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299288208 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299284414 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.h ## @@ -0,0 +1,116 @@ +// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299286552 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299024099 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-01 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299027679 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] yiguolei opened a new pull request #1417: Check if there exist a rowset contains the added rowset

2019-07-01 Thread GitBox
yiguolei opened a new pull request #1417: Check if there exist a rowset contains the added rowset URL: https://github.com/apache/incubator-doris/pull/1417 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1417: Check if there exist a rowset contains the added rowset

2019-07-01 Thread GitBox
kangpinghuang commented on a change in pull request #1417: Check if there exist a rowset contains the added rowset URL: https://github.com/apache/incubator-doris/pull/1417#discussion_r299324034 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -104,7 +10

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1418: SetSmt support Expr

2019-07-02 Thread GitBox
chenhao7253886 opened a new pull request #1418: SetSmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1419: Fix the deadlock of database and loadjob

2019-07-02 Thread GitBox
EmmyMiao87 opened a new pull request #1419: Fix the deadlock of database and loadjob URL: https://github.com/apache/incubator-doris/pull/1419 This commit change the idToTable to concurrent hashmap in database. It don't need to lock the database before getTable. The database will be lock

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1417: Check if there exist a rowset contains the added rowset

2019-07-02 Thread GitBox
yiguolei commented on a change in pull request #1417: Check if there exist a rowset contains the added rowset URL: https://github.com/apache/incubator-doris/pull/1417#discussion_r299345872 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -104,7 +104,7 @

[GitHub] [incubator-doris] imay commented on a change in pull request #1418: SetSmt support Expr

2019-07-02 Thread GitBox
imay commented on a change in pull request #1418: SetSmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299341375 ## File path: fe/src/main/java/org/apache/doris/rewrite/FEFunctions.java ## @@ -666,4 +667,14 @@ public static DecimalLiteral

[GitHub] [incubator-doris] imay commented on a change in pull request #1418: SetSmt support Expr

2019-07-02 Thread GitBox
imay commented on a change in pull request #1418: SetSmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299340887 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -2542,7 +2542,7 @@ option_value_follow_option_type ::= option_value_no_

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299327345 ## File path: be/src/olap/olap_index.cpp ## @@ -102,20 +127,17 @@ OLAPStatus MemIndex::l

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299348582 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299355120 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the A

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299325862 ## File path: be/src/olap/column_data.cpp ## @@ -302,10 +302,9 @@ OLAPStatus ColumnData:

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299351406 ## File path: be/src/olap/olap_index.h ## @@ -87,13 +83,11 @@ struct OLAPIndexOffset {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299356049 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the A

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299331696 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,197 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299347038 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299348135 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299346873 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299357760 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,197 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299354278 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the A

[GitHub] [incubator-doris] imay merged pull request #1419: Fix the deadlock of database and loadjob

2019-07-02 Thread GitBox
imay merged pull request #1419: Fix the deadlock of database and loadjob URL: https://github.com/apache/incubator-doris/pull/1419 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299369366 ## File path: be/src/olap/olap_index.h ## @@ -87,13 +83,11 @@ struct OLAPIndexOffset { // 唯一标识

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299370573 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299370692 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299370940 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371008 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,197 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371062 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() { for

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371129 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() { for

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371157 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() { for

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371219 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() { for

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371455 ## File path: be/src/olap/column_data.cpp ## @@ -302,10 +302,9 @@ OLAPStatus ColumnData::_seek_to

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371502 ## File path: be/src/olap/olap_index.cpp ## @@ -102,20 +127,17 @@ OLAPStatus MemIndex::load_segme

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371962 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,197 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299372288 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299372378 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299372720 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299372447 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299372523 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299373207 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299375828 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] chenhao7253886 opened a new issue #1420: Pruning partitions with string value fails

2019-07-02 Thread GitBox
chenhao7253886 opened a new issue #1420: Pruning partitions with string value fails URL: https://github.com/apache/incubator-doris/issues/1420 Now if the value in predicate about partition column is string, but the partition column is date, we can't prune parititon successfully. I will imp

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299431920 ## File path: be/src/olap/short_key_index.h ## @@ -120,6 +120,11 @@ class ShortKeyIndexI

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299435951 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.h ## @@ -0,0 +1,116 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299432549 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.h ## @@ -0,0 +1,116 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1418: SetSmt support Expr

2019-07-02 Thread GitBox
chenhao7253886 commented on a change in pull request #1418: SetSmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299438737 ## File path: fe/src/main/java/org/apache/doris/rewrite/FEFunctions.java ## @@ -666,4 +667,14 @@ public static Deci

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1418: SetSmt support Expr

2019-07-02 Thread GitBox
chenhao7253886 commented on a change in pull request #1418: SetSmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299438676 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -2542,7 +2542,7 @@ option_value_follow_option_type ::= option

[GitHub] [incubator-doris] morningman opened a new pull request #1421: Forbid adding rollup with REPLACE value but without all key columns.

2019-07-02 Thread GitBox
morningman opened a new pull request #1421: Forbid adding rollup with REPLACE value but without all key columns. URL: https://github.com/apache/incubator-doris/pull/1421 When a rollup table contains value columns of REPLACE aggregation type, all key columns of base table should be includ

[GitHub] [incubator-doris] imay commented on a change in pull request #1418: Set stmt support Expr

2019-07-02 Thread GitBox
imay commented on a change in pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299742745 ## File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java ## @@ -162,13 +160,52 @@ public FEFunctio

[GitHub] [incubator-doris] morningman commented on a change in pull request #1418: Set stmt support Expr

2019-07-02 Thread GitBox
morningman commented on a change in pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299743123 ## File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java ## @@ -162,13 +160,52 @@ public FEF

[GitHub] [incubator-doris] imay merged pull request #1421: Forbid adding rollup with REPLACE value but without all key columns.

2019-07-02 Thread GitBox
imay merged pull request #1421: Forbid adding rollup with REPLACE value but without all key columns. URL: https://github.com/apache/incubator-doris/pull/1421 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-doris] morningman opened a new pull request #1422: Cast the type of constant value in binary predicate to column type.

2019-07-02 Thread GitBox
morningman opened a new pull request #1422: Cast the type of constant value in binary predicate to column type. URL: https://github.com/apache/incubator-doris/pull/1422 If one child of a binary predicate is column, and the other is a constant expr, set the compatible type to column's ty

[GitHub] [incubator-doris] imay closed issue #1336: 建议添加dayofweek函数

2019-07-02 Thread GitBox
imay closed issue #1336: 建议添加dayofweek函数 URL: https://github.com/apache/incubator-doris/issues/1336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] imay commented on a change in pull request #1422: Cast the type of constant value in binary predicate to column type.

2019-07-02 Thread GitBox
imay commented on a change in pull request #1422: Cast the type of constant value in binary predicate to column type. URL: https://github.com/apache/incubator-doris/pull/1422#discussion_r299746936 ## File path: fe/src/main/java/org/apache/doris/analysis/BinaryPredicate.java ###

[GitHub] [incubator-doris] zhaomingzhu closed issue #1399: llvm 无法编译

2019-07-02 Thread GitBox
zhaomingzhu closed issue #1399: llvm 无法编译 URL: https://github.com/apache/incubator-doris/issues/1399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] zhaomingzhu commented on issue #1399: llvm 无法编译

2019-07-02 Thread GitBox
zhaomingzhu commented on issue #1399: llvm 无法编译 URL: https://github.com/apache/incubator-doris/issues/1399#issuecomment-507909117 重新安装环境编译成功。 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1417: Check if there exist a rowset contains the added rowset

2019-07-02 Thread GitBox
kangpinghuang commented on a change in pull request #1417: Check if there exist a rowset contains the added rowset URL: https://github.com/apache/incubator-doris/pull/1417#discussion_r299792880 ## File path: be/src/olap/rowset/segment_group.cpp ## @@ -766,29 +775,35 @@ OLA

[GitHub] [incubator-doris] chaoyli merged pull request #1417: Check if there exist a rowset contains the added rowset

2019-07-03 Thread GitBox
chaoyli merged pull request #1417: Check if there exist a rowset contains the added rowset URL: https://github.com/apache/incubator-doris/pull/1417 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] chaoyli opened a new pull request #1423: Fix tablet null pointer and wrong number of rows

2019-07-03 Thread GitBox
chaoyli opened a new pull request #1423: Fix tablet null pointer and wrong number of rows URL: https://github.com/apache/incubator-doris/pull/1423 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-doris] chaoyli merged pull request #1423: Fix tablet null pointer and wrong number of rows

2019-07-03 Thread GitBox
chaoyli merged pull request #1423: Fix tablet null pointer and wrong number of rows URL: https://github.com/apache/incubator-doris/pull/1423 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-doris] chaoyli opened a new pull request #1424: Fix tablet null pointer and wrong number of rows

2019-07-03 Thread GitBox
chaoyli opened a new pull request #1424: Fix tablet null pointer and wrong number of rows URL: https://github.com/apache/incubator-doris/pull/1424 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-doris] chaoyli merged pull request #1424: Fix tablet null pointer and wrong number of rows

2019-07-03 Thread GitBox
chaoyli merged pull request #1424: Fix tablet null pointer and wrong number of rows URL: https://github.com/apache/incubator-doris/pull/1424 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #1390: Support zone map for column

2019-07-03 Thread GitBox
kangpinghuang edited a comment on issue #1390: Support zone map for column URL: https://github.com/apache/incubator-doris/issues/1390#issuecomment-508015441 here is my design: 1. define ZoneMap with serialize and deserialize class ZoneMap { public: serialize(); deserializ

[GitHub] [incubator-doris] kangpinghuang commented on issue #1390: Support zone map for column

2019-07-03 Thread GitBox
kangpinghuang commented on issue #1390: Support zone map for column URL: https://github.com/apache/incubator-doris/issues/1390#issuecomment-508015441 here is my design: 1. define ZoneMap with serialize and deserialize class ZoneMap { public: serialize(); deserialize();

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #1390: Support zone map for column

2019-07-03 Thread GitBox
kangpinghuang edited a comment on issue #1390: Support zone map for column URL: https://github.com/apache/incubator-doris/issues/1390#issuecomment-508015441 here is my design: 1. define ZoneMap with serialize and deserialize class ZoneMap { public: serialize(); deserializ

[GitHub] [incubator-doris] imay merged pull request #1422: Cast the type of constant value in binary predicate to column type.

2019-07-03 Thread GitBox
imay merged pull request #1422: Cast the type of constant value in binary predicate to column type. URL: https://github.com/apache/incubator-doris/pull/1422 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1418: Set stmt support Expr

2019-07-03 Thread GitBox
chenhao7253886 commented on a change in pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r300166455 ## File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java ## @@ -162,13 +160,52 @@ publi

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1418: Set stmt support Expr

2019-07-03 Thread GitBox
chenhao7253886 commented on a change in pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r300166835 ## File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java ## @@ -162,13 +160,52 @@ publi

<    8   9   10   11   12   13   14   15   16   17   >