[GitHub] [incubator-doris] kangkaisen commented on issue #1356: Wrong query result with constant

2019-06-21 Thread GitBox
kangkaisen commented on issue #1356: Wrong query result with constant URL: https://github.com/apache/incubator-doris/issues/1356#issuecomment-504405059 why the poi_second_city_id IN (-1) predicate is used to prune partition? 1 poi_second_city_id IN (-1) is -1 in (-1) 2 In `Si

[GitHub] [incubator-doris] imay commented on issue #1356: Wrong query result with constant

2019-06-21 Thread GitBox
imay commented on issue #1356: Wrong query result with constant URL: https://github.com/apache/incubator-doris/issues/1356#issuecomment-504407905 I think the problem located in step `3`. `-1 in (-1)` can not be used to prune partition. What we want to use to prune partition is in predicat

[GitHub] [incubator-doris] morningman opened a new pull request #1358: Increase the timeout of publish version task

2019-06-21 Thread GitBox
morningman opened a new pull request #1358: Increase the timeout of publish version task URL: https://github.com/apache/incubator-doris/pull/1358 The origin timeout of publish version task of a transaction is 3 seconds. This timeout is too short that may cause a problem that some of publ

[GitHub] [incubator-doris] morningman closed pull request #1358: Increase the timeout of publish version task

2019-06-21 Thread GitBox
morningman closed pull request #1358: Increase the timeout of publish version task URL: https://github.com/apache/incubator-doris/pull/1358 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] imay merged pull request #1353: Add Checkstyle for doris-fe

2019-06-21 Thread GitBox
imay merged pull request #1353: Add Checkstyle for doris-fe URL: https://github.com/apache/incubator-doris/pull/1353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-doris] imay merged pull request #1357: Fix wrong query result with constant InPredicate

2019-06-21 Thread GitBox
imay merged pull request #1357: Fix wrong query result with constant InPredicate URL: https://github.com/apache/incubator-doris/pull/1357 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] imay merged pull request #1344: Add more UT for FEFunctions

2019-06-21 Thread GitBox
imay merged pull request #1344: Add more UT for FEFunctions URL: https://github.com/apache/incubator-doris/pull/1344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] morningman opened a new pull request #1359: Increase the timeout of publish version task when doing alter job

2019-06-21 Thread GitBox
morningman opened a new pull request #1359: Increase the timeout of publish version task when doing alter job URL: https://github.com/apache/incubator-doris/pull/1359 The previous setting of timeout of a publish version task is mess. I change it to a configurable time, default it 30 seco

[GitHub] [incubator-doris] imay opened a new pull request #1360: Fix FE unit test's failure

2019-06-21 Thread GitBox
imay opened a new pull request #1360: Fix FE unit test's failure URL: https://github.com/apache/incubator-doris/pull/1360 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-doris] imay merged pull request #1360: Fix FE unit test's failure

2019-06-21 Thread GitBox
imay merged pull request #1360: Fix FE unit test's failure URL: https://github.com/apache/incubator-doris/pull/1360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] kangkaisen commented on issue #1356: Wrong query result with constant

2019-06-21 Thread GitBox
kangkaisen commented on issue #1356: Wrong query result with constant URL: https://github.com/apache/incubator-doris/issues/1356#issuecomment-504619540 Yes. I see And I agree with you. The issue should be here: ``` if (!expr.isBound(desc.getId())) {

[GitHub] [incubator-doris] morningman opened a new pull request #1359: Increase the timeout of publish version task when doing alter job

2019-06-21 Thread GitBox
morningman opened a new pull request #1359: Increase the timeout of publish version task when doing alter job URL: https://github.com/apache/incubator-doris/pull/1359 The previous setting of timeout of a publish version task is mess. I change it to a configurable time, default it 30 seco

[GitHub] [incubator-doris] morningman closed pull request #1359: Increase the timeout of publish version task when doing alter job

2019-06-21 Thread GitBox
morningman closed pull request #1359: Increase the timeout of publish version task when doing alter job URL: https://github.com/apache/incubator-doris/pull/1359 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-doris] imay merged pull request #1343: Thrift definition for scanning data ability for computing system

2019-06-21 Thread GitBox
imay merged pull request #1343: Thrift definition for scanning data ability for computing system URL: https://github.com/apache/incubator-doris/pull/1343 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] imay merged pull request #1359: Increase the timeout of publish version task when doing alter job

2019-06-21 Thread GitBox
imay merged pull request #1359: Increase the timeout of publish version task when doing alter job URL: https://github.com/apache/incubator-doris/pull/1359 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] chaoyli opened a new pull request #1361: Check get_header status returned

2019-06-22 Thread GitBox
chaoyli opened a new pull request #1361: Check get_header status returned URL: https://github.com/apache/incubator-doris/pull/1361 When performing storage_medium_migration, the header may be already droped. In this scenario, header returned will be null pointer. Saving data to a null p

[GitHub] [incubator-doris] imay commented on a change in pull request #1361: Check get_header status returned

2019-06-22 Thread GitBox
imay commented on a change in pull request #1361: Check get_header status returned URL: https://github.com/apache/incubator-doris/pull/1361#discussion_r296465636 ## File path: be/src/olap/olap_snapshot.cpp ## @@ -718,6 +718,16 @@ OLAPStatus OLAPEngine::storage_medium_migra

[GitHub] [incubator-doris] kangkaisen commented on issue #1289: Modify colocation creation logic

2019-06-22 Thread GitBox
kangkaisen commented on issue #1289: Modify colocation creation logic URL: https://github.com/apache/incubator-doris/pull/1289#issuecomment-504723709 After I tested in my test env, I found two minor issue: 1 This PR don't support cascade colocate join. for example: ```

[GitHub] [incubator-doris] kangkaisen commented on issue #1293: Change default value to NOT NULL when creating table

2019-06-22 Thread GitBox
kangkaisen commented on issue #1293: Change default value to NOT NULL when creating table URL: https://github.com/apache/incubator-doris/pull/1293#issuecomment-504723997 Hi. Please at least add a config for this change, otherwise, there will be a serious case that a lot of load job will fa

[GitHub] [incubator-doris] imay merged pull request #1361: Check get_header status returned

2019-06-23 Thread GitBox
imay merged pull request #1361: Check get_header status returned URL: https://github.com/apache/incubator-doris/pull/1361 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-doris] morningman opened a new issue #1362: Follower FE restart failed

2019-06-23 Thread GitBox
morningman opened a new issue #1362: Follower FE restart failed URL: https://github.com/apache/incubator-doris/issues/1362 **Describe the bug** Restore a follower FE, throw exception: 2019-06-23 17:49:06,546 ERROR 1 [BDBEnvironment.setup():195] error to open replicated environmen

[GitHub] [incubator-doris] chaoyli merged pull request #1363: Check get_meta status returned

2019-06-23 Thread GitBox
chaoyli merged pull request #1363: Check get_meta status returned URL: https://github.com/apache/incubator-doris/pull/1363 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] chaoyli opened a new pull request #1363: Check get_meta status returned

2019-06-23 Thread GitBox
chaoyli opened a new pull request #1363: Check get_meta status returned URL: https://github.com/apache/incubator-doris/pull/1363 When performing storage_medium_migration, the header may be already droped. In this scenario, tablet_meta returned will be null pointer. Saving data to a nul

[GitHub] [incubator-doris] imay closed pull request #1247: Add segment v2 api

2019-06-23 Thread GitBox
imay closed pull request #1247: Add segment v2 api URL: https://github.com/apache/incubator-doris/pull/1247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-doris] imay closed pull request #1285: Optimize page interface

2019-06-23 Thread GitBox
imay closed pull request #1285: Optimize page interface URL: https://github.com/apache/incubator-doris/pull/1285 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] imay closed issue #1318: BE crash when Loading data to unpartitioned table with specified partition

2019-06-23 Thread GitBox
imay closed issue #1318: BE crash when Loading data to unpartitioned table with specified partition URL: https://github.com/apache/incubator-doris/issues/1318 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1364: Fix bug that cast DateLiteral to other types

2019-06-23 Thread GitBox
chenhao7253886 opened a new pull request #1364: Fix bug that cast DateLiteral to other types URL: https://github.com/apache/incubator-doris/pull/1364 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] chaoyli merged pull request #1350: Release schema change lock when get migration lock failed

2019-06-23 Thread GitBox
chaoyli merged pull request #1350: Release schema change lock when get migration lock failed URL: https://github.com/apache/incubator-doris/pull/1350 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] imay merged pull request #1364: Fix bug that cast DateLiteral to other types

2019-06-23 Thread GitBox
imay merged pull request #1364: Fix bug that cast DateLiteral to other types URL: https://github.com/apache/incubator-doris/pull/1364 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1341: Add plain page

2019-06-23 Thread GitBox
kangpinghuang commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295869905 ## File path: be/src/olap/rowset/segment_v2/plain_page.h ## @@ -0,0 +1,170 @@ +#pragma once + +#include "util/coding.h" +

[GitHub] [incubator-doris] kangkaisen opened a new issue #1365: Stream Load error msg no column name

2019-06-23 Thread GitBox
kangkaisen opened a new issue #1365: Stream Load error msg no column name URL: https://github.com/apache/incubator-doris/issues/1365 **Describe the bug** ``` Reason: the length of input is too long than schema. input_str: [onekkk] schema length: 8; actual length: 14; . src lin

[GitHub] [incubator-doris] kangkaisen opened a new pull request #1366: Add varchar column name to stream load error msg

2019-06-23 Thread GitBox
kangkaisen opened a new pull request #1366: Add varchar column name to stream load error msg URL: https://github.com/apache/incubator-doris/pull/1366 For https://github.com/apache/incubator-doris/issues/1365 This is an automa

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-23 Thread GitBox
kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296570993 ## File path: be/src/olap/rowset/segment_v2/encoding_info.cpp ## @@ -33,14 +34,33 @@ struct Typ

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-23 Thread GitBox
kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296076918 ## File path: be/src/olap/rowset/segment_v2/encoding_info.h ## @@ -40,23 +42,28 @@ class Encodi

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-23 Thread GitBox
kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296565161 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -0,0 +1,330 @@ +// Licensed

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-23 Thread GitBox
kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296076877 ## File path: be/src/olap/rowset/segment_v2/encoding_info.h ## @@ -40,23 +42,28 @@ class Encodi

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-23 Thread GitBox
kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296077079 ## File path: be/src/runtime/vectorized_row_batch.h ## @@ -91,10 +93,26 @@ class ColumnVectorVi

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-23 Thread GitBox
kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296560240 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -0,0 +1,330 @@ +// Licensed

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-23 Thread GitBox
kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296561838 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -0,0 +1,330 @@ +// Licensed

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-23 Thread GitBox
kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296565655 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -0,0 +1,330 @@ +// Licensed

[GitHub] [incubator-doris] imay merged pull request #1366: Add varchar column name to stream load error msg

2019-06-23 Thread GitBox
imay merged pull request #1366: Add varchar column name to stream load error msg URL: https://github.com/apache/incubator-doris/pull/1366 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296576675 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -0,0 +1,330 @@ +// Licensed

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1367: Add privilege method for Frontend service

2019-06-24 Thread GitBox
wuyunfeng opened a new pull request #1367: Add privilege method for Frontend service URL: https://github.com/apache/incubator-doris/pull/1367 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] wuyunfeng closed pull request #1367: Add privilege method for Frontend service

2019-06-24 Thread GitBox
wuyunfeng closed pull request #1367: Add privilege method for Frontend service URL: https://github.com/apache/incubator-doris/pull/1367 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] imay commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-24 Thread GitBox
imay commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296584410 ## File path: be/src/olap/rowset/segment_v2/encoding_info.h ## @@ -40,23 +42,28 @@ class EncodingInfo {

[GitHub] [incubator-doris] imay commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-24 Thread GitBox
imay commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296589585 ## File path: be/src/olap/rowset/segment_v2/encoding_info.cpp ## @@ -33,14 +34,33 @@ struct TypeEncoding

[GitHub] [incubator-doris] imay commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-24 Thread GitBox
imay commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296592059 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -0,0 +1,330 @@ +// Licensed to the A

[GitHub] [incubator-doris] chaoyli opened a new pull request #1368: Fix olap_header destruction error

2019-06-24 Thread GitBox
chaoyli opened a new pull request #1368: Fix olap_header destruction error URL: https://github.com/apache/incubator-doris/pull/1368 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] chenhao7253886 opened a new issue #1369: Casting float string to int will return null

2019-06-24 Thread GitBox
chenhao7253886 opened a new issue #1369: Casting float string to int will return null URL: https://github.com/apache/incubator-doris/issues/1369 Because StringParser does't support cast float string to int, as following: mysql> select cast("11.22" as int); +--+

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1370: Add sql-function doc of cast_to_bigint

2019-06-24 Thread GitBox
EmmyMiao87 opened a new pull request #1370: Add sql-function doc of cast_to_bigint URL: https://github.com/apache/incubator-doris/pull/1370 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1370: Add sql-function doc of cast_to_bigint

2019-06-24 Thread GitBox
chenhao7253886 commented on a change in pull request #1370: Add sql-function doc of cast_to_bigint URL: https://github.com/apache/incubator-doris/pull/1370#discussion_r296632521 ## File path: docs/documentation/cn/sql-reference/sql-functions/cast-function/cast_to_bigint.md ###

[GitHub] [incubator-doris] kangkaisen closed issue #1365: Stream Load error msg no column name

2019-06-24 Thread GitBox
kangkaisen closed issue #1365: Stream Load error msg no column name URL: https://github.com/apache/incubator-doris/issues/1365 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] yiguolei opened a new pull request #1371: Fix dead lock bug in storage migration

2019-06-24 Thread GitBox
yiguolei opened a new pull request #1371: Fix dead lock bug in storage migration URL: https://github.com/apache/incubator-doris/pull/1371 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] chaoyli merged pull request #1371: Fix dead lock bug in storage migration

2019-06-24 Thread GitBox
chaoyli merged pull request #1371: Fix dead lock bug in storage migration URL: https://github.com/apache/incubator-doris/pull/1371 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] chaoyli merged pull request #1368: Fix olap_header destruction error

2019-06-24 Thread GitBox
chaoyli merged pull request #1368: Fix olap_header destruction error URL: https://github.com/apache/incubator-doris/pull/1368 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] imay merged pull request #1370: Add sql-function doc of cast_to_bigint

2019-06-24 Thread GitBox
imay merged pull request #1370: Add sql-function doc of cast_to_bigint URL: https://github.com/apache/incubator-doris/pull/1370 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-doris] morningman commented on issue #1289: Modify colocation creation logic

2019-06-24 Thread GitBox
morningman commented on issue #1289: Modify colocation creation logic URL: https://github.com/apache/incubator-doris/pull/1289#issuecomment-504977393 > After I tested in my test env, I found two minor issue: > > 1 This PR don't support cascade colocate join. > > for example:

[GitHub] [incubator-doris] EmmyMiao87 edited a comment on issue #1095: Unifies load flow

2019-06-24 Thread GitBox
EmmyMiao87 edited a comment on issue #1095: Unifies load flow URL: https://github.com/apache/incubator-doris/issues/1095#issuecomment-504322449 I propose to test the performance of streaming broker load and mini load. This test will ignore the effect of rollup and query. The result of test

[GitHub] [incubator-doris] kangkaisen commented on issue #1289: Modify colocation creation logic

2019-06-24 Thread GitBox
kangkaisen commented on issue #1289: Modify colocation creation logic URL: https://github.com/apache/incubator-doris/pull/1289#issuecomment-504984238 @morningman OK, I see. Thank you. This is an automated message from the Apac

[GitHub] [incubator-doris] chaoyli opened a new pull request #1372: Unref MiniLoadCtx before destruction

2019-06-24 Thread GitBox
chaoyli opened a new pull request #1372: Unref MiniLoadCtx before destruction URL: https://github.com/apache/incubator-doris/pull/1372 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] imay closed pull request #1372: Unref MiniLoadCtx before destruction

2019-06-24 Thread GitBox
imay closed pull request #1372: Unref MiniLoadCtx before destruction URL: https://github.com/apache/incubator-doris/pull/1372 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1373: Add tablet version and descriptor table for query paln

2019-06-24 Thread GitBox
wuyunfeng opened a new pull request #1373: Add tablet version and descriptor table for query paln URL: https://github.com/apache/incubator-doris/pull/1373 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1373: Add tablet version and descriptor table for query paln

2019-06-24 Thread GitBox
wuyunfeng opened a new pull request #1373: Add tablet version and descriptor table for query paln URL: https://github.com/apache/incubator-doris/pull/1373 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] morningman closed pull request #1373: Add tablet version and descriptor table for query paln

2019-06-24 Thread GitBox
morningman closed pull request #1373: Add tablet version and descriptor table for query paln URL: https://github.com/apache/incubator-doris/pull/1373 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang opened a new pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297012349 ## File path: be/src/olap/storage_engine.cpp ## @@ -944,6 +944,20 @@ OLAPStatus StorageEngine::execute_task(

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297014765 ## File path: be/src/olap/tablet.cpp ## @@ -839,6 +839,12 @@ bool Tablet::check_path(const std::string& path

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297016665 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { LOG(IN

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297012871 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { LOG(IN

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297016006 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { LOG(IN

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297014671 ## File path: be/src/olap/tablet.h ## @@ -248,6 +252,7 @@ class Tablet : public std::enable_shared_from_this

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297019428 ## File path: be/src/olap/tablet.h ## @@ -248,6 +252,7 @@ class Tablet : public std::enable_shared_from

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297017712 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { L

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297020315 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { L

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297019316 ## File path: be/src/olap/tablet.cpp ## @@ -839,6 +839,12 @@ bool Tablet::check_path(const std::string&

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297017409 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { L

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-25 Thread GitBox
chaoyli commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297037919 ## File path: be/src/olap/tablet.cpp ## @@ -839,6 +839,30 @@ bool Tablet::check_path(const std::string& path_

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-25 Thread GitBox
chaoyli commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297037830 ## File path: be/src/olap/tablet.cpp ## @@ -839,6 +839,30 @@ bool Tablet::check_path(const std::string& path_

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-25 Thread GitBox
chaoyli commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297037578 ## File path: be/src/olap/tablet.cpp ## @@ -839,6 +839,30 @@ bool Tablet::check_path(const std::string& path_

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-25 Thread GitBox
chaoyli commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297024489 ## File path: be/src/olap/storage_engine.cpp ## @@ -944,6 +944,20 @@ OLAPStatus StorageEngine::execute_task(E

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1375: Fix the core of mini load

2019-06-25 Thread GitBox
EmmyMiao87 opened a new pull request #1375: Fix the core of mini load URL: https://github.com/apache/incubator-doris/pull/1375 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] chaoyli merged pull request #1374: add garbase collect by rowsetid

2019-06-25 Thread GitBox
chaoyli merged pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] imay commented on a change in pull request #1375: Fix the core of mini load

2019-06-25 Thread GitBox
imay commented on a change in pull request #1375: Fix the core of mini load URL: https://github.com/apache/incubator-doris/pull/1375#discussion_r297060191 ## File path: be/src/http/action/mini_load.cpp ## @@ -331,12 +339,14 @@ int MiniLoadAction::on_header(HttpRequest* req)

[GitHub] [incubator-doris] EmmyMiao87 edited a comment on issue #1095: Unifies load flow

2019-06-25 Thread GitBox
EmmyMiao87 edited a comment on issue #1095: Unifies load flow URL: https://github.com/apache/incubator-doris/issues/1095#issuecomment-504322449 I propose to test the performance of streaming broker load and mini load. This test will ignore the effect of rollup and query. The result of test

[GitHub] [incubator-doris] EmmyMiao87 edited a comment on issue #1095: Unifies load flow

2019-06-25 Thread GitBox
EmmyMiao87 edited a comment on issue #1095: Unifies load flow URL: https://github.com/apache/incubator-doris/issues/1095#issuecomment-504322449 I propose to test the performance of streaming broker load and mini load. This test will ignore the effect of rollup and query. The result of test

[GitHub] [incubator-doris] chaoyli merged pull request #1346: Add column reader writer for segment V2

2019-06-25 Thread GitBox
chaoyli merged pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1373: Add tablet version and descriptor table for query paln

2019-06-25 Thread GitBox
wuyunfeng opened a new pull request #1373: Add tablet version and descriptor table for query paln URL: https://github.com/apache/incubator-doris/pull/1373 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] wuyunfeng closed pull request #1373: Add tablet version and descriptor table for query paln

2019-06-25 Thread GitBox
wuyunfeng closed pull request #1373: Add tablet version and descriptor table for query paln URL: https://github.com/apache/incubator-doris/pull/1373 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1376: Add dayofweek function

2019-06-25 Thread GitBox
HangyuanLiu opened a new pull request #1376: Add dayofweek function URL: https://github.com/apache/incubator-doris/pull/1376 1.add dayofweek function 2.Merge left/right aliases #1336 This is an automated message from th

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1377: Add some function doc

2019-06-25 Thread GitBox
HangyuanLiu opened a new pull request #1377: Add some function doc URL: https://github.com/apache/incubator-doris/pull/1377 Add some function doc This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-doris] imay merged pull request #1375: Fix the core of mini load

2019-06-25 Thread GitBox
imay merged pull request #1375: Fix the core of mini load URL: https://github.com/apache/incubator-doris/pull/1375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1376: Add dayofweek function

2019-06-25 Thread GitBox
HangyuanLiu opened a new pull request #1376: Add dayofweek function URL: https://github.com/apache/incubator-doris/pull/1376 1.add dayofweek function 2.Merge left/right aliases #1336 This is an automated message from th

[GitHub] [incubator-doris] imay closed pull request #1376: Add dayofweek function

2019-06-25 Thread GitBox
imay closed pull request #1376: Add dayofweek function URL: https://github.com/apache/incubator-doris/pull/1376 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] imay merged pull request #1373: Add tablet version and descriptor table for query paln

2019-06-25 Thread GitBox
imay merged pull request #1373: Add tablet version and descriptor table for query paln URL: https://github.com/apache/incubator-doris/pull/1373 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-doris] imay merged pull request #1377: Add some function doc

2019-06-25 Thread GitBox
imay merged pull request #1377: Add some function doc URL: https://github.com/apache/incubator-doris/pull/1377 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] imay merged pull request #1289: Modify colocation creation logic

2019-06-25 Thread GitBox
imay merged pull request #1289: Modify colocation creation logic URL: https://github.com/apache/incubator-doris/pull/1289 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-doris] imay merged pull request #1376: Add dayofweek function

2019-06-25 Thread GitBox
imay merged pull request #1376: Add dayofweek function URL: https://github.com/apache/incubator-doris/pull/1376 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] morningman opened a new pull request #1378: Optimize Export feature

2019-06-25 Thread GitBox
morningman opened a new pull request #1378: Optimize Export feature URL: https://github.com/apache/incubator-doris/pull/1378 1. Add 'timeout' property in Export stmt. 2. Add 'tablet_num_per_task' property in Export stmt. 2. Add more infos in 'show export' stmt. 3. Add more logs for

[GitHub] [incubator-doris] imay merged pull request #1378: Optimize Export feature

2019-06-25 Thread GitBox
imay merged pull request #1378: Optimize Export feature URL: https://github.com/apache/incubator-doris/pull/1378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] imay merged pull request #1341: Add plain page

2019-06-25 Thread GitBox
imay merged pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

<    6   7   8   9   10   11   12   13   14   15   >