Re:Re: Add more rules to checkstyle.xml in fe

2022-06-14 Thread 陈明雨
I'm not sure if we currently have some overly restrictive rules that the developer hard to follow. However, I think we can try to turn on the required check, observe the recently submitted PR, and if any unreasonable checks are found, modify them in time to prevent such checks from affecting th

Re:Re: Add more rules to checkstyle.xml in fe

2022-06-14 Thread morrysnow
Hi , all devs After this PR: https://github.com/apache/incubator-doris/pull/10134, all checkstyle error has been fixed. So, i want to turn Github workflow 'FE Code Style Checker' to 'Required' after this PR be merged. After #10134 be merged, when compiling fe with `maven`, `CheckStyle` checks

Re:Re: Add more rules to checkstyle.xml in fe

2022-04-28 Thread 陈明雨
That would be great! Some suggestion about the rules: > d. license header check For now, we use skywalking-eyes to check license header, is this rule still needed? > adjust the order of import to "static, org.apache.doris, third party, java" Better not using static import -- 此致!Best Regar