Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread Lijia Liu
+1 回复的原邮件 发件人 mailto:yiguo...@gmail.com";>GuoLei Yi

Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread De Li
+1 李德 l...@apache.org On 2022/04/25 08:13:20 GuoLei Yi wrote: > Hello everyone, with the increasing number of pull requests, we need to > strictly control the code merge process. I plan to turn on "requested" CI > checks, that is, when all "requested" CI checks of a PR pass, the code can > be mer

Re:[DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread stalary
+1 | | stalary | | stal...@163.com | 签名由网易邮箱大师定制 On 04/25/2022 16:13，GuoLei Yi wrote： Hello everyone, with the increasing number of pull requests, we need to strictly control the code merge process. I plan to turn on "requested" CI checks, that is, when all "requested" CI checks of a PR pass, t

Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread 41108453
+1 -- Original -- From: GuoLei Yi

Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread ling miao
> BTW, I have a small problem, currently BE UT, BE UT, P0 regression, Incubator Doris UT are all running with personal accounts, the risk of whether they can continue to run, and also need the account password to view the failure information, so it is not very convenient, can you migrate to the off

Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread zhg yang
+1 BTW, I have a small problem, currently BE UT, BE UT, P0 regression, Incubator Doris UT are all running with personal accounts, the risk of whether they can continue to run, and also need the account password to view the failure information, so it is not very convenient, can you migrate to th

Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread ling miao
1. FE code format should be "requested" in the future. 2. There are some duplicate checks should be removed such as: Incubator Doris UT. 3. I recommend keeping the original P0 check until the P0 case is migrated. 4. I can not login to the new TeamCity. The CI tools should easily accessible to al

Re:[DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread 陈明雨
+1 -- 此致！Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org At 2022-04-25 16:13:20, "GuoLei Yi" wrote: >Hello everyone, with the increasing number of pull requests, we need to >strictly control the code merge process. I plan to turn on "requested" CI >checks, that is, when all "re