Re: Discuss commit specification

2018-10-31 Thread Zhao Chun
Hi Willem Willem Jiang 于2018年10月31日周三 下午5:07写道: > It looks good to me. > Can we put it into the website as a developer commit guide? > After it was accepted, we put it to our contributing files. > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Wed, Oct 31, 2018 at 3:38 PM Zh

Re: Discuss commit specification

2018-10-31 Thread Willem Jiang
It looks good to me. Can we put it into the website as a developer commit guide? Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Oct 31, 2018 at 3:38 PM Zhao Chun wrote: > > Hi all, > > I want to discuss Apache Doris(incubating) code commit specification. > > Pull requests. In order t

Discuss commit specification

2018-10-31 Thread Zhao Chun
Hi all, I want to discuss Apache Doris(incubating) code commit specification. Pull requests. In order to ensure that our master branch is working, we will disable the contributor push code master branch directly. On GitHub we will open `Require pull request reviews before merging` for master, so