Re: Vote for Apache Doris 2.1.3

2024-05-15 Thread vin jake
+1 (binding) I checked: - the download link is valid. - the PGP signature is valid. - the LICENSE and NOTICE files are correct. On Thu, May 16, 2024 at 9:32 AM GuoLei Yi wrote: > Hi all, > > Please review and vote on Apache Doris 2.1.3 release. > > The release candidate has been tagged in GitHu

Re: [VOTE] Release Apache Doris-Shade 2.0.2

2024-05-09 Thread vin jake
+1 (binding) On Fri, May 10, 2024 at 10:48 AM Calvin Kirs wrote: > Hi all, > This is a call for the vote to release Apache Doris-Shade 2.0.2 > The git tag for the release: > https://github.com/apache/doris-shade/releases/tag/doris-shade-2.0.2 > Release Notes are here: > https://github.com/apache

Re: [Welcome] New Committers and PMC Members

2023-02-06 Thread vin jake
Congratulations! On Mon, Feb 6, 2023 at 9:18 PM Gabriel Lee wrote: > Congrats! > > Best, > Gabriel > > On Mon, 6 Feb 2023 at 21:14, Mingyu Chen wrote: > > > Hi all, > > The Project Management Committee (PMC) for Apache Doris has invited new > > committers and PMC members. > > > > > > New PMC Me

Re: [Discussion] remove hadoop dpp code from Apache Doris

2023-01-16 Thread vin jake
+1 These code looks like don't need to maintain in new version GuoLei Yi 于 2023年1月16日周一 19:01写道: > There are two kinds of DPP load in Doris, one is hadoop and the other > is spark. I think we could remove hadoop dpp because: > > 1. Most of users are using spark now. > 2. And there are not man

Re: Remove non-vectorization code

2022-12-05 Thread vin jake
+1 It's enough to keep non-vectorization code just in 1.1-lts It's time to remove non-vectorization code now in master On Tue, Dec 6, 2022 at 12:23 PM GuoLei Yi wrote: > Hi All Developers, > > Vectorization is introduced into Doris in 1.0 which is released > earlier this year. Many companies is

Re: Checkstyle for Doris FE

2022-04-19 Thread vin jake
e** together in > one PR. So as it can avoid the compilation problem caused by checkstyle. > > Secondly, is it possible to export the code format of IDE and put it in the > document, so that we can write code in the correct format in the future? > > Ling Miao > > vin jake 于

Checkstyle for Doris FE

2022-04-19 Thread vin jake
Hi everyone: For the situation of Doris Fe of lacking `format style`, I'm trying to fix this thing. I made a draft `checkstyle` in the PR link . I format the stable directory of FE with this style for reviewing. PR link

Re: Add more rules to checkstyle.xml in fe

2022-04-18 Thread vin jake
bator-doris/issues/8985 On Thu, Apr 14, 2022 at 6:52 PM vin jake wrote: > great, I will trim it in my PR. > > checkstyle.xml need more discussion > > On Thu, Apr 14, 2022 at 5:48 PM morrysnow wrote: > >> I agree with u. >> >> For the first point, I

Re: Add more rules to checkstyle.xml in fe

2022-04-14 Thread vin jake
ould do some work to make the code clean > > and readable. > > > > My concern is: > > 1. We should have an agreement on the code style specification in the > > community at first. > > 2. If the many lines of code change after applying the code style rule, > we > &

Re: Add more rules to checkstyle.xml in fe

2022-04-14 Thread vin jake
I have add it in PR https://github.com/apache/incubator-doris/pull/8987 On Thu, Apr 14, 2022 at 4:37 PM morrysnow wrote: > Hi, devs, > > Currently, we only have two rules in checkstyle.xml in fe. These are all > about import. So, the code style in fe is very casual. > I want to add more rules to

Re: [Discuss] Invite external collaborators with the triage role on GitHub

2022-02-10 Thread vin jake
id: jackwener I'm willing to do something for building better community. 陈明雨 于 2022年2月11日周五 12:12写道: > Hi all: > > > I just find that we can assign external collaborators with the triage role > on GitHub[1] > The external collaborators can assign, edit, close the issues and PRs, but > without w