Re: [PR] [improve] Support writing data from one topic to multiple tables by c… [doris-kafka-connector]

2024-12-23 Thread via GitHub
chuang-wang-pre commented on code in PR #55: URL: https://github.com/apache/doris-kafka-connector/pull/55#discussion_r1895707494 ## src/main/java/org/apache/doris/kafka/connector/service/DorisDefaultSinkService.java: ## @@ -161,12 +177,66 @@ public void commit(Map offsets) {

Re: [PR] [improve] Support writing data from one topic to multiple tables by c… [doris-kafka-connector]

2024-12-23 Thread via GitHub
DongLiang-0 commented on code in PR #55: URL: https://github.com/apache/doris-kafka-connector/pull/55#discussion_r1895578856 ## src/main/java/org/apache/doris/kafka/connector/cfg/DorisSinkConnectorConfig.java: ## @@ -52,6 +52,7 @@ public class DorisSinkConnectorConfig { pu

Re: [PR] [improve] Support writing data from one topic to multiple tables by c… [doris-kafka-connector]

2024-12-23 Thread via GitHub
DongLiang-0 commented on code in PR #55: URL: https://github.com/apache/doris-kafka-connector/pull/55#discussion_r1895527089 ## src/main/java/org/apache/doris/kafka/connector/service/DorisDefaultSinkService.java: ## @@ -161,12 +177,66 @@ public void commit(Map offsets) {

Re: [PR] [improve] Support writing data from one topic to multiple tables by c… [doris-kafka-connector]

2024-12-23 Thread via GitHub
chuang-wang-pre commented on PR #55: URL: https://github.com/apache/doris-kafka-connector/pull/55#issuecomment-2559134920 > Please add an e2e test case, please refer to `org.apache.doris.kafka.connector.e2e.sink.stringconverter.StringMsgE2ETest` @DongLiang-0 Thank you for the reminde