Re: Add more rules to checkstyle.xml in fe

Hi, devs I want to add Step 0 before all steps. Step 0: Add checkstyle action to github action to check pr style. This action checks incremental code and adds comment to pr automatically. Action: https://github.com/dbelyaev/action-checkstyle Demo

Re: Add more rules to checkstyle.xml in fe

Hi, mingyu 1. Check license is needed for local check. 2. Add a rule to forbidden static import is ok for me > 2022年4月28日 21:34，陈明雨 写道： > > That would be great! > Some suggestion about the rules: > > >> d. license header check > For now, we use skywalking-eyes to check license header, is this

[NOTICE] BE code format

Hi all, I will merge this PR[1] today to format all BE code using clang. And aslo enable the code format check as required check. [1] https://github.com/apache/incubator-doris/pull/9305 -- 此致！Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org

Re:Re: Add more rules to checkstyle.xml in fe

That would be great! Some suggestion about the rules: > d. license header check For now, we use skywalking-eyes to check license header, is this rule still needed? > adjust the order of import to "static, org.apache.doris, third party, java" Better not using static import -- 此致！Best Regar

Re: Add more rules to checkstyle.xml in fe

Hi, devs, I split adding java check style into 5 steps. I’m willing to get feedback about it. CheckStyle and Spotless will modify about 10k lines. Step 1: 1. Add Spotless plugin and do some simple format(1198 files changed, 3205 insertions(+), 4350 deletions(-)) a. end with new line