Re: [Discuess][DSIP] Using global dict to accelerate query that have low cardinality string

2022-04-25 Thread Gabriel Lee
Hi Guolei, I have some questions for this. 1. I think we cannot trust users completely, so we should add a protection mechanism for global dictionary. For example, fallback to raw string processing when entries in dictionary are too many. 2. Should we consider local dictionary instead of global dic

Re: [Discuess][DSIP] Using global dict to accelerate query that have lowcardinality string

2022-04-25 Thread 41108453
+1 Nice work! -- Original -- From: GuoLei Yi

[Discuess][DSIP] Using global dict to accelerate query that have low cardinality string

2022-04-25 Thread GuoLei Yi
*Issue Description:* In Doris, many dimension columns are string type with low cardinality (cardinality < 1024), such as some status codes, provinces, regions, genders, etc. During group by or join operation, it has to make a hash table in the form of strings. The efficiency is relatively low. Thr

Re: [Discuss][DSIP] Add Row Policy support

2022-04-25 Thread 41108453
Nice work This is also a function that many community users want -- Original -- From: stalary https://github.com/apache/incubator-doris/issues/7540 There will be 2 stages: 1. Design a new set of Policy syntax     a) create policy     b) drop policy     c) show p

Re:[Discuss][DSIP] Add Row Policy support

2022-04-25 Thread 陈明雨
Nice work! I created DSIP-009[1] for it. You can write more details in it. And this issue[2] is most in Chinese, I think we should translate it into English in DSIP. Besides the user interface, I would like to know more about how to implement it. [1] https://cwiki.apache.org/confluence/display

[Discuss][DSIP] Add Row Policy support

2022-04-25 Thread stalary
Dear All, I’d like to add row policy support to Doris, column policy will also be supported in the future. Sometimes we need permission control not only at the table level, but also at the row level, column level. At present, many users need to parse SQL and rewrite sql on out of doris or

[RESULT][VOTE] Release Apache Doris Manager v1.0.0 rc03 for Apache Doris(Incubating)

2022-04-25 Thread 41108453
Hi all, Thanks to everyone participating in this release vote of Release Apache Doris Manager v1.0.0 rc03 for Apache Doris(Incubating) The vote PASSES with 3 (+1 binding) and no +0 or -1 vote. binding: - Mingyu Chen - Ling Miao - Zhengguo Yang - Jiafeng Zhang The vote thread: https

Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread Lijia Liu
+1 回复的原邮件 发件人 mailto:yiguo...@gmail.com";>GuoLei Yi

Re:Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread 陈明雨
> BTW, I have a small problem, currently BE UT, BE UT, P0 regression, Incubator > Doris UT are all running with personal accounts, the risk of whether they can > ? > continue to run, and also need the account password to view the failure > information, so it is not very convenient, can you migra

Re:回复:[DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread 陈明雨
> Maybe we should add a test to confirm clang compatibility? Some codes cannot > be compiled with clang, but can be compiled with gcc.I will make this test -- 此致!Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org 在 2022-04-25 16:38:32,"952130278" 写道: >Maybe we should add a test t

Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread De Li
+1 李德 l...@apache.org On 2022/04/25 08:13:20 GuoLei Yi wrote: > Hello everyone, with the increasing number of pull requests, we need to > strictly control the code merge process. I plan to turn on "requested" CI > checks, that is, when all "requested" CI checks of a PR pass, the code can > be mer

Re:[DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread stalary
+1 | | stalary | | stal...@163.com | 签名由网易邮箱大师定制 On 04/25/2022 16:13,GuoLei Yi wrote: Hello everyone, with the increasing number of pull requests, we need to strictly control the code merge process. I plan to turn on "requested" CI checks, that is, when all "requested" CI checks of a PR pass, t

Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread 41108453
+1 -- Original -- From: GuoLei Yi

Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread ling miao
> BTW, I have a small problem, currently BE UT, BE UT, P0 regression, Incubator Doris UT are all running with personal accounts, the risk of whether they can continue to run, and also need the account password to view the failure information, so it is not very convenient, can you migrate to the off

Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread zhg yang
+1 BTW, I have a small problem, currently BE UT, BE UT, P0 regression, Incubator Doris UT are all running with personal accounts, the risk of whether they can continue to run, and also need the account password to view the failure information, so it is not very convenient, can you migrate to th

??????[DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread 952130278
Maybe we should add a test to confirm clang compatibility? Some codes cannot be compiled with clang, but can be compiled with gcc. -- -- ??:

Re:Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread 陈明雨
> 4. I can not login to the new TeamCity. The CI tools should easily accessible to all contributors. You can click "login as guest" And later I think the PPMC member should have admin privilege. -- 此致!Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org 在 2022-04-25 16:30:31,"ling mia

??????[DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread stephen
+1 --  -- ??: "dev"

Re: [DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread ling miao
1. FE code format should be "requested" in the future. 2. There are some duplicate checks should be removed such as: Incubator Doris UT. 3. I recommend keeping the original P0 check until the P0 case is migrated. 4. I can not login to the new TeamCity. The CI tools should easily accessible to al

Re:[DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread 陈明雨
+1 -- 此致!Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org At 2022-04-25 16:13:20, "GuoLei Yi" wrote: >Hello everyone, with the increasing number of pull requests, we need to >strictly control the code merge process. I plan to turn on "requested" CI >checks, that is, when all "re

[DISCUSS] Add requested CI check for Pull Requests

2022-04-25 Thread GuoLei Yi
Hello everyone, with the increasing number of pull requests, we need to strictly control the code merge process. I plan to turn on "requested" CI checks, that is, when all "requested" CI checks of a PR pass, the code can be merged. The following admissions will be forced on: 1. BE Code Formatter /