[GitHub] [incubator-doris] imay opened a new issue #1755: Remove author tag in our code

2019-09-05 Thread GitBox
imay opened a new issue #1755: Remove author tag in our code URL: https://github.com/apache/incubator-doris/issues/1755 We should remove author tag in our code [Here](http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_09_22.txt) and [Here] is reference. --

[GitHub] [incubator-doris] imay commented on issue #1753: Use crc32c checksum for segment v2

2019-09-05 Thread GitBox
imay commented on issue #1753: Use crc32c checksum for segment v2 URL: https://github.com/apache/incubator-doris/pull/1753#issuecomment-528724219 @gaodayue I have two questions about this PR. 1. Even if HashUtils::crc_hash doesn't generate standard CRC-32 checksum, the checksums

[GitHub] [incubator-doris] gaodayue opened a new pull request #1754: fix a bug in BetaRowsetReader which results in empty result

2019-09-05 Thread GitBox
gaodayue opened a new pull request #1754: fix a bug in BetaRowsetReader which results in empty result URL: https://github.com/apache/incubator-doris/pull/1754 I didn't notice that `Reader` [relies on](https://github.com/apache/incubator-doris/blob/master/be/src/olap/reader.cpp#L120) the `

[GitHub] [incubator-doris] gaodayue opened a new pull request #1753: Use crc32c checksum for segment v2

2019-09-05 Thread GitBox
gaodayue opened a new pull request #1753: Use crc32c checksum for segment v2 URL: https://github.com/apache/incubator-doris/pull/1753 The following error is encountered when testing V2 table. ``` Page checksum mismatch, actual=3372108349 vs expect=3375987274 ``` The reasons a

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1738: add bloom filter index

2019-09-05 Thread GitBox
kangpinghuang commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r321569645 ## File path: be/src/olap/rowset/segment_v2/bloom_filter_page.cpp ## @@ -0,0 +1,114 @@ +// Licensed to the Apach

[DISCUSS]Create FieldList to reuse filed and schema

2019-09-05 Thread Zhao Chun
Now in our storage engine, we create so many Schema/Field for many purpose. I think after a table is created, its Schema and Filed are not modified unless there is a schema change. However, schema change for a table is infrequent operation, which means that Schema/Field will keep the same most time

[GitHub] [incubator-doris] imay opened a new issue #1752: Create FieldList to reuse filed and schema

2019-09-05 Thread GitBox
imay opened a new issue #1752: Create FieldList to reuse filed and schema URL: https://github.com/apache/incubator-doris/issues/1752 Now in our storage engine, we create so many Schema/Field for many purpose. I think after a table is created, its Schema and Filed are not modified unless th

[GitHub] [incubator-doris] yiguolei commented on issue #1751: Active rowset is garbage collected

2019-09-05 Thread GitBox
yiguolei commented on issue #1751: Active rowset is garbage collected URL: https://github.com/apache/incubator-doris/issues/1751#issuecomment-528691857 During publish version stage, it will first add rowset meta to tablet meta and then remove it from rowset meta manager. If we check table

[GitHub] [incubator-doris] yiguolei commented on issue #1750: Check rowset is useful atomicly

2019-09-05 Thread GitBox
yiguolei commented on issue #1750: Check rowset is useful atomicly URL: https://github.com/apache/incubator-doris/pull/1750#issuecomment-528691384 #1751 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] yiguolei opened a new issue #1751: Active rowset is garbage collected

2019-09-05 Thread GitBox
yiguolei opened a new issue #1751: Active rowset is garbage collected URL: https://github.com/apache/incubator-doris/issues/1751 Rowset is published but is garbaged collected during gc thread. This is an automated message from

[GitHub] [incubator-doris] yiguolei opened a new pull request #1750: Check rowset is useful atomicly

2019-09-05 Thread GitBox
yiguolei opened a new pull request #1750: Check rowset is useful atomicly URL: https://github.com/apache/incubator-doris/pull/1750 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] imay merged pull request #1749: Fix compile error

2019-09-05 Thread GitBox
imay merged pull request #1749: Fix compile error URL: https://github.com/apache/incubator-doris/pull/1749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-doris] imay opened a new pull request #1749: Fix compile error

2019-09-05 Thread GitBox
imay opened a new pull request #1749: Fix compile error URL: https://github.com/apache/incubator-doris/pull/1749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] imay merged pull request #1747: Add check for to_bitmap function argument

2019-09-05 Thread GitBox
imay merged pull request #1747: Add check for to_bitmap function argument URL: https://github.com/apache/incubator-doris/pull/1747 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] imay merged pull request #1748: RowsetFactory as a single entry for Rowset creation

2019-09-05 Thread GitBox
imay merged pull request #1748: RowsetFactory as a single entry for Rowset creation URL: https://github.com/apache/incubator-doris/pull/1748 This is an automated message from the Apache Git Service. To respond to the message