[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1747: Add check for to_bitmap function argument

2019-09-04 Thread GitBox
kangkaisen commented on a change in pull request #1747: Add check for to_bitmap function argument URL: https://github.com/apache/incubator-doris/pull/1747#discussion_r321050410 ## File path: be/src/exec/base_scanner.cpp ## @@ -144,6 +144,14 @@ bool BaseScanner::fill_dest_t

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1748: RowsetFactory as a single entry for Rowset creation

2019-09-04 Thread GitBox
gaodayue commented on a change in pull request #1748: RowsetFactory as a single entry for Rowset creation URL: https://github.com/apache/incubator-doris/pull/1748#discussion_r321049846 ## File path: be/src/olap/task/engine_clone_task.cpp ## @@ -847,10 +844,19 @@ OLAPStatus

Re: [DISCUSS] Move GitHub/Gitbox messages to a commits@doris Mailing List

2019-09-04 Thread Zhao Chun
Thanks Dave, I will look into it Dave Fisher 于2019年9月5日周四 上午1:36写道: > Hi Zhao Chun - > > Mail moderation is not too difficult and depending on the list may not > even be once a month. > > Here is a resource - http://apache.org/dev/committers.html#mail-moderate > > There is a beta level helper in

[GitHub] [incubator-doris] morningman commented on issue #1723: 元数据支持存储计算分离

2019-09-04 Thread GitBox
morningman commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-528150030 > 要求用户在建表时必须指定backend_tag,感觉不是很合理。 我觉得我们可以在整个集群,cluster,DB粒度设置backend_tag属性,建表时backend_tag作为可选项。 让用户在建表时指定backend_tag,会极大增加Doris Admin的运维成本。 backend_ta

Re: [DISCUSS] Move GitHub/Gitbox messages to a commits@doris Mailing List

2019-09-04 Thread Dave Fisher
Hi Zhao Chun - Mail moderation is not too difficult and depending on the list may not even be once a month. Here is a resource - http://apache.org/dev/committers.html#mail-moderate There is a beta level helper in whimsy here - https://whimsy.apache.org/committers/moderationhelper This include

[GitHub] [incubator-doris] imay removed a comment on issue #1723: 元数据支持存储计算分离

2019-09-04 Thread GitBox
imay removed a comment on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-527934459 > > CREATE TABLE tbl1 (k1 int) DISTRIBUTED BY HASH(k1) BUCKETS 4 > > PROPERTIES ( > > "backend_tag" = "rack1:2, rack2:1,", // required > > "remote_st

[GitHub] [incubator-doris] imay closed issue #1723: 元数据支持存储计算分离

2019-09-04 Thread GitBox
imay closed issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-doris] morningman opened a new issue #1723: 元数据支持存储计算分离

2019-09-04 Thread GitBox
morningman opened a new issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723 # 元数据支持存储计算分离 在存储计算架构中,数据可能存储在本地、远端,或同时存储在本地和远端。当数据存储在远端时,本地存储将作为一个全量Cache存在。在这种架构,现有的以下流程需求进行重新设计: * Backend 的元数据管理 * 建表或创建分区时数据分片的分布管理 * 数据副本的修改,数据分片的修复和均衡 *

[GitHub] [incubator-doris] imay commented on issue #1723: 元数据支持存储计算分离

2019-09-04 Thread GitBox
imay commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-527934459 > > CREATE TABLE tbl1 (k1 int) DISTRIBUTED BY HASH(k1) BUCKETS 4 > > PROPERTIES ( > > "backend_tag" = "rack1:2, rack2:1,", // required > > "remote_storage_ta

[GitHub] [incubator-doris] imay commented on a change in pull request #1748: RowsetFactory as a single entry for Rowset creation

2019-09-04 Thread GitBox
imay commented on a change in pull request #1748: RowsetFactory as a single entry for Rowset creation URL: https://github.com/apache/incubator-doris/pull/1748#discussion_r320795386 ## File path: be/src/olap/task/engine_clone_task.cpp ## @@ -847,10 +844,19 @@ OLAPStatus En

[GitHub] [incubator-doris] imay commented on a change in pull request #1747: Add check for to_bitmap function argument

2019-09-04 Thread GitBox
imay commented on a change in pull request #1747: Add check for to_bitmap function argument URL: https://github.com/apache/incubator-doris/pull/1747#discussion_r320787795 ## File path: be/src/exec/base_scanner.cpp ## @@ -144,6 +144,14 @@ bool BaseScanner::fill_dest_tuple(c

[GitHub] [incubator-doris] gaodayue opened a new pull request #1748: RowsetFactory as a single entry for Rowset creation

2019-09-04 Thread GitBox
gaodayue opened a new pull request #1748: RowsetFactory as a single entry for Rowset creation URL: https://github.com/apache/incubator-doris/pull/1748 In this PR, all creations of Rowset are done through the `RowsetFactory.create_rowset` factory method (except OlapSnapshotConverter which

[GitHub] [incubator-doris] kangkaisen commented on issue #1723: 元数据支持存储计算分离

2019-09-04 Thread GitBox
kangkaisen commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-527907152 > CREATE TABLE tbl1 (k1 int) DISTRIBUTED BY HASH(k1) BUCKETS 4 PROPERTIES ( "backend_tag" = "rack1:2, rack2:1,", // required "remote_storage_ta

[GitHub] [incubator-doris] morningman commented on issue #1723: 元数据支持存储计算分离

2019-09-04 Thread GitBox
morningman commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-527897856 资源这个词,可以再讨论~ This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] morningman commented on issue #1723: 元数据支持存储计算分离

2019-09-04 Thread GitBox
morningman commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-527897477 > 我们需要把所有的节点都打平么?感觉BE、FE、Broker这些之间似乎也没有什么共性。还有打平的话我觉得叫做资源不太恰当。毕竟通常我们说的都是CPU资源,IO资源,网络资源,存储资源,一般都指的是逻辑的概念。 这个我得意思主要是所有的这些节点都可以用一套 tag 机制来管理。而当前其实我们主要是对

[GitHub] [incubator-doris] kangkaisen opened a new pull request #1747: Add check for to_bitmap function argument

2019-09-04 Thread GitBox
kangkaisen opened a new pull request #1747: Add check for to_bitmap function argument URL: https://github.com/apache/incubator-doris/pull/1747 For https://github.com/apache/incubator-doris/issues/1746 1 Add invalid_argument and out_of_range check for to_bitmap function 2 change th

[GitHub] [incubator-doris] kangkaisen opened a new issue #1746: BE core when to_bitmap argument is invalid

2019-09-04 Thread GitBox
kangkaisen opened a new issue #1746: BE core when to_bitmap argument is invalid URL: https://github.com/apache/incubator-doris/issues/1746 Today, BE core when our user test the bitmap_union: ``` terminate called after throwing an instance of 'std::out_of_range' what(): sto

[GitHub] [incubator-doris] chaoyli merged pull request #1742: Reduce unnecessary memory allocate and copy in OlapScanNode

2019-09-04 Thread GitBox
chaoyli merged pull request #1742: Reduce unnecessary memory allocate and copy in OlapScanNode URL: https://github.com/apache/incubator-doris/pull/1742 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] imay commented on a change in pull request #1745: add delete predicate filter(#1636)

2019-09-04 Thread GitBox
imay commented on a change in pull request #1745: add delete predicate filter(#1636) URL: https://github.com/apache/incubator-doris/pull/1745#discussion_r320726868 ## File path: be/src/olap/delete_handler.cpp ## @@ -343,5 +343,17 @@ void DeleteHandler::finalize() { _i

[GitHub] [incubator-doris] kangpinghuang commented on issue #1652: support filter with predicate in BetaRowset

2019-09-04 Thread GitBox
kangpinghuang commented on issue #1652: support filter with predicate in BetaRowset URL: https://github.com/apache/incubator-doris/issues/1652#issuecomment-527873905 I will do this feature This is an automated message from t

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1745: add delete predicate filter(#1636)

2019-09-04 Thread GitBox
kangpinghuang opened a new pull request #1745: add delete predicate filter(#1636) URL: https://github.com/apache/incubator-doris/pull/1745 Delete predicate can be used to prune data by zone map. This is an automated message f

[GitHub] [incubator-doris] imay commented on a change in pull request #1617: Add PreAgg Hint

2019-09-04 Thread GitBox
imay commented on a change in pull request #1617: Add PreAgg Hint URL: https://github.com/apache/incubator-doris/pull/1617#discussion_r320714060 ## File path: fe/src/main/jflex/sql_scanner.flex ## @@ -439,20 +439,36 @@ QuotedIdentifier = \`(\`\`|[^\`])*\` SingleQuoteString

[GitHub] [incubator-doris] gaodayue commented on issue #1652: support filter with predicate in BetaRowset

2019-09-04 Thread GitBox
gaodayue commented on issue #1652: support filter with predicate in BetaRowset URL: https://github.com/apache/incubator-doris/issues/1652#issuecomment-527863509 I see, thanks This is an automated message from the Apache Git S

[GitHub] [incubator-doris] imay commented on issue #1723: 元数据支持存储计算分离

2019-09-04 Thread GitBox
imay commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-527861098 > Resource 资源。可以为 Doris 提供某种服务的实体。比如 Backend 是一种资源,Broker 也是一种资源。资源需要先通过命令加入到 Doris 集群中才能被使用。 我们需要把所有的节点都打平么?感觉BE、FE、Broker这些之间似乎也没有什么共性。还有打平的话我觉得叫做资源不太恰当

[GitHub] [incubator-doris] imay merged pull request #1744: Shuffle partitioned instance to avoid skew

2019-09-04 Thread GitBox
imay merged pull request #1744: Shuffle partitioned instance to avoid skew URL: https://github.com/apache/incubator-doris/pull/1744 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] imay commented on issue #1652: support filter with predicate in BetaRowset

2019-09-04 Thread GitBox
imay commented on issue #1652: support filter with predicate in BetaRowset URL: https://github.com/apache/incubator-doris/issues/1652#issuecomment-527842993 @gaodayue > If you mean filter rows by columns's zonemap, it's already supported I mean that vectorized predicate filter. I

[GitHub] [incubator-doris] gaodayue commented on issue #1652: support filter with predicate in BetaRowset

2019-09-04 Thread GitBox
gaodayue commented on issue #1652: support filter with predicate in BetaRowset URL: https://github.com/apache/incubator-doris/issues/1652#issuecomment-527833177 If you mean filter rows by columns's zonemap, it's already supported

[GitHub] [incubator-doris] gaodayue commented on issue #1647: V2 segment file should contain no more than INT32_MAX rows

2019-09-04 Thread GitBox
gaodayue commented on issue #1647: V2 segment file should contain no more than INT32_MAX rows URL: https://github.com/apache/incubator-doris/issues/1647#issuecomment-527831621 fixed by #1705 This is an automated message fro

[GitHub] [incubator-doris] gaodayue closed issue #1647: V2 segment file should contain no more than INT32_MAX rows

2019-09-04 Thread GitBox
gaodayue closed issue #1647: V2 segment file should contain no more than INT32_MAX rows URL: https://github.com/apache/incubator-doris/issues/1647 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-doris] imay closed pull request #1471: Planner support push down predicates past agg, win and sort

2019-09-04 Thread GitBox
imay closed pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1471: Planner support push down predicates past agg, win and sort

2019-09-04 Thread GitBox
chenhao7253886 opened a new pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471 #1438 This is an automated message from the Apache Git Servi

[GitHub] [incubator-doris] imay merged pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar

2019-09-04 Thread GitBox
imay merged pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar URL: https://github.com/apache/incubator-doris/pull/1739 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] imay opened a new pull request #1744: Shuffle partitioned instance to avoid skew

2019-09-04 Thread GitBox
imay opened a new pull request #1744: Shuffle partitioned instance to avoid skew URL: https://github.com/apache/incubator-doris/pull/1744 #1743 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] imay merged pull request #1740: use RowsetFactory to create and init RowsetWriter

2019-09-04 Thread GitBox
imay merged pull request #1740: use RowsetFactory to create and init RowsetWriter URL: https://github.com/apache/incubator-doris/pull/1740 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] morningman commented on issue #1723: 元数据支持存储计算分离

2019-09-04 Thread GitBox
morningman commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-527787272 > @morningman > > 我觉得我们应该还是保留Backend这个实体,而不是将Storage全部替换为Backend。 > > 1. Storage,StorageGroup应该做为Backend的某个属性存在。因为Backend上不仅有Storage的功能还有Compute的