[GitHub] [incubator-doris] imay opened a new issue #1743: compute skew when concurrent queries

2019-09-03 Thread GitBox
imay opened a new issue #1743: compute skew when concurrent queries URL: https://github.com/apache/incubator-doris/issues/1743 When we do high concurrency test to Doris, we found that one of all backends are complete consumed, but other backends have 60% CPU idle. ![image](https://

[GitHub] [incubator-doris] imay commented on issue #1726: CPU idle is still high when concurrent access is high

2019-09-03 Thread GitBox
imay commented on issue #1726: CPU idle is still high when concurrent access is high URL: https://github.com/apache/incubator-doris/issues/1726#issuecomment-527759718 After looking into this case, I found some problems that will hurt performance. 1. There are too many unnecessary m

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1740: use RowsetFactory to create and init RowsetWriter

2019-09-03 Thread GitBox
gaodayue commented on a change in pull request #1740: use RowsetFactory to create and init RowsetWriter URL: https://github.com/apache/incubator-doris/pull/1740#discussion_r320587846 ## File path: be/src/olap/merger.cpp ## @@ -21,107 +21,55 @@ #include #include "olap/

[GitHub] [incubator-doris] morningman merged pull request #1688: Fixbug: It can not create a new partition when paritions of a table is empty

2019-09-03 Thread GitBox
morningman merged pull request #1688: Fixbug: It can not create a new partition when paritions of a table is empty URL: https://github.com/apache/incubator-doris/pull/1688 This is an automated message from the Apache Git Ser

[GitHub] [incubator-doris] imay commented on a change in pull request #1734: Commit kafka offset in routine load

2019-09-03 Thread GitBox
imay commented on a change in pull request #1734: Commit kafka offset in routine load URL: https://github.com/apache/incubator-doris/pull/1734#discussion_r320572734 ## File path: be/src/runtime/routine_load/data_consumer.h ## @@ -133,6 +133,8 @@ class KafkaDataConsumer : p

[GitHub] [incubator-doris] imay commented on a change in pull request #1738: add bloom filter index

2019-09-03 Thread GitBox
imay commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r320569013 ## File path: be/src/olap/types.h ## @@ -74,6 +74,7 @@ class TypeInfo { inline void set_to_min(void* buf) const { _se

[GitHub] [incubator-doris] imay commented on a change in pull request #1738: add bloom filter index

2019-09-03 Thread GitBox
imay commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r320570400 ## File path: be/src/olap/rowset/segment_v2/bloom_filter_page.cpp ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1738: add bloom filter index

2019-09-03 Thread GitBox
imay commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r320569559 ## File path: be/src/olap/bloom_filter.hpp ## @@ -71,6 +70,16 @@ class BitSet { return true; } +bool i

[GitHub] [incubator-doris] imay commented on a change in pull request #1738: add bloom filter index

2019-09-03 Thread GitBox
imay commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r320571323 ## File path: be/src/olap/rowset/segment_v2/bloom_filter_page.cpp ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1738: add bloom filter index

2019-09-03 Thread GitBox
imay commented on a change in pull request #1738: add bloom filter index URL: https://github.com/apache/incubator-doris/pull/1738#discussion_r320570534 ## File path: be/src/olap/rowset/segment_v2/bloom_filter_page.cpp ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1740: use RowsetFactory to create and init RowsetWriter

2019-09-03 Thread GitBox
imay commented on a change in pull request #1740: use RowsetFactory to create and init RowsetWriter URL: https://github.com/apache/incubator-doris/pull/1740#discussion_r320557618 ## File path: be/src/olap/merger.cpp ## @@ -21,107 +21,55 @@ #include #include "olap/olap

[GitHub] [incubator-doris] imay opened a new pull request #1742: Reduce unnecessary memory allocat and copy in OlapScanNode

2019-09-03 Thread GitBox
imay opened a new pull request #1742: Reduce unnecessary memory allocat and copy in OlapScanNode URL: https://github.com/apache/incubator-doris/pull/1742 This is an automated message from the Apache Git Service. To respond t

Re: [DISCUSS] Move GitHub/Gitbox messages to a commits@doris Mailing List

2019-09-03 Thread Zhao Chun
Hi Dave, I want to be a volunteer to moderate the mailing list. But I have no experience about moderating a mailing list, it's good if you can provide some material. Dave Fisher 于2019年9月4日周三 上午12:50写道: > Hi - > > Unless there is an objection we will request a commits@doris mailing list > and sw

[GitHub] [incubator-doris] morningman commented on a change in pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar

2019-09-03 Thread GitBox
morningman commented on a change in pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar URL: https://github.com/apache/incubator-doris/pull/1739#discussion_r320539275 ## File path: be/src/olap/aggregate_func.h ## @@ -203,6 +203,36 @@ struct Ag

Re:Re: Release plan of Doris

2019-09-03 Thread 陈明雨
Hi Katte: The Doris project is currently developing the following functions: 1. Decouple Storage and Compute We hope that Doris will be able to provide better flexibility and lower cost in the cloud by decoupling Storage and Compute. At present, we are improving some basic processes to adapt

[DISCUSS] Move GitHub/Gitbox messages to a commits@doris Mailing List

2019-09-03 Thread Dave Fisher
Hi - Unless there is an objection we will request a commits@doris mailing list and switch over messages. Before doing this we need two volunteers to moderate the mailing list in order to approve subscriptions and prevent spam. Regards, Dave -

[GitHub] [incubator-doris] lxqfy commented on a change in pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar

2019-09-03 Thread GitBox
lxqfy commented on a change in pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar URL: https://github.com/apache/incubator-doris/pull/1739#discussion_r320332527 ## File path: be/src/olap/aggregate_func.h ## @@ -203,6 +203,36 @@ struct Aggrega

[GitHub] [incubator-doris] lxqfy commented on a change in pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar

2019-09-03 Thread GitBox
lxqfy commented on a change in pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar URL: https://github.com/apache/incubator-doris/pull/1739#discussion_r320331794 ## File path: be/src/olap/aggregate_func.h ## @@ -203,6 +203,36 @@ struct Aggrega

[GitHub] [incubator-doris] morningman commented on a change in pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar

2019-09-03 Thread GitBox
morningman commented on a change in pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar URL: https://github.com/apache/incubator-doris/pull/1739#discussion_r320286176 ## File path: be/src/olap/aggregate_func.h ## @@ -203,6 +203,36 @@ struct Ag

[GitHub] [incubator-doris] morningman commented on a change in pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar

2019-09-03 Thread GitBox
morningman commented on a change in pull request #1739: Added MIN/MAX aggregate function compatible with char/varchar URL: https://github.com/apache/incubator-doris/pull/1739#discussion_r320285662 ## File path: be/src/olap/aggregate_func.h ## @@ -203,6 +203,36 @@ struct Ag

[GitHub] [incubator-doris] morningman commented on a change in pull request #1734: Commit kafka offset in routine load

2019-09-03 Thread GitBox
morningman commented on a change in pull request #1734: Commit kafka offset in routine load URL: https://github.com/apache/incubator-doris/pull/1734#discussion_r320282365 ## File path: be/src/runtime/routine_load/routine_load_task_executor.cpp ## @@ -227,6 +227,28 @@ void

[GitHub] [incubator-doris] morningman commented on a change in pull request #1734: Commit kafka offset in routine load

2019-09-03 Thread GitBox
morningman commented on a change in pull request #1734: Commit kafka offset in routine load URL: https://github.com/apache/incubator-doris/pull/1734#discussion_r320282904 ## File path: be/src/runtime/routine_load/routine_load_task_executor.cpp ## @@ -227,6 +227,28 @@ void

[GitHub] [incubator-doris] morningman merged pull request #1741: Not add alter task to tablet in alter tablet request v2

2019-09-03 Thread GitBox
morningman merged pull request #1741: Not add alter task to tablet in alter tablet request v2 URL: https://github.com/apache/incubator-doris/pull/1741 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] yiguolei opened a new pull request #1741: Not add alter task to tablet in alter tablet request v2

2019-09-03 Thread GitBox
yiguolei opened a new pull request #1741: Not add alter task to tablet in alter tablet request v2 URL: https://github.com/apache/incubator-doris/pull/1741 1. Not add alter task to tablet in alter tablet request v2 2. Should not check tablet under schema change when do compaction. --

[GitHub] [incubator-doris] gaodayue opened a new pull request #1740: use RowsetFactory to create and init RowsetWriter

2019-09-03 Thread GitBox
gaodayue opened a new pull request #1740: use RowsetFactory to create and init RowsetWriter URL: https://github.com/apache/incubator-doris/pull/1740 The PR contains the following changes - a factory method `create_rowset_writer` is added to `RowsetFactory`. All clients of RowsetWrit