imay commented on a change in pull request #1678: Add rowset id generator to FE
and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r319825420
##
File path: be/src/olap/rowset/segment_group.h
##
@@ -248,7 +248,7 @@ class SegmentGroup {
int64_t
imay commented on a change in pull request #1678: Add rowset id generator to FE
and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r319824694
##
File path: be/src/olap/storage_engine.h
##
@@ -196,6 +197,12 @@ class StorageEngine {
// TODO(ygl)
imay commented on a change in pull request #1678: Add rowset id generator to FE
and BE
URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r319825362
##
File path: be/src/olap/rowset/segment_group.h
##
@@ -262,12 +262,12 @@ class SegmentGroup {
OLAPS
kangkaisen commented on issue #1732: Add exchange in MemPool to reduce
alloc/free operation
URL: https://github.com/apache/incubator-doris/pull/1732#issuecomment-527023087
+1. LGTM.
The main change of this PR is add the `MemPool::exchange_data` method, other
diff is because of indent.
imay commented on a change in pull request #1732: Add exchange in MemPool to
reduce alloc/free operation
URL: https://github.com/apache/incubator-doris/pull/1732#discussion_r319822402
##
File path: be/src/runtime/mem_pool.cpp
##
@@ -26,248 +26,239 @@
#include "common/na
kangkaisen commented on issue #1733: Free olap scanner out of lock
URL: https://github.com/apache/incubator-doris/pull/1733#issuecomment-527021936
+1. LGTM.
This is an automated message from the Apache Git Service.
To respond
kangkaisen commented on a change in pull request #1732: Add exchange in MemPool
to reduce alloc/free operation
URL: https://github.com/apache/incubator-doris/pull/1732#discussion_r319821901
##
File path: be/src/runtime/mem_pool.cpp
##
@@ -26,248 +26,239 @@
#include "com
imay commented on issue #1732: Add exchange in MemPool to reduce alloc/free
operation
URL: https://github.com/apache/incubator-doris/pull/1732#issuecomment-527017158
> This PR seems have a indent issue?
Origin code is 2 spaces indent, I change it to 4 spaces which is consistent
with
kangkaisen commented on issue #1733: Free olap scanner out of lock
URL: https://github.com/apache/incubator-doris/pull/1733#issuecomment-527017035
> > @imay Hi, do you have a benchmark test for this PR?
>
> @kangkaisen
>
> This only one reason leading to competition.
> After
imay commented on issue #1733: Free olap scanner out of lock
URL: https://github.com/apache/incubator-doris/pull/1733#issuecomment-527016602
> @imay Hi, do you have a benchmark test for this PR?
@kangkaisen
This only one reason leading to competition.
After this is fixed, c
kangkaisen commented on issue #1732: Add exchange in MemPool to reduce
alloc/free operation
URL: https://github.com/apache/incubator-doris/pull/1732#issuecomment-527015673
This PR seems have a indent issue?
This is an autom
kangkaisen commented on issue #1733: Free olap scanner out of lock
URL: https://github.com/apache/incubator-doris/pull/1733#issuecomment-527014747
@imay Hi, do you have a benchmark test for this PR?
This is an automated messag
imay opened a new pull request #1733: Free olap scanner out of lock
URL: https://github.com/apache/incubator-doris/pull/1733
This PR will close scanner out of OlapScanner's batch lock,
which will lead all scanners wait for one scanner to finish.
#1726
---
imay closed pull request #1733: Free olap scanner out of lock
URL: https://github.com/apache/incubator-doris/pull/1733
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
imay commented on a change in pull request #1718: Basic implementation for
BetaRowsetReader
URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319814625
##
File path: be/src/olap/rowset/beta_rowset_reader.cpp
##
@@ -0,0 +1,122 @@
+// Licensed to the Apach
gaodayue commented on a change in pull request #1718: Basic implementation for
BetaRowsetReader
URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319811405
##
File path: be/src/olap/rowset/beta_rowset_reader.cpp
##
@@ -0,0 +1,122 @@
+// Licensed to the A
gaodayue commented on a change in pull request #1718: Basic implementation for
BetaRowsetReader
URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319810639
##
File path: be/src/olap/rowset/beta_rowset_reader.cpp
##
@@ -0,0 +1,122 @@
+// Licensed to the A
imay commented on a change in pull request #1718: Basic implementation for
BetaRowsetReader
URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319804287
##
File path: be/src/olap/rowset/beta_rowset_reader.cpp
##
@@ -0,0 +1,122 @@
+// Licensed to the Apach
imay commented on a change in pull request #1718: Basic implementation for
BetaRowsetReader
URL: https://github.com/apache/incubator-doris/pull/1718#discussion_r319804882
##
File path: be/src/olap/rowset/beta_rowset_reader.cpp
##
@@ -0,0 +1,122 @@
+// Licensed to the Apach
morningman opened a new pull request #1735: Fix NPE of DataDescription
URL: https://github.com/apache/incubator-doris/pull/1735
When user does not specify column mapping in BrokerLoadStmt, NPE may be
thrown.
This is an automa
HangyuanLiu opened a new pull request #1734: Commit kafka offset in routine load
URL: https://github.com/apache/incubator-doris/pull/1734
Commit kafka offset in routine load
This is an automated message from the Apache Git Ser
imay opened a new pull request #1733: Free olap scanner out of lock
URL: https://github.com/apache/incubator-doris/pull/1733
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
imay opened a new pull request #1732: Add exchange in MemPool to reduce
alloc/free operation
URL: https://github.com/apache/incubator-doris/pull/1732
This is an automated message from the Apache Git Service.
To respond to th
wuyunfeng opened a new pull request #1731: Add scroll keepalive and http
timeout configuration
URL: https://github.com/apache/incubator-doris/pull/1731
This is an automated message from the Apache Git Service.
To respond to
gaodayue commented on issue #1718: Basic implementation for BetaRowsetReader
URL: https://github.com/apache/incubator-doris/pull/1718#issuecomment-526985884
@kangpinghuang I have updated the description for the PR
This is an a
yiguolei commented on issue #1678: Add rowset id generator to FE and BE
URL: https://github.com/apache/incubator-doris/pull/1678#issuecomment-526979725
#1717
This is an automated message from the Apache Git Service.
To respond
morningman commented on a change in pull request #1695: Refactor alter job
URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319787154
##
File path: fe/src/main/java/org/apache/doris/load/Load.java
##
@@ -643,16 +634,12 @@ public static void checkAndCreat
kangpinghuang commented on issue #1718: Basic implementation for
BetaRowsetReader
URL: https://github.com/apache/incubator-doris/pull/1718#issuecomment-526973901
add a description for this pr.
This is an automated message fro
morningman commented on a change in pull request #1695: Refactor alter job
URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319785451
##
File path: fe/src/main/java/org/apache/doris/analysis/DataDescription.java
##
@@ -65,34 +67,43 @@
public class DataD
EmmyMiao87 commented on a change in pull request #1695: Refactor alter job
URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319758180
##
File path: fe/src/main/java/org/apache/doris/load/Load.java
##
@@ -643,16 +634,12 @@ public static void checkAndCreat
EmmyMiao87 commented on a change in pull request #1695: Refactor alter job
URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319757282
##
File path: fe/src/main/java/org/apache/doris/analysis/DataDescription.java
##
@@ -65,34 +67,43 @@
public class DataD
EmmyMiao87 commented on a change in pull request #1695: Refactor alter job
URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319758050
##
File path: fe/src/main/java/org/apache/doris/planner/BrokerScanNode.java
##
@@ -225,62 +229,73 @@ private void initPa
32 matches
Mail list logo
