[GitHub] [incubator-doris] imay merged pull request #1721: Make bitmap_union agg column support insert into and broker load

2019-08-29 Thread GitBox
imay merged pull request #1721: Make bitmap_union agg column support insert into and broker load URL: https://github.com/apache/incubator-doris/pull/1721 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319337884 ## File path: fe/src/main/java/org/apache/doris/task/StreamLoadTask.java ## @@ -83,8 +84,15 @@ public TFileFormatType getForma

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319345455 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -303,6 +304,10 @@ protected void setJobProperti

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319336556 ## File path: fe/src/main/java/org/apache/doris/planner/StreamLoadScanNode.java ## @@ -124,67 +126,85 @@ public void init(Anal

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319372633 ## File path: fe/src/main/java/org/apache/doris/analysis/DataDescription.java ## @@ -65,34 +67,43 @@ public class DataDescrip

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319369421 ## File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java ## @@ -0,0 +1,744 @@ +// Licensed to the Apache Softwar

[GitHub] [incubator-doris] imay commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
imay commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319337464 ## File path: fe/src/main/java/org/apache/doris/transaction/TransactionState.java ## @@ -408,6 +414,23 @@ public void setTxnCo

Re: doris 后续发布计划

2019-08-29 Thread tan zhongyi
Hi, katte, Since we are in global open source community, And there are several guys not from China. Can you resend it again and using English? Thanks 在 2019/8/30 下午12:01,“Katte” 写入: 您好!请问一下,doris后续的发布路线图或新版本发布计划 是否有?谢谢! 发送自 Windows 10 版邮件应用 -

doris 后续发布计划

2019-08-29 Thread Katte
您好!请问一下,doris后续的发布路线图或新版本发布计划 是否有?谢谢! 发送自 Windows 10 版邮件应用

[GitHub] [incubator-doris] kangkaisen commented on issue #1721: Make bitmap_union agg column support insert into and broker load

2019-08-29 Thread GitBox
kangkaisen commented on issue #1721: Make bitmap_union agg column support insert into and broker load URL: https://github.com/apache/incubator-doris/pull/1721#issuecomment-526440302 > There are a lot change related to load process in my pull request #1695 . > So...Please do not change an

Re:Re: #1719 Add English document for Doris official website

2019-08-29 Thread 陈明雨
OK, we will find out how to add this link~ -- 此致!Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org 在 2019-08-30 07:31:15,"Willem Jiang" 写道: >Yeah, it's good to see we have a quick fix for the document issue. >If we can add a link of "edit it in github" to the page, that would >lower

Re: #1719 Add English document for Doris official website

2019-08-29 Thread Willem Jiang
Yeah, it's good to see we have a quick fix for the document issue. If we can add a link of "edit it in github" to the page, that would lower the bar for the community to fix the document issue. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Aug 29, 2019 at 3:06 PM Xu,Yang(BDG) wrote:

[GitHub] [incubator-doris] imay commented on issue #1429: Refactor the process of ALTER job.

2019-08-29 Thread GitBox
imay commented on issue #1429: Refactor the process of ALTER job. URL: https://github.com/apache/incubator-doris/issues/1429#issuecomment-526228394 > rollup replica 在整个作业期间不能进行副本均衡和修复。 如果整个作业期间不能进行rollup replica副本修复,那么我担心Job作业时间过长,导入有多个副本损坏,会导致正常的导入作业也没法完成。 > 对于 WAITING_TXN 的作

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319079538 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@ -329,15 +328,20 @@ public v

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319074000 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@ -778,8 +758,8 @@ public boo

[GitHub] [incubator-doris] morningman opened a new issue #1724: Support checking transaction at table level instead of database level

2019-08-29 Thread GitBox
morningman opened a new issue #1724: Support checking transaction at table level instead of database level URL: https://github.com/apache/incubator-doris/issues/1724 When altering table, we will wait for all previous transaction to be finished. But because there is no table info in tran

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319072094 ## File path: fe/src/main/java/org/apache/doris/alter/RollupHandler.java ## @@ -270,93 +273,56 @@ private void processAd

[GitHub] [incubator-doris] morningman commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
morningman commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319071480 ## File path: be/src/olap/schema_change.cpp ## @@ -1332,9 +1332,12 @@ OLAPStatus SchemaChangeHandler::_do_process_alter

[GitHub] [incubator-doris] morningman commented on issue #1721: Make bitmap_union agg column support insert into and broker load

2019-08-29 Thread GitBox
morningman commented on issue #1721: Make bitmap_union agg column support insert into and broker load URL: https://github.com/apache/incubator-doris/pull/1721#issuecomment-526185297 There are a lot change related to load process in my pull request #1695 . So...Please do not change any cl

[GitHub] [incubator-doris] imay merged pull request #1722: Use double when converting TIME type value

2019-08-29 Thread GitBox
imay merged pull request #1722: Use double when converting TIME type value URL: https://github.com/apache/incubator-doris/pull/1722 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] imay commented on issue #1723: 元数据支持存储计算分离

2019-08-29 Thread GitBox
imay commented on issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723#issuecomment-526166188 @morningman 我觉得我们应该还是保留Backend这个实体,而不是将Storage全部替换为Backend。 1. Storage,StorageGroup应该做为Backend的某个属性存在。因为Backend上不仅有Storage的功能还有Compute的能力。 2. 未来我们想要把我

[GitHub] [incubator-doris] imay commented on a change in pull request #1721: Make bitmap_union agg column support insert into and broker load

2019-08-29 Thread GitBox
imay commented on a change in pull request #1721: Make bitmap_union agg column support insert into and broker load URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r319030547 ## File path: fe/src/main/java/org/apache/doris/planner/ScanNode.java ## @@ -37

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
yiguolei commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319025624 ## File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java ## @@ -0,0 +1,744 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] morningman opened a new issue #1723: 元数据支持存储计算分离

2019-08-29 Thread GitBox
morningman opened a new issue #1723: 元数据支持存储计算分离 URL: https://github.com/apache/incubator-doris/issues/1723 在存储计算架构中,数据可能存储在本地、远端,或同时存储在本地和远端。当数据存储在远端时,本地存储将作为一个全量Cache存在。在这种架构,现有的以下流程需求进行重新设计: * Backend 的元数据管理 * 建表或创建分区时数据分片的分布管理 * 数据副本的修改,数据分片的修复和均衡 * 数据导入控制 * StorageMe

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into and broker load

2019-08-29 Thread GitBox
kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into and broker load URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r319023099 ## File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java #

[GitHub] [incubator-doris] imay closed issue #1648: optimize V2 BinaryPlainPage format

2019-08-29 Thread GitBox
imay closed issue #1648: optimize V2 BinaryPlainPage format URL: https://github.com/apache/incubator-doris/issues/1648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] imay closed issue #1651: Support checksum in BetaRowset

2019-08-29 Thread GitBox
imay closed issue #1651: Support checksum in BetaRowset URL: https://github.com/apache/incubator-doris/issues/1651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re:#1719 Add English document for Doris official website

2019-08-29 Thread 陈明雨
Nice Job! We should continuously improve the English version of document. -- 此致!Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org At 2019-08-29 15:06:45, "Xu,Yang(BDG)" wrote: >Doris offical website (http://doris.incubator.apache.org) only have Chinese >version web content in the prev

[GitHub] [incubator-doris] wuyunfeng commented on issue #1716: Avoid consistency problem when has no more data

2019-08-29 Thread GitBox
wuyunfeng commented on issue #1716: Avoid consistency problem when has no more data URL: https://github.com/apache/incubator-doris/pull/1716#issuecomment-526136160 https://github.com/apache/incubator-doris/issues/1525 This is

[GitHub] [incubator-doris] morningman merged pull request #1716: Avoid consistency problem when has no more data

2019-08-29 Thread GitBox
morningman merged pull request #1716: Avoid consistency problem when has no more data URL: https://github.com/apache/incubator-doris/pull/1716 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
yiguolei commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319007129 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@ -778,8 +758,8 @@ public boole

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
yiguolei commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r319004248 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java ## @@ -329,15 +328,20 @@ public voi

[GitHub] [incubator-doris] imay commented on a change in pull request #1721: Make bitmap_union agg column support insert into

2019-08-29 Thread GitBox
imay commented on a change in pull request #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r319002033 ## File path: fe/src/main/java/org/apache/doris/analysis/InsertStmt.java ## @@ -478,6 +489,24 @

[GitHub] [incubator-doris] gaodayue commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-29 Thread GitBox
gaodayue commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526113327 @kangpinghuang > Can we write bitmap index of each column into a independent file, named with column_id in its na

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into

2019-08-29 Thread GitBox
kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r318979529 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Definition/CREATE TABLE.md

[GitHub] [incubator-doris] morningman commented on a change in pull request #1722: Use double when converting TIME type value

2019-08-29 Thread GitBox
morningman commented on a change in pull request #1722: Use double when converting TIME type value URL: https://github.com/apache/incubator-doris/pull/1722#discussion_r318975266 ## File path: be/src/runtime/memory_scratch_sink.cpp ## @@ -140,7 +140,7 @@ Status MemoryScrat

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1721: Make bitmap_union agg column support insert into

2019-08-29 Thread GitBox
HangyuanLiu commented on a change in pull request #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r318972876 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Definition/CREATE TABLE.md

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into

2019-08-29 Thread GitBox
kangkaisen commented on a change in pull request #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r318968848 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Definition/CREATE TABLE.md

[GitHub] [incubator-doris] kangkaisen commented on issue #1721: Make bitmap_union agg column support insert into

2019-08-29 Thread GitBox
kangkaisen commented on issue #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#issuecomment-526101291 > @kangkaisen > I have seen this PR. > I think you should check source column is a valid bitmap in InsertStatement lik

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1721: Make bitmap_union agg column support insert into

2019-08-29 Thread GitBox
HangyuanLiu commented on a change in pull request #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#discussion_r318964623 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Definition/CREATE TABLE.md

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
yiguolei commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318961674 ## File path: fe/src/main/java/org/apache/doris/alter/RollupHandler.java ## @@ -270,93 +273,56 @@ private void processAddR

[GitHub] [incubator-doris] imay commented on a change in pull request #1716: Avoid consistency problem when has no more data

2019-08-29 Thread GitBox
imay commented on a change in pull request #1716: Avoid consistency problem when has no more data URL: https://github.com/apache/incubator-doris/pull/1716#discussion_r318955067 ## File path: be/src/runtime/result_queue_mgr.cpp ## @@ -47,6 +47,10 @@ Status ResultQueueMgr::f

[GitHub] [incubator-doris] kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-29 Thread GitBox
kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526087487 > Agree. In this way the I/O cost of adding a new index is minimum, but reader now needs to know what indexes are av

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1695: Refactor alter job

2019-08-29 Thread GitBox
yiguolei commented on a change in pull request #1695: Refactor alter job URL: https://github.com/apache/incubator-doris/pull/1695#discussion_r318950070 ## File path: be/src/olap/schema_change.cpp ## @@ -1332,9 +1332,12 @@ OLAPStatus SchemaChangeHandler::_do_process_alter_t

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-29 Thread GitBox
kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526081460 Can we write bitmap index of each column into a independent file, named with column_id in its name, eg: segme

[GitHub] [incubator-doris] kangpinghuang removed a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-29 Thread GitBox
kangpinghuang removed a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526082595 > `test test` > > ` [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitmap Index for Col

[GitHub] [incubator-doris] kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-29 Thread GitBox
kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526082595 > `test test` > > ` [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitmap Index for Column n] [

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-29 Thread GitBox
kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526081460 ` test test ` ` [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitma

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-29 Thread GitBox
kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526081460 ` [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitmap Index for Column n] [Foot

[GitHub] [incubator-doris] kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-29 Thread GitBox
kangpinghuang edited a comment on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526081460 > [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitmap Index for Column n]

[GitHub] [incubator-doris] kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-29 Thread GitBox
kangpinghuang commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526081460 > [Bitmap Index for Column 1] [Bitmap Index for Column 2] ... [Bitmap Index for Column n] [Footer

[GitHub] [incubator-doris] imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-29 Thread GitBox
imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526075357 > @imay thanks for the comments. > > > If we support other type of index, for example B+Tree, do we need to store all

[GitHub] [incubator-doris] imay commented on issue #1721: Make bitmap_union agg column support insert into

2019-08-29 Thread GitBox
imay commented on issue #1721: Make bitmap_union agg column support insert into URL: https://github.com/apache/incubator-doris/pull/1721#issuecomment-526064274 @kangkaisen I have seen this PR. I think you should check source column is a valid bitmap in InsertStatement like HLL [here

[GitHub] [incubator-doris] gaodayue commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

2019-08-29 Thread GitBox
gaodayue commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-526063742 @imay thanks for the comments. > If we support other type of index, for example B+Tree, do we need to store all in

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-29 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318921870 ## File path: be/src/olap/rowset/segment_group.h ## @@ -248,7 +248,7 @@ class SegmentGroup { int

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1722: Use int64 when converting TIME type value

2019-08-29 Thread GitBox
chaoyli commented on a change in pull request #1722: Use int64 when converting TIME type value URL: https://github.com/apache/incubator-doris/pull/1722#discussion_r318919843 ## File path: be/src/runtime/memory_scratch_sink.cpp ## @@ -140,7 +140,7 @@ Status MemoryScratchSi

#1719 Add English document for Doris official website

2019-08-29 Thread Xu,Yang(BDG)
Doris offical website (http://doris.incubator.apache.org) only have Chinese version web content in the previous time. I translated the menu items and documents in the website by machine. And I put all translated documents under docs/documentation/en. However, because it is machine translation, th

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-29 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318914954 ## File path: be/src/olap/data_dir.cpp ## @@ -582,7 +576,9 @@ OLAPStatus DataDir::_convert_old_tablet()

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-29 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318914117 ## File path: be/src/olap/rowset/rowset_meta_manager.h ## @@ -31,20 +31,20 @@ namespace doris { // Hel

[GitHub] [incubator-doris] morningman opened a new pull request #1722: Use int64 when converting TIME type value

2019-08-29 Thread GitBox
morningman opened a new pull request #1722: Use int64 when converting TIME type value URL: https://github.com/apache/incubator-doris/pull/1722 TIME type value is saved in DOUBLE, so using int64 can extend the time range. Thi