[GitHub] [incubator-doris] imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-525596953 And for `Encoding for integer dictionary`, I think it's OK to use one byte to store BitWidth. If we store BitWidth, last fram

Re: 导入数据时提示 too many filtered rows

你所有的数据都被过滤掉了，你需要看下ErrorURL给出的过滤原因，然后修改下原始数据，使得数据符合表格式 Katte 于2019年8月28日周三 下午12:02写道： > 你好，我在导入数据时提示 too many filtered rows，是不是因为记录条数太多了呢？ > > 导入的文本文件，在61条记录，导入时提示如下： > > root@master:/mywork/data/T4# curl --location-trusted -u fm:Fm123456 -H > "label:tb04_20190828_1" -H "column_separator:," -

加载数据时提示 too many filtered rows

你好，我加载数据到doris中时提示 too many filtered rows ，是不是记录条数太多了呢 root@master:/mywork/data/T4# curl --location-trusted -u fm:Fm123456 -H "label:tb04_20190828_1" -H "column_separator:," -T T4_1.txt http://slave1:8040/api/futurmaster/tb04/_stream_load { "TxnId": 2002, "Label": "tb04_20190828_1",

导入数据时提示 too many filtered rows

你好，我在导入数据时提示 too many filtered rows，是不是因为记录条数太多了呢？ 导入的文本文件，在61条记录，导入时提示如下： root@master:/mywork/data/T4# curl --location-trusted -u fm:Fm123456 -H "label:tb04_20190828_1" -H "column_separator:," -T T4_1.txt http://slave1:8040/api/futurmaster/tb04/_stream_load { "TxnId": 2002, "Label

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort

chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471#discussion_r318373907 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort

chenhao7253886 commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471#discussion_r318373022 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318360328 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318368417 ## File path: be/src/olap/rowset/unique_rowset_id_generator.cpp ## @@ -0,0 +1,50 @@ +// Licensed t

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318361481 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318365231 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318367344 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318360237 ## File path: be/src/olap/rowset/rowset_id_generator.h ## @@ -28,27 +28,17 @@ class OlapMeta; c

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318365672 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318360296 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318368276 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318364183 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318363270 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318360367 ## File path: be/src/olap/rowset/unique_rowset_id_generator.h ## @@ -0,0 +1,48 @@ +// Licensed to

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318369258 ## File path: be/test/olap/rowset/unique_rowset_id_generator_test.cpp ## @@ -0,0 +1,101 @@ +// Lic

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318363048 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318358302 ## File path: be/src/olap/storage_engine.h ## @@ -196,6 +197,12 @@ class StorageEngine { // T

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318364245 ## File path: be/src/olap/olap_common.h ## @@ -241,7 +246,83 @@ typedef std::set UniqueIdSet; //

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318366359 ## File path: be/src/olap/rowset/rowset_meta.h ## @@ -71,12 +74,15 @@ class RowsetMeta {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318357984 ## File path: be/src/agent/agent_server.cpp ## @@ -426,7 +426,11 @@ void AgentServer::make_snapsho

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE

kangpinghuang commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r318366159 ## File path: be/src/olap/rowset/beta_rowset.cpp ## @@ -26,7 +26,7 @@ namespace doris { std::s

[GitHub] [incubator-doris] imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment

imay commented on issue #1684: [Proposal] Bitmap Index File Format for V2 segment URL: https://github.com/apache/incubator-doris/issues/1684#issuecomment-52249 @gaodayue Good proposal, I have some questions about this proposal. 1. If we support other type of index, for e

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647)

gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#discussion_r318366011 ## File path: be/src/olap/rowset/segment_v2/segment_writer.h ## @@ -82,6 +84,7 @@ class SegmentWrite

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647)

gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#discussion_r318365380 ## File path: be/src/olap/rowset/segment_v2/segment_writer.h ## @@ -60,6 +60,8 @@ class SegmentWrite

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647)

gaodayue commented on a change in pull request #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#discussion_r318366047 ## File path: be/src/olap/rowset/beta_rowset_writer.cpp ## @@ -84,6 +84,9 @@ OLAPStatus BetaRowsetWr

[GitHub] [incubator-doris] gaodayue commented on issue #1705: Limit V2 segment file row count (#1647)

gaodayue commented on issue #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#issuecomment-525554010 In addition - `SegmentFooterPB.num_rows` should be changed from uint64 to uint32 - `segment_v2::SegmentWriter::_row_count` should b

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547)

kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318357108 ## File path: fe/src/main/java/org/apache/doris/qe/ShowExecutor.java ## @@ -1146,14 +1147,69 @@ private

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547)

kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318354377 ## File path: fe/src/main/java/org/apache/doris/analysis/ShowTabletStmt.java ## @@ -79,10 +135,112 @@ p

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547)

kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318354371 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulation/SHOW TABLET.md ## @

[GitHub] [incubator-doris] imay closed issue #1706: BE crash when inserting data

imay closed issue #1706: BE crash when inserting data URL: https://github.com/apache/incubator-doris/issues/1706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] morningman commented on a change in pull request #1687: add limit to show tablet(#1547)

morningman commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318111308 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulation/SHOW TABLET.md ## @@ -

[GitHub] [incubator-doris] morningman commented on a change in pull request #1687: add limit to show tablet(#1547)

morningman commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318112418 ## File path: fe/src/main/java/org/apache/doris/qe/ShowExecutor.java ## @@ -1146,14 +1147,69 @@ private vo

[GitHub] [incubator-doris] morningman commented on a change in pull request #1687: add limit to show tablet(#1547)

morningman commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318111226 ## File path: fe/src/main/java/org/apache/doris/analysis/ShowTabletStmt.java ## @@ -79,10 +135,112 @@ publ

[GitHub] [incubator-doris] morningman merged pull request #1644: Refactor DateLiteral class in FE

morningman merged pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-doris] morningman merged pull request #1702: Limit the disk usage to avoid running out of disk capacity

morningman merged pull request #1702: Limit the disk usage to avoid running out of disk capacity URL: https://github.com/apache/incubator-doris/pull/1702 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] morningman merged pull request #1709: Make the max recursion depth of distribution pruner configurable

morningman merged pull request #1709: Make the max recursion depth of distribution pruner configurable URL: https://github.com/apache/incubator-doris/pull/1709 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-doris] morningman merged pull request #1711: Add particular log info for doris on es

morningman merged pull request #1711: Add particular log info for doris on es URL: https://github.com/apache/incubator-doris/pull/1711 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] morningman merged pull request #1712: Make StringValue's memory layout same with Slice

morningman merged pull request #1712: Make StringValue's memory layout same with Slice URL: https://github.com/apache/incubator-doris/pull/1712 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-doris] kangkaisen commented on issue #1712: Make StringValue's memory layout same with Slice

kangkaisen commented on issue #1712: Make StringValue's memory layout same with Slice URL: https://github.com/apache/incubator-doris/pull/1712#issuecomment-525252535 Fix https://github.com/apache/incubator-doris/issues/1706 +1 LGTM ---

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547)

kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318015451 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulation/SHOW TABLET.md ## @

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547)

kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318015491 ## File path: fe/src/main/java/org/apache/doris/analysis/ShowTabletStmt.java ## @@ -79,10 +131,106 @@ p

[GitHub] [incubator-doris] chaoyli merged pull request #1713: fix from string bug(#1710)

chaoyli merged pull request #1713: fix from string bug(#1710) URL: https://github.com/apache/incubator-doris/pull/1713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1713: fix from string bug(#1710)

kangpinghuang opened a new pull request #1713: fix from string bug(#1710) URL: https://github.com/apache/incubator-doris/pull/1713 Fix WrapperField from_string bug for char type. This is an automated message from the Apache Gi

[GitHub] [incubator-doris] imay opened a new pull request #1712: Make StringValue's memory layout same with Slice

imay opened a new pull request #1712: Make StringValue's memory layout same with Slice URL: https://github.com/apache/incubator-doris/pull/1712 In our storage engine's code, we cast StringValue to Slice. Because their memory layout is not differenct, it may cause BE process crash.

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1711: Add particular log info for doris on es

wuyunfeng opened a new pull request #1711: Add particular log info for doris on es URL: https://github.com/apache/incubator-doris/pull/1711 It is necessary for logging the generated query DSL for Doris On ES This is an automa

[GitHub] [incubator-doris] imay merged pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

imay merged pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-doris] kangpinghuang commented on issue #1710: query will failed when where predicate has string field

kangpinghuang commented on issue #1710: query will failed when where predicate has string field URL: https://github.com/apache/incubator-doris/issues/1710#issuecomment-525221296 this is because there is a bug when wrapper_field.from_string(), which lead to string compare failed.

[GitHub] [incubator-doris] kangpinghuang opened a new issue #1710: query will failed when where predicate has string field

kangpinghuang opened a new issue #1710: query will failed when where predicate has string field URL: https://github.com/apache/incubator-doris/issues/1710 the result of sql select * from baseall where k6='true' order by k6; is different from query: select * from baseall order

[GitHub] [incubator-doris] imay commented on a change in pull request #1709: Make the max recursion depth of distribution pruner configurable

imay commented on a change in pull request #1709: Make the max recursion depth of distribution pruner configurable URL: https://github.com/apache/incubator-doris/pull/1709#discussion_r317951835 ## File path: fe/src/main/java/org/apache/doris/planner/HashDistributionPruner.java ###

[GitHub] [incubator-doris] imay commented on a change in pull request #1709: Make the max recursion depth of distribution pruner configurable

imay commented on a change in pull request #1709: Make the max recursion depth of distribution pruner configurable URL: https://github.com/apache/incubator-doris/pull/1709#discussion_r317951999 ## File path: fe/src/main/java/org/apache/doris/planner/HashDistributionPruner.java ###

[GitHub] [incubator-doris] morningman opened a new pull request #1709: Make the max recursion depth of distribution pruner configurable

morningman opened a new pull request #1709: Make the max recursion depth of distribution pruner configurable URL: https://github.com/apache/incubator-doris/pull/1709 Add a new FE config 'max_distribution_pruner_recursion_depth'. -

Re: issues about the website

I have added donating to ASF in Doris README. Here is the link https://github.com/apache/incubator-doris/pull/1708 Dave Fisher 于2019年8月26日周一 下午10:02写道： > Hi - > > Also on the website there should be the Incubation Disclaimer. See > http://incubator.apache.org/guides/branding.html#disclaimers > >

[GitHub] [incubator-doris] imay merged pull request #1708: Add donating to ASF in README

imay merged pull request #1708: Add donating to ASF in README URL: https://github.com/apache/incubator-doris/pull/1708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] chaoyli commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23

chaoyli commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23 URL: https://github.com/apache/incubator-doris/issues/1256#issuecomment-525169788 You can compare the exec/olap_scanner.cpp, which call capture_rs_readers() in a

[GitHub] [incubator-doris] chaoyli edited a comment on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23

chaoyli edited a comment on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23 URL: https://github.com/apache/incubator-doris/issues/1256#issuecomment-525168855 Query may lasts so long. During this period, compaction has done and remo

[GitHub] [incubator-doris] imay opened a new pull request #1708: Add donating to ASF in README

imay opened a new pull request #1708: Add donating to ASF in README URL: https://github.com/apache/incubator-doris/pull/1708 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] chaoyli commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23

chaoyli commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23 URL: https://github.com/apache/incubator-doris/issues/1256#issuecomment-525168855 Query may lasts so long. During this period, compaction has done and remove com

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317922042 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317921343 ## File path: be/src/olap/iterators.h ## @@ -28,27 +28,63 @@ class Row

[GitHub] [incubator-doris] HawickMason commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23

HawickMason commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23 URL: https://github.com/apache/incubator-doris/issues/1256#issuecomment-525167861 any idea why this hanppened @imay I got the same error with "failed to ini