[GitHub] [incubator-doris] imay merged pull request #1610: Add bitmap agg type and udaf

imay merged pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-doris] imay merged pull request #1698: refactor RowsetReaderContext

imay merged pull request #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317461796 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -222,39 +194,26 @@ class Bina

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317461852 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -147,37 +140,16 @@ class Bina

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317461652 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,19 @@ class Binary

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317461632 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,19 @@ class Binary

[GitHub] [incubator-doris] imay commented on issue #1698: refactor RowsetReaderContext

imay commented on issue #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524728679 > > I see that in schema_chage.cpp you assign need_ordered_result to true here, which I think it should be false? > > This is to keep the behavi

[GitHub] [incubator-doris] gaodayue commented on issue #1694: optimize V2 BinaryPlainPage format (#1648)

gaodayue commented on issue #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#issuecomment-524725582 Please also update the PR description that this is to fix #1648 Thi

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317453726 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -222,39 +194,26 @@ class Bi

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317456094 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -63,9 +63,9 @@ class Binary

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317458003 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -222,39 +194,26 @@ class Bi

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317453369 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,19 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317457866 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -222,39 +194,26 @@ class Bi

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317454379 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -147,37 +140,16 @@ class Bi

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317452834 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,19 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317452506 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,19 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on issue #1698: refactor RowsetReaderContext

gaodayue commented on issue #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524716865 > I see that in schema_chage.cpp you assign need_ordered_result to true here, which I think it should be false? This is to keep the behavior

[GitHub] [incubator-doris] imay commented on issue #1698: refactor RowsetReaderContext

imay commented on issue #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524712910 > @imay > > > I think preaggregation and need_ordered_result are different things. When preaggregation is true, returning unordered data is OK.

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r317437457 ## File path: be/src/olap/wrapper_field.cpp ## @@ -53,14 +53,17 @@ WrapperField* WrapperField::create(const T

[GitHub] [incubator-doris] gaodayue commented on issue #1698: refactor RowsetReaderContext

gaodayue commented on issue #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524696441 @imay > I think preaggregation and need_ordered_result are different things. When preaggregation is true, returning unordered data is OK.

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r317432262 ## File path: be/src/olap/wrapper_field.cpp ## @@ -53,14 +53,17 @@ WrapperField* WrapperField::create(const TabletCo

[GitHub] [incubator-doris] imay commented on issue #1698: refactor RowsetReaderContext

imay commented on issue #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524688567 @gaodayue I think `preaggregation` and `need_ordered_result ` are different things. When `preaggregation` is true, returning unordered data is OK.

[GitHub] [incubator-doris] morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317424096 ## File path: be/src/util/arrow/row_block.cpp ## @@ -0,0 +1,323 @@ +// Licensed t

[GitHub] [incubator-doris] morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317424846 ## File path: be/src/util/arrow/row_batch.h ## @@ -0,0 +1,70 @@ +// Licensed to t

[GitHub] [incubator-doris] morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317423529 ## File path: be/src/util/arrow/row_block.h ## @@ -0,0 +1,65 @@ +// Licensed to t

[GitHub] [incubator-doris] morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317423425 ## File path: be/src/util/arrow/utils.h ## @@ -0,0 +1,49 @@ +// Licensed to the A

[GitHub] [incubator-doris] imay opened a new pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

imay opened a new pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] gaodayue opened a new pull request #1698: refactor RowsetReaderContext

gaodayue opened a new pull request #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698 This PR refactors RowsetReaderContext and adds more comments to help developers understand the read path. Tha main changes are - move index stream ca