[GitHub] [incubator-doris] thimoonxy edited a comment on issue #1682: Failed to insert decimal data

2019-08-20 Thread GitBox
thimoonxy edited a comment on issue #1682: Failed to insert decimal data URL: https://github.com/apache/incubator-doris/issues/1682#issuecomment-523323335 > seems not a bug, DECIMAL(4,3) allows 3 digits after decimal point, 1 before point only. > decimal(5,3) indicates: int(2).double(3)

[GitHub] [incubator-doris] thimoonxy edited a comment on issue #1682: Failed to insert decimal data

2019-08-20 Thread GitBox
thimoonxy edited a comment on issue #1682: Failed to insert decimal data URL: https://github.com/apache/incubator-doris/issues/1682#issuecomment-523323335 > seems not a bug, DECIMAL(4,3) allows 3 digits after decimal point, 1 before point only. ``` mysql> create table t3 (k1 int, k2

[GitHub] [incubator-doris] thimoonxy commented on issue #1682: Failed to insert decimal data

2019-08-20 Thread GitBox
thimoonxy commented on issue #1682: Failed to insert decimal data URL: https://github.com/apache/incubator-doris/issues/1682#issuecomment-523323335 > seems not a bug, DECIMAL(4,3) allows 3 digits after decimal point, 1 before point only. ``` mysql> create table t3 (k1 int, k2 date, v

[GitHub] [incubator-doris] thimoonxy closed issue #1682: Failed to insert decimal data

2019-08-20 Thread GitBox
thimoonxy closed issue #1682: Failed to insert decimal data URL: https://github.com/apache/incubator-doris/issues/1682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r316021515 ## File path: be/src/exprs/bitmap_function.cpp ## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] thimoonxy opened a new issue #1682: Failed to insert decimal data

2019-08-20 Thread GitBox
thimoonxy opened a new issue #1682: Failed to insert decimal data URL: https://github.com/apache/incubator-doris/issues/1682 version: Doris-0.10.18 ``` mysql> desc t2; +---+--+--+---+-+---+ | Field | Type | Null | Key | Default |

[GitHub] [incubator-doris] imay commented on a change in pull request #1680: fixup bug: "SHOW DATA" or "SHOW PARTITIONS", the DATA-SIZE less than 0

2019-08-20 Thread GitBox
imay commented on a change in pull request #1680: fixup bug: "SHOW DATA" or "SHOW PARTITIONS", the DATA-SIZE less than 0 URL: https://github.com/apache/incubator-doris/pull/1680#discussion_r315997217 ## File path: fe/src/main/java/org/apache/doris/catalog/Replica.java ## @

[GitHub] [incubator-doris] yuanlihan opened a new issue #1681: Extract data from data source with nested structure

2019-08-20 Thread GitBox
yuanlihan opened a new issue #1681: Extract data from data source with nested structure URL: https://github.com/apache/incubator-doris/issues/1681 **Currently, Doris is not well-supported for nested data parsing in data ingestion** Users may need to load data sources, like JSON/Parquet

[GitHub] [incubator-doris] yuanlihan closed issue #1582: Enable Partition Discovery for Broker Load

2019-08-20 Thread GitBox
yuanlihan closed issue #1582: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/issues/1582 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] yuanlihan commented on issue #1582: Enable Partition Discovery for Broker Load

2019-08-20 Thread GitBox
yuanlihan commented on issue #1582: Enable Partition Discovery for Broker Load URL: https://github.com/apache/incubator-doris/issues/1582#issuecomment-523284628 Added This is an automated message from the Apache Git Service.

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315984891 ## File path: be/src/runtime/fe_based_rowset_id_generator.cpp ## @@ -0,0 +1,108 @@ +// Licensed to the

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315981868 ## File path: be/src/exprs/bitmap_function.cpp ## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315981727 ## File path: be/src/olap/row_cursor.cpp ## @@ -184,31 +179,9 @@ OLAPStatus RowCursor::allocate_memory_for_string_t

Apache project meetup in ShangHai Sep 21st

2019-08-20 Thread Willem Jiang
Hi, We would like to hold a meetup in ShangHai Sep 21st by inviting some Apache members ( Craig Russell, Justin Mclean, Willem Jiang)and some apache projects committers in China like we did last year. We hold this meetup can help Apache projects to know each other in China. As there are lot of Ap

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315979655 ## File path: be/src/olap/row.h ## @@ -75,7 +75,7 @@ template void init_row_with_others(DstRowType* dst, con

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315976929 ## File path: be/src/olap/schema.h ## @@ -78,16 +98,22 @@ class Schema { ~Schema(); -void reset(

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315976631 ## File path: be/src/olap/row_cursor.cpp ## @@ -184,31 +179,9 @@ OLAPStatus RowCursor::allocate_memory_for_s

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315974781 ## File path: be/src/exec/olap_scanner.cpp ## @@ -328,6 +328,11 @@ Status OlapScanner::get_batch(

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315974753 ## File path: docs/documentation/cn/sql-reference/sql-functions/aggregate-functions/bitmap.md ## @@ -0,0 +1,

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315974625 ## File path: be/src/exprs/bitmap_function.cpp ## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315972900 ## File path: be/src/olap/rowset/segment_v2/column_writer.h ## @@ -147,8 +154,10 @@ class ColumnWriter {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315972783 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315972291 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315972301 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315971934 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315971867 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
kangpinghuang commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315971841 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -50,18 +50,19 @@ class BinaryPlainPageBu

[GitHub] [incubator-doris] wkhappy1 closed pull request #1667: kafka导入添加fillnull

2019-08-20 Thread GitBox
wkhappy1 closed pull request #1667: kafka导入添加fillnull URL: https://github.com/apache/incubator-doris/pull/1667 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] worker24h opened a new pull request #1680: fixup bug: "SHOW DATA" or "SHOW PARTITIONS", the DATA-SIZE less than 0

2019-08-20 Thread GitBox
worker24h opened a new pull request #1680: fixup bug: "SHOW DATA" or "SHOW PARTITIONS", the DATA-SIZE less than 0 URL: https://github.com/apache/incubator-doris/pull/1680 This is an automated message from the Apache Git Serv

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: fixbug and extend partition function

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1679: fixbug and extend partition function URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r315966311 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -1515,6 +1521,15 @@ partition_key_desc ::= :}

[GitHub] [incubator-doris] morningman commented on a change in pull request #1679: fixbug and extend partition function

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1679: fixbug and extend partition function URL: https://github.com/apache/incubator-doris/pull/1679#discussion_r315966080 ## File path: fe/src/main/java/org/apache/doris/catalog/Replica.java ## @@ -111,7 +111,7 @@ public Re

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315714288 ## File path: be/src/olap/schema.h ## @@ -78,16 +98,22 @@ class Schema { ~Schema(); -void reset(const s

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315712380 ## File path: docs/documentation/cn/sql-reference/sql-functions/aggregate-functions/bitmap.md ## @@ -0,0 +1,77 @@ +

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315696818 ## File path: be/src/olap/row.h ## @@ -75,7 +75,7 @@ template void init_row_with_others(DstRowType* dst, const SrcR

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315687953 ## File path: be/src/exprs/bitmap_function.cpp ## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Foundation (A

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315716956 ## File path: be/src/exec/olap_scanner.cpp ## @@ -328,6 +328,11 @@ Status OlapScanner::get_batch(

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315699551 ## File path: be/src/olap/row_cursor.cpp ## @@ -184,31 +179,9 @@ OLAPStatus RowCursor::allocate_memory_for_string_t

[GitHub] [incubator-doris] morningman merged pull request #1677: Add strict mode in Routine load, Stream load and Mini load

2019-08-20 Thread GitBox
morningman merged pull request #1677: Add strict mode in Routine load, Stream load and Mini load URL: https://github.com/apache/incubator-doris/pull/1677 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] worker24h opened a new pull request #1679: fixbug and extend partition function

2019-08-20 Thread GitBox
worker24h opened a new pull request #1679: fixbug and extend partition function URL: https://github.com/apache/incubator-doris/pull/1679 1. Add fixed partitions. for example: ALTER TABLE test_table ADD PARTITION p0125 VALUES ["20190125", "20190126"); 2. fixup bug: "SHOW DATA" or "

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315653515 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -48,9 +57,17 @@ public DateLite

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315654711 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ protected E

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315653967 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ protected E

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315658493 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ protected E

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315659643 ## File path: fe/src/main/java/org/apache/doris/rewrite/FEFunctions.java ## @@ -75,9 +75,11 @@ public static In

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315655937 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -150,17 +178,28 @@ public Strin

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315652679 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -29,16 +31,23 @@ import org.

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315654846 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ protected E

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315653644 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -61,66 +78,77 @@ public D

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315650319 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -61,66 +78,77 @@ public DateLit

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315646295 ## File path: fe/src/main/java/org/apache/doris/catalog/RowsetIdGenerator.java ## @@ -0,0 +1,71 @@ +// Lice

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
HangyuanLiu commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315639291 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ prot

[GitHub] [incubator-doris] imay merged pull request #1675: Reduce the number of partition info in BrokerScanNode param

2019-08-20 Thread GitBox
imay merged pull request #1675: Reduce the number of partition info in BrokerScanNode param URL: https://github.com/apache/incubator-doris/pull/1675 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315623094 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -61,66 +78,77 @@ public D

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315624772 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ prote

[GitHub] [incubator-doris] morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-20 Thread GitBox
morningman commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r315625125 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -187,18 +222,266 @@ prote

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315611578 ## File path: fe/src/main/java/org/apache/doris/catalog/RowsetIdGenerator.java ## @@ -0,0 +1,71 @@ +//

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315610629 ## File path: gensrc/thrift/FrontendService.thrift ## @@ -604,6 +604,12 @@ struct TSnapshotLoaderReport

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315608293 ## File path: be/src/runtime/fe_based_rowset_id_generator.cpp ## @@ -0,0 +1,108 @@ +// Licensed to the

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
yiguolei commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315596244 ## File path: be/src/runtime/fe_based_rowset_id_generator.cpp ## @@ -0,0 +1,108 @@ +// Licensed to the

[GitHub] [incubator-doris] imay merged pull request #1662: Add broker doc

2019-08-20 Thread GitBox
imay merged pull request #1662: Add broker doc URL: https://github.com/apache/incubator-doris/pull/1662 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1677: Add strict mode in Routine load, Stream load and Mini load

2019-08-20 Thread GitBox
EmmyMiao87 commented on a change in pull request #1677: Add strict mode in Routine load, Stream load and Mini load URL: https://github.com/apache/incubator-doris/pull/1677#discussion_r315581731 ## File path: fe/src/main/java/org/apache/doris/analysis/CreateRoutineLoadStmt.java ###

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315522900 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315566904 ## File path: be/src/olap/rowset/segment_v2/column_writer.cpp ## @@ -142,8 +156,20 @@ Status ColumnWriter::_append_d

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315523190 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315539815 ## File path: be/src/olap/rowset/segment_v2/column_writer.h ## @@ -147,8 +154,10 @@ class ColumnWriter { std::u

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315529630 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315530048 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315518993 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -50,18 +50,19 @@ class BinaryPlainPageBuilder

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315523106 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1633: add zone map page(#1390)

2019-08-20 Thread GitBox
gaodayue commented on a change in pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633#discussion_r315522947 ## File path: be/src/olap/rowset/segment_v2/column_zone_map.h ## @@ -0,0 +1,118 @@ +// Licensed to the Apache Softwa

[GitHub] [incubator-doris] kangkaisen closed pull request #1645: Acquire data_sources at the beginning of the olapscanner

2019-08-20 Thread GitBox
kangkaisen closed pull request #1645: Acquire data_sources at the beginning of the olapscanner URL: https://github.com/apache/incubator-doris/pull/1645 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] kangkaisen closed issue #1663: NumberTotalRows in stream load result is double

2019-08-20 Thread GitBox
kangkaisen closed issue #1663: NumberTotalRows in stream load result is double URL: https://github.com/apache/incubator-doris/issues/1663 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315560459 ## File path: be/src/olap/row.h ## @@ -142,7 +142,7 @@ template void agg_finalize_row(const std::vector& ids

[GitHub] [incubator-doris] imay commented on a change in pull request #1677: Add strict mode in Routine load, Stream load and Mini load

2019-08-20 Thread GitBox
imay commented on a change in pull request #1677: Add strict mode in Routine load, Stream load and Mini load URL: https://github.com/apache/incubator-doris/pull/1677#discussion_r315560268 ## File path: fe/src/main/java/org/apache/doris/analysis/CreateRoutineLoadStmt.java #

[GitHub] [incubator-doris] imay commented on a change in pull request #1677: Add strict mode in Routine load, Stream load and Mini load

2019-08-20 Thread GitBox
imay commented on a change in pull request #1677: Add strict mode in Routine load, Stream load and Mini load URL: https://github.com/apache/incubator-doris/pull/1677#discussion_r315559859 ## File path: fe/src/main/java/org/apache/doris/task/StreamLoadTask.java ## @@ -57,6

[GitHub] [incubator-doris] imay commented on a change in pull request #1677: Add strict mode in Routine load, Stream load and Mini load

2019-08-20 Thread GitBox
imay commented on a change in pull request #1677: Add strict mode in Routine load, Stream load and Mini load URL: https://github.com/apache/incubator-doris/pull/1677#discussion_r315536265 ## File path: gensrc/thrift/FrontendService.thrift ## @@ -522,7 +522,8 @@ struct TStr

[GitHub] [incubator-doris] imay commented on a change in pull request #1677: Add strict mode in Routine load, Stream load and Mini load

2019-08-20 Thread GitBox
imay commented on a change in pull request #1677: Add strict mode in Routine load, Stream load and Mini load URL: https://github.com/apache/incubator-doris/pull/1677#discussion_r315559611 ## File path: fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315560061 ## File path: docs/documentation/cn/sql-reference/sql-functions/aggregate-functions/bitmap.md ## @@ -0,0 +1,

[GitHub] [incubator-doris] kangkaisen commented on issue #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on issue #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#issuecomment-522906488 This update contains the following change: 1 Release row_cursor arena memory immediately 2 Move bitmap functions from `AggregateFunction

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-20 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r315559959 ## File path: docs/documentation/cn/sql-reference/sql-functions/aggregate-functions/bitmap_union.md ## @@ -0

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r31323 ## File path: fe/src/main/java/org/apache/doris/catalog/RowsetIdGenerator.java ## @@ -0,0 +1,71 @@ +// Lice

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315554311 ## File path: be/src/runtime/fe_based_rowset_id_generator.cpp ## @@ -0,0 +1,108 @@ +// Licensed to the Apac

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315553619 ## File path: be/src/runtime/fe_based_rowset_id_generator.cpp ## @@ -0,0 +1,108 @@ +// Licensed to the Apac

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315556290 ## File path: gensrc/thrift/FrontendService.thrift ## @@ -604,6 +604,12 @@ struct TSnapshotLoaderReportRequ

[GitHub] [incubator-doris] imay commented on a change in pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
imay commented on a change in pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#discussion_r315552994 ## File path: be/src/runtime/fe_based_rowset_id_generator.cpp ## @@ -0,0 +1,108 @@ +// Licensed to the Apac

[GitHub] [incubator-doris] imay merged pull request #1670: Support setting timeout for stream load

2019-08-20 Thread GitBox
imay merged pull request #1670: Support setting timeout for stream load URL: https://github.com/apache/incubator-doris/pull/1670 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] yiguolei opened a new pull request #1678: Add rowset id generator to FE and BE

2019-08-20 Thread GitBox
yiguolei opened a new pull request #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1677: Add strict mode in Routine load, Stream load and Mini load

2019-08-20 Thread GitBox
EmmyMiao87 opened a new pull request #1677: Add strict mode in Routine load, Stream load and Mini load URL: https://github.com/apache/incubator-doris/pull/1677 This is an automated message from the Apache Git Service. To res