[GitHub] [incubator-doris] imay merged pull request #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
imay merged pull request #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] morningman merged pull request #1565: Fix NullPointerException when creating mini load in LoadManager

2019-07-29 Thread GitBox
morningman merged pull request #1565: Fix NullPointerException when creating mini load in LoadManager URL: https://github.com/apache/incubator-doris/pull/1565 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1565: Fix NullPointerException when creating mini load in LoadManager

2019-07-29 Thread GitBox
EmmyMiao87 opened a new pull request #1565: Fix NullPointerException when creating mini load in LoadManager URL: https://github.com/apache/incubator-doris/pull/1565 The catch statement cancel the load job in the function named createMiniLoad. But sometimes, the load job hasn't been creat

[GitHub] [incubator-doris] imay merged pull request #1562: EnginePublishVersionTask: remove unreachable code

2019-07-29 Thread GitBox
imay merged pull request #1562: EnginePublishVersionTask: remove unreachable code URL: https://github.com/apache/incubator-doris/pull/1562 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] manannan2017 opened a new issue #1564: the

2019-07-29 Thread GitBox
manannan2017 opened a new issue #1564: the URL: https://github.com/apache/incubator-doris/issues/1564 **Describe the bug** A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior: 1. Go to '...' 2. Click on '' 3. Scroll d

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1562: EnginePublishVersionTask: remove unreachable code

2019-07-29 Thread GitBox
yiguolei commented on a change in pull request #1562: EnginePublishVersionTask: remove unreachable code URL: https://github.com/apache/incubator-doris/pull/1562#discussion_r308519975 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -104,21 +104,11 @@ OL

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1563: Add log for tables order

2019-07-29 Thread GitBox
chenhao7253886 opened a new pull request #1563: Add log for tables order URL: https://github.com/apache/incubator-doris/pull/1563 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] chenhao7253886 merged pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-29 Thread GitBox
chenhao7253886 merged pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1562: EnginePublishVersionTask: remove unreachable code

2019-07-29 Thread GitBox
gaodayue commented on a change in pull request #1562: EnginePublishVersionTask: remove unreachable code URL: https://github.com/apache/incubator-doris/pull/1562#discussion_r308515164 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -104,21 +104,11 @@ OL

[GitHub] [incubator-doris] zhangy5 closed issue #1555: Insert default value failed when column is nullable and do not set default value explicitly

2019-07-29 Thread GitBox
zhangy5 closed issue #1555: Insert default value failed when column is nullable and do not set default value explicitly URL: https://github.com/apache/incubator-doris/issues/1555 This is an automated message from the Apache

[GitHub] [incubator-doris] morningman closed issue #1554: Insert default value failed when column is nullable and do not set default value

2019-07-29 Thread GitBox
morningman closed issue #1554: Insert default value failed when column is nullable and do not set default value URL: https://github.com/apache/incubator-doris/issues/1554 This is an automated message from the Apache Git Serv

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1556: Allow the null default in insert into stmt

2019-07-29 Thread GitBox
EmmyMiao87 commented on issue #1556: Allow the null default in insert into stmt URL: https://github.com/apache/incubator-doris/pull/1556#issuecomment-516234953 #1555 This is an automated message from the Apache Git Service. T

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1555: Insert default value failed when column is nullable and do not set default value explicitly

2019-07-29 Thread GitBox
EmmyMiao87 commented on issue #1555: Insert default value failed when column is nullable and do not set default value explicitly URL: https://github.com/apache/incubator-doris/issues/1555#issuecomment-516234902 #1556 This i

[GitHub] [incubator-doris] zhangy5 closed issue #1534: Parquet导入问题

2019-07-29 Thread GitBox
zhangy5 closed issue #1534: Parquet导入问题 URL: https://github.com/apache/incubator-doris/issues/1534 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-29 Thread GitBox
chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r308509064 ## File path: be/src/exprs/binary_predicate.cpp ## @@ -511,6 +543,114 @@ St

[GitHub] [incubator-doris] morningman commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-29 Thread GitBox
morningman commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r308506428 ## File path: be/src/exprs/binary_predicate.cpp ## @@ -511,6 +543,114 @@ Status

[GitHub] [incubator-doris] kangkaisen commented on issue #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
kangkaisen commented on issue #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561#issuecomment-516225931 > > @imay Hi. Why introduce the new concept `ContiguousRow` and `RowCursorCell`? Are they necessary? I think we should keep core conce

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308497228 ## File path: be/src/runtime/external_scan_context_mgr.cpp ## @@ -0,0 +1,115 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308499544 ## File path: be/src/runtime/result_queue_mgr.cpp ## @@ -0,0 +1,79 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308497573 ## File path: be/src/runtime/external_scan_context_mgr.cpp ## @@ -0,0 +1,115 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308499925 ## File path: be/src/runtime/result_queue_mgr.h ## @@ -0,0 +1,62 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308498964 ## File path: be/src/runtime/memory_scratch_sink.cpp ## @@ -0,0 +1,264 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] imay commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
imay commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561#discussion_r308496749 ## File path: be/src/olap/schema.h ## @@ -143,24 +154,30 @@ class Schema { *reinterpret_cast(ro

[GitHub] [incubator-doris] imay commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
imay commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561#discussion_r308488666 ## File path: be/src/olap/row_cursor.h ## @@ -160,28 +115,44 @@ class RowCursor { inline size_t get

[GitHub] [incubator-doris] imay commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
imay commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561#discussion_r308488353 ## File path: be/src/olap/row_cursor_cell.h ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
chaoyli commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561#discussion_r308290412 ## File path: be/src/olap/schema.h ## @@ -81,58 +99,51 @@ class Schema { reset(cols, num_key

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
chaoyli commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561#discussion_r308288000 ## File path: be/src/olap/schema.h ## @@ -143,24 +154,30 @@ class Schema { *reinterpret_cast

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
chaoyli commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561#discussion_r308289751 ## File path: be/src/olap/wrapper_field.h ## @@ -83,65 +78,58 @@ class WrapperField { } b

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
chaoyli commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561#discussion_r308297293 ## File path: be/src/olap/row_cursor.h ## @@ -160,28 +115,44 @@ class RowCursor { inline size_t

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
chaoyli commented on a change in pull request #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561#discussion_r308224221 ## File path: be/src/olap/row_cursor_cell.h ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] imay merged pull request #1560: Do not get file size in Broker openReader() method

2019-07-29 Thread GitBox
imay merged pull request #1560: Do not get file size in Broker openReader() method URL: https://github.com/apache/incubator-doris/pull/1560 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-doris] imay commented on issue #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
imay commented on issue #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561#issuecomment-515987932 > @imay Hi. Why introduce the new concept `ContiguousRow` and `RowCursorCell`? Are they necessary? I think we should keep core concepts as

[GitHub] [incubator-doris] kangkaisen commented on issue #1561: Unify Field and ColumnSchema in Storage

2019-07-29 Thread GitBox
kangkaisen commented on issue #1561: Unify Field and ColumnSchema in Storage URL: https://github.com/apache/incubator-doris/pull/1561#issuecomment-515982775 @imay Hi. Why introduce the new concept `ContiguousRow` and `RowCursorCell`? Are they necessary? I think we should keep core concepts

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1562: EnginePublishVersionTask: remove unreachable code

2019-07-29 Thread GitBox
yiguolei commented on a change in pull request #1562: EnginePublishVersionTask: remove unreachable code URL: https://github.com/apache/incubator-doris/pull/1562#discussion_r308185821 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -104,21 +104,11 @@ OL

[GitHub] [incubator-doris] gaodayue opened a new pull request #1562: EnginePublishVersionTask: remove unreachable code

2019-07-29 Thread GitBox
gaodayue opened a new pull request #1562: EnginePublishVersionTask: remove unreachable code URL: https://github.com/apache/incubator-doris/pull/1562 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
wuyunfeng opened a new pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527 This PR is related with [Spark-Doris-Connector](https://github.com/apache/incubator-doris/issues/1525). First step is exposing data pruned-fil

[GitHub] [incubator-doris] wuyunfeng closed pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
wuyunfeng closed pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308103965 ## File path: be/src/runtime/external_scan_context_mgr.h ## @@ -0,0 +1,83 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308102664 ## File path: be/src/runtime/result_queue_mgr.cpp ## @@ -0,0 +1,80 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308103439 ## File path: be/src/runtime/external_scan_context_mgr.cpp ## @@ -0,0 +1,115 @@ +// Licensed to the Apach

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308106775 ## File path: be/src/runtime/external_scan_context_mgr.h ## @@ -0,0 +1,83 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308118834 ## File path: be/src/runtime/fragment_mgr.cpp ## @@ -547,5 +551,109 @@ void FragmentMgr::debug(std::strin

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308102293 ## File path: be/src/runtime/fragment_mgr.cpp ## @@ -547,5 +551,109 @@ void FragmentMgr::debug(std::strin

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308102076 ## File path: be/src/runtime/fragment_mgr.cpp ## @@ -547,5 +551,109 @@ void FragmentMgr::debug(std::strin

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308102831 ## File path: be/src/runtime/result_queue_mgr.cpp ## @@ -0,0 +1,80 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308103896 ## File path: be/src/runtime/external_scan_context_mgr.h ## @@ -0,0 +1,83 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308118791 ## File path: be/src/runtime/fragment_mgr.cpp ## @@ -547,5 +551,109 @@ void FragmentMgr::debug(std::strin

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308102756 ## File path: be/src/runtime/result_queue_mgr.cpp ## @@ -0,0 +1,80 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308103696 ## File path: be/src/runtime/external_scan_context_mgr.h ## @@ -0,0 +1,83 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-29 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r308106652 ## File path: be/src/runtime/external_scan_context_mgr.h ## @@ -0,0 +1,83 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] morningman commented on a change in pull request #1560: Do not get file size in Broker openReader() method

2019-07-29 Thread GitBox
morningman commented on a change in pull request #1560: Do not get file size in Broker openReader() method URL: https://github.com/apache/incubator-doris/pull/1560#discussion_r308103420 ## File path: be/src/exec/broker_reader.cpp ## @@ -112,6 +113,9 @@ Status BrokerReader

[GitHub] [incubator-doris] imay commented on a change in pull request #1560: Do not get file size in Broker openReader() method

2019-07-29 Thread GitBox
imay commented on a change in pull request #1560: Do not get file size in Broker openReader() method URL: https://github.com/apache/incubator-doris/pull/1560#discussion_r308095991 ## File path: be/src/exec/broker_reader.cpp ## @@ -112,6 +113,9 @@ Status BrokerReader::open

[GitHub] [incubator-doris] imay merged pull request #1558: Modify load docs

2019-07-29 Thread GitBox
imay merged pull request #1558: Modify load docs URL: https://github.com/apache/incubator-doris/pull/1558 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th