[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1515: Add storage rowwise iterator

gaodayue commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305669471 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1515: Add storage rowwise iterator

gaodayue commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305679231 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1515: Add storage rowwise iterator

gaodayue commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305687268 ## File path: be/src/olap/row_block2.h ## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation (ASF

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1515: Add storage rowwise iterator

gaodayue commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305679199 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Founda

[GitHub] [incubator-doris] imay merged pull request #1515: Add storage rowwise iterator

imay merged pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650627 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650529 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650455 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650222 ## File path: be/src/olap/row_block2.h ## @@ -0,0 +1,110 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650191 ## File path: be/src/olap/row_block2.cpp ## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation (ASF) u

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305650025 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305649997 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305649917 ## File path: be/src/olap/generic_iterators.h ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305649853 ## File path: be/src/olap/iterators.h ## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-doris] imay commented on a change in pull request #1515: Add storage rowwise iterator

imay commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305649806 ## File path: be/src/olap/iterators.h ## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-doris] morningman closed issue #1440: non-sense segment is been generated

morningman closed issue #1440: non-sense segment is been generated URL: https://github.com/apache/incubator-doris/issues/1440 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] imay commented on a change in pull request #1522: Support setting replica status as bad manually

imay commented on a change in pull request #1522: Support setting replica status as bad manually URL: https://github.com/apache/incubator-doris/pull/1522#discussion_r305623714 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -6139,5 +6140,47 @@ pu

[GitHub] [incubator-doris] imay commented on a change in pull request #1522: Support setting replica status as bad manually

imay commented on a change in pull request #1522: Support setting replica status as bad manually URL: https://github.com/apache/incubator-doris/pull/1522#discussion_r305623295 ## File path: fe/src/main/java/org/apache/doris/analysis/AdminSetReplicaStatusStmt.java ## @@ -0

[GitHub] [incubator-doris] imay merged pull request #1523: Fix variable arguments bug in UDAF

imay merged pull request #1523: Fix variable arguments bug in UDAF URL: https://github.com/apache/incubator-doris/pull/1523 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1515: Add storage rowwise iterator

chaoyli commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305620137 ## File path: be/src/olap/row_block2.h ## @@ -0,0 +1,110 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1515: Add storage rowwise iterator

chaoyli commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305620450 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1515: Add storage rowwise iterator

chaoyli commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305621204 ## File path: be/src/olap/types.h ## @@ -33,54 +33,60 @@ #include "util/mem_util.hpp" #include "util/slice.h"

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1515: Add storage rowwise iterator

chaoyli commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305620914 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1515: Add storage rowwise iterator

chaoyli commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305620857 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305616064 ## File path: be/src/olap/iterators.h ## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305616331 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305617249 ## File path: be/src/olap/row_block2.cpp ## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305616145 ## File path: be/src/olap/generic_iterators.h ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software Foundat

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305616606 ## File path: be/src/olap/generic_iterators.cpp ## @@ -0,0 +1,346 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] morningman commented on a change in pull request #1515: Add storage rowwise iterator

morningman commented on a change in pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515#discussion_r305616092 ## File path: be/src/olap/iterators.h ## @@ -0,0 +1,53 @@ +// Licensed to the Apache Software Foundation (ASF

[GitHub] [incubator-doris] morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be

morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r305609913 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external

[GitHub] [incubator-doris] morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be

morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r305610008 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external

[GitHub] [incubator-doris] morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be

morningman commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r305610222 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r305608919 ## File path: be/src/exprs/binary_predicate.cpp ## @@ -468,12 +462,10 @@ DA

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r305608601 ## File path: be/src/exprs/binary_predicate.h ## @@ -41,8 +41,28 @@ class B