[GitHub] [incubator-doris] imay opened a new issue #1520: Refactor storage aggregate_func.h

2019-07-19 Thread GitBox
imay opened a new issue #1520: Refactor storage aggregate_func.h URL: https://github.com/apache/incubator-doris/issues/1520 I want to refactor be/src/olap/aggregate_func.h. Current implementation have some problems. Now, Storage maintain two function map, one for aggregate function,

[GitHub] [incubator-doris] zhuyuncheng opened a new issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng opened a new issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509 🌹🌹 This is an automated message f

[GitHub] [incubator-doris] zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513204112 Let me try. @imay ---

[GitHub] [incubator-doris] zhuyuncheng closed issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng closed issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509 This is an automated message from the

[GitHub] [incubator-doris] zhuyuncheng removed a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng removed a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513204022 > @zhuyuncheng > I think you are right. Currently, we don't supp

[GitHub] [incubator-doris] zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513204022 > @zhuyuncheng > I think you are right. Currently, we don't support offs

[GitHub] [incubator-doris] imay edited a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
imay edited a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513182530 @zhuyuncheng I think you are right. Currently, we don't support offset

[GitHub] [incubator-doris] imay commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
imay commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513182530 @zhuyuncheng I think you are right. Currently, we don't support offset in `SHO

[GitHub] [incubator-doris] imay commented on issue #1519: 创建表不支持timestamp类型吗?

2019-07-19 Thread GitBox
imay commented on issue #1519: 创建表不支持timestamp类型吗? URL: https://github.com/apache/incubator-doris/issues/1519#issuecomment-513179723 现在不支持timestamp,你可以使用datetime类型 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] zhaomingzhu opened a new issue #1519: 创建表不支持timestamp类型吗?

2019-07-19 Thread GitBox
zhaomingzhu opened a new issue #1519: 创建表不支持timestamp类型吗? URL: https://github.com/apache/incubator-doris/issues/1519 比如 `modified` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP 不支持? This is an automated message from the Apac

[GitHub] [incubator-doris] imay merged pull request #1514: Fix bug that WrapperField does not consider HLL column type when creating

2019-07-19 Thread GitBox
imay merged pull request #1514: Fix bug that WrapperField does not consider HLL column type when creating URL: https://github.com/apache/incubator-doris/pull/1514 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] imay merged pull request #1518: Add index.rst file for aggregation-function SQL reference docs

2019-07-19 Thread GitBox
imay merged pull request #1518: Add index.rst file for aggregation-function SQL reference docs URL: https://github.com/apache/incubator-doris/pull/1518 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] imay commented on a change in pull request #1517: Fix bug that replicas of a tablet may be located on same host

2019-07-19 Thread GitBox
imay commented on a change in pull request #1517: Fix bug that replicas of a tablet may be located on same host URL: https://github.com/apache/incubator-doris/pull/1517#discussion_r305276350 ## File path: fe/src/main/java/org/apache/doris/clone/TabletScheduler.java ## @@ -

[GitHub] [incubator-doris] morningman opened a new pull request #1518: Add index.rst file for aggregation-function SQL reference docs

2019-07-19 Thread GitBox
morningman opened a new pull request #1518: Add index.rst file for aggregation-function SQL reference docs URL: https://github.com/apache/incubator-doris/pull/1518 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] morningman opened a new pull request #1517: Fix bug that replicas of a tablet may be located on same host

2019-07-19 Thread GitBox
morningman opened a new pull request #1517: Fix bug that replicas of a tablet may be located on same host URL: https://github.com/apache/incubator-doris/pull/1517 Doris supports deploying multi BE on one host. So when allocating BE for replicas of a tablet, we should select different ho

[GitHub] [incubator-doris] imay commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-19 Thread GitBox
imay commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r305270111 ## File path: be/src/exprs/binary_predicate.cpp ## @@ -468,12 +462,10 @@ DATETIME_BIN

[GitHub] [incubator-doris] morningman commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-19 Thread GitBox
morningman commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r305267689 ## File path: be/src/exprs/binary_predicate.h ## @@ -41,8 +41,28 @@ class Binar

[GitHub] [incubator-doris] morningman commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-19 Thread GitBox
morningman commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r305267656 ## File path: be/src/exprs/binary_predicate.h ## @@ -41,8 +41,28 @@ class Binar

[GitHub] [incubator-doris] imay merged pull request #1513: Fix segment group add zone check bug and remove unused meta log

2019-07-19 Thread GitBox
imay merged pull request #1513: Fix segment group add zone check bug and remove unused meta log URL: https://github.com/apache/incubator-doris/pull/1513 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1516: Fix bug that <=> operator and in operator get wrong result

2019-07-19 Thread GitBox
chenhao7253886 opened a new pull request #1516: Fix bug that <=> operator and in operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1516 #1492 This is an automated message from the Apache Git Servic

[GitHub] [incubator-doris] imay opened a new pull request #1515: Add storage rowwise iterator

2019-07-19 Thread GitBox
imay opened a new pull request #1515: Add storage rowwise iterator URL: https://github.com/apache/incubator-doris/pull/1515 Use RowwiseIterator to uniform all data fetch in storage engine. All objects in storage engine can be read in iterator format. For example: Segment, Rowset.

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-19 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305237002 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-19 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305250606 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-19 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305246433 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-19 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305239672 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1409: Add dict page

2019-07-19 Thread GitBox
gaodayue commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r305227490 ## File path: be/src/olap/rowset/segment_v2/bitshuffle_page.h ## @@ -170,11 +148,11 @@ class BitshufflePageBuilder : public Pag

[GitHub] [incubator-doris] chenhao7253886 closed pull request #1491: Fix bug that <=> operator get wrong result

2019-07-19 Thread GitBox
chenhao7253886 closed pull request #1491: Fix bug that <=> operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1491 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] morningman opened a new pull request #1514: Fix bug that WrapperField does not consider HLL column type when creating

2019-07-19 Thread GitBox
morningman opened a new pull request #1514: Fix bug that WrapperField does not consider HLL column type when creating URL: https://github.com/apache/incubator-doris/pull/1514 This bug may cause BE crash when handling HLL column in some process. This bug is introduced by code merge. Versi

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1513: Fix segment group add zone check bug and remove unused meta log

2019-07-19 Thread GitBox
kangpinghuang opened a new pull request #1513: Fix segment group add zone check bug and remove unused meta log URL: https://github.com/apache/incubator-doris/pull/1513 This is an automated message from the Apache Git Service

[GitHub] [incubator-doris] zhuyuncheng edited a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng edited a comment on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513121662 https://github.com/apache/incubator-doris/blob/master/fe/src/main/j

[GitHub] [incubator-doris] zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported?

2019-07-19 Thread GitBox
zhuyuncheng commented on issue #1509: This code whether only limit operations are supported and offset operations are not supported? URL: https://github.com/apache/incubator-doris/issues/1509#issuecomment-513121662 https://github.com/apache/incubator-doris/blob/master/fe/src/main/java/org