[GitHub] [incubator-doris] imay commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
imay commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304755077 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,205 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] imay commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
imay commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304754732 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] [incubator-doris] imay commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
imay commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304753942 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304708173 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304710679 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304708671 ## File path: be/src/olap/segment_group.h ## @@ -124,7 +124,7 @@ class SegmentGroup { OLAPStatus find_prev_p

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304749799 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,205 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304716291 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache So

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304706814 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304711343 ## File path: be/src/olap/rowset/segment_v2/segment.h ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Found

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304713238 ## File path: be/src/olap/row_block2.h ## @@ -0,0 +1,77 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304714270 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.h ## @@ -0,0 +1,106 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304713931 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.h ## @@ -0,0 +1,106 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304714313 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.h ## @@ -0,0 +1,106 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304716734 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache So

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304713345 ## File path: be/src/olap/row_block2.h ## @@ -0,0 +1,77 @@ +// Licensed to the Apache Software Foundation (ASF) und

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304713960 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.h ## @@ -0,0 +1,106 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304711035 ## File path: be/src/olap/rowset/segment_v2/segment.cpp ## @@ -0,0 +1,198 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304716545 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache So

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304710453 ## File path: be/src/olap/rowset/segment_v2/segment.cpp ## @@ -0,0 +1,198 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304749410 ## File path: be/src/olap/rowset/segment_v2/segment_writer.cpp ## @@ -0,0 +1,205 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304722394 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -0,0 +1,234 @@ +// Licensed to the Apache So

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1474: Add segment iterator

2019-07-17 Thread GitBox
kangpinghuang commented on a change in pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474#discussion_r304710581 ## File path: be/src/olap/rowset/segment_v2/segment.cpp ## @@ -0,0 +1,198 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] imay commented on a change in pull request #1500: Add timediff function

2019-07-17 Thread GitBox
imay commented on a change in pull request #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500#discussion_r304731398 ## File path: be/src/udf/udf.h ## @@ -554,6 +554,34 @@ struct DoubleVal : public AnyVal { } }; +struct TimeVal : pu

[GitHub] [incubator-doris] imay commented on a change in pull request #1500: Add timediff function

2019-07-17 Thread GitBox
imay commented on a change in pull request #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500#discussion_r304731552 ## File path: fe/src/main/java/org/apache/doris/analysis/TimeLiteral.java ## @@ -0,0 +1,147 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay commented on a change in pull request #1500: Add timediff function

2019-07-17 Thread GitBox
imay commented on a change in pull request #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500#discussion_r304730873 ## File path: be/src/exec/olap_scanner.cpp ## @@ -414,7 +414,8 @@ void OlapScanner::_convert_row_to_tuple(Tuple* tuple) {

[GitHub] [incubator-doris] imay commented on a change in pull request #1500: Add timediff function

2019-07-17 Thread GitBox
imay commented on a change in pull request #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500#discussion_r304731516 ## File path: fe/src/main/java/org/apache/doris/analysis/TimeLiteral.java ## @@ -0,0 +1,147 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay merged pull request #1498: Refactor types.h to reduce code and add UT

2019-07-17 Thread GitBox
imay merged pull request #1498: Refactor types.h to reduce code and add UT URL: https://github.com/apache/incubator-doris/pull/1498 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] shgxwxl opened a new issue #1501: reabalance may cause one tablet's 3 replicas scheduled to one machine

2019-07-17 Thread GitBox
shgxwxl opened a new issue #1501: reabalance may cause one tablet's 3 replicas scheduled to one machine URL: https://github.com/apache/incubator-doris/issues/1501 **Describe the bug** 9 bes per machine one ip per machine reabalance may cause one tablet's 3 replicas sc

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1500: Add timediff function

2019-07-17 Thread GitBox
HangyuanLiu opened a new pull request #1500: Add timediff function URL: https://github.com/apache/incubator-doris/pull/1500 1. add a new udf type TimeVal 2.add new function timediff #1428 This is an automated messag

[GitHub] [incubator-doris] imay merged pull request #1496: Add log to trace writer validate failure

2019-07-17 Thread GitBox
imay merged pull request #1496: Add log to trace writer validate failure URL: https://github.com/apache/incubator-doris/pull/1496 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] imay closed pull request #1498: Refactor types.h to reduce code and add UT

2019-07-17 Thread GitBox
imay closed pull request #1498: Refactor types.h to reduce code and add UT URL: https://github.com/apache/incubator-doris/pull/1498 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] imay opened a new pull request #1498: Refactor types.h to reduce code and add UT

2019-07-17 Thread GitBox
imay opened a new pull request #1498: Refactor types.h to reduce code and add UT URL: https://github.com/apache/incubator-doris/pull/1498 #1494 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] Zerotoone opened a new issue #1499: Be break down and mostly can not be started

2019-07-17 Thread GitBox
Zerotoone opened a new issue #1499: Be break down and mostly can not be started URL: https://github.com/apache/incubator-doris/issues/1499 **Describe the bug** 1. Be break down and mostly can not be started 2. after repeatedly started, some be revover and back to alive 3. before

[GitHub] [incubator-doris] imay commented on a change in pull request #1497: Add ALTER_TABLET task in be

2019-07-17 Thread GitBox
imay commented on a change in pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#discussion_r304407797 ## File path: be/src/olap/schema_change.cpp ## @@ -1121,6 +1121,207 @@ bool SchemaChangeWithSorting::_external_sortin

[GitHub] [incubator-doris] imay commented on a change in pull request #1496: Add log to trace writer validate failure

2019-07-17 Thread GitBox
imay commented on a change in pull request #1496: Add log to trace writer validate failure URL: https://github.com/apache/incubator-doris/pull/1496#discussion_r304372185 ## File path: be/src/olap/rowset/alpha_rowset.h ## @@ -126,6 +126,10 @@ class AlphaRowset : public Rows

[GitHub] [incubator-doris] imay opened a new pull request #1498: Refactor types.h to reduce code and add UT

2019-07-17 Thread GitBox
imay opened a new pull request #1498: Refactor types.h to reduce code and add UT URL: https://github.com/apache/incubator-doris/pull/1498 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] yiguolei opened a new pull request #1497: Add ALTER_TABLET task in be

2019-07-17 Thread GitBox
yiguolei opened a new pull request #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] yiguolei commented on issue #1497: Add ALTER_TABLET task in be

2019-07-17 Thread GitBox
yiguolei commented on issue #1497: Add ALTER_TABLET task in be URL: https://github.com/apache/incubator-doris/pull/1497#issuecomment-512227454 #1429 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1496: Add log to trace writer validate failure

2019-07-17 Thread GitBox
kangpinghuang opened a new pull request #1496: Add log to trace writer validate failure URL: https://github.com/apache/incubator-doris/pull/1496 AlphaRowsetWriter validate rowset failed when build rowset because rowset's num_rows is not equal to segment groups' num_rows when add_rowse

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1495: Planner may push unsupported functions to mysql external table

2019-07-17 Thread GitBox
EmmyMiao87 commented on issue #1495: Planner may push unsupported functions to mysql external table URL: https://github.com/apache/incubator-doris/issues/1495#issuecomment-512176677 please assign to me This is an automated

[GitHub] [incubator-doris] chenhao7253886 opened a new issue #1495: Planner may push unsupported functions to mysql external table

2019-07-17 Thread GitBox
chenhao7253886 opened a new issue #1495: Planner may push unsupported functions to mysql external table URL: https://github.com/apache/incubator-doris/issues/1495 Planner may push unsupported functions to mysql external table, because some functions in doris can't supported by mysql, and

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1471: Planner support push down predicates past agg, win and sort

2019-07-17 Thread GitBox
chenhao7253886 opened a new pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471 #1438 This is an automated message from the Apache Git Servi

[GitHub] [incubator-doris] chenhao7253886 closed pull request #1471: Planner support push down predicates past agg, win and sort

2019-07-17 Thread GitBox
chenhao7253886 closed pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-doris] imay commented on issue #1491: Fix bug that <=> operator get wrong result

2019-07-17 Thread GitBox
imay commented on issue #1491: Fix bug that <=> operator get wrong result URL: https://github.com/apache/incubator-doris/pull/1491#issuecomment-512136194 I think your patch can make const's computation works well. But for non const computation, this predicate will return NULL too, which i

[GitHub] [incubator-doris] imay opened a new issue #1494: Refactor storage types

2019-07-17 Thread GitBox
imay opened a new issue #1494: Refactor storage types URL: https://github.com/apache/incubator-doris/issues/1494 Now we have repeated code in be/src/olap/types.h. Same code is written many times. So I want to refactor this file to reduce duplicate code --