[GitHub] [incubator-doris] imay merged pull request #1455: Bug-fix: Query ES table would fail when thrift_port not set

2019-07-10 Thread GitBox
imay merged pull request #1455: Bug-fix: Query ES table would fail when thrift_port not set URL: https://github.com/apache/incubator-doris/pull/1455 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1459: Add new CreateTabletReq and AlterTabletReqV2 thrift struct

2019-07-10 Thread GitBox
yiguolei commented on a change in pull request #1459: Add new CreateTabletReq and AlterTabletReqV2 thrift struct URL: https://github.com/apache/incubator-doris/pull/1459#discussion_r302349411 ## File path: gensrc/thrift/AgentService.thrift ## @@ -61,6 +63,18 @@ struct TAlt

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1459: Add new CreateTabletReq and AlterTabletReqV2 thrift struct

2019-07-10 Thread GitBox
yiguolei commented on a change in pull request #1459: Add new CreateTabletReq and AlterTabletReqV2 thrift struct URL: https://github.com/apache/incubator-doris/pull/1459#discussion_r302349176 ## File path: gensrc/thrift/AgentService.thrift ## @@ -48,6 +48,8 @@ struct TCrea

[GitHub] [incubator-doris] imay merged pull request #1456: Add utc_timestamp function

2019-07-10 Thread GitBox
imay merged pull request #1456: Add utc_timestamp function URL: https://github.com/apache/incubator-doris/pull/1456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] morningman opened a new pull request #1459: Add new CreateTabletReq and AlterTabletReqV2 thrift struct

2019-07-10 Thread GitBox
morningman opened a new pull request #1459: Add new CreateTabletReq and AlterTabletReqV2 thrift struct URL: https://github.com/apache/incubator-doris/pull/1459 This is for developing new alter table process. This is an automa

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1455: Bug-fix: Query ES table would fail when thrift_port not set

2019-07-10 Thread GitBox
wuyunfeng opened a new pull request #1455: Bug-fix: Query ES table would fail when thrift_port not set URL: https://github.com/apache/incubator-doris/pull/1455 When create ES external table without the thrift_port not configure, query ES external table using HTTP Transport Mode would f

[GitHub] [incubator-doris] wuyunfeng closed pull request #1455: Bug-fix: Query ES table would fail when thrift_port not set

2019-07-10 Thread GitBox
wuyunfeng closed pull request #1455: Bug-fix: Query ES table would fail when thrift_port not set URL: https://github.com/apache/incubator-doris/pull/1455 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] imay merged pull request #1458: Fix bug of wrong judgement for Hll type column's default value

2019-07-10 Thread GitBox
imay merged pull request #1458: Fix bug of wrong judgement for Hll type column's default value URL: https://github.com/apache/incubator-doris/pull/1458 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] imay merged pull request #1457: Validate the UTF-8 encode of loading data

2019-07-10 Thread GitBox
imay merged pull request #1457: Validate the UTF-8 encode of loading data URL: https://github.com/apache/incubator-doris/pull/1457 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] morningman commented on a change in pull request #1457: Validate the UTF-8 encode of loading data

2019-07-10 Thread GitBox
morningman commented on a change in pull request #1457: Validate the UTF-8 encode of loading data URL: https://github.com/apache/incubator-doris/pull/1457#discussion_r302328757 ## File path: be/src/exec/broker_scanner.cpp ## @@ -453,6 +454,16 @@ bool BrokerScanner::convert

[GitHub] [incubator-doris] morningman opened a new pull request #1458: Fix bug of wrong judgement for Hll type column's default value

2019-07-10 Thread GitBox
morningman opened a new pull request #1458: Fix bug of wrong judgement for Hll type column's default value URL: https://github.com/apache/incubator-doris/pull/1458 Fix the bug that user may receive '"Hll can not set default value' error when creating table with Hll type columns. ---

[GitHub] [incubator-doris] morningman commented on a change in pull request #1457: Validate the UTF-8 encode of loading data

2019-07-10 Thread GitBox
morningman commented on a change in pull request #1457: Validate the UTF-8 encode of loading data URL: https://github.com/apache/incubator-doris/pull/1457#discussion_r302328757 ## File path: be/src/exec/broker_scanner.cpp ## @@ -453,6 +454,16 @@ bool BrokerScanner::convert

[GitHub] [incubator-doris] imay merged pull request #1453: Fix bug that user can set null default value to non-nullable column in create table stmt

2019-07-10 Thread GitBox
imay merged pull request #1453: Fix bug that user can set null default value to non-nullable column in create table stmt URL: https://github.com/apache/incubator-doris/pull/1453 This is an automated message from the Apache G

[GitHub] [incubator-doris] imay commented on a change in pull request #1457: Validate the UTF-8 encode of loading data

2019-07-10 Thread GitBox
imay commented on a change in pull request #1457: Validate the UTF-8 encode of loading data URL: https://github.com/apache/incubator-doris/pull/1457#discussion_r302138372 ## File path: be/src/exec/broker_scanner.cpp ## @@ -453,6 +454,16 @@ bool BrokerScanner::convert_one_r

[GitHub] [incubator-doris] morningman opened a new pull request #1457: Validate the UTF-8 encode of loading data

2019-07-10 Thread GitBox
morningman opened a new pull request #1457: Validate the UTF-8 encode of loading data URL: https://github.com/apache/incubator-doris/pull/1457 Currently, Doris only support UTF-8 encoded data. All data will be shown to user in UTF-8 format. So if data loaded in Doris does not UTF-8 en

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-10 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r302101549 ## File path: be/src/exprs/aggregate_functions.cpp ## @@ -231,6 +232,81 @@ void AggregateFunctions::avg

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-10 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r302101016 ## File path: be/src/exprs/aggregate_functions.cpp ## @@ -231,6 +232,81 @@ void AggregateFunctions::avg

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-10 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r302100579 ## File path: be/src/exprs/aggregate_functions.cpp ## @@ -231,6 +232,81 @@ void AggregateFunctions::avg

[GitHub] [incubator-doris] imay commented on a change in pull request #1454: Fix parquet load bug

2019-07-10 Thread GitBox
imay commented on a change in pull request #1454: Fix parquet load bug URL: https://github.com/apache/incubator-doris/pull/1454#discussion_r302095968 ## File path: be/src/exec/parquet_reader.cpp ## @@ -47,38 +47,45 @@ ParquetReaderWrap::~ParquetReaderWrap() { } Status

[GitHub] [incubator-doris] imay commented on a change in pull request #1454: Fix parquet load bug

2019-07-10 Thread GitBox
imay commented on a change in pull request #1454: Fix parquet load bug URL: https://github.com/apache/incubator-doris/pull/1454#discussion_r302098415 ## File path: be/src/exec/parquet_scanner.cpp ## @@ -108,22 +98,26 @@ Status ParquetScanner::open_file_reader() {

[GitHub] [incubator-doris] imay commented on a change in pull request #1454: Fix parquet load bug

2019-07-10 Thread GitBox
imay commented on a change in pull request #1454: Fix parquet load bug URL: https://github.com/apache/incubator-doris/pull/1454#discussion_r302098511 ## File path: be/src/exec/parquet_scanner.cpp ## @@ -108,22 +98,26 @@ Status ParquetScanner::open_file_reader() {

[GitHub] [incubator-doris] imay commented on a change in pull request #1454: Fix parquet load bug

2019-07-10 Thread GitBox
imay commented on a change in pull request #1454: Fix parquet load bug URL: https://github.com/apache/incubator-doris/pull/1454#discussion_r302096762 ## File path: be/src/exec/parquet_reader.cpp ## @@ -47,38 +47,45 @@ ParquetReaderWrap::~ParquetReaderWrap() { } Status

[GitHub] [incubator-doris] imay commented on a change in pull request #1454: Fix parquet load bug

2019-07-10 Thread GitBox
imay commented on a change in pull request #1454: Fix parquet load bug URL: https://github.com/apache/incubator-doris/pull/1454#discussion_r302096240 ## File path: be/src/exec/parquet_reader.cpp ## @@ -47,38 +47,45 @@ ParquetReaderWrap::~ParquetReaderWrap() { } Status

[GitHub] [incubator-doris] imay commented on a change in pull request #1454: Fix parquet load bug

2019-07-10 Thread GitBox
imay commented on a change in pull request #1454: Fix parquet load bug URL: https://github.com/apache/incubator-doris/pull/1454#discussion_r302099099 ## File path: be/src/exec/parquet_scanner.cpp ## @@ -133,13 +127,21 @@ Status ParquetScanner::open_file_reader() {

[GitHub] [incubator-doris] imay commented on a change in pull request #1456: Add utc_timestamp function

2019-07-10 Thread GitBox
imay commented on a change in pull request #1456: Add utc_timestamp function URL: https://github.com/apache/incubator-doris/pull/1456#discussion_r302093156 ## File path: be/src/exprs/timestamp_functions.cpp ## @@ -243,6 +243,17 @@ DateTimeVal TimestampFunctions::curtime(Fun

[GitHub] [incubator-doris] imay commented on a change in pull request #1453: Fix bug that user can set null default value to non-nullable column in create table stmt

2019-07-10 Thread GitBox
imay commented on a change in pull request #1453: Fix bug that user can set null default value to non-nullable column in create table stmt URL: https://github.com/apache/incubator-doris/pull/1453#discussion_r302088419 ## File path: fe/src/main/java/org/apache/doris/analysis/ColumnDe

[GitHub] [incubator-doris] HangyuanLiu commented on issue #1428: 使用Power BI连接到doris时提示:MySQL: No matching function with signature:utc_timestamp().

2019-07-10 Thread GitBox
HangyuanLiu commented on issue #1428: 使用Power BI连接到doris时提示:MySQL: No matching function with signature:utc_timestamp(). URL: https://github.com/apache/incubator-doris/issues/1428#issuecomment-510062955 This new utc_timestamp function does not support timezone as usual, but I will modif

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1456: Add utc_timestamp function

2019-07-10 Thread GitBox
HangyuanLiu opened a new pull request #1456: Add utc_timestamp function URL: https://github.com/apache/incubator-doris/pull/1456 Add utc_timestamp function #1428 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] HangyuanLiu closed pull request #1456: Add utc_timestamp function

2019-07-10 Thread GitBox
HangyuanLiu closed pull request #1456: Add utc_timestamp function URL: https://github.com/apache/incubator-doris/pull/1456 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1456: Add utc_timestamp function

2019-07-10 Thread GitBox
HangyuanLiu opened a new pull request #1456: Add utc_timestamp function URL: https://github.com/apache/incubator-doris/pull/1456 Add utc_timestamp function #1428 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1455: Bug-fix: Query ES table would fail when thrift_port not set

2019-07-10 Thread GitBox
wuyunfeng opened a new pull request #1455: Bug-fix: Query ES table would fail when thrift_port not set URL: https://github.com/apache/incubator-doris/pull/1455 # Problem When create Elasticsearch external table without the thrift_port not configure, query the es table using HTTP Trans

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1454: Fix parquet load bug

2019-07-10 Thread GitBox
HangyuanLiu opened a new pull request #1454: Fix parquet load bug URL: https://github.com/apache/incubator-doris/pull/1454 1、fix the problem of importing non-parquet format file causing be crash 2、ignore the empty files under the folder (such as _SUCCESS generated by spark) 3、fix the