[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1447: Fix bug that BE crashs when insert null value to the not null column

2019-07-08 Thread GitBox
chenhao7253886 opened a new pull request #1447: Fix bug that BE crashs when insert null value to the not null column URL: https://github.com/apache/incubator-doris/pull/1447 …mn can't be null This is an automated message from

[GitHub] [incubator-doris] imay merged pull request #1418: Set stmt support Expr

2019-07-08 Thread GitBox
imay merged pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1418: Set stmt support Expr

2019-07-08 Thread GitBox
chenhao7253886 commented on a change in pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r301381068 ## File path: fe/src/main/java/org/apache/doris/analysis/CastExpr.java ## @@ -250,6 +250,7 @@ public boolean can

[GitHub] [incubator-doris] imay commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
imay commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301377754 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -236,6 +254,8 @@ protected void setJo

[GitHub] [incubator-doris] Xuxue1 closed pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
Xuxue1 closed pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-doris] Xuxue1 commented on issue #1445: Add string function split_part

2019-07-08 Thread GitBox
Xuxue1 commented on issue #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#issuecomment-509467533 感谢指出问题, 我仔细修改下再提交。 This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-doris] imay merged pull request #1442: Fix bug that unable to delete redundant replicas

2019-07-08 Thread GitBox
imay merged pull request #1442: Fix bug that unable to delete redundant replicas URL: https://github.com/apache/incubator-doris/pull/1442 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] imay merged pull request #1433: Add a configuration to modify the reverse time of load error log

2019-07-08 Thread GitBox
imay merged pull request #1433: Add a configuration to modify the reverse time of load error log URL: https://github.com/apache/incubator-doris/pull/1433 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] imay commented on a change in pull request #1418: Set stmt support Expr

2019-07-08 Thread GitBox
imay commented on a change in pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r301371735 ## File path: fe/src/main/java/org/apache/doris/analysis/CastExpr.java ## @@ -250,6 +250,7 @@ public boolean canHashPartiti

[GitHub] [incubator-doris] imay merged pull request #1444: Modify insert operation's behavior

2019-07-08 Thread GitBox
imay merged pull request #1444: Modify insert operation's behavior URL: https://github.com/apache/incubator-doris/pull/1444 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368361 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368553 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368087 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368106 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368155 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368501 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368188 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301368405 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::money_format(Fu

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-08 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r301364547 ## File path: be/test/exprs/percentile_approx_test.cpp ## @@ -0,0 +1,46 @@ +// Licensed to the Apache S

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-08 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r301364199 ## File path: be/src/util/tdigest.h ## @@ -0,0 +1,728 @@ +/* Review comment: you can add ASF head

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-08 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r301366914 ## File path: fe/src/main/java/org/apache/doris/catalog/FunctionSet.java ## @@ -957,6 +957,25 @@ privat

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-08 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r301364084 ## File path: be/src/exprs/aggregate_functions.cpp ## @@ -231,6 +232,81 @@ void AggregateFunctions::avg

[GitHub] [incubator-doris] imay commented on a change in pull request #1432: Add percentile_approx aggregate function

2019-07-08 Thread GitBox
imay commented on a change in pull request #1432: Add percentile_approx aggregate function URL: https://github.com/apache/incubator-doris/pull/1432#discussion_r301364484 ## File path: be/src/util/tdigest.h ## @@ -0,0 +1,728 @@ +/* + * Licensed to Derrick R. Burns under one

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
chenhao7253886 commented on a change in pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445#discussion_r301363914 ## File path: be/src/exprs/string_functions.cpp ## @@ -761,4 +761,61 @@ StringVal StringFunctions::mone

[GitHub] [incubator-doris] chaoyli merged pull request #1446: Remove unused imported package in FE

2019-07-08 Thread GitBox
chaoyli merged pull request #1446: Remove unused imported package in FE URL: https://github.com/apache/incubator-doris/pull/1446 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] chaoyli opened a new pull request #1446: Remove unused imported package in FE

2019-07-08 Thread GitBox
chaoyli opened a new pull request #1446: Remove unused imported package in FE URL: https://github.com/apache/incubator-doris/pull/1446 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] Xuxue1 opened a new pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
Xuxue1 opened a new pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445 Add string function split_part. Just like postgresql This is an automated message from the Apache

[GitHub] [incubator-doris] imay closed pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
imay closed pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-doris] Xuxue1 opened a new pull request #1445: Add string function split_part

2019-07-08 Thread GitBox
Xuxue1 opened a new pull request #1445: Add string function split_part URL: https://github.com/apache/incubator-doris/pull/1445 Add string function split_part. Just like postgresql This is an automated message from the Apache

[GitHub] [incubator-doris] morningman commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load

2019-07-08 Thread GitBox
morningman commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load URL: https://github.com/apache/incubator-doris/pull/1444#discussion_r301100307 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/InsertLoadJo

[GitHub] [incubator-doris] morningman commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load

2019-07-08 Thread GitBox
morningman commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load URL: https://github.com/apache/incubator-doris/pull/1444#discussion_r301100346 ## File path: fe/src/main/java/org/apache/doris/transaction/Transaction

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301061694 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -367,29 +382,54 @@ public void

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301061694 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -367,29 +382,54 @@ public void

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
EmmyMiao87 commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301058545 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -185,6 +185,21 @@ public long

[GitHub] [incubator-doris] morningman commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
morningman commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301055381 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -367,29 +382,54 @@ public void

[GitHub] [incubator-doris] morningman commented on a change in pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
morningman commented on a change in pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301055939 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -185,6 +185,21 @@ public long

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load

2019-07-08 Thread GitBox
EmmyMiao87 commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load URL: https://github.com/apache/incubator-doris/pull/1444#discussion_r301055605 ## File path: fe/src/main/java/org/apache/doris/transaction/Transaction

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load

2019-07-08 Thread GitBox
EmmyMiao87 commented on a change in pull request #1444: Modify insert operation's behavior when all partitions have no data to load URL: https://github.com/apache/incubator-doris/pull/1444#discussion_r301047445 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/InsertLoadJo

[GitHub] [incubator-doris] morningman opened a new pull request #1444: Modify insert operation's behavior when all partitions have no data to load

2019-07-08 Thread GitBox
morningman opened a new pull request #1444: Modify insert operation's behavior when all partitions have no data to load URL: https://github.com/apache/incubator-doris/pull/1444 Before changing default insert operation to streaming load, if the select result of a insert stmt is empty, a

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1443: Persist auth info in LoadJob

2019-07-08 Thread GitBox
EmmyMiao87 opened a new pull request #1443: Persist auth info in LoadJob URL: https://github.com/apache/incubator-doris/pull/1443 The new class named 'AuthorizationInfo' is used to save the auth info in jobs. The job doesn't need to retrieve the auth info by meta id which maybe throw th

[GitHub] [incubator-doris] bigtreeliujie commented on issue #676: New SQL Optimizer

2019-07-08 Thread GitBox
bigtreeliujie commented on issue #676: New SQL Optimizer URL: https://github.com/apache/incubator-doris/issues/676#issuecomment-509161767 This is a huge improvement for doris! This is an automated message from the Apache Git S

[GitHub] [incubator-doris] chaoyli merged pull request #1441: Fix bug of generating non-sense segment when close ColumnDataWriter

2019-07-08 Thread GitBox
chaoyli merged pull request #1441: Fix bug of generating non-sense segment when close ColumnDataWriter URL: https://github.com/apache/incubator-doris/pull/1441 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-doris] morningman opened a new pull request #1442: Fix bug that unable to delete redundant replicas

2019-07-08 Thread GitBox
morningman opened a new pull request #1442: Fix bug that unable to delete redundant replicas URL: https://github.com/apache/incubator-doris/pull/1442 This can happen if the Doris cluster is deployed with all, for example, SSD medium, but create all tables with HDD storage medium propert

[GitHub] [incubator-doris] chaoyli opened a new pull request #1441: Fix bug of generating non-sense segment when close ColumnDataWriter

2019-07-08 Thread GitBox
chaoyli opened a new pull request #1441: Fix bug of generating non-sense segment when close ColumnDataWriter URL: https://github.com/apache/incubator-doris/pull/1441 #1440 This is an automated message from the Apache Git Ser

[GitHub] [incubator-doris] chaoyli opened a new issue #1440: non-sense segment is been generated

2019-07-08 Thread GitBox
chaoyli opened a new issue #1440: non-sense segment is been generated URL: https://github.com/apache/incubator-doris/issues/1440 When doing schema change, error occurs when flushing segment. ![image](https://user-images.githubusercontent.com/44767902/60794369-35bc1700-a19c-11e9-9018-9d6d

[GitHub] [incubator-doris] chaoyli commented on issue #1440: non-sense segment is been generated

2019-07-08 Thread GitBox
chaoyli commented on issue #1440: non-sense segment is been generated URL: https://github.com/apache/incubator-doris/issues/1440#issuecomment-509127679 Segment which size reaches OLAP_MAX_COLUMN_SEGMENT_FILE_SIZE will be flushed into disk. If the previous segment reach the threshold ju