[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1417: Check if there exist a rowset contains the added rowset

kangpinghuang commented on a change in pull request #1417: Check if there exist a rowset contains the added rowset URL: https://github.com/apache/incubator-doris/pull/1417#discussion_r299792880 ## File path: be/src/olap/rowset/segment_group.cpp ## @@ -766,29 +775,35 @@ OLA

[GitHub] [incubator-doris] zhaomingzhu closed issue #1399: llvm 无法编译

zhaomingzhu closed issue #1399: llvm 无法编译 URL: https://github.com/apache/incubator-doris/issues/1399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] zhaomingzhu commented on issue #1399: llvm 无法编译

zhaomingzhu commented on issue #1399: llvm 无法编译 URL: https://github.com/apache/incubator-doris/issues/1399#issuecomment-507909117 重新安装环境编译成功。 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-doris] imay commented on a change in pull request #1422: Cast the type of constant value in binary predicate to column type.

imay commented on a change in pull request #1422: Cast the type of constant value in binary predicate to column type. URL: https://github.com/apache/incubator-doris/pull/1422#discussion_r299746936 ## File path: fe/src/main/java/org/apache/doris/analysis/BinaryPredicate.java ###

[GitHub] [incubator-doris] imay closed issue #1336: 建议添加dayofweek函数

imay closed issue #1336: 建议添加dayofweek函数 URL: https://github.com/apache/incubator-doris/issues/1336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] morningman opened a new pull request #1422: Cast the type of constant value in binary predicate to column type.

morningman opened a new pull request #1422: Cast the type of constant value in binary predicate to column type. URL: https://github.com/apache/incubator-doris/pull/1422 If one child of a binary predicate is column, and the other is a constant expr, set the compatible type to column's ty

[GitHub] [incubator-doris] imay merged pull request #1421: Forbid adding rollup with REPLACE value but without all key columns.

imay merged pull request #1421: Forbid adding rollup with REPLACE value but without all key columns. URL: https://github.com/apache/incubator-doris/pull/1421 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-doris] morningman commented on a change in pull request #1418: Set stmt support Expr

morningman commented on a change in pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299743123 ## File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java ## @@ -162,13 +160,52 @@ public FEF

[GitHub] [incubator-doris] imay commented on a change in pull request #1418: Set stmt support Expr

imay commented on a change in pull request #1418: Set stmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299742745 ## File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java ## @@ -162,13 +160,52 @@ public FEFunctio

[GitHub] [incubator-doris] morningman opened a new pull request #1421: Forbid adding rollup with REPLACE value but without all key columns.

morningman opened a new pull request #1421: Forbid adding rollup with REPLACE value but without all key columns. URL: https://github.com/apache/incubator-doris/pull/1421 When a rollup table contains value columns of REPLACE aggregation type, all key columns of base table should be includ

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1418: SetSmt support Expr

chenhao7253886 commented on a change in pull request #1418: SetSmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299438737 ## File path: fe/src/main/java/org/apache/doris/rewrite/FEFunctions.java ## @@ -666,4 +667,14 @@ public static Deci

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1418: SetSmt support Expr

chenhao7253886 commented on a change in pull request #1418: SetSmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299438676 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -2542,7 +2542,7 @@ option_value_follow_option_type ::= option

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299432549 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.h ## @@ -0,0 +1,116 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299435951 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.h ## @@ -0,0 +1,116 @@ +// Licensed to the Apache Software Fo

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299431920 ## File path: be/src/olap/short_key_index.h ## @@ -120,6 +120,11 @@ class ShortKeyIndexI

[GitHub] [incubator-doris] chenhao7253886 opened a new issue #1420: Pruning partitions with string value fails

chenhao7253886 opened a new issue #1420: Pruning partitions with string value fails URL: https://github.com/apache/incubator-doris/issues/1420 Now if the value in predicate about partition column is string, but the partition column is date, we can't prune parititon successfully. I will imp

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299375828 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299373207 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299372447 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299372523 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299372720 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299372378 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r299372288 ## File path: be/src/olap/rowset/segment_v2/binary_dict_page.cpp ## @@ -0,0 +1,213 @@ +// Licensed to the Apache Software

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371962 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,197 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371502 ## File path: be/src/olap/olap_index.cpp ## @@ -102,20 +127,17 @@ OLAPStatus MemIndex::load_segme

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371157 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() { for

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371219 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() { for

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371455 ## File path: be/src/olap/column_data.cpp ## @@ -302,10 +302,9 @@ OLAPStatus ColumnData::_seek_to

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371129 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() { for

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371008 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,197 @@ +// Licensed to the Apache Softw

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299371062 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() { for

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299370940 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299370692 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299370573 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the Apache Sof

[GitHub] [incubator-doris] imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator

imay commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299369366 ## File path: be/src/olap/olap_index.h ## @@ -87,13 +83,11 @@ struct OLAPIndexOffset { // 唯一标识

[GitHub] [incubator-doris] imay merged pull request #1419: Fix the deadlock of database and loadjob

imay merged pull request #1419: Fix the deadlock of database and loadjob URL: https://github.com/apache/incubator-doris/pull/1419 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299354278 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the A

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299355120 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the A

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299325862 ## File path: be/src/olap/column_data.cpp ## @@ -302,10 +302,9 @@ OLAPStatus ColumnData:

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299351406 ## File path: be/src/olap/olap_index.h ## @@ -87,13 +83,11 @@ struct OLAPIndexOffset {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299356049 ## File path: be/src/olap/short_key_index.cpp ## @@ -0,0 +1,153 @@ +// Licensed to the A

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299331696 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,197 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299347038 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299348135 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299346873 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299357760 ## File path: be/src/olap/short_key_index.h ## @@ -0,0 +1,197 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299327345 ## File path: be/src/olap/olap_index.cpp ## @@ -102,20 +127,17 @@ OLAPStatus MemIndex::l

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator

kangpinghuang commented on a change in pull request #1413: Add short key index builder, decoder, iterator URL: https://github.com/apache/incubator-doris/pull/1413#discussion_r299348582 ## File path: be/src/olap/olap_index.cpp ## @@ -50,41 +53,63 @@ MemIndex::~MemIndex() {

[GitHub] [incubator-doris] imay commented on a change in pull request #1418: SetSmt support Expr

imay commented on a change in pull request #1418: SetSmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299341375 ## File path: fe/src/main/java/org/apache/doris/rewrite/FEFunctions.java ## @@ -666,4 +667,14 @@ public static DecimalLiteral

[GitHub] [incubator-doris] imay commented on a change in pull request #1418: SetSmt support Expr

imay commented on a change in pull request #1418: SetSmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418#discussion_r299340887 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -2542,7 +2542,7 @@ option_value_follow_option_type ::= option_value_no_

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1417: Check if there exist a rowset contains the added rowset

yiguolei commented on a change in pull request #1417: Check if there exist a rowset contains the added rowset URL: https://github.com/apache/incubator-doris/pull/1417#discussion_r299345872 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -104,7 +104,7 @

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1419: Fix the deadlock of database and loadjob

EmmyMiao87 opened a new pull request #1419: Fix the deadlock of database and loadjob URL: https://github.com/apache/incubator-doris/pull/1419 This commit change the idToTable to concurrent hashmap in database. It don't need to lock the database before getTable. The database will be lock

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1418: SetSmt support Expr

chenhao7253886 opened a new pull request #1418: SetSmt support Expr URL: https://github.com/apache/incubator-doris/pull/1418 This is an automated message from the Apache Git Service. To respond to the message, please log on t