[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner

2019-06-26 Thread GitBox
kangpinghuang commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298018184 ## File path: be/src/olap/reader.cpp ## @@ -452,7 +452,8 @@ OLAPStatus Reader::_

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner

2019-06-26 Thread GitBox
yiguolei commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298016738 ## File path: be/src/exec/olap_scanner.cpp ## @@ -474,6 +488,13 @@ Status OlapScanner

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner

2019-06-26 Thread GitBox
yiguolei commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298016514 ## File path: be/src/olap/reader.cpp ## @@ -452,7 +452,8 @@ OLAPStatus Reader::_captu

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner

2019-06-26 Thread GitBox
yiguolei commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298016412 ## File path: fe/src/main/java/org/apache/doris/common/Config.java ## @@ -483,9 +483,

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner

2019-06-26 Thread GitBox
yiguolei commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298016335 ## File path: be/src/exec/olap_scanner.cpp ## @@ -150,6 +150,20 @@ Status OlapScanner

[GitHub] [incubator-doris] imay commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner

2019-06-26 Thread GitBox
imay commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298015789 ## File path: be/src/exec/olap_scanner.cpp ## @@ -150,6 +150,20 @@ Status OlapScanner::_i

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner

2019-06-26 Thread GitBox
kangpinghuang commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298002733 ## File path: fe/src/main/java/org/apache/doris/common/Config.java ## @@ -483,9

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner

2019-06-26 Thread GitBox
kangpinghuang commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298000905 ## File path: be/src/olap/reader.cpp ## @@ -452,7 +452,8 @@ OLAPStatus Reader::_

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner

2019-06-26 Thread GitBox
kangpinghuang commented on a change in pull request #1400: Acquire rs readers at the beginning of the olapscanner URL: https://github.com/apache/incubator-doris/pull/1400#discussion_r298000144 ## File path: be/src/exec/olap_scanner.cpp ## @@ -474,6 +488,13 @@ Status OlapSc

[GitHub] [incubator-doris] yiguolei opened a new pull request #1400: Acquire rs readers at the beginning of the olapscanner

2019-06-26 Thread GitBox
yiguolei opened a new pull request #1400: Acquire rs readers at the beginning of the olapscanner URL: https://github.com/apache/incubator-doris/pull/1400 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-doris] imay merged pull request #1398: Fix a bug of v2 ColumnReader when reading not-null column

2019-06-26 Thread GitBox
imay merged pull request #1398: Fix a bug of v2 ColumnReader when reading not-null column URL: https://github.com/apache/incubator-doris/pull/1398 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-doris] imay commented on issue #1399: llvm 无法编译

2019-06-26 Thread GitBox
imay commented on issue #1399: llvm 无法编译 URL: https://github.com/apache/incubator-doris/issues/1399#issuecomment-505913192 0.9.0是老版本了,建议使用0.10版本。 还有就是建议使用我们的Docker环境进行编译 This is an automated message from the Apache Git

[GitHub] [incubator-doris] zhaomingzhu opened a new issue #1399: llvm 无法编译

2019-06-26 Thread GitBox
zhaomingzhu opened a new issue #1399: llvm 无法编译 URL: https://github.com/apache/incubator-doris/issues/1399 环境: 1)OS centos7.2 2)gcc --version gcc (GCC) 5.4.0 3)cmake --version cmake version 3.4.3 3)rpm -qa|grep libstdc **libstdc++-devel-4.8.5-36.el7.x86_64 libstdc++-4

[GitHub] [incubator-doris] gaodayue opened a new pull request #1398: Fix a bug of v2 ColumnReader when reading not-null column

2019-06-26 Thread GitBox
gaodayue opened a new pull request #1398: Fix a bug of v2 ColumnReader when reading not-null column URL: https://github.com/apache/incubator-doris/pull/1398 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1379: Add rle page

2019-06-26 Thread GitBox
gaodayue commented on a change in pull request #1379: Add rle page URL: https://github.com/apache/incubator-doris/pull/1379#discussion_r297633133 ## File path: be/src/olap/rowset/segment_v2/rle_page.h ## @@ -0,0 +1,255 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1379: Add rle page

2019-06-26 Thread GitBox
gaodayue commented on a change in pull request #1379: Add rle page URL: https://github.com/apache/incubator-doris/pull/1379#discussion_r297644227 ## File path: be/src/olap/types.cpp ## @@ -62,6 +62,7 @@ TypeInfoResolver::TypeInfoResolver() { add_mapping(); add_map

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1397: fix garbage collect bug

2019-06-26 Thread GitBox
kangpinghuang opened a new pull request #1397: fix garbage collect bug URL: https://github.com/apache/incubator-doris/pull/1397 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1379: Add rle page

2019-06-26 Thread GitBox
gaodayue commented on a change in pull request #1379: Add rle page URL: https://github.com/apache/incubator-doris/pull/1379#discussion_r297619170 ## File path: be/src/olap/rowset/segment_v2/rle_page.h ## @@ -0,0 +1,255 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1379: Add rle page

2019-06-26 Thread GitBox
gaodayue commented on a change in pull request #1379: Add rle page URL: https://github.com/apache/incubator-doris/pull/1379#discussion_r297617809 ## File path: be/src/olap/rowset/segment_v2/rle_page.h ## @@ -0,0 +1,255 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] kangkaisen closed pull request #1394: Fix schema change clear alter task could not finish bug

2019-06-26 Thread GitBox
kangkaisen closed pull request #1394: Fix schema change clear alter task could not finish bug URL: https://github.com/apache/incubator-doris/pull/1394 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] imay merged pull request #1383: Modify some method for external invoking and add extra sink

2019-06-26 Thread GitBox
imay merged pull request #1383: Modify some method for external invoking and add extra sink URL: https://github.com/apache/incubator-doris/pull/1383 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] imay merged pull request #1396: Add a website builder of Doris documentations

2019-06-26 Thread GitBox
imay merged pull request #1396: Add a website builder of Doris documentations URL: https://github.com/apache/incubator-doris/pull/1396 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] morningman merged pull request #1381: Fix column nullable property in show create table stmt result

2019-06-26 Thread GitBox
morningman merged pull request #1381: Fix column nullable property in show create table stmt result URL: https://github.com/apache/incubator-doris/pull/1381 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-doris] morningman opened a new pull request #1396: Add a website builder of Doris documentations

2019-06-26 Thread GitBox
morningman opened a new pull request #1396: Add a website builder of Doris documentations URL: https://github.com/apache/incubator-doris/pull/1396 The build script locates in docs/website. Built with Sphinx using a theme provided by Read the Docs. ---

[GitHub] [incubator-doris] imay opened a new issue #1395: Make new format work with old format

2019-06-26 Thread GitBox
imay opened a new issue #1395: Make new format work with old format URL: https://github.com/apache/incubator-doris/issues/1395 This work will make all new format work compatible with old code. Then we can create table which will use new format. Output of compaction will be generated in new

[GitHub] [incubator-doris] kangkaisen opened a new pull request #1394: Fix schema change clear alter task could not finish bug

2019-06-26 Thread GitBox
kangkaisen opened a new pull request #1394: Fix schema change clear alter task could not finish bug URL: https://github.com/apache/incubator-doris/pull/1394 For https://github.com/apache/incubator-doris/issues/1393 This is an

[GitHub] [incubator-doris] kangkaisen opened a new issue #1393: Schema change job could not finished

2019-06-26 Thread GitBox
kangkaisen opened a new issue #1393: Schema change job could not finished URL: https://github.com/apache/incubator-doris/issues/1393 **Describe the bug** Just now, our user found a schema change job run a long time: ![image](https://user-images.githubusercontent.com/9894906/60170981-3

[GitHub] [incubator-doris] imay opened a new issue #1392: Support column page compress

2019-06-26 Thread GitBox
imay opened a new issue #1392: Support column page compress URL: https://github.com/apache/incubator-doris/issues/1392 we should support page compress. for example plain binary encode page, we can use compress to make it smaller in size. #1305 --

[GitHub] [incubator-doris] imay opened a new issue #1391: Add column page cache

2019-06-26 Thread GitBox
imay opened a new issue #1391: Add column page cache URL: https://github.com/apache/incubator-doris/issues/1391 We should add column page cache which can help use reduce our CPU/IO use when read same column data. #1305 ---

[GitHub] [incubator-doris] imay opened a new issue #1390: Support zone map for column

2019-06-26 Thread GitBox
imay opened a new issue #1390: Support zone map for column URL: https://github.com/apache/incubator-doris/issues/1390 we should support zone map for column include min/max value for column page. When scan data, we can use this information to eliminate data loading. We should add a Zo

[GitHub] [incubator-doris] imay opened a new issue #1389: Support bloom filter in new format segment

2019-06-26 Thread GitBox
imay opened a new issue #1389: Support bloom filter in new format segment URL: https://github.com/apache/incubator-doris/issues/1389 We should support bloom filter in new format segment, so we can convert old data into new format without impact query's performance. This will add Bloo

[GitHub] [incubator-doris] imay opened a new issue #1388: Add new ShortKeyIndexBuilder

2019-06-26 Thread GitBox
imay opened a new issue #1388: Add new ShortKeyIndexBuilder URL: https://github.com/apache/incubator-doris/issues/1388 In current code, short key index is written to file directly. In new format version, index will written into segment file. So we need a ShortKeyIndexBuilder which will enc

[GitHub] [incubator-doris] imay opened a new issue #1387: Add new SegmentGroupWriter

2019-06-26 Thread GitBox
imay opened a new issue #1387: Add new SegmentGroupWriter URL: https://github.com/apache/incubator-doris/issues/1387 This class is same as CoumnDataWriter. we create one in order to not modify origin code. This class will write data into ordered segments in new format. This class wil

[GitHub] [incubator-doris] imay opened a new issue #1386: Add new SegmentGroupIterator

2019-06-26 Thread GitBox
imay opened a new issue #1386: Add new SegmentGroupIterator URL: https://github.com/apache/incubator-doris/issues/1386 Now we have SegmentGroup who have some segments, and these segment is ordered. And we have another class named Rowset who is container of SegmentGroup. But I think we can

[GitHub] [incubator-doris] imay opened a new issue #1385: Add SegmentWriter for new format segment

2019-06-26 Thread GitBox
imay opened a new issue #1385: Add SegmentWriter for new format segment URL: https://github.com/apache/incubator-doris/issues/1385 We should create a new SegmentWriter to write data in new format. This will arrange all kinds of data into one file. These include 1. Column data. 2

[GitHub] [incubator-doris] imay opened a new issue #1384: Add new SegmentIterator

2019-06-26 Thread GitBox
imay opened a new issue #1384: Add new SegmentIterator URL: https://github.com/apache/incubator-doris/issues/1384 according to #1382 , we should implement a new `SegmetIterator` for new format segment. This class will leverage statistics information and bloom filter to reduce data load.

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1383: Modify some method for external invoking and add extra sink

2019-06-26 Thread GitBox
wuyunfeng opened a new pull request #1383: Modify some method for external invoking and add extra sink URL: https://github.com/apache/incubator-doris/pull/1383 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-doris] imay opened a new issue #1382: Add StorageRowIterator to uniform read in storage

2019-06-26 Thread GitBox
imay opened a new issue #1382: Add StorageRowIterator to uniform read in storage URL: https://github.com/apache/incubator-doris/issues/1382 Currently in storage engine, there is too many interface to read data. Including followings 1. SegmentReader which is used to read data from Se

[GitHub] [incubator-doris] morningman opened a new pull request #1381: Fix column nullable property in show create table stmt result

2019-06-26 Thread GitBox
morningman opened a new pull request #1381: Fix column nullable property in show create table stmt result URL: https://github.com/apache/incubator-doris/pull/1381 Since the default nullable of a column changed to NOT NULL, result of show table stmt should show the correct nullable proper