[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297017409 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { L

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297019428 ## File path: be/src/olap/tablet.h ## @@ -248,6 +252,7 @@ class Tablet : public std::enable_shared_from

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297017712 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { L

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297020315 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { L

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297019316 ## File path: be/src/olap/tablet.cpp ## @@ -839,6 +839,12 @@ bool Tablet::check_path(const std::string&

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297014765 ## File path: be/src/olap/tablet.cpp ## @@ -839,6 +839,12 @@ bool Tablet::check_path(const std::string& path

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297016665 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { LOG(IN

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297012871 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { LOG(IN

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297016006 ## File path: be/src/olap/data_dir.cpp ## @@ -932,6 +932,52 @@ void DataDir::perform_path_gc() { LOG(IN

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297014671 ## File path: be/src/olap/tablet.h ## @@ -248,6 +252,7 @@ class Tablet : public std::enable_shared_from_this

[GitHub] [incubator-doris] yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
yiguolei commented on a change in pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374#discussion_r297012349 ## File path: be/src/olap/storage_engine.cpp ## @@ -944,6 +944,20 @@ OLAPStatus StorageEngine::execute_task(

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1374: add garbase collect by rowsetid

2019-06-24 Thread GitBox
kangpinghuang opened a new pull request #1374: add garbase collect by rowsetid URL: https://github.com/apache/incubator-doris/pull/1374 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1373: Add tablet version and descriptor table for query paln

2019-06-24 Thread GitBox
wuyunfeng opened a new pull request #1373: Add tablet version and descriptor table for query paln URL: https://github.com/apache/incubator-doris/pull/1373 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] morningman closed pull request #1373: Add tablet version and descriptor table for query paln

2019-06-24 Thread GitBox
morningman closed pull request #1373: Add tablet version and descriptor table for query paln URL: https://github.com/apache/incubator-doris/pull/1373 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1373: Add tablet version and descriptor table for query paln

2019-06-24 Thread GitBox
wuyunfeng opened a new pull request #1373: Add tablet version and descriptor table for query paln URL: https://github.com/apache/incubator-doris/pull/1373 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] imay closed pull request #1372: Unref MiniLoadCtx before destruction

2019-06-24 Thread GitBox
imay closed pull request #1372: Unref MiniLoadCtx before destruction URL: https://github.com/apache/incubator-doris/pull/1372 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] chaoyli opened a new pull request #1372: Unref MiniLoadCtx before destruction

2019-06-24 Thread GitBox
chaoyli opened a new pull request #1372: Unref MiniLoadCtx before destruction URL: https://github.com/apache/incubator-doris/pull/1372 This is an automated message from the Apache Git Service. To respond to the message, pleas

[RESULT][VOTE] Release Apache Doris 0.10.0-incubating-rc04

2019-06-24 Thread 陈明雨
Hi All: I create a new mail thread to show the vote result of Apache Doris 0.10.0-incubating-rc04. Thanks to everyone, and this vote is now closed. It has passed with 3 (binding) votes and no 0 or -1 votes. Binding: +1 Zhao Chun +1 Li De +1 Li Chaoyong -- 此致!Best Regards 陈明雨 Mingyu Chen E

[RESULT][VOTE] Release Apache Doris 0.10.0-incubating-rc04

2019-06-24 Thread 陈明雨
Thanks to everyone, and this vote is now closed. It has passed with 3 (binding) votes and no 0 or -1 votes. Binding: +1 Zhao Chun +1 Li De +1 Li Chaoyong -- 此致!Best Regards 陈明雨 Mingyu Chen Email: chenmin...@apache.org 在 2019-06-24 19:14:57,"Li,Chaoyong" 写道: >+1 >I have checked: > >1. Dow

[GitHub] [incubator-doris] kangkaisen commented on issue #1289: Modify colocation creation logic

2019-06-24 Thread GitBox
kangkaisen commented on issue #1289: Modify colocation creation logic URL: https://github.com/apache/incubator-doris/pull/1289#issuecomment-504984238 @morningman OK, I see. Thank you. This is an automated message from the Apac

[GitHub] [incubator-doris] EmmyMiao87 edited a comment on issue #1095: Unifies load flow

2019-06-24 Thread GitBox
EmmyMiao87 edited a comment on issue #1095: Unifies load flow URL: https://github.com/apache/incubator-doris/issues/1095#issuecomment-504322449 I propose to test the performance of streaming broker load and mini load. This test will ignore the effect of rollup and query. The result of test

[GitHub] [incubator-doris] morningman commented on issue #1289: Modify colocation creation logic

2019-06-24 Thread GitBox
morningman commented on issue #1289: Modify colocation creation logic URL: https://github.com/apache/incubator-doris/pull/1289#issuecomment-504977393 > After I tested in my test env, I found two minor issue: > > 1 This PR don't support cascade colocate join. > > for example:

[GitHub] [incubator-doris] imay merged pull request #1370: Add sql-function doc of cast_to_bigint

2019-06-24 Thread GitBox
imay merged pull request #1370: Add sql-function doc of cast_to_bigint URL: https://github.com/apache/incubator-doris/pull/1370 This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [VOTE] Release Apache Doris 0.10.0-incubating-rc04

2019-06-24 Thread Li,Chaoyong
+1 I have checked: 1. Download links are all valid. 2. Checksums and PGP signatures are OK. 3. LICENSE and NOTICE files are all corrected. 4. All source files have license headers. 5. Build from scratch are OK in Docker. Best Regards, Li Chaoyong 在 2019/6/24 下午12:45,“Li,De 代表 德 李” 写入:

[GitHub] [incubator-doris] chaoyli merged pull request #1371: Fix dead lock bug in storage migration

2019-06-24 Thread GitBox
chaoyli merged pull request #1371: Fix dead lock bug in storage migration URL: https://github.com/apache/incubator-doris/pull/1371 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] chaoyli merged pull request #1368: Fix olap_header destruction error

2019-06-24 Thread GitBox
chaoyli merged pull request #1368: Fix olap_header destruction error URL: https://github.com/apache/incubator-doris/pull/1368 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] yiguolei opened a new pull request #1371: Fix dead lock bug in storage migration

2019-06-24 Thread GitBox
yiguolei opened a new pull request #1371: Fix dead lock bug in storage migration URL: https://github.com/apache/incubator-doris/pull/1371 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] kangkaisen closed issue #1365: Stream Load error msg no column name

2019-06-24 Thread GitBox
kangkaisen closed issue #1365: Stream Load error msg no column name URL: https://github.com/apache/incubator-doris/issues/1365 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1370: Add sql-function doc of cast_to_bigint

2019-06-24 Thread GitBox
chenhao7253886 commented on a change in pull request #1370: Add sql-function doc of cast_to_bigint URL: https://github.com/apache/incubator-doris/pull/1370#discussion_r296632521 ## File path: docs/documentation/cn/sql-reference/sql-functions/cast-function/cast_to_bigint.md ###

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1370: Add sql-function doc of cast_to_bigint

2019-06-24 Thread GitBox
EmmyMiao87 opened a new pull request #1370: Add sql-function doc of cast_to_bigint URL: https://github.com/apache/incubator-doris/pull/1370 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] chenhao7253886 opened a new issue #1369: Casting float string to int will return null

2019-06-24 Thread GitBox
chenhao7253886 opened a new issue #1369: Casting float string to int will return null URL: https://github.com/apache/incubator-doris/issues/1369 Because StringParser does't support cast float string to int, as following: mysql> select cast("11.22" as int); +--+

[GitHub] [incubator-doris] chaoyli opened a new pull request #1368: Fix olap_header destruction error

2019-06-24 Thread GitBox
chaoyli opened a new pull request #1368: Fix olap_header destruction error URL: https://github.com/apache/incubator-doris/pull/1368 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] imay commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-24 Thread GitBox
imay commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296592059 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -0,0 +1,330 @@ +// Licensed to the A

[GitHub] [incubator-doris] imay commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-24 Thread GitBox
imay commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296589585 ## File path: be/src/olap/rowset/segment_v2/encoding_info.cpp ## @@ -33,14 +34,33 @@ struct TypeEncoding

[GitHub] [incubator-doris] imay commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-24 Thread GitBox
imay commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296584410 ## File path: be/src/olap/rowset/segment_v2/encoding_info.h ## @@ -40,23 +42,28 @@ class EncodingInfo {

[GitHub] [incubator-doris] wuyunfeng closed pull request #1367: Add privilege method for Frontend service

2019-06-24 Thread GitBox
wuyunfeng closed pull request #1367: Add privilege method for Frontend service URL: https://github.com/apache/incubator-doris/pull/1367 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1367: Add privilege method for Frontend service

2019-06-24 Thread GitBox
wuyunfeng opened a new pull request #1367: Add privilege method for Frontend service URL: https://github.com/apache/incubator-doris/pull/1367 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2

2019-06-24 Thread GitBox
kangpinghuang commented on a change in pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346#discussion_r296576675 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -0,0 +1,330 @@ +// Licensed