[GitHub] [incubator-doris] kangkaisen commented on issue #1293: Change default value to NOT NULL when creating table

2019-06-22 Thread GitBox
kangkaisen commented on issue #1293: Change default value to NOT NULL when creating table URL: https://github.com/apache/incubator-doris/pull/1293#issuecomment-504723997 Hi. Please at least add a config for this change, otherwise, there will be a serious case that a lot of load job will fa

[GitHub] [incubator-doris] kangkaisen commented on issue #1289: Modify colocation creation logic

2019-06-22 Thread GitBox
kangkaisen commented on issue #1289: Modify colocation creation logic URL: https://github.com/apache/incubator-doris/pull/1289#issuecomment-504723709 After I tested in my test env, I found two minor issue: 1 This PR don't support cascade colocate join. for example: ```

[GitHub] [incubator-doris] imay commented on a change in pull request #1361: Check get_header status returned

2019-06-22 Thread GitBox
imay commented on a change in pull request #1361: Check get_header status returned URL: https://github.com/apache/incubator-doris/pull/1361#discussion_r296465636 ## File path: be/src/olap/olap_snapshot.cpp ## @@ -718,6 +718,16 @@ OLAPStatus OLAPEngine::storage_medium_migra

[GitHub] [incubator-doris] chaoyli opened a new pull request #1361: Check get_header status returned

2019-06-22 Thread GitBox
chaoyli opened a new pull request #1361: Check get_header status returned URL: https://github.com/apache/incubator-doris/pull/1361 When performing storage_medium_migration, the header may be already droped. In this scenario, header returned will be null pointer. Saving data to a null p