[GitHub] [incubator-doris] chaoyli merged pull request #1352: remove file created in segment group

2019-06-20 Thread GitBox
chaoyli merged pull request #1352: remove file created in segment group URL: https://github.com/apache/incubator-doris/pull/1352 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] DDDDDDouble opened a new pull request #1353: Add Checkstyle for doris-fe

2019-06-20 Thread GitBox
DDouble opened a new pull request #1353: Add Checkstyle for doris-fe URL: https://github.com/apache/incubator-doris/pull/1353 For https://github.com/apache/incubator-doris/issues/1345 This is an automated message from the

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1352: remove file created in segment group

2019-06-20 Thread GitBox
kangpinghuang opened a new pull request #1352: remove file created in segment group URL: https://github.com/apache/incubator-doris/pull/1352 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1095: Unifies load flow

2019-06-20 Thread GitBox
EmmyMiao87 commented on issue #1095: Unifies load flow URL: https://github.com/apache/incubator-doris/issues/1095#issuecomment-504306817 #1335 Add the streaming broker load in load jobs proc This is an automated message from

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1095: Unifies load flow

2019-06-20 Thread GitBox
EmmyMiao87 commented on issue #1095: Unifies load flow URL: https://github.com/apache/incubator-doris/issues/1095#issuecomment-504306694 #1338 Fix the hung bug in streaming broker load This is an automated message from the Ap

[GitHub] [incubator-doris] EmmyMiao87 commented on issue #1095: Unifies load flow

2019-06-20 Thread GitBox
EmmyMiao87 commented on issue #1095: Unifies load flow URL: https://github.com/apache/incubator-doris/issues/1095#issuecomment-504306467 #1323 The streaming mini load has been implemented in this commit This is an automated m

[GitHub] [incubator-doris] imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r296102914 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -1,22

[GitHub] [incubator-doris] chaoyli merged pull request #1351: Set version of ReaderParams for CumulativeCompaction

2019-06-20 Thread GitBox
chaoyli merged pull request #1351: Set version of ReaderParams for CumulativeCompaction URL: https://github.com/apache/incubator-doris/pull/1351 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-doris] chaoyli opened a new pull request #1351: Set version of ReaderParams for CumulativeCompaction

2019-06-20 Thread GitBox
chaoyli opened a new pull request #1351: Set version of ReaderParams for CumulativeCompaction URL: https://github.com/apache/incubator-doris/pull/1351 This is an automated message from the Apache Git Service. To respond to t

[DISCUSS] ISSUE-1291 Refactor the logic of creating and managing colocated tables

2019-06-20 Thread 陈明雨
Hi all: I'd like to propose issue 1291(https://github.com/apache/incubator-doris/issues/1291) This proposal would refactor the logic of creating and managing colocated tables. The original design can be found here: [ISSUE 245](https://github.com/apache/incubator-doris/issues/245) The origi

[GitHub] [incubator-doris] yiguolei opened a new pull request #1350: Check file created and empty

2019-06-20 Thread GitBox
yiguolei opened a new pull request #1350: Check file created and empty URL: https://github.com/apache/incubator-doris/pull/1350 1. check file created and empty 2. Release schema change lock when get lock failed This is an a

[GitHub] [incubator-doris] worker24h opened a new pull request #1349: support mysql client 8.0 connection fe

2019-06-20 Thread GitBox
worker24h opened a new pull request #1349: support mysql client 8.0 connection fe URL: https://github.com/apache/incubator-doris/pull/1349 for example: mysql --default-auth=mysql_native_password -P9030 -utest -ptest123456 -hA.B.C.D --

[GitHub] [incubator-doris] imay closed pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
imay closed pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
EmmyMiao87 opened a new pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323 * This commit has brought contribution to streaming mini load The operation of streaming mini load is sames as previous. Also,

[GitHub] [incubator-doris] chaoyli merged pull request #1347: Set version for base_compaction

2019-06-20 Thread GitBox
chaoyli merged pull request #1347: Set version for base_compaction URL: https://github.com/apache/incubator-doris/pull/1347 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] DDDDDDouble opened a new pull request #1344: Add more UT for FEFunctions

2019-06-20 Thread GitBox
DDouble opened a new pull request #1344: Add more UT for FEFunctions URL: https://github.com/apache/incubator-doris/pull/1344 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] imay closed pull request #1344: Add more UT for FEFunctions

2019-06-20 Thread GitBox
imay closed pull request #1344: Add more UT for FEFunctions URL: https://github.com/apache/incubator-doris/pull/1344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] imay merged pull request #1348: Fix run-ut.sh failed

2019-06-20 Thread GitBox
imay merged pull request #1348: Fix run-ut.sh failed URL: https://github.com/apache/incubator-doris/pull/1348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-doris] imay opened a new pull request #1348: Fix run-ut.sh failed

2019-06-20 Thread GitBox
imay opened a new pull request #1348: Fix run-ut.sh failed URL: https://github.com/apache/incubator-doris/pull/1348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] chaoyli opened a new pull request #1347: Set version for base_compaction

2019-06-20 Thread GitBox
chaoyli opened a new pull request #1347: Set version for base_compaction URL: https://github.com/apache/incubator-doris/pull/1347 Upon base compaction, delete handler use version to init del_pred_array, So the version should be set. ---

[GitHub] [incubator-doris] imay opened a new pull request #1346: Add column reader writer for segment V2

2019-06-20 Thread GitBox
imay opened a new pull request #1346: Add column reader writer for segment V2 URL: https://github.com/apache/incubator-doris/pull/1346 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1341: Add plain page

2019-06-20 Thread GitBox
kangpinghuang commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295875195 ## File path: be/src/olap/rowset/segment_v2/plain_page.h ## @@ -0,0 +1,170 @@ +#pragma once + +#include "util/coding.h" +

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1341: Add plain page

2019-06-20 Thread GitBox
kangpinghuang commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295869905 ## File path: be/src/olap/rowset/segment_v2/plain_page.h ## @@ -0,0 +1,170 @@ +#pragma once + +#include "util/coding.h" +

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1341: Add plain page

2019-06-20 Thread GitBox
kangpinghuang commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295878361 ## File path: be/src/olap/rowset/segment_v2/plain_page.h ## @@ -0,0 +1,170 @@ +#pragma once + +#include "util/coding.h" +

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1341: Add plain page

2019-06-20 Thread GitBox
kangpinghuang commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295881199 ## File path: be/test/olap/rowset/segment_v2/plain_page_test.cpp ## @@ -0,0 +1,192 @@ + +#include "olap/rowset/segment_v2

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1341: Add plain page

2019-06-20 Thread GitBox
kangpinghuang commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295877128 ## File path: be/src/olap/rowset/segment_v2/plain_page.h ## @@ -0,0 +1,170 @@ +#pragma once + +#include "util/coding.h" +

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1341: Add plain page

2019-06-20 Thread GitBox
kangpinghuang commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295875490 ## File path: be/src/olap/rowset/segment_v2/plain_page.h ## @@ -0,0 +1,170 @@ +#pragma once + +#include "util/coding.h" +

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1341: Add plain page

2019-06-20 Thread GitBox
kangpinghuang commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295880717 ## File path: be/src/olap/rowset/segment_v2/plain_page.h ## @@ -0,0 +1,170 @@ +#pragma once + +#include "util/coding.h" +

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
EmmyMiao87 commented on a change in pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r295784533 ## File path: be/src/util/string_parser.hpp ## @@ -122,6 +123,38 @@ class Stri

[GitHub] [incubator-doris] DDDDDDouble opened a new pull request #1344: Add more UT for FEFunctions

2019-06-20 Thread GitBox
DDouble opened a new pull request #1344: Add more UT for FEFunctions URL: https://github.com/apache/incubator-doris/pull/1344 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] imay closed pull request #1344: Add more UT for FEFunctions

2019-06-20 Thread GitBox
imay closed pull request #1344: Add more UT for FEFunctions URL: https://github.com/apache/incubator-doris/pull/1344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
EmmyMiao87 commented on a change in pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r295780360 ## File path: be/src/http/action/mini_load.cpp ## @@ -318,14 +330,47 @@ int Mi

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
EmmyMiao87 commented on a change in pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r295779532 ## File path: fe/src/main/java/org/apache/doris/common/FeMetaVersion.java ## @

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
EmmyMiao87 commented on a change in pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r295778055 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/MiniLoadJob.java ##

[GitHub] [incubator-doris] imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r295773180 ## File path: be/src/http/action/mini_load.cpp ## @@ -318,14 +330,47 @@ int MiniLoad

[GitHub] [incubator-doris] imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r295774215 ## File path: be/src/util/string_parser.hpp ## @@ -122,6 +123,38 @@ class StringPars

[GitHub] [incubator-doris] imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r295772191 ## File path: gensrc/thrift/FrontendService.thrift ## @@ -443,6 +443,30 @@ struct TL

[GitHub] [incubator-doris] imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r295771939 ## File path: gensrc/thrift/FrontendService.thrift ## @@ -581,9 +612,14 @@ service F

[GitHub] [incubator-doris] imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r295769985 ## File path: fe/src/main/java/org/apache/doris/common/FeMetaVersion.java ## @@ -116

[GitHub] [incubator-doris] imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load

2019-06-20 Thread GitBox
imay commented on a change in pull request #1323: This commit has brought contribution to streaming mini load URL: https://github.com/apache/incubator-doris/pull/1323#discussion_r295770274 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/MiniLoadJob.java ## @@ -

[GitHub] [incubator-doris] imay merged pull request #1338: Fix the broker hang when fe restart

2019-06-20 Thread GitBox
imay merged pull request #1338: Fix the broker hang when fe restart URL: https://github.com/apache/incubator-doris/pull/1338 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] imay commented on a change in pull request #1343: Thrift definition for scanning data ability for computing system

2019-06-20 Thread GitBox
imay commented on a change in pull request #1343: Thrift definition for scanning data ability for computing system URL: https://github.com/apache/incubator-doris/pull/1343#discussion_r295761294 ## File path: gensrc/thrift/DorisScanService.thrift ## @@ -0,0 +1,162 @@ +// Li

[GitHub] [incubator-doris] imay commented on a change in pull request #1343: Thrift definition for scanning data ability for computing system

2019-06-20 Thread GitBox
imay commented on a change in pull request #1343: Thrift definition for scanning data ability for computing system URL: https://github.com/apache/incubator-doris/pull/1343#discussion_r295761661 ## File path: gensrc/thrift/DorisScanService.thrift ## @@ -0,0 +1,162 @@ +// Li

[GitHub] [incubator-doris] imay commented on a change in pull request #1343: Thrift definition for scanning data ability for computing system

2019-06-20 Thread GitBox
imay commented on a change in pull request #1343: Thrift definition for scanning data ability for computing system URL: https://github.com/apache/incubator-doris/pull/1343#discussion_r295760542 ## File path: gensrc/thrift/DorisScanService.thrift ## @@ -0,0 +1,162 @@ +// Li

[GitHub] [incubator-doris] imay commented on a change in pull request #1343: Thrift definition for scanning data ability for computing system

2019-06-20 Thread GitBox
imay commented on a change in pull request #1343: Thrift definition for scanning data ability for computing system URL: https://github.com/apache/incubator-doris/pull/1343#discussion_r295760320 ## File path: gensrc/thrift/DorisScanService.thrift ## @@ -0,0 +1,162 @@ +// Li

[GitHub] [incubator-doris] imay commented on a change in pull request #1343: Thrift definition for scanning data ability for computing system

2019-06-20 Thread GitBox
imay commented on a change in pull request #1343: Thrift definition for scanning data ability for computing system URL: https://github.com/apache/incubator-doris/pull/1343#discussion_r295762218 ## File path: gensrc/thrift/DorisScanService.thrift ## @@ -0,0 +1,162 @@ +// Li

[GitHub] [incubator-doris] imay commented on issue #1345: Add Checkstyle for doris-fe

2019-06-20 Thread GitBox
imay commented on issue #1345: Add Checkstyle for doris-fe URL: https://github.com/apache/incubator-doris/issues/1345#issuecomment-503986323 @DDouble Thanks for your proposal. For License header, I prefer second type. Because most of our code is forked from Apache Impala, who u

[GitHub] [incubator-doris] imay commented on a change in pull request #1341: Add plain page

2019-06-20 Thread GitBox
imay commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295755872 ## File path: be/src/olap/rowset/segment_v2/plain_page.h ## @@ -0,0 +1,170 @@ +#pragma once + +#include "util/coding.h" +#include

[GitHub] [incubator-doris] imay commented on a change in pull request #1341: Add plain page

2019-06-20 Thread GitBox
imay commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295755128 ## File path: be/src/olap/rowset/segment_v2/plain_page.h ## @@ -0,0 +1,170 @@ +#pragma once Review comment: License header

[GitHub] [incubator-doris] imay commented on a change in pull request #1341: Add plain page

2019-06-20 Thread GitBox
imay commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295755216 ## File path: be/src/olap/rowset/segment_v2/plain_page.h ## @@ -0,0 +1,170 @@ +#pragma once + +#include "util/coding.h" +#include

[GitHub] [incubator-doris] imay commented on a change in pull request #1341: Add plain page

2019-06-20 Thread GitBox
imay commented on a change in pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341#discussion_r295756183 ## File path: be/src/olap/rowset/segment_v2/plain_page.h ## @@ -0,0 +1,170 @@ +#pragma once + +#include "util/coding.h" +#include

[GitHub] [incubator-doris] imay merged pull request #1342: Fix bug that function greast and least return wrong type

2019-06-20 Thread GitBox
imay merged pull request #1342: Fix bug that function greast and least return wrong type URL: https://github.com/apache/incubator-doris/pull/1342 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-doris] HangyuanLiu commented on issue #1336: 建议添加dayofweek函数

2019-06-20 Thread GitBox
HangyuanLiu commented on issue #1336: 建议添加dayofweek函数 URL: https://github.com/apache/incubator-doris/issues/1336#issuecomment-503973450 I will add a dayofweek function for doris. This is an automated message from the Apache G

[GitHub] [incubator-doris] DDDDDDouble opened a new issue #1345: Add Checkstyle for doris-fe

2019-06-20 Thread GitBox
DDouble opened a new issue #1345: Add Checkstyle for doris-fe URL: https://github.com/apache/incubator-doris/issues/1345 @imay HI, I want to add Checkstyle plugin to FE code to check the code style. I'm going to start with a simple check. First we need to discuss which parts of

[GitHub] [incubator-doris] DDDDDDouble opened a new pull request #1344: Add more UT for FEFunctions

2019-06-20 Thread GitBox
DDouble opened a new pull request #1344: Add more UT for FEFunctions URL: https://github.com/apache/incubator-doris/pull/1344 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] chaoyli merged pull request #1340: open unit tests

2019-06-20 Thread GitBox
chaoyli merged pull request #1340: open unit tests URL: https://github.com/apache/incubator-doris/pull/1340 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-doris] chaoyli merged pull request #1337: Be refactor optimize meta tool new

2019-06-20 Thread GitBox
chaoyli merged pull request #1337: Be refactor optimize meta tool new URL: https://github.com/apache/incubator-doris/pull/1337 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1343: Add thrift prototype for exposing ability of scanning data ability to…

2019-06-20 Thread GitBox
wuyunfeng opened a new pull request #1343: Add thrift prototype for exposing ability of scanning data ability to… URL: https://github.com/apache/incubator-doris/pull/1343 … other compute system This is an automated message fr

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1342: Fix bug that function greast and least return wrong type

2019-06-20 Thread GitBox
chenhao7253886 opened a new pull request #1342: Fix bug that function greast and least return wrong type URL: https://github.com/apache/incubator-doris/pull/1342 This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1341: Add plain page

2019-06-20 Thread GitBox
HangyuanLiu opened a new pull request #1341: Add plain page URL: https://github.com/apache/incubator-doris/pull/1341 Add plain page This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1340: open unit tests

2019-06-20 Thread GitBox
kangpinghuang opened a new pull request #1340: open unit tests URL: https://github.com/apache/incubator-doris/pull/1340 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git